| Message ID | 20170425045201.71457-1-bjsdjshi@linux.vnet.ibm.com |
|---|---|
| State | New |
| Headers | show |
* Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> [2017-04-25 06:52:01 +0200]: Hey Alex, Please ignore the "RFC" tag in the subject. Sorry for the mistake. > When the "No host device provided" error occurs, the hint message > that starts with "Use -vfio-pci," makes no sense, since "-vfio-pci" > is not a valid command line parameter. > > Correct this by replacing "-vfio-pci" with "-device vfio-pci". > > Signed-off-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> > --- > hw/vfio/pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 03a3d01..32aca77 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -2625,8 +2625,8 @@ static void vfio_realize(PCIDevice *pdev, Error **errp) > if (!(~vdev->host.domain || ~vdev->host.bus || > ~vdev->host.slot || ~vdev->host.function)) { > error_setg(errp, "No provided host device"); > - error_append_hint(errp, "Use -vfio-pci,host=DDDD:BB:DD.F " > - "or -vfio-pci,sysfsdev=PATH_TO_DEVICE\n"); > + error_append_hint(errp, "Use -device vfio-pci,host=DDDD:BB:DD.F " > + "or -device vfio-pci,sysfsdev=PATH_TO_DEVICE\n"); > return; > } > vdev->vbasedev.sysfsdev = > -- > 2.10.2 >
Hi Dong, On 25/04/2017 06:56, Dong Jia Shi wrote: > * Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> [2017-04-25 06:52:01 +0200]: > > Hey Alex, > > Please ignore the "RFC" tag in the subject. Sorry for the mistake. > >> When the "No host device provided" error occurs, the hint message >> that starts with "Use -vfio-pci," makes no sense, since "-vfio-pci" >> is not a valid command line parameter. >> >> Correct this by replacing "-vfio-pci" with "-device vfio-pci". >> >> Signed-off-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> Reviewed-by: Eric Auger <eric.auger@redhat.com> Thanks Eric >> --- >> hw/vfio/pci.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c >> index 03a3d01..32aca77 100644 >> --- a/hw/vfio/pci.c >> +++ b/hw/vfio/pci.c >> @@ -2625,8 +2625,8 @@ static void vfio_realize(PCIDevice *pdev, Error **errp) >> if (!(~vdev->host.domain || ~vdev->host.bus || >> ~vdev->host.slot || ~vdev->host.function)) { >> error_setg(errp, "No provided host device"); >> - error_append_hint(errp, "Use -vfio-pci,host=DDDD:BB:DD.F " >> - "or -vfio-pci,sysfsdev=PATH_TO_DEVICE\n"); >> + error_append_hint(errp, "Use -device vfio-pci,host=DDDD:BB:DD.F " >> + "or -device vfio-pci,sysfsdev=PATH_TO_DEVICE\n"); >> return; >> } >> vdev->vbasedev.sysfsdev = >> -- >> 2.10.2 >> >
* Auger Eric <eric.auger@redhat.com> [2017-04-26 10:06:58 +0200]: Hi Eric, > Hi Dong, > > On 25/04/2017 06:56, Dong Jia Shi wrote: > > * Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> [2017-04-25 06:52:01 +0200]: > > > > Hey Alex, > > > > Please ignore the "RFC" tag in the subject. Sorry for the mistake. > > > >> When the "No host device provided" error occurs, the hint message > >> that starts with "Use -vfio-pci," makes no sense, since "-vfio-pci" > >> is not a valid command line parameter. > >> > >> Correct this by replacing "-vfio-pci" with "-device vfio-pci". > >> > >> Signed-off-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> > Reviewed-by: Eric Auger <eric.auger@redhat.com> Thanks for the review! > > Thanks > > Eric > >> --- > >> hw/vfio/pci.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > >> index 03a3d01..32aca77 100644 > >> --- a/hw/vfio/pci.c > >> +++ b/hw/vfio/pci.c > >> @@ -2625,8 +2625,8 @@ static void vfio_realize(PCIDevice *pdev, Error **errp) > >> if (!(~vdev->host.domain || ~vdev->host.bus || > >> ~vdev->host.slot || ~vdev->host.function)) { > >> error_setg(errp, "No provided host device"); > >> - error_append_hint(errp, "Use -vfio-pci,host=DDDD:BB:DD.F " > >> - "or -vfio-pci,sysfsdev=PATH_TO_DEVICE\n"); > >> + error_append_hint(errp, "Use -device vfio-pci,host=DDDD:BB:DD.F " > >> + "or -device vfio-pci,sysfsdev=PATH_TO_DEVICE\n"); > >> return; > >> } > >> vdev->vbasedev.sysfsdev = > >> -- > >> 2.10.2 > >> > > >
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 03a3d01..32aca77 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -2625,8 +2625,8 @@ static void vfio_realize(PCIDevice *pdev, Error **errp) if (!(~vdev->host.domain || ~vdev->host.bus || ~vdev->host.slot || ~vdev->host.function)) { error_setg(errp, "No provided host device"); - error_append_hint(errp, "Use -vfio-pci,host=DDDD:BB:DD.F " - "or -vfio-pci,sysfsdev=PATH_TO_DEVICE\n"); + error_append_hint(errp, "Use -device vfio-pci,host=DDDD:BB:DD.F " + "or -device vfio-pci,sysfsdev=PATH_TO_DEVICE\n"); return; } vdev->vbasedev.sysfsdev =
When the "No host device provided" error occurs, the hint message that starts with "Use -vfio-pci," makes no sense, since "-vfio-pci" is not a valid command line parameter. Correct this by replacing "-vfio-pci" with "-device vfio-pci". Signed-off-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> --- hw/vfio/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)