diff mbox

scsi: ibmvfc: don't check for failure from mempool_alloc()

Message ID 878tn9xb2m.fsf@notabene.neil.brown.name (mailing list archive)
State Not Applicable
Headers show

Commit Message

NeilBrown April 10, 2017, 2:15 a.m. UTC 
mempool_alloc() cannot fail when passed GFP_NOIO or any
other gfp setting that is permitted to sleep.
So remove this pointless code.

Signed-off-by: NeilBrown <neilb@suse.com>
---
 drivers/scsi/ibmvscsi/ibmvfc.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Tyrel Datwyler April 17, 2017, 7:03 p.m. UTC | #1 
On 04/09/2017 07:15 PM, NeilBrown wrote:
> 
> mempool_alloc() cannot fail when passed GFP_NOIO or any
> other gfp setting that is permitted to sleep.
> So remove this pointless code.
> 
> Signed-off-by: NeilBrown <neilb@suse.com>

Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>

> ---
>  drivers/scsi/ibmvscsi/ibmvfc.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index 2c92dabb55f6..26cd3c28186a 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -3910,12 +3910,6 @@ static int ibmvfc_alloc_target(struct ibmvfc_host *vhost, u64 scsi_id)
>  	spin_unlock_irqrestore(vhost->host->host_lock, flags);
>  
>  	tgt = mempool_alloc(vhost->tgt_pool, GFP_NOIO);
> -	if (!tgt) {
> -		dev_err(vhost->dev, "Target allocation failure for scsi id %08llx\n",
> -			scsi_id);
> -		return -ENOMEM;
> -	}
> -
>  	memset(tgt, 0, sizeof(*tgt));
>  	tgt->scsi_id = scsi_id;
>  	tgt->new_scsi_id = scsi_id;
>
Martin K. Petersen April 19, 2017, 1:51 a.m. UTC | #2 
NeilBrown <neilb@suse.com> writes:

> mempool_alloc() cannot fail when passed GFP_NOIO or any other gfp
> setting that is permitted to sleep.  So remove this pointless code.

Applied to 4.12/scsi-queue. Thanks!
diff mbox

Patch

diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 2c92dabb55f6..26cd3c28186a 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -3910,12 +3910,6 @@  static int ibmvfc_alloc_target(struct ibmvfc_host *vhost, u64 scsi_id)
 	spin_unlock_irqrestore(vhost->host->host_lock, flags);
 
 	tgt = mempool_alloc(vhost->tgt_pool, GFP_NOIO);
-	if (!tgt) {
-		dev_err(vhost->dev, "Target allocation failure for scsi id %08llx\n",
-			scsi_id);
-		return -ENOMEM;
-	}
-
 	memset(tgt, 0, sizeof(*tgt));
 	tgt->scsi_id = scsi_id;
 	tgt->new_scsi_id = scsi_id;