diff mbox

powerpc/mm/hash: don't opencode VMALLOC_INDEX

Message ID 1491972022-14602-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com (mailing list archive)
State Accepted
Commit 5f8122611b35c563a7c907485aafd8d4682e9184
Headers show

Commit Message

Aneesh Kumar K.V April 12, 2017, 4:40 a.m. UTC
Also remove wrong indentation to fix checkpatch.pl warning.

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 arch/powerpc/mm/slb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Michael Ellerman April 12, 2017, 6:55 a.m. UTC | #1
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> writes:

> powerpc/mm/hash: don't opencode VMALLOC_INDEX

OK.

> Also remove wrong indentation to fix checkpatch.pl warning.

No thanks :)

Or at least do it as a separate patch.

I'll fix it up this time.

cheers

> diff --git a/arch/powerpc/mm/slb.c b/arch/powerpc/mm/slb.c
> index 98ae810b8c21..3d580ccf4b71 100644
> --- a/arch/powerpc/mm/slb.c
> +++ b/arch/powerpc/mm/slb.c
> @@ -131,9 +131,9 @@ static void __slb_flush_and_rebolt(void)
>  		     "slbmte	%2,%3\n"
>  		     "isync"
>  		     :: "r"(mk_vsid_data(VMALLOC_START, mmu_kernel_ssize, vflags)),
> -		        "r"(mk_esid_data(VMALLOC_START, mmu_kernel_ssize, 1)),
> -		        "r"(ksp_vsid_data),
> -		        "r"(ksp_esid_data)
> +			"r"(mk_esid_data(VMALLOC_START, mmu_kernel_ssize, VMALLOC_INDEX)),
> +			"r"(ksp_vsid_data),
> +			"r"(ksp_esid_data)
>  		     : "memory");
>  }
>  
> -- 
> 2.7.4
Michael Ellerman April 19, 2017, 3:47 a.m. UTC | #2
On Wed, 2017-04-12 at 04:40:22 UTC, "Aneesh Kumar K.V" wrote:
> Also remove wrong indentation to fix checkpatch.pl warning.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/5f8122611b35c563a7c907485aafd8

cheers
diff mbox

Patch

diff --git a/arch/powerpc/mm/slb.c b/arch/powerpc/mm/slb.c
index 98ae810b8c21..3d580ccf4b71 100644
--- a/arch/powerpc/mm/slb.c
+++ b/arch/powerpc/mm/slb.c
@@ -131,9 +131,9 @@  static void __slb_flush_and_rebolt(void)
 		     "slbmte	%2,%3\n"
 		     "isync"
 		     :: "r"(mk_vsid_data(VMALLOC_START, mmu_kernel_ssize, vflags)),
-		        "r"(mk_esid_data(VMALLOC_START, mmu_kernel_ssize, 1)),
-		        "r"(ksp_vsid_data),
-		        "r"(ksp_esid_data)
+			"r"(mk_esid_data(VMALLOC_START, mmu_kernel_ssize, VMALLOC_INDEX)),
+			"r"(ksp_vsid_data),
+			"r"(ksp_esid_data)
 		     : "memory");
 }