| Message ID | alpine.LFD.2.00.1009281708350.2416@localhost6.localdomain6 (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Benjamin Herrenschmidt |
| Headers | show |
On Tuesday 28 September 2010, Thomas Gleixner wrote: > Calling unmask_msi_irq on irq shutdown is at least suboptimal. > Use mask_msi_irq instead. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Arnd Bergmann <arnd@arndb.de>
Index: linux-2.6/arch/powerpc/platforms/cell/axon_msi.c =================================================================== --- linux-2.6.orig/arch/powerpc/platforms/cell/axon_msi.c +++ linux-2.6/arch/powerpc/platforms/cell/axon_msi.c @@ -312,7 +312,7 @@ static void axon_msi_teardown_msi_irqs(s static struct irq_chip msic_irq_chip = { .mask = mask_msi_irq, .unmask = unmask_msi_irq, - .shutdown = unmask_msi_irq, + .shutdown = mask_msi_irq, .name = "AXON-MSI", };
Calling unmask_msi_irq on irq shutdown is at least suboptimal. Use mask_msi_irq instead. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- arch/powerpc/platforms/cell/axon_msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)