| Message ID | 1485970213-25532-3-git-send-email-clombard@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 02/02/17 04:30, Christophe Lombard wrote: > The two fields pid and tid of the structure cxl_irq_info are only used > in the guest environment. To avoid confusion, it's not necessary > to fill the fields in the bare-metal environment. > The PSL Process and Thread Identification Register is only used when > attaching a dedicated process for PSL8 only. > > Signed-off-by: Christophe Lombard <clombard@linux.vnet.ibm.com> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > --- > drivers/misc/cxl/native.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/misc/cxl/native.c b/drivers/misc/cxl/native.c > index 09505f4..8a3ce99 100644 > --- a/drivers/misc/cxl/native.c > +++ b/drivers/misc/cxl/native.c > @@ -858,8 +858,6 @@ static int native_detach_process(struct cxl_context *ctx) > > static int native_get_irq_info(struct cxl_afu *afu, struct cxl_irq_info *info) > { > - u64 pidtid; > - > /* If the adapter has gone away, we can't get any meaningful > * information. > */ > @@ -869,9 +867,6 @@ static int native_get_irq_info(struct cxl_afu *afu, struct cxl_irq_info *info) > info->dsisr = cxl_p2n_read(afu, CXL_PSL_DSISR_An); > info->dar = cxl_p2n_read(afu, CXL_PSL_DAR_An); > info->dsr = cxl_p2n_read(afu, CXL_PSL_DSR_An); > - pidtid = cxl_p2n_read(afu, CXL_PSL_PID_TID_An); > - info->pid = pidtid >> 32; > - info->tid = pidtid & 0xffffffff; > info->afu_err = cxl_p2n_read(afu, CXL_AFU_ERR_An); > info->errstat = cxl_p2n_read(afu, CXL_PSL_ErrStat_An); > info->proc_handle = 0; >
diff --git a/drivers/misc/cxl/native.c b/drivers/misc/cxl/native.c index 09505f4..8a3ce99 100644 --- a/drivers/misc/cxl/native.c +++ b/drivers/misc/cxl/native.c @@ -858,8 +858,6 @@ static int native_detach_process(struct cxl_context *ctx) static int native_get_irq_info(struct cxl_afu *afu, struct cxl_irq_info *info) { - u64 pidtid; - /* If the adapter has gone away, we can't get any meaningful * information. */ @@ -869,9 +867,6 @@ static int native_get_irq_info(struct cxl_afu *afu, struct cxl_irq_info *info) info->dsisr = cxl_p2n_read(afu, CXL_PSL_DSISR_An); info->dar = cxl_p2n_read(afu, CXL_PSL_DAR_An); info->dsr = cxl_p2n_read(afu, CXL_PSL_DSR_An); - pidtid = cxl_p2n_read(afu, CXL_PSL_PID_TID_An); - info->pid = pidtid >> 32; - info->tid = pidtid & 0xffffffff; info->afu_err = cxl_p2n_read(afu, CXL_AFU_ERR_An); info->errstat = cxl_p2n_read(afu, CXL_PSL_ErrStat_An); info->proc_handle = 0;
The two fields pid and tid of the structure cxl_irq_info are only used in the guest environment. To avoid confusion, it's not necessary to fill the fields in the bare-metal environment. The PSL Process and Thread Identification Register is only used when attaching a dedicated process for PSL8 only. Signed-off-by: Christophe Lombard <clombard@linux.vnet.ibm.com> --- drivers/misc/cxl/native.c | 5 ----- 1 file changed, 5 deletions(-)