| Message ID | 1481074285-178976-1-git-send-email-longpeng2@huawei.com |
|---|---|
| State | New |
| Headers | show |
On Wed, Dec 07, 2016 at 09:31:25AM +0800, Longpeng(Mike) wrote: > Single-DES is obsolete and it's broken/useless for decades, we should > remove it in cryptodev, as suggested by Daniel. > Guest who wants to use this obsolete cipher alg will use its built-in > implementation instead. > > Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com> > --- > backends/cryptodev-builtin.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c > index a4224f4..5fb2836 100644 > --- a/backends/cryptodev-builtin.c > +++ b/backends/cryptodev-builtin.c > @@ -205,10 +205,6 @@ static int cryptodev_builtin_create_cipher_session( > return -1; > } > break; > - case VIRTIO_CRYPTO_CIPHER_DES_ECB: > - mode = QCRYPTO_CIPHER_MODE_ECB; > - algo = QCRYPTO_CIPHER_ALG_DES_RFB; > - break; > default: > error_setg(errp, "Unsupported cipher alg :%u", > sess_info->cipher_alg); Reviewed-by: Daniel P. Berrange <berrange@redhat.com> Regards, Daniel
> > From: Daniel P. Berrange [mailto:berrange@redhat.com] > Sent: Wednesday, December 07, 2016 5:07 PM > To: longpeng > Cc: Gonglei (Arei); eblake@redhat.com; Wubin (H); Zhoujian (jay, Euler); > qemu-devel@nongnu.org > Subject: Re: [PATCH for-2.9] cryptodev: remove single-DES support in cryptodev > > On Wed, Dec 07, 2016 at 09:31:25AM +0800, Longpeng(Mike) wrote: > > Single-DES is obsolete and it's broken/useless for decades, we should > > remove it in cryptodev, as suggested by Daniel. > > Guest who wants to use this obsolete cipher alg will use its built-in > > implementation instead. > > > > Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com> > > --- > > backends/cryptodev-builtin.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c > > index a4224f4..5fb2836 100644 > > --- a/backends/cryptodev-builtin.c > > +++ b/backends/cryptodev-builtin.c > > @@ -205,10 +205,6 @@ static int cryptodev_builtin_create_cipher_session( > > return -1; > > } > > break; > > - case VIRTIO_CRYPTO_CIPHER_DES_ECB: > > - mode = QCRYPTO_CIPHER_MODE_ECB; > > - algo = QCRYPTO_CIPHER_ALG_DES_RFB; > > - break; > > default: > > error_setg(errp, "Unsupported cipher alg :%u", > > sess_info->cipher_alg); > > Reviewed-by: Daniel P. Berrange <berrange@redhat.com> > Queued, thanks. Regards, -Gonglei
diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c index a4224f4..5fb2836 100644 --- a/backends/cryptodev-builtin.c +++ b/backends/cryptodev-builtin.c @@ -205,10 +205,6 @@ static int cryptodev_builtin_create_cipher_session( return -1; } break; - case VIRTIO_CRYPTO_CIPHER_DES_ECB: - mode = QCRYPTO_CIPHER_MODE_ECB; - algo = QCRYPTO_CIPHER_ALG_DES_RFB; - break; default: error_setg(errp, "Unsupported cipher alg :%u", sess_info->cipher_alg);
Single-DES is obsolete and it's broken/useless for decades, we should remove it in cryptodev, as suggested by Daniel. Guest who wants to use this obsolete cipher alg will use its built-in implementation instead. Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com> --- backends/cryptodev-builtin.c | 4 ---- 1 file changed, 4 deletions(-)