| Message ID | 1475778995-1420-6-git-send-email-arbab@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
Reza Arbab <arbab@linux.vnet.ibm.com> writes: > To support movable memory nodes (CONFIG_MOVABLE_NODE), at least one of > the following must be true: > > 1. We're on x86. This arch has the capability to identify movable nodes > at boot by parsing the ACPI SRAT, if the movable_node option is used. > > 2. Our config supports memory hotplug, which means that a movable node > can be created by hotplugging all of its memory into ZONE_MOVABLE. > > Fix the Kconfig definition of CONFIG_MOVABLE_NODE, which currently > recognizes (1), but not (2). > We now enable a lot of new code on different arch, such as the new node list N_MEMORY. Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > Signed-off-by: Reza Arbab <arbab@linux.vnet.ibm.com> > --- > mm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index be0ee11..5d0818f 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -153,7 +153,7 @@ config MOVABLE_NODE > bool "Enable to assign a node which has only movable memory" > depends on HAVE_MEMBLOCK > depends on NO_BOOTMEM > - depends on X86_64 > + depends on X86_64 || MEMORY_HOTPLUG > depends on NUMA > default n > help > -- > 1.8.3.1
On 07/10/16 05:36, Reza Arbab wrote: > To support movable memory nodes (CONFIG_MOVABLE_NODE), at least one of > the following must be true: > > 1. We're on x86. This arch has the capability to identify movable nodes > at boot by parsing the ACPI SRAT, if the movable_node option is used. > > 2. Our config supports memory hotplug, which means that a movable node > can be created by hotplugging all of its memory into ZONE_MOVABLE. > > Fix the Kconfig definition of CONFIG_MOVABLE_NODE, which currently > recognizes (1), but not (2). > > Signed-off-by: Reza Arbab <arbab@linux.vnet.ibm.com> > --- > mm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index be0ee11..5d0818f 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -153,7 +153,7 @@ config MOVABLE_NODE > bool "Enable to assign a node which has only movable memory" > depends on HAVE_MEMBLOCK > depends on NO_BOOTMEM > - depends on X86_64 > + depends on X86_64 || MEMORY_HOTPLUG > depends on NUMA > default n > help > Acked-by: Balbir Singh <bsingharora@gmail.com>
diff --git a/mm/Kconfig b/mm/Kconfig index be0ee11..5d0818f 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -153,7 +153,7 @@ config MOVABLE_NODE bool "Enable to assign a node which has only movable memory" depends on HAVE_MEMBLOCK depends on NO_BOOTMEM - depends on X86_64 + depends on X86_64 || MEMORY_HOTPLUG depends on NUMA default n help
To support movable memory nodes (CONFIG_MOVABLE_NODE), at least one of the following must be true: 1. We're on x86. This arch has the capability to identify movable nodes at boot by parsing the ACPI SRAT, if the movable_node option is used. 2. Our config supports memory hotplug, which means that a movable node can be created by hotplugging all of its memory into ZONE_MOVABLE. Fix the Kconfig definition of CONFIG_MOVABLE_NODE, which currently recognizes (1), but not (2). Signed-off-by: Reza Arbab <arbab@linux.vnet.ibm.com> --- mm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)