Message ID | 20160804053703.GN775@mwanda (mailing list archive) |
---|---|
State | Accepted |
Headers | show |
On Thursday, August 4, 2016 8:37:03 AM CEST Dan Carpenter wrote: > We should return -ENOMEM if alloc_spu_gang() fails. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > Acked-by: Arnd Bergmann <arnd@arndb.de>
On Thu, 2016-04-08 at 05:37:03 UTC, Dan Carpenter wrote: > We should return -ENOMEM if alloc_spu_gang() fails. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > Acked-by: Arnd Bergmann <arnd@arndb.de> Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/54a94fcf2f00c9deb9491d5ab2 cheers
diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c index 5be15cf..2975754 100644 --- a/arch/powerpc/platforms/cell/spufs/inode.c +++ b/arch/powerpc/platforms/cell/spufs/inode.c @@ -496,8 +496,10 @@ spufs_mkgang(struct inode *dir, struct dentry *dentry, umode_t mode) gang = alloc_spu_gang(); SPUFS_I(inode)->i_ctx = NULL; SPUFS_I(inode)->i_gang = gang; - if (!gang) + if (!gang) { + ret = -ENOMEM; goto out_iput; + } inode->i_op = &simple_dir_inode_operations; inode->i_fop = &simple_dir_operations;
We should return -ENOMEM if alloc_spu_gang() fails. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>