Message ID | 1468117056-14370-1-git-send-email-weiyj_lk@163.com |
---|---|
State | New |
Headers | show |
On Sun, Jul 10, 2016 at 4:17 AM, <weiyj_lk@163.com> wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > fwnode_handle_put() should be used when terminating > device_for_each_child_node() iteration with break or > return to prevent stale device node references from > being left behind. > > Generated by Coccinelle. > > Fixes: 4ba8cfa79f44 ("gpio: dwapb: convert device node to fwnode") > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c index 34779bb..6193f62 100644 --- a/drivers/gpio/gpio-dwapb.c +++ b/drivers/gpio/gpio-dwapb.c @@ -486,6 +486,7 @@ dwapb_gpio_get_pdata(struct device *dev) pp->idx >= DWAPB_MAX_PORTS) { dev_err(dev, "missing/invalid port index for port%d\n", i); + fwnode_handle_put(fwnode); return ERR_PTR(-EINVAL); }