Message ID | 1462462573-27779-1-git-send-email-horia.geanta@nxp.com (mailing list archive) |
---|---|
State | Not Applicable |
Headers | show |
On 5/5/2016 6:37 PM, Horia Geantă wrote: > This will allow device drivers to consistently use io{read,write}XX > also for 64-bit accesses. > > Signed-off-by: Horia Geantă <horia.geanta@nxp.com> It would be great if PPC maintainers could Ack this patch. As stated in the cover letter: https://lkml.org/lkml/2016/5/5/340 I'd like to go with the whole patch set via cryptodev-2.6 tree. Thanks, Horia > --- > arch/powerpc/kernel/iomap.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/powerpc/kernel/iomap.c b/arch/powerpc/kernel/iomap.c > index 12e48d56f771..3963f0b68d52 100644 > --- a/arch/powerpc/kernel/iomap.c > +++ b/arch/powerpc/kernel/iomap.c > @@ -38,6 +38,18 @@ EXPORT_SYMBOL(ioread16); > EXPORT_SYMBOL(ioread16be); > EXPORT_SYMBOL(ioread32); > EXPORT_SYMBOL(ioread32be); > +#ifdef __powerpc64__ > +u64 ioread64(void __iomem *addr) > +{ > + return readq(addr); > +} > +u64 ioread64be(void __iomem *addr) > +{ > + return readq_be(addr); > +} > +EXPORT_SYMBOL(ioread64); > +EXPORT_SYMBOL(ioread64be); > +#endif /* __powerpc64__ */ > > void iowrite8(u8 val, void __iomem *addr) > { > @@ -64,6 +76,18 @@ EXPORT_SYMBOL(iowrite16); > EXPORT_SYMBOL(iowrite16be); > EXPORT_SYMBOL(iowrite32); > EXPORT_SYMBOL(iowrite32be); > +#ifdef __powerpc64__ > +void iowrite64(u64 val, void __iomem *addr) > +{ > + writeq(val, addr); > +} > +void iowrite64be(u64 val, void __iomem *addr) > +{ > + writeq_be(val, addr); > +} > +EXPORT_SYMBOL(iowrite64); > +EXPORT_SYMBOL(iowrite64be); > +#endif /* __powerpc64__ */ > > /* > * These are the "repeat read/write" functions. Note the >
On 05/09/2016 03:20 AM, Horia Ioan Geanta Neag wrote: > On 5/5/2016 6:37 PM, Horia Geantă wrote: >> This will allow device drivers to consistently use io{read,write}XX >> also for 64-bit accesses. >> >> Signed-off-by: Horia Geantă <horia.geanta@nxp.com> > > It would be great if PPC maintainers could Ack this patch. > > As stated in the cover letter: https://lkml.org/lkml/2016/5/5/340 > I'd like to go with the whole patch set via cryptodev-2.6 tree. It looks good to me. Michael? -Scott > > Thanks, > Horia > >> --- >> arch/powerpc/kernel/iomap.c | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/powerpc/kernel/iomap.c b/arch/powerpc/kernel/iomap.c >> index 12e48d56f771..3963f0b68d52 100644 >> --- a/arch/powerpc/kernel/iomap.c >> +++ b/arch/powerpc/kernel/iomap.c >> @@ -38,6 +38,18 @@ EXPORT_SYMBOL(ioread16); >> EXPORT_SYMBOL(ioread16be); >> EXPORT_SYMBOL(ioread32); >> EXPORT_SYMBOL(ioread32be); >> +#ifdef __powerpc64__ >> +u64 ioread64(void __iomem *addr) >> +{ >> + return readq(addr); >> +} >> +u64 ioread64be(void __iomem *addr) >> +{ >> + return readq_be(addr); >> +} >> +EXPORT_SYMBOL(ioread64); >> +EXPORT_SYMBOL(ioread64be); >> +#endif /* __powerpc64__ */ >> >> void iowrite8(u8 val, void __iomem *addr) >> { >> @@ -64,6 +76,18 @@ EXPORT_SYMBOL(iowrite16); >> EXPORT_SYMBOL(iowrite16be); >> EXPORT_SYMBOL(iowrite32); >> EXPORT_SYMBOL(iowrite32be); >> +#ifdef __powerpc64__ >> +void iowrite64(u64 val, void __iomem *addr) >> +{ >> + writeq(val, addr); >> +} >> +void iowrite64be(u64 val, void __iomem *addr) >> +{ >> + writeq_be(val, addr); >> +} >> +EXPORT_SYMBOL(iowrite64); >> +EXPORT_SYMBOL(iowrite64be); >> +#endif /* __powerpc64__ */ >> >> /* >> * These are the "repeat read/write" functions. Note the >> > >
On Tue, 2016-05-10 at 18:50 +0000, Scott Wood wrote: > On 05/09/2016 03:20 AM, Horia Ioan Geanta Neag wrote: > > On 5/5/2016 6:37 PM, Horia Geantă wrote: > > > This will allow device drivers to consistently use io{read,write}XX > > > also for 64-bit accesses. > > > > > > Signed-off-by: Horia Geantă <horia.geanta@nxp.com> > > > > It would be great if PPC maintainers could Ack this patch. > > > > As stated in the cover letter: https://lkml.org/lkml/2016/5/5/340 > > I'd like to go with the whole patch set via cryptodev-2.6 tree. > > It looks good to me. Michael? I didn't get the cover letter, or any of the rest of the series, so although I saw the patch I had no context. And I didn't have time to chase it up. At a glance it seems fine, so: Acked-by: Michael Ellerman <mpe@ellerman.id.au> cheers
diff --git a/arch/powerpc/kernel/iomap.c b/arch/powerpc/kernel/iomap.c index 12e48d56f771..3963f0b68d52 100644 --- a/arch/powerpc/kernel/iomap.c +++ b/arch/powerpc/kernel/iomap.c @@ -38,6 +38,18 @@ EXPORT_SYMBOL(ioread16); EXPORT_SYMBOL(ioread16be); EXPORT_SYMBOL(ioread32); EXPORT_SYMBOL(ioread32be); +#ifdef __powerpc64__ +u64 ioread64(void __iomem *addr) +{ + return readq(addr); +} +u64 ioread64be(void __iomem *addr) +{ + return readq_be(addr); +} +EXPORT_SYMBOL(ioread64); +EXPORT_SYMBOL(ioread64be); +#endif /* __powerpc64__ */ void iowrite8(u8 val, void __iomem *addr) { @@ -64,6 +76,18 @@ EXPORT_SYMBOL(iowrite16); EXPORT_SYMBOL(iowrite16be); EXPORT_SYMBOL(iowrite32); EXPORT_SYMBOL(iowrite32be); +#ifdef __powerpc64__ +void iowrite64(u64 val, void __iomem *addr) +{ + writeq(val, addr); +} +void iowrite64be(u64 val, void __iomem *addr) +{ + writeq_be(val, addr); +} +EXPORT_SYMBOL(iowrite64); +EXPORT_SYMBOL(iowrite64be); +#endif /* __powerpc64__ */ /* * These are the "repeat read/write" functions. Note the
This will allow device drivers to consistently use io{read,write}XX also for 64-bit accesses. Signed-off-by: Horia Geantă <horia.geanta@nxp.com> --- arch/powerpc/kernel/iomap.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)