Message ID | 1450270635-27080-9-git-send-email-marcin.krzeminski@nokia.com |
---|---|
State | New |
Headers | show |
On Wed, Dec 16, 2015 at 4:57 AM, <marcin.krzeminski@nokia.com> wrote: > From: Marcin Krzeminski <marcin.krzeminski@nokia.com> > > Signed-off-by: Marcin Krzeminski <marcin.krzeminski@nokia.com> > --- > hw/block/m25p80.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index f0f637e..a41c2f1 100644 > --- a/hw/block/m25p80.c > +++ b/hw/block/m25p80.c > @@ -214,6 +214,8 @@ static const FlashPartInfo known_devices[] = { > > /* Numonyx -- n25q128 */ Comment needs update to qXXX or just drop the part name altogether for: /* Numonyx */ Otherwise: Reviewed-by: Peter Crosthwaite <crosthwaite.peter@gmail.com> Regards, Peter > { INFO("n25q128", 0x20ba18, 0, 64 << 10, 256, 0) }, > + { INFO("n25q256a", 0x20ba19, 0, 64 << 10, 512, ER_4K) }, > + { INFO("n25q512a", 0x20ba20, 0, 64 << 10, 1024, ER_4K) }, > }; > > typedef enum { > -- > 2.5.0 > >
W dniu 21.12.2015 o 11:29, Peter Crosthwaite pisze: > On Wed, Dec 16, 2015 at 4:57 AM, <marcin.krzeminski@nokia.com> wrote: >> From: Marcin Krzeminski <marcin.krzeminski@nokia.com> >> >> Signed-off-by: Marcin Krzeminski <marcin.krzeminski@nokia.com> >> --- >> hw/block/m25p80.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c >> index f0f637e..a41c2f1 100644 >> --- a/hw/block/m25p80.c >> +++ b/hw/block/m25p80.c >> @@ -214,6 +214,8 @@ static const FlashPartInfo known_devices[] = { >> >> /* Numonyx -- n25q128 */ > > Comment needs update to qXXX or just drop the part name altogether for: > > /* Numonyx */ Will be dropped. Thanks, Marcin > > Otherwise: > > Reviewed-by: Peter Crosthwaite <crosthwaite.peter@gmail.com> > > Regards, > Peter > >> { INFO("n25q128", 0x20ba18, 0, 64 << 10, 256, 0) }, >> + { INFO("n25q256a", 0x20ba19, 0, 64 << 10, 512, ER_4K) }, >> + { INFO("n25q512a", 0x20ba20, 0, 64 << 10, 1024, ER_4K) }, >> }; >> >> typedef enum { >> -- >> 2.5.0 >> >> > >
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index f0f637e..a41c2f1 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -214,6 +214,8 @@ static const FlashPartInfo known_devices[] = { /* Numonyx -- n25q128 */ { INFO("n25q128", 0x20ba18, 0, 64 << 10, 256, 0) }, + { INFO("n25q256a", 0x20ba19, 0, 64 << 10, 512, ER_4K) }, + { INFO("n25q512a", 0x20ba20, 0, 64 << 10, 1024, ER_4K) }, }; typedef enum {