diff mbox

powerpc: IRQF_NO_SUSPEND not IRQF_TIMER for non-timer

Message ID 87lha4fwrc.fsf@linutronix.de (mailing list archive)
State Accepted
Headers show

Commit Message

John Ogness Nov. 11, 2015, 2:15 p.m. UTC 
Since gpio1 is not a timer, it also should not use IRQF_TIMER.

Similar to commit ba461f094bab ("powerpc: Use IRQF_NO_SUSPEND not
IRQF_TIMER for non-timer interrupts").

Signed-off-by: John Ogness <john.ogness@linutronix.de>
---
 drivers/macintosh/via-pmu.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Michael Ellerman Nov. 26, 2015, 12:15 p.m. UTC | #1 
On Wed, 2015-11-11 at 14:15:03 UTC, John Ogness wrote:
> Since gpio1 is not a timer, it also should not use IRQF_TIMER.
> 
> Similar to commit ba461f094bab ("powerpc: Use IRQF_NO_SUSPEND not
> IRQF_TIMER for non-timer interrupts").
> 
> Signed-off-by: John Ogness <john.ogness@linutronix.de>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/6c3082151e13846fd872cc21

cheers
diff mbox

Patch

diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index f9512bf..01ee736 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -425,8 +425,9 @@  static int __init via_pmu_start(void)
 			gpio_irq = irq_of_parse_and_map(gpio_node, 0);
 
 		if (gpio_irq != NO_IRQ) {
-			if (request_irq(gpio_irq, gpio1_interrupt, IRQF_TIMER,
-					"GPIO1 ADB", (void *)0))
+			if (request_irq(gpio_irq, gpio1_interrupt,
+					IRQF_NO_SUSPEND, "GPIO1 ADB",
+					(void *)0))
 				printk(KERN_ERR "pmu: can't get irq %d"
 				       " (GPIO1)\n", gpio_irq);
 			else