Message ID | 1445850626-29407-9-git-send-email-den@openvz.org |
---|---|
State | New |
Headers | show |
On 26/10/2015 10:10, Denis V. Lunev wrote: > log will become common facility with tracepoints support in next step. > > Signed-off-by: Denis V. Lunev <den@openvz.org> > --- > Makefile.objs | 1 - > util/Makefile.objs | 1 + > qemu-log.c => util/log.c | 0 > 3 files changed, 1 insertion(+), 1 deletion(-) > rename qemu-log.c => util/log.c (100%) > > diff --git a/Makefile.objs b/Makefile.objs > index ecfe03c..ce32193 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -81,7 +81,6 @@ endif > > ####################################################################### > # Target-independent parts used in system and user emulation > -common-obj-y += qemu-log.o > common-obj-y += tcg-runtime.o > common-obj-y += hw/ > common-obj-y += qom/ > diff --git a/util/Makefile.objs b/util/Makefile.objs > index d7cc399..a11915c 100644 > --- a/util/Makefile.objs > +++ b/util/Makefile.objs > @@ -29,3 +29,4 @@ util-obj-y += qemu-coroutine.o qemu-coroutine-lock.o qemu-coroutine-io.o > util-obj-y += qemu-coroutine-sleep.o > util-obj-y += coroutine-$(CONFIG_COROUTINE_BACKEND).o > util-obj-y += buffer.o > +util-obj-y += log.o > diff --git a/qemu-log.c b/util/log.c > similarity index 100% > rename from qemu-log.c > rename to util/log.c > Yes, this makes sense after the previous patch. The declaration of the LOG_* constants is a bit ad hoc for util/, but I guess it's fine. Another possibility is to move it to trace/. I'll leave this to Stefan to judge. Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Paolo
On 10/26/2015 08:20 PM, Paolo Bonzini wrote: > > On 26/10/2015 10:10, Denis V. Lunev wrote: >> log will become common facility with tracepoints support in next step. >> >> Signed-off-by: Denis V. Lunev <den@openvz.org> >> --- >> Makefile.objs | 1 - >> util/Makefile.objs | 1 + >> qemu-log.c => util/log.c | 0 >> 3 files changed, 1 insertion(+), 1 deletion(-) >> rename qemu-log.c => util/log.c (100%) >> >> diff --git a/Makefile.objs b/Makefile.objs >> index ecfe03c..ce32193 100644 >> --- a/Makefile.objs >> +++ b/Makefile.objs >> @@ -81,7 +81,6 @@ endif >> >> ####################################################################### >> # Target-independent parts used in system and user emulation >> -common-obj-y += qemu-log.o >> common-obj-y += tcg-runtime.o >> common-obj-y += hw/ >> common-obj-y += qom/ >> diff --git a/util/Makefile.objs b/util/Makefile.objs >> index d7cc399..a11915c 100644 >> --- a/util/Makefile.objs >> +++ b/util/Makefile.objs >> @@ -29,3 +29,4 @@ util-obj-y += qemu-coroutine.o qemu-coroutine-lock.o qemu-coroutine-io.o >> util-obj-y += qemu-coroutine-sleep.o >> util-obj-y += coroutine-$(CONFIG_COROUTINE_BACKEND).o >> util-obj-y += buffer.o >> +util-obj-y += log.o >> diff --git a/qemu-log.c b/util/log.c >> similarity index 100% >> rename from qemu-log.c >> rename to util/log.c >> > Yes, this makes sense after the previous patch. The declaration of the > LOG_* constants is a bit ad hoc for util/, but I guess it's fine. > Another possibility is to move it to trace/. > > I'll leave this to Stefan to judge. > > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> > > Paolo this is better to keep here to avoid linking problems. This subsystem should be a part of EACH binary if we will improve logging further in next steps. 'log' is utility from my point of view :) Den
diff --git a/Makefile.objs b/Makefile.objs index ecfe03c..ce32193 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -81,7 +81,6 @@ endif ####################################################################### # Target-independent parts used in system and user emulation -common-obj-y += qemu-log.o common-obj-y += tcg-runtime.o common-obj-y += hw/ common-obj-y += qom/ diff --git a/util/Makefile.objs b/util/Makefile.objs index d7cc399..a11915c 100644 --- a/util/Makefile.objs +++ b/util/Makefile.objs @@ -29,3 +29,4 @@ util-obj-y += qemu-coroutine.o qemu-coroutine-lock.o qemu-coroutine-io.o util-obj-y += qemu-coroutine-sleep.o util-obj-y += coroutine-$(CONFIG_COROUTINE_BACKEND).o util-obj-y += buffer.o +util-obj-y += log.o diff --git a/qemu-log.c b/util/log.c similarity index 100% rename from qemu-log.c rename to util/log.c
log will become common facility with tracepoints support in next step. Signed-off-by: Denis V. Lunev <den@openvz.org> --- Makefile.objs | 1 - util/Makefile.objs | 1 + qemu-log.c => util/log.c | 0 3 files changed, 1 insertion(+), 1 deletion(-) rename qemu-log.c => util/log.c (100%)