diff mbox

[RFC,1/2] target-ppc: remove hreg_compute_mem_idx() from cpu_post_load

Message ID 1442259039-22137-2-git-send-email-mark.cave-ayland@ilande.co.uk
State New
Headers show

Commit Message

Mark Cave-Ayland Sept. 14, 2015, 7:30 p.m. UTC 
hreg_compute_mem_idx() has already been called previously by ppc_store_msr()
via hreg_store_msr() and hreg_compute_hflags(). Drop the duplicate function
call as it is no longer needed.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 target-ppc/machine.c |    2 --
 1 file changed, 2 deletions(-)

Comments

Alexey Kardashevskiy Sept. 14, 2015, 11:25 p.m. UTC | #1 
On 09/15/2015 05:30 AM, Mark Cave-Ayland wrote:
> hreg_compute_mem_idx() has already been called previously by ppc_store_msr()
> via hreg_store_msr() and hreg_compute_hflags(). Drop the duplicate function
> call as it is no longer needed.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>	

> ---
>   target-ppc/machine.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/target-ppc/machine.c b/target-ppc/machine.c
> index f4ac761..bd99844 100644
> --- a/target-ppc/machine.c
> +++ b/target-ppc/machine.c
> @@ -197,8 +197,6 @@ static int cpu_post_load(void *opaque, int version_id)
>       env->msr ^= ~((1ULL << MSR_TGPR) | MSR_HVB);
>       ppc_store_msr(env, msr);
>
> -    hreg_compute_mem_idx(env);
> -
>       return 0;
>   }
>
>
diff mbox

Patch

diff --git a/target-ppc/machine.c b/target-ppc/machine.c
index f4ac761..bd99844 100644
--- a/target-ppc/machine.c
+++ b/target-ppc/machine.c
@@ -197,8 +197,6 @@  static int cpu_post_load(void *opaque, int version_id)
     env->msr ^= ~((1ULL << MSR_TGPR) | MSR_HVB);
     ppc_store_msr(env, msr);
 
-    hreg_compute_mem_idx(env);
-
     return 0;
 }