Message ID | 1442071950-9414-1-git-send-email-gang.chen.5i5j@gmail.com |
---|---|
State | New |
Headers | show |
On 12 September 2015 at 16:32, <gang.chen.5i5j@gmail.com> wrote: > From: Chen Gang <gang.chen.5i5j@gmail.com> > > qemu has already considered about some targets may have no traditional > signals. And openrisc's setup_frame() is dummy, but it can be supported > by setup_rt_frame(). > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > --- > linux-user/signal.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
On 9/13/15 00:23, Peter Maydell wrote: > On 12 September 2015 at 16:32, <gang.chen.5i5j@gmail.com> wrote: >> From: Chen Gang <gang.chen.5i5j@gmail.com> >> >> qemu has already considered about some targets may have no traditional >> signals. And openrisc's setup_frame() is dummy, but it can be supported >> by setup_rt_frame(). >> >> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> >> --- >> linux-user/signal.c | 9 ++------- >> 1 file changed, 2 insertions(+), 7 deletions(-) > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > Thank you very much. I am just analyzing the raise insn about tilegx, and shall implement the related code in signal.c, your Reviewed-by is very helpful for it. :-) Thanks.
diff --git a/linux-user/signal.c b/linux-user/signal.c index 502efd9..ac82baa 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -3900,12 +3900,6 @@ static inline abi_ulong get_sigframe(struct target_sigaction *ka, return sp; } -static void setup_frame(int sig, struct target_sigaction *ka, - target_sigset_t *set, CPUOpenRISCState *env) -{ - qemu_log("Not implement.\n"); -} - static void setup_rt_frame(int sig, struct target_sigaction *ka, target_siginfo_t *info, target_sigset_t *set, CPUOpenRISCState *env) @@ -5662,7 +5656,8 @@ void process_pending_signals(CPUArchState *cpu_env) } #endif /* prepare the stack frame of the virtual CPU */ -#if defined(TARGET_ABI_MIPSN32) || defined(TARGET_ABI_MIPSN64) +#if defined(TARGET_ABI_MIPSN32) || defined(TARGET_ABI_MIPSN64) \ + || defined(TARGET_OPENRISC) /* These targets do not have traditional signals. */ setup_rt_frame(sig, sa, &q->info, &target_old_set, cpu_env); #else