| Message ID | 1427796008-40028-1-git-send-email-Yuantian.Tang@freescale.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Scott Wood |
| Headers | show |
On Tue, 2015-03-31 at 18:00 +0800, Yuantian.Tang@freescale.com wrote: > From: Tang Yuantian <Yuantian.Tang@freescale.com> > > Otherwise there wil be no SCSI device nodes. > > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com> > Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com> > --- > arch/powerpc/configs/corenet64_smp_defconfig | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/powerpc/configs/corenet64_smp_defconfig b/arch/powerpc/configs/corenet64_smp_defconfig > index 04737aa..77a8151 100644 > --- a/arch/powerpc/configs/corenet64_smp_defconfig > +++ b/arch/powerpc/configs/corenet64_smp_defconfig > @@ -75,6 +75,13 @@ CONFIG_BLK_DEV_LOOP=y > CONFIG_BLK_DEV_RAM=y > CONFIG_BLK_DEV_RAM_SIZE=131072 > CONFIG_EEPROM_LEGACY=y > +CONFIG_BLK_DEV_SD=y > +CONFIG_CHR_DEV_ST=y > +CONFIG_BLK_DEV_SR=y > +CONFIG_CHR_DEV_SG=y Ben already sent a patch enabling these (except ST -- do we really need that?) in both corenet32 and corenet64. > +CONFIG_SCSI_MULTI_LUN=y This option was removed by c309b35171dd > +CONFIG_SCSI_LOGGING=y > +CONFIG_SCSI_SPI_ATTRS=y If you want these enabled, do it in a separate patch with an explanation of why we should enable them by default, and do it for other 85xx/corenet configs as well. -Scott
> -----Original Message----- > From: Wood Scott-B07421 > Sent: Friday, April 03, 2015 7:56 AM > To: Tang Yuantian-B29983 > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; Xie Shaohui-B21989 > Subject: Re: [PATCH] powerpc/config: add SCSI configs for > corenet64_smp_defconfig > > On Tue, 2015-03-31 at 18:00 +0800, Yuantian.Tang@freescale.com wrote: > > From: Tang Yuantian <Yuantian.Tang@freescale.com> > > > > Otherwise there wil be no SCSI device nodes. > > > > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com> > > Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com> > > --- > > arch/powerpc/configs/corenet64_smp_defconfig | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/powerpc/configs/corenet64_smp_defconfig > > b/arch/powerpc/configs/corenet64_smp_defconfig > > index 04737aa..77a8151 100644 > > --- a/arch/powerpc/configs/corenet64_smp_defconfig > > +++ b/arch/powerpc/configs/corenet64_smp_defconfig > > @@ -75,6 +75,13 @@ CONFIG_BLK_DEV_LOOP=y CONFIG_BLK_DEV_RAM=y > > CONFIG_BLK_DEV_RAM_SIZE=131072 > > CONFIG_EEPROM_LEGACY=y > > +CONFIG_BLK_DEV_SD=y > > +CONFIG_CHR_DEV_ST=y > > +CONFIG_BLK_DEV_SR=y > > +CONFIG_CHR_DEV_SG=y > > Ben already sent a patch enabling these (except ST -- do we really need > that?) in both corenet32 and corenet64. > > > +CONFIG_SCSI_MULTI_LUN=y > > This option was removed by c309b35171dd > > > +CONFIG_SCSI_LOGGING=y > > +CONFIG_SCSI_SPI_ATTRS=y > > If you want these enabled, do it in a separate patch with an explanation > of why we should enable them by default, and do it for other 85xx/corenet > configs as well. > OK, I will investigate this and resend if needed. Thanks, Yuantian > -Scott >
diff --git a/arch/powerpc/configs/corenet64_smp_defconfig b/arch/powerpc/configs/corenet64_smp_defconfig index 04737aa..77a8151 100644 --- a/arch/powerpc/configs/corenet64_smp_defconfig +++ b/arch/powerpc/configs/corenet64_smp_defconfig @@ -75,6 +75,13 @@ CONFIG_BLK_DEV_LOOP=y CONFIG_BLK_DEV_RAM=y CONFIG_BLK_DEV_RAM_SIZE=131072 CONFIG_EEPROM_LEGACY=y +CONFIG_BLK_DEV_SD=y +CONFIG_CHR_DEV_ST=y +CONFIG_BLK_DEV_SR=y +CONFIG_CHR_DEV_SG=y +CONFIG_SCSI_MULTI_LUN=y +CONFIG_SCSI_LOGGING=y +CONFIG_SCSI_SPI_ATTRS=y CONFIG_ATA=y CONFIG_SATA_FSL=y CONFIG_SATA_SIL24=y