From patchwork Sat Mar 2 12:31:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaohe Lin X-Patchwork-Id: 1050605 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44BQfs6YHkz9s4Y for ; Sat, 2 Mar 2019 23:32:53 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726357AbfCBMba (ORCPT ); Sat, 2 Mar 2019 07:31:30 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:36790 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726044AbfCBMba (ORCPT ); Sat, 2 Mar 2019 07:31:30 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 157ED4D3B409CA9C4883; Sat, 2 Mar 2019 20:31:27 +0800 (CST) Received: from [127.0.0.1] (10.184.189.20) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.408.0; Sat, 2 Mar 2019 20:31:20 +0800 To: David Ahern , Shrijeet Mukherjee , From: linmiaohe Subject: [PATCH net] net: vrf: fix remove vrf module error when there's no reference CC: Mingfangsen Message-ID: Date: Sat, 2 Mar 2019 20:31:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 Content-Language: en-US X-Originating-IP: [10.184.189.20] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Miaohe Lin If we insmod vrf.ko, there is no way to remove it because of lack of module_exit. I think we may need it. Signed-off-by: Miaohe Lin --- drivers/net/vrf.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 7c1430ed0244..0e93690482d4 100644 --- a/drivers/net/vrf.c +++ b/drivers/net/vrf.c @@ -1462,7 +1462,15 @@ static int __init vrf_init_module(void) return rc; } +static void __exit vrf_fini_module(void) +{ + rtnl_link_unregister(&vrf_link_ops); + unregister_pernet_subsys(&vrf_net_ops); + unregister_netdevice_notifier(&vrf_notifier_block); +} + module_init(vrf_init_module); +module_exit(vrf_fini_module); MODULE_AUTHOR("Shrijeet Mukherjee, David Ahern"); MODULE_DESCRIPTION("Device driver to instantiate VRF domains"); MODULE_LICENSE("GPL");