From patchwork Wed Feb 27 01:00:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1048624 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="uipsVa+F"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 448HRJ05DTz9s9y for ; Wed, 27 Feb 2019 12:00:27 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729202AbfB0BAZ (ORCPT ); Tue, 26 Feb 2019 20:00:25 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:33497 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728766AbfB0BAZ (ORCPT ); Tue, 26 Feb 2019 20:00:25 -0500 Received: by mail-pl1-f193.google.com with SMTP id y10so7121474plp.0 for ; Tue, 26 Feb 2019 17:00:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=bXIFBT1vV6GfEJwHoM70cX/2DiTRbzv6A7QYz7iIlfU=; b=uipsVa+FSebgmQsiTX+lmKDGmLtHueQeWQLfD2H7tDvMwCo7hr0v2j0pclI28CoecI +w2QtTxKXVynjos+vrkkmbglpUnjpMaEtsnud0D/cXa10ALjfP6T775uGvaB9fTfNRQe OHLho6JeYEbJ6gU9HY4wF/uhfunc6pCYpgiKD7F4WD0MU7jhC27W7ZdPdfIO3koFMAN+ BkBFffAwIv4kCwLgEr19hQGr1nq9BQgBd7kLqsehxhvb0hIV07uzTkhvFgir1pvFroW+ cM1BDAamJT6SIGPNPL0a8UXCbsbChO5eQIlPHWeveDP5eOHoCmgtYTTynMXTqw2uEW/K bdiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bXIFBT1vV6GfEJwHoM70cX/2DiTRbzv6A7QYz7iIlfU=; b=poX7HA4FvLH9DFJOmnO62pCCSht2lOirji+sNQyapAK1/jhBQBByd2QXNEOTOJFJOd ZXUDsbxxYicHvKkoTzR+ggUFGeex7uwy3F4oU5b1FKZQnqVXbdnaTt/vLHPI0tKwAaTA t/oKOORLRkyVN/6CJfm6H5rS2UpkXdFDdbv0rsIs6fnnBpODPfux7UVqPeyH9EO9oN6A BQzuJ5AAHWWrIIEy78T9hlZpRdBeWMFQxsXcA0Qn6jI0Bfzp4eIYqbrhT8hgaAIkBMsf TLcBsMaFWZwKsSJRJzwQNAFsdFKcRm/Lgxu9UiFiRjXJFU3RWCcT9gqs1yhoVK7nsbCq 6wOQ== X-Gm-Message-State: AHQUAubQ+o361ESm+D5jXeML9I4dFRSKFN7qbMh4aNY7kB7pa6WpDwiq k1jPJjDRpuR2TgZllEWQITypVR4E X-Google-Smtp-Source: AHgI3IawjoqKmNDTOLm0JYYiUWX+ZJFjfrJiFIYgRm+gynLDkF63hnyT2LPa+fCxHrHLorCFcPL4/g== X-Received: by 2002:a17:902:33c1:: with SMTP id b59mr28894360plc.220.1551229224438; Tue, 26 Feb 2019 17:00:24 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id a1sm18556172pfn.26.2019.02.26.17.00.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Feb 2019 17:00:23 -0800 (PST) From: Leslie Monis To: davem@davemloft.net Cc: netdev@vger.kernel.org, Leslie Monis Subject: [PATCH net-next] net: sched: pie: fix 64-bit division Date: Wed, 27 Feb 2019 06:30:06 +0530 Message-Id: <20190227010006.22219-1-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use div_u64() to resolve build failures on 32-bit platforms. Fixes: 3f7ae5f3dc52 ("net: sched: pie: add more cases to auto-tune alpha and beta") Signed-off-by: Leslie Monis Reported-by: Randy Dunlap Tested-by: Randy Dunlap --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 4c0670b6aec1..f93cfe034c72 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -429,7 +429,7 @@ static void calculate_probability(struct Qdisc *sch) */ if (qdelay == 0 && qdelay_old == 0 && update_prob) - q->vars.prob = (q->vars.prob * 98) / 100; + q->vars.prob = 98 * div_u64(q->vars.prob, 100); q->vars.qdelay = qdelay; q->vars.qlen_old = qlen;