From patchwork Mon Feb 18 08:15:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yue Haibing X-Patchwork-Id: 1043813 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 442xD519Hkz9s3l for ; Mon, 18 Feb 2019 19:02:13 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728998AbfBRICL (ORCPT ); Mon, 18 Feb 2019 03:02:11 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3762 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725881AbfBRICL (ORCPT ); Mon, 18 Feb 2019 03:02:11 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 48914755B1C0731873C1; Mon, 18 Feb 2019 16:02:07 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.408.0; Mon, 18 Feb 2019 16:01:58 +0800 From: YueHaibing To: "David S . Miller" , Yang Wei CC: YueHaibing , , Subject: [PATCH net-next] yellowfin: fix remove set but not used variable warning Date: Mon, 18 Feb 2019 08:15:46 +0000 Message-ID: <20190218081546.189509-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/packetengines/yellowfin.c: In function 'yellowfin_rx': drivers/net/ethernet/packetengines/yellowfin.c:1053:18: warning: variable 'yf_size' set but not used [-Wunused-but-set-variable] This puts the variable declaration into the YF_PROTOTYPE macro. Signed-off-by: YueHaibing --- drivers/net/ethernet/packetengines/yellowfin.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/packetengines/yellowfin.c b/drivers/net/ethernet/packetengines/yellowfin.c index 6f8d6584f809..edc8cc7f0d0d 100644 --- a/drivers/net/ethernet/packetengines/yellowfin.c +++ b/drivers/net/ethernet/packetengines/yellowfin.c @@ -1050,8 +1050,11 @@ static int yellowfin_rx(struct net_device *dev) struct sk_buff *rx_skb = yp->rx_skbuff[entry]; s16 frame_status; u16 desc_status; - int data_size, yf_size; + int data_size; u8 *buf_addr; +#ifdef YF_PROTOTYPE + int yf_size = sizeof(struct yellowfin_desc); +#endif if(!desc->result_status) break; @@ -1068,8 +1071,6 @@ static int yellowfin_rx(struct net_device *dev) if (--boguscnt < 0) break; - yf_size = sizeof(struct yellowfin_desc); - if ( ! (desc_status & RX_EOP)) { if (data_size != 0) netdev_warn(dev, "Oversized Ethernet frame spanned multiple buffers, status %04x, data_size %d!\n",