From patchwork Fri Feb 15 21:44:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Angelo Compagnucci X-Patchwork-Id: 1043206 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Jj30MjZ5"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 441Rc95WfPz9s5c for ; Sat, 16 Feb 2019 08:44:25 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id A184F30C77; Fri, 15 Feb 2019 21:44:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zZotLmdazUH1; Fri, 15 Feb 2019 21:44:21 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 7D37B220A9; Fri, 15 Feb 2019 21:44:21 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 42FD41BF973 for ; Fri, 15 Feb 2019 21:44:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4019B86204 for ; Fri, 15 Feb 2019 21:44:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8VhwX_4UIhtq for ; Fri, 15 Feb 2019 21:44:18 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 66B2085F95 for ; Fri, 15 Feb 2019 21:44:18 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id x10so11785787wrs.8 for ; Fri, 15 Feb 2019 13:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=iVyofPTJQ+RMJY79zAFZnJ5nOl71d/Ms/OGxLaEMt7s=; b=Jj30MjZ5mdJxD4DTsm1//wEfUnZB+zBfd9q61Al8gW0EXEt88a34kzfZR3/iyoWmV5 /szP1Bl4CEkkau6gw5QoQ1h2uiv4QYX9kOmIuX/LCyWJWQCWjn36a11vHOUW2vmEcJQq sLQdlP/z8j/+fU8ys6ofAaTiVxTtFx+CkKNjxVJHU8wSBHxR/7HPsJmh3Pql1aYIfvBW euWkn86uB/KFOXridFBbTR4NxGpJpMFryCgMcwBKz7X27AoKzuVdeRD1XdCw3MnoyKdt b6kbp/I5XUn3nrXTNuqZhb9aL1Y5ghCSsKGR3U22y14N9DrQzb99YHNJ6vEt7Q1+xmeq +Pvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=iVyofPTJQ+RMJY79zAFZnJ5nOl71d/Ms/OGxLaEMt7s=; b=HOncR9h5Yv8T08pUOVk+b8hbJmSOhcn9Bl+e51Ijoe3+/MZiGIWnOMb5LZwcOaP7AV MrwGv1ZIPk8pArtdJ9NEMagORz9UMo/czHEE5G+a7q+d45int6MyRSzJM17nIgCUCSAu ES5wMGUGpZkI5HmYz9L0ROmavBmo85O7rpbywQtwY8PEM1Vs73/5zArA5CdEubujeul8 Zpi3LmWVte0xIUijkQhvOf4Z4rRBSwBqT3jAFQ3tRFyaxSYsoewHFKCIhL8oCTCagDcT 3Oi9N2PTiBj+/Dm5lCa1yu6B+XADd1P1pFpxeX0r+CWddrdPEkV1oUECQRXbwMqyN4Cu 7n1A== X-Gm-Message-State: AHQUAuYAEmIPepuvu1LfB/X9QCnvjakvsTjsobnbRSq7/VLD/llmwBZN rV28tJCy+740d7haLgUbfBLZ9jIT X-Google-Smtp-Source: AHgI3IbAZYbP5ZUfuJriIv/4zuFxVqp6IVg/k5zGpieZpgxJuE0seBoHhZ5+VwHwM9Lbr2jSt2FCag== X-Received: by 2002:adf:eb90:: with SMTP id t16mr7924028wrn.324.1550267056746; Fri, 15 Feb 2019 13:44:16 -0800 (PST) Received: from localhost.localdomain ([37.162.56.132]) by smtp.gmail.com with ESMTPSA id f2sm8066844wmb.19.2019.02.15.13.44.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Feb 2019 13:44:16 -0800 (PST) From: Angelo Compagnucci X-Google-Original-From: Angelo Compagnucci To: buildroot@buildroot.org Date: Fri, 15 Feb 2019 22:44:10 +0100 Message-Id: <20190215214410.29132-1-angelo@amarulasolutions.com> X-Mailer: git-send-email 2.17.1 Subject: [Buildroot] [PATCH] package/mender: fix sysv startup script X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Angelo Compagnucci MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Mender is a service explicitly written for systemd and so it doesn't fork on background, doesn't redirect outputs and doesn't create a pid file by itself. To make the service running correctly is therefore necessary to use the -m switch of start-stop-daemon to create the pid file and -b option to send the process to background. Logging is preserved because the service will log anyway on syslog. Signed-off-by: Angelo Compagnucci --- package/mender/S42mender | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/mender/S42mender b/package/mender/S42mender index 665a9dd74a..108fecfea9 100644 --- a/package/mender/S42mender +++ b/package/mender/S42mender @@ -24,7 +24,7 @@ start() { printf "Starting mender service: " umask 077 - start-stop-daemon -S -q -p /var/run/mender.pid \ + start-stop-daemon -S -q -b -m -p /var/run/mender.pid \ --exec /usr/bin/mender -- -daemon [ $? = 0 ] && echo "OK" || echo "FAIL" }