From patchwork Mon Jan 28 18:05:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Chopra X-Patchwork-Id: 1032111 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=marvell.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43pHfD21j0z9s3q for ; Tue, 29 Jan 2019 05:07:32 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726923AbfA1SHb (ORCPT ); Mon, 28 Jan 2019 13:07:31 -0500 Received: from mail-eopbgr740042.outbound.protection.outlook.com ([40.107.74.42]:52417 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726738AbfA1SHa (ORCPT ); Mon, 28 Jan 2019 13:07:30 -0500 Received: from SN4PR0701CA0006.namprd07.prod.outlook.com (2603:10b6:803:28::16) by DM5PR07MB2907.namprd07.prod.outlook.com (2603:10b6:3:9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.17; Mon, 28 Jan 2019 18:07:26 +0000 Received: from BY2NAM05FT021.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::201) by SN4PR0701CA0006.outlook.office365.com (2603:10b6:803:28::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1537.26 via Frontend Transport; Mon, 28 Jan 2019 18:07:25 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by BY2NAM05FT021.mail.protection.outlook.com (10.152.100.158) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1580.2 via Frontend Transport; Mon, 28 Jan 2019 18:07:24 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Mon, 28 Jan 2019 10:05:14 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x0SI5DN4009943; Mon, 28 Jan 2019 10:05:13 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x0SI5Dei009942; Mon, 28 Jan 2019 10:05:13 -0800 From: Manish Chopra To: CC: , , Subject: [PATCH net 1/5] qed: Fix bug in tx promiscuous mode settings Date: Mon, 28 Jan 2019 10:05:04 -0800 Message-ID: <20190128180508.9902-2-manishc@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190128180508.9902-1-manishc@marvell.com> References: <20190128180508.9902-1-manishc@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131931724453098630; (abac79dc-c90b-41ba-8033-08d666125e47); (abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38; IPV:CAL; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(396003)(136003)(346002)(39860400002)(2980300002)(1110001)(1109001)(339900001)(199004)(189003)(50466002)(316002)(48376002)(2906002)(68736007)(11346002)(126002)(2616005)(476003)(486006)(16586007)(446003)(8676002)(81166006)(50226002)(336012)(81156014)(26005)(85426001)(47776003)(42186006)(8936002)(14444005)(54906003)(6666004)(86362001)(26826003)(105606002)(87636003)(69596002)(51416003)(97736004)(4326008)(6862004)(356004)(2351001)(107886003)(36756003)(80596001)(498600001)(1076003)(53936002)(305945005)(76176011)(106466001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB2907; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Fail; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BY2NAM05FT021; 1:8bi9cCJ2i0FMqWRkb/3kiQWzIwI+xY0VSgcSV2NA6XpH+BlS1/lFtbpgON5HCWj9XoFnvfdFepAKyI0G2EHwRIu/7pIiv+UClKtqWesRGmug+xloEGwWxO77qHUapDW16k69/4Zjl7iBVgvIbp2wfXmHrXU1ahKXmzOz8IPpGMM= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73e94098-cfb9-4725-15b9-08d6854b750f X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(5600110)(711020)(4605077)(2017052603328); SRVR:DM5PR07MB2907; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2907; 3:ijmlRiFFiQAAMzI9LSiWizfNvd53dKrXeAOMyJtTM+InrraPpoyIfJBJuqdPmtmUC19s4kyukvdA1W90bloyD8BmhTNh/pOx2KGkHtXV1ZxYkDRlnV9wPNzx10EqB7Ie6eJiG2g7fd8sjYIeBbku4XSskwwYeN7jBqtn9X3j0NbVSLg1MHyyYuArP7AUZgxVyLTQ5VmivhdIVDqAGughJI6qXXmI2TNnQgtLddY1EEaEc3IlH+3JYhBreB/Tt1zZ0h7BZrEz+5eDXVjB4zTKrVIkxh/46WBrRpljkIqbD7Hr/MgjB2DTPQ7KV6QhtnIZfhf75bOoxwaHWut6t9jTdXLqqqHHgFKTXp6l1bdyhDnJxWvr/T9g3UZxXd8a4HuF; 25:AMrLlO6cwRXjJtE9/jJm6bJm4tpn44A7FemVqa1zy3TC1sOGka/EPREAhyixEcS1DMInDwUJNpfo18g1cBpBsd7O3ry3Hs+wT4/sv4hocVYYGNgupnZxgxRSWNYH/Fncfq83lHICQBxZb2eetOuisF8Ivb9mQXV7J015pKyz1gI6l/tNWjeNLkiNCU54UksMgOcGWoqSh46TAVUZ7mF0UbU9tGIXC9FK9IJXhiHs7KRK9EMx/PxbRh9Eau2Bp5lSzmr9McNFAdoMRz/fiY2lVAPPD+00M2Of60vfPW9e/PTT2RJTy4FrSJsH7ir9oPN0aCwsjFb1QYpODyNvY9+JLA== X-MS-TrafficTypeDiagnostic: DM5PR07MB2907: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2907; 31:CNF4roGJMmD6arXJ5lIDlR+3zrLeMskX0jgcc5COxYCiOfl34KFDyjbcT6s2YMy2tm62HddOG1A1IQTnQnqBXb1gVLfOqsf2M6ChnfLCn7+FwQLLF/ZOUP/KwLnWFQ2dzS4j82ww6pFPeFW7XZx0g6fXKIadiDeELuH5REtY6gbrHgbZhOEhfDgVrpIDH1a043GU8awG7JiF9IICVwz7M7eoL72pLFvzggD0fR4AGQ4=; 4:WOelo+pGv9CJ0l2Nz0g7oZZ3JfBSpx1MrAIXMaK56zsvKkk8RBxfjiPUyp17xV8fC02l3UAwLhEv1HaSlT3DHFAOJ9NXgPH+4gBXkXjacFgC5Ek5nlFme1itKQqhqHl6YUpVuOsKmfcPBtooOkEOxsKn4kjUYHkGphyiiYSatKuiXaxTu2sfU65YwYBItUEqcWiDLRLsvRNby4Gm/ghob0Uzm6ujtk+rPzi40eU0r9UjvlrbpTQj6aCIs+8blEowdp9RKmrb/GydOjpd7J9KQ1FnTAl54AuL0EjJ2zsHaXDcgm91GLh7cPPena40NfVw X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 0931CB1479 X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2907; 23:NmiD9CgTdomQGhrnooQPZnljnWnFCLlvCcECVrKAhtz/BBTc80/Ub2Sk5PpwDxesfdEOabnOQGKGUJGhTmkITuEw5D10ahSWnSviQUQ4udAwpULAO1+Dum1exbGB01JWUd854v8FY6+pvyL6PHgvmXbne8CKf5tN/w/QbabdLgc7JGV3XNVlHMUpqu0ZXkMZOzcVu9t0Im7XnrqSzLxge/lQh5ShiXd8C5TVuaH+dFvvGVxDZ/CEPBKS+Xv/MWV2eN7bIuH+PBJS3OMUkzaEojB70bmuHX9m1WHwVFobvu0kZt8h0gfvr/WFThDHZPY5IklomRydutCGvNJmcpTBmQET+T1wllsZmBDztPGBdOlPVl19iqTh8LOKNj6Blr91xaJ5VjwuKMY/3hsp7hYrgxlxN5zPwqMydlBha3r3pz4/UEbVO1NLfEddkoSZJqrWNu01In7U2OIlursbzDEW8hCOKs+Lop3QbxMMgITV97Qcw3H38/ULns0vtIRI+sqUH0EtmPvyaTPgbAutpeIvmV5VX/Wg06ToAsRJ24524ynS9snHZtwUsL11m5GsGBnC8F/K30ZMuQZjZzt6kPJ3Fh8qilWF2kEVUoxwkJj7RMsmikboRSIhpWesououy2WJc2yPSc6bmGIsHfgPri2+Eouu8MYRoCVttmOV6Cn+OOcegmMDmNMh+E7HMLiiUxL5kfCfp+kdCTDw/TZNxWDyg96X9yfZBX0lptL0wSUPTklxOxtNvNjPK4lCyLBhg/nkZlMp3pWoV7K1pktCTYODrbAYoqBN/2iKE9lKevCpJm6kD3MMUHBe+xipUEmRYmBzZuRJvZrbYLCQ81hIZEzil+WGTiVL4rx0ug22oHytKIPxlH+ih78CPEiCFoWfuCTAbj7uSycnzSMXbkJz6aNCHaqetdfKDc4NYoUv/zddgfMlXboiBk8Tq1uc9ymyOteMkyo2vL/3bCiJ9jmP+5sMu1ZpuWcA7rJvmetxz6goglw3eoP3kiKBsvpJl6P2+2RiUXgFJfETRD8DXjlefnxQRKdPwYBHPn/3yCKEP80vs012qufVC6G578pLUnta6g9Old796EgYBAsUi+kJojKyrx2dJ2LsnnhIKdPZjMBojxMpDwASizWqkRfRSOW5/ZHvCtOHcgktCuKzEaxBvgYdbEDh8tJ85sGHoj9FdXIgFY326LLM0IFPwDSCUBzXnNTN+LOOU67GghaXIWrntcZDsew+JS1nlgTrLrD1W7VbI5Q= X-Microsoft-Antispam-Message-Info: GVLLTCqNu5OPCLueZkuuHKkYmRyS8ZF3Hcr8xfz8Fi8MYmakpSA94LYZKgTwTdkdpCvheOzHw6Ge7tkfhY/BvQsY1KAznU7avkIQeTCP0jBgUCvdLscixaRFozyDonAiU1U3/sH3BCRDI0q4UQY0sXibg3PUu4adF4pTvR0bs5dUqwLJWhYsZDro+gMbcxFpQVYpbTsR7uSbJQdAPgnkagoZPYBadBni3YlvT9aV9z08B0kNrhzFyfVQP/qpP5jSCn3d46BR88rRtxf1keZVwAkke/uDJ614hsRz7PYtAuh2epi1UsMMSq8JaML1cRl2Ipf0fiPrjrOUY/6GqBxbpF595+YeF5Je4RZtbZMkHorhpsB0zGKojwXbozslzEgZPsUcJLhnJ2n3WZLr+LhlPjDSUj3QigrFBgs5R2wwIm8= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2907; 6:0ne8ShUpVwwVRKD/sh8rkdsJwmxMcsB9oF1cq64LrAoq0+3xakOr3iL6oLAaLq4IEmRJT9FneU4FkyGZjPCxUfirNnmWwxvLuNENGyOYncqVzLXWh1NUT05536ZtAAcEZGNMMvPXF7bku7F3UwNliLLWYSe0YukDcw9qFk9R6WXCbi73Dgx8lWLiAtx+XzUTslGey2iKd+g7T48w5+8n3QuHp8WuI/W7gCu0lHMEMWvBso6G02wfPX+nuqi6MktQvxFYSlXYHoQ9fulx4aAbapL6W7vOgo8/J2CdGm/eXDqrkdjHrdWPIl5mfT8zQW0XM7luABtrK1nEzwPD9el6RhdlntNxf7H9VqU2n5aO79T7WZZS9MLZ7J4Pn8mXeveaZUc6DxMM0EGc8jxija5u6rofzJsOIVeA4NKIU89jcqNXNgSXI1sG9Ds7AIb435RSl97MpGVIhTdquTefl4riNw==; 5:UBN+amifu/mh1rettEc5CruY3ixpb2Lur9VNj7rEJc9BbMN7TXxroHQ2Uo4BLo0yXyo7irP4gtUpGPJzknsDsn4l5Ec4xIQWYILM8Y1PhpL17jCjtd7jqqq0FEHLH04CyLOsxuSN/CAjci74gQEWr9GR9jKtwr4ufVP4vLXHKOyda6xzWjbHN38710nzoanhVlkg7xIhhsR4+xeDH62uTg==; 7:Y+IIx0RQy1z68hYD+68aQW7/rIKcO8Gz4AkFypc7aVvs1mnuCa13oobfgo42DOTUP5aJENDN5me+SOLFQNucLxzgPfgKWHJCPe0VXM+VwVOCFLMNr+CPma6SdHeuQ5WRkS+gZv4ipKpaKg7ZmPhPoA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2019 18:07:24.7864 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73e94098-cfb9-4725-15b9-08d6854b750f X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[199.233.58.38]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB2907 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When running tx switched traffic between VNICs created via a bridge(to which VFs are added), adapter drops the unicast packets in tx flow due to VNIC's ucast mac being unknown to it. But VF interfaces being in promiscuous mode should have caused adapter to accept all the unknown ucast packets. Later, it was found that driver doesn't really configure tx promiscuous mode settings to accept all unknown unicast macs. This patch fixes tx promiscuous mode settings to accept all unknown/unmatched unicast macs and works out the scenario. Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_l2.c b/drivers/net/ethernet/qlogic/qed/qed_l2.c index 67c02ea93..b8baa6fc 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_l2.c +++ b/drivers/net/ethernet/qlogic/qed/qed_l2.c @@ -609,6 +609,10 @@ static int qed_sp_vport_start(struct qed_hwfn *p_hwfn, (!!(accept_filter & QED_ACCEPT_MCAST_MATCHED) && !!(accept_filter & QED_ACCEPT_MCAST_UNMATCHED))); + SET_FIELD(state, ETH_VPORT_TX_MODE_UCAST_ACCEPT_ALL, + (!!(accept_filter & QED_ACCEPT_UCAST_MATCHED) && + !!(accept_filter & QED_ACCEPT_UCAST_UNMATCHED))); + SET_FIELD(state, ETH_VPORT_TX_MODE_BCAST_ACCEPT_ALL, !!(accept_filter & QED_ACCEPT_BCAST)); @@ -2688,7 +2692,8 @@ static int qed_configure_filter_rx_mode(struct qed_dev *cdev, if (type == QED_FILTER_RX_MODE_TYPE_PROMISC) { accept_flags.rx_accept_filter |= QED_ACCEPT_UCAST_UNMATCHED | QED_ACCEPT_MCAST_UNMATCHED; - accept_flags.tx_accept_filter |= QED_ACCEPT_MCAST_UNMATCHED; + accept_flags.tx_accept_filter |= QED_ACCEPT_UCAST_UNMATCHED | + QED_ACCEPT_MCAST_UNMATCHED; } else if (type == QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC) { accept_flags.rx_accept_filter |= QED_ACCEPT_MCAST_UNMATCHED; accept_flags.tx_accept_filter |= QED_ACCEPT_MCAST_UNMATCHED; From patchwork Mon Jan 28 18:05:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Chopra X-Patchwork-Id: 1032113 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=marvell.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43pHfK0R1gz9sDB for ; Tue, 29 Jan 2019 05:07:37 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726954AbfA1SHe (ORCPT ); Mon, 28 Jan 2019 13:07:34 -0500 Received: from mail-eopbgr750071.outbound.protection.outlook.com ([40.107.75.71]:50166 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726738AbfA1SHd (ORCPT ); Mon, 28 Jan 2019 13:07:33 -0500 Received: from DM5PR07CA0037.namprd07.prod.outlook.com (2603:10b6:3:16::23) by DM5PR07MB2905.namprd07.prod.outlook.com (2603:10b6:3:9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.17; Mon, 28 Jan 2019 18:07:30 +0000 Received: from BY2NAM05FT037.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::209) by DM5PR07CA0037.outlook.office365.com (2603:10b6:3:16::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1558.16 via Frontend Transport; Mon, 28 Jan 2019 18:07:30 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by BY2NAM05FT037.mail.protection.outlook.com (10.152.100.174) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1580.2 via Frontend Transport; Mon, 28 Jan 2019 18:07:29 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Mon, 28 Jan 2019 10:05:18 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x0SI5GMe009947; Mon, 28 Jan 2019 10:05:16 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x0SI5Gew009946; Mon, 28 Jan 2019 10:05:16 -0800 From: Manish Chopra To: CC: , , Subject: [PATCH net 2/5] qed: Fix LACP pdu drops for VFs Date: Mon, 28 Jan 2019 10:05:05 -0800 Message-ID: <20190128180508.9902-3-manishc@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190128180508.9902-1-manishc@marvell.com> References: <20190128180508.9902-1-manishc@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131931724498551654; (abac79dc-c90b-41ba-8033-08d666125e47); (abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38; IPV:CAL; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(39860400002)(136003)(376002)(346002)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(8676002)(105606002)(1076003)(97736004)(69596002)(81166006)(2906002)(446003)(81156014)(86362001)(48376002)(2616005)(76176011)(476003)(68736007)(486006)(11346002)(85426001)(336012)(6666004)(2351001)(80596001)(498600001)(126002)(50466002)(106466001)(47776003)(36756003)(50226002)(8936002)(16586007)(26826003)(51416003)(316002)(54906003)(107886003)(6862004)(87636003)(14444005)(53936002)(26005)(36906005)(305945005)(42186006)(356004)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB2905; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Fail; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BY2NAM05FT037; 1:2YrcVVZluPfvhWdN0X8+3q9/Hiq6yZm+S+GGekemew/ZBgf1yJa9UA13SJ7EuD8mMby4qg/XB3Rc4W3cY1h83qfdPbb5OYhiR/+gpXfQWvVZtzMMNcPkIhnFSl8OAbYfC/8hGuCaO+SG1Bu309xOYNJxXtFgEu6BzWj34sSe22A= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 239e77b3-1ba3-4da1-36f3-08d6854b77c0 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(5600110)(711020)(4605077)(2017052603328); SRVR:DM5PR07MB2905; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2905; 3:bEWW9SjFr6z2FVee5QPMv1kyQCebFcTZy6hpQkOruiFZ5fpISJIpRL+aoC1oiV3E5AmuL4JRj139xJdoiK1bE55SJhof5pE2vERObrBQ+eQLybq4lW0QtkSTlKcwblZEqTamQx1J7a0aCts612y1fRjHXwqyA6wcmABiCVfDpcwmnYyKVAaQcj2zhxh9iMe2ZaozCMwTzyZWWWH5Gmu1q86fG8yOp7xgR4tFL4F7PehI1bfWwybChVmtwMycsEVQ4PUpRUaykb1NexpiyytFTqY3Iw3J0gTHxn+344tWKKteK4Ae7H6oWP49Rw43fYsYAYTxpq5E97uLp6cTrspGSLoyYVQmKCjU6aFZhAO/Oee2GTk9Dm/66gJkffVsTgzA; 25:Czz+8NYG0uVXazp+61U8pKZ8vkxTq6kMQHoHYnwL0TBNCktciIRHl3jWUN9R4tO/QbfN5N4NR2clVWA0fo+BBCgEZi1PEeNmtwxrn2E8c+paoaP5BErdhxjHJ2Sd2/ZtMXMGPb819lkkiVrD8md6Mlcq9H/24SH1aX08sOKuW5vrMvEEAfOE3T1IR9JZ0KIn092HDVoUgxpNGPWgnJAqmcdgW0HQvbwAXfLm2aexsR83jrHVNQDiwIDusb8zdICoxzvtdenmkp6c+SjS+rWK0fMif0onppdORWmLV4N3Bwco9Zbo/G5QR/XXyOgWsjla2mMLaAohJ2+hwDK0NnLn5Q== X-MS-TrafficTypeDiagnostic: DM5PR07MB2905: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2905; 31:WFyWOcFlda/MjODhAM2OlZ4dcVqEhoBht3LVMqCC+5Oihtx0PWbXketS4c0ku9OH+Gdqi9eYi4DT47gf0m22KHdbr2FS0gU85lK9S2f46ewXLE5piyJwofhB//uq+qSxSre0f6Cp3711AqaE6Y/DTTSFvvQcx+D8JtH1Vg5jAmHK+/w0ARhDXa72ycpwZa1GWpzyLALprBpVpCSBn2JK/9CE/BxNWCXyHoM4Sky9Xe4=; 4:jFTOXBY7fGxTIr8dfQI5rfxisaGuW9wPTIWJlP61dCBJsRg60W3qYZ+PXF6tWazYtCJDGZgiFqsWpx1/537gpton6HOxQtRVrCAa6oj0ZU3NL0uWwMvooB/Oqgh13Dv4YsPDvCA7lgUB4bdW27B0JJHzeXPbTMbMgLGjf3gsnRIusUkmeCtDlvxcIuQYtfmPInVDWGJOr91MbLdvCkTJXFzNb6iXXT33xvH/purAmxz3SUOktHbnZNhun5ARjjtwzzBodcRLmuUcgTthC3vHpl3+cWnqPLTfSvR28DiCogmPLFUPEABUuTlPRZaHpCO2 X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 0931CB1479 X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2905; 23:UBZ3Cyk2wiac662t0amB+9LGFzJSKcmzV02+rtn0f+0+IBhicEbOrHDb1gQumrqtykVvUYFyOkaIgZGgJNGctta7IprgRF9Ba7XTNp54ramfPf+DAFUfQMsd3S/1K4saXZ0ddVe6uRV9z+Bp9baryK9ULnjoik/iwYnpa92yXz+fW5+oT4DosjREzZvuPrl0eYbWb9DpYd1d2noVEA4hVsq+iTWepoj7Tld/MXOHqAxbK5hh0h990MeHIRaQUfgziEE05Wnsh5b+Hwu7E/rycLav5QEb9E2iU3pGk+4RivcmxSmQ41dFfL97ch46b0b9LikqKSeCEGaOQes9QaFjGs62J1iP9dO0pzn/gD3dura25baqr6ET6NXljRIwpvAOsa8ROv2ZN/bPqgx+Iel5JtJKEhZ+Pc3ViSJILfxaJThzuZUEN1kGDKQfbLF5UkbN7kEZBE/68PaaGZY5MCzGeSRTvEoK2KrLggWCNNP56AEEJVTF4SYDOOfNmTLVEL8oOwf3Xlk6nGbAP41S2HIG8vL2rQnQ+D4yW6tB2lXhKKU+DiLM6t/Oo7WEsH33jBa3blkySOiuYEhnel2clsy7XtZf8022LAS087/3orqSNbcKUMwz3g96Kr4Qx5yB8043RuGF0MmVjYsLhnZPQJ1tbwTare2JTPFrR6g7QFU0Uwh4Ni7W1HR0n7CiSDha0OLK1JatXCL8Bk12h1JBUo8b1tsb4qW7vbXAYdR7Alo0Cn/+7bQf0aynSeGF8xR/axA8nWjTzcbO4SdB3cn07pnqWojxT0tFEQXtUkwN1TXzH7JrsBW5f5qp9WpEWfGODxxTyv5UJ9gcAQf1djIm1PYicMSlBTnJzXLtg2pYUwRjAqElno8uCTqYrOu+IHe5fczIk0IS13Ic4D69IjCza+W+JV9cqDu4n315om0O7kMJjOFGYRU9N208kQAqvALLQaub+s5smePZcWmhOXB8DHC7JKenKn1xHBrO1lG9QBokzYX+QPz450Pbe8N8hivinim5GMAamr9aDNQJZYatzkXmGx9eJvK1gX955bJ8BUXA20lW4RiWe+8ljz2WDk4f/ET59gP8bJAdKCNPYkv8xksCJZftYFD+A5ZVVvdn34OzU1Cn7kNdtxm8XdJaE4bVaRVFB9SETti+jCs7/AHCUziNLSf7bMfuveU8V75go8FPZVJWAv6u+TQHRW1QkYOPv1Axl7HxrVgkSxD86GYY5HMZ5v/Je2Icxbfj7XDEzpUfc3KowuqaVYiqQVWYhb/gzrUu X-Microsoft-Antispam-Message-Info: iXI0Rz6X8eJONJ5kSS+YQM/d6Ae1P/NAHOubh4rEsh0fhC/2IsdXTq56hxG+oKQo0LWxSBdSaW8nHWyi7o66uS39i2XZSfYHZIT+rL/MhzUtcAXfysWQMSZhzbk/iRTpgxUPMt/H9VLoU07isjyrTKorEBYmZgZhCOWBISBIYBVQZRPIarGspIyawYvC9oVMPwkQ0hkxDaEiWfE1wiTJoD+vU6kMq3OeNk8xDX6cAlZSdd0aOjb2gMNemfyFeFnjcgtnNft7TNm9p12R9htVaXwcIApRshjeCuT6g/Hbx+QNWhO6IqT1lU2lKYA844pKvygltuS3D6W1vkDT4uw0JkIj6pY8AjkP16aZzrUqWavhphA6/2vS7bri6+wPTcVjI1sUFp1QdLPobhAm0e8MFQyl3yj+UBQh4OA9bOjny0w= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB2905; 6:RXPpOkHmS/oaZjfs3rh7GluKWJLjIBvQd8iLi418UnK5DvjYMUPjx4GSVrMCSf06IEpjOWBgqX6T69YCeQu068FEnp5Pw9JIt+Q4+8dZi2d5GvA9RsopfSJKOeqACGeeQDG+Pd6oP2P+fT7EhNsVjuLi7IjbBSLm15Zw2hCFC8sEFato2lynNohEBBJ24gXHNmc+jJTVrodSTvfrJ52MdCB3ozJ0Q/Wj8qcvKYG004vyAUQCSxjdQM4sVMjHFzi3KUl+3auxkNMlGnnhd+RFRlUDcB9MmbSmG4tkDUHXTdnqXYyxFBo/Y5vVabHyCowS1W0uB1RUYjCrCNviSh+meJGK1gDz81xmtFbmdatIUn4j1WTikTzqqQIhxY8MZI1le8+OyhuKv5uQ5v8XRzPzCaSeNRjw9AvjUe7MlWEeN0xCqXDI1q2q+h7jARAkGW0YQuyjoeixTr8fg8Wpql+xcQ==; 5:/J//nL4C0xFciPwWu6QKcYZL5CATpXJ+YNKye6ESiwUQw3TbN3ZBMhoMOoa5WVsnjNiiAtDH2u8roWSeFtSjFAeZk5DJv/bR+chHTuNpBtiNnTrcwkAdnXYR6V2ZWZMAj9vnPLEVP0pK6U0AZKxGgS7Olxe4EtO5TBPRmkMHm9AmB3W1d6FTo6EoqXQOP6eW9vxXOVvUtA2e/JDwWBc2Qg==; 7:Bvsg+QdWq3kejW2t41KwBWZYCaMDvHb8kA3RrnJDxQ//girfyZBWOjDHfL7rnH34XrMLdtDp5nFni4HzHO2ijRbmQ+OOtFXW/exrMrE9bK4yzTUHISRKN4Mrf3rKmcaD6aRhtJg8JuK2d2nFBP5RWg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2019 18:07:29.5078 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 239e77b3-1ba3-4da1-36f3-08d6854b77c0 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[199.233.58.38]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB2905 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org VF is always configured to drop control frames (with reserved mac addresses) but to work LACP on the VFs, it would require LACP control frames to be forwarded or transmitted successfully. This patch fixes this in such a way that trusted VFs (marked through ndo_set_vf_trust) would be allowed to pass the control frames such as LACP pdus. Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 5 +++++ drivers/net/ethernet/qlogic/qed/qed_l2.h | 3 +++ drivers/net/ethernet/qlogic/qed/qed_sriov.c | 10 ++++++++-- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_l2.c b/drivers/net/ethernet/qlogic/qed/qed_l2.c index b8baa6fc..e68ca83 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_l2.c +++ b/drivers/net/ethernet/qlogic/qed/qed_l2.c @@ -748,6 +748,11 @@ int qed_sp_vport_update(struct qed_hwfn *p_hwfn, return rc; } + if (p_params->update_ctl_frame_check) { + p_cmn->ctl_frame_mac_check_en = p_params->mac_chk_en; + p_cmn->ctl_frame_ethtype_check_en = p_params->ethtype_chk_en; + } + /* Update mcast bins for VFs, PF doesn't use this functionality */ qed_sp_update_mcast_bin(p_hwfn, p_ramrod, p_params); diff --git a/drivers/net/ethernet/qlogic/qed/qed_l2.h b/drivers/net/ethernet/qlogic/qed/qed_l2.h index 8d80f10..7127d5a 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_l2.h +++ b/drivers/net/ethernet/qlogic/qed/qed_l2.h @@ -219,6 +219,9 @@ struct qed_sp_vport_update_params { struct qed_rss_params *rss_params; struct qed_filter_accept_flags accept_flags; struct qed_sge_tpa_params *sge_tpa_params; + u8 update_ctl_frame_check; + u8 mac_chk_en; + u8 ethtype_chk_en; }; int qed_sp_vport_update(struct qed_hwfn *p_hwfn, diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.c b/drivers/net/ethernet/qlogic/qed/qed_sriov.c index ca6290f..71a7af1 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_sriov.c +++ b/drivers/net/ethernet/qlogic/qed/qed_sriov.c @@ -1969,7 +1969,9 @@ static void qed_iov_vf_mbx_start_vport(struct qed_hwfn *p_hwfn, params.vport_id = vf->vport_id; params.max_buffers_per_cqe = start->max_buffers_per_cqe; params.mtu = vf->mtu; - params.check_mac = true; + + /* Non trusted VFs should enable control frame filtering */ + params.check_mac = !vf->p_vf_info.is_trusted_configured; rc = qed_sp_eth_vport_start(p_hwfn, ¶ms); if (rc) { @@ -5130,6 +5132,9 @@ static void qed_iov_handle_trust_change(struct qed_hwfn *hwfn) params.opaque_fid = vf->opaque_fid; params.vport_id = vf->vport_id; + params.update_ctl_frame_check = 1; + params.mac_chk_en = !vf_info->is_trusted_configured; + if (vf_info->rx_accept_mode & mask) { flags->update_rx_mode_config = 1; flags->rx_accept_filter = vf_info->rx_accept_mode; @@ -5147,7 +5152,8 @@ static void qed_iov_handle_trust_change(struct qed_hwfn *hwfn) } if (flags->update_rx_mode_config || - flags->update_tx_mode_config) + flags->update_tx_mode_config || + params.update_ctl_frame_check) qed_sp_vport_update(hwfn, ¶ms, QED_SPQ_MODE_EBLOCK, NULL); } From patchwork Mon Jan 28 18:05:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Chopra X-Patchwork-Id: 1032112 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=marvell.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43pHfH33wTz9s3q for ; Tue, 29 Jan 2019 05:07:35 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727032AbfA1SHe (ORCPT ); Mon, 28 Jan 2019 13:07:34 -0500 Received: from mail-eopbgr820075.outbound.protection.outlook.com ([40.107.82.75]:17584 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726926AbfA1SHd (ORCPT ); Mon, 28 Jan 2019 13:07:33 -0500 Received: from DM5PR07CA0043.namprd07.prod.outlook.com (2603:10b6:3:16::29) by SN1PR0701MB1933.namprd07.prod.outlook.com (2a01:111:e400:517d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.17; Mon, 28 Jan 2019 18:07:31 +0000 Received: from BY2NAM05FT037.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::204) by DM5PR07CA0043.outlook.office365.com (2603:10b6:3:16::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1558.17 via Frontend Transport; Mon, 28 Jan 2019 18:07:30 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by BY2NAM05FT037.mail.protection.outlook.com (10.152.100.174) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1580.2 via Frontend Transport; Mon, 28 Jan 2019 18:07:30 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Mon, 28 Jan 2019 10:05:21 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x0SI5JHZ009951; Mon, 28 Jan 2019 10:05:19 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x0SI5JAV009950; Mon, 28 Jan 2019 10:05:19 -0800 From: Manish Chopra To: CC: , , Subject: [PATCH net 3/5] qed: Fix VF probe failure while FLR Date: Mon, 28 Jan 2019 10:05:06 -0800 Message-ID: <20190128180508.9902-4-manishc@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190128180508.9902-1-manishc@marvell.com> References: <20190128180508.9902-1-manishc@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131931724508169642; (abac79dc-c90b-41ba-8033-08d666125e47); (abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38; IPV:CAL; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(376002)(136003)(396003)(346002)(2980300002)(1109001)(1110001)(339900001)(189003)(199004)(486006)(2616005)(476003)(69596002)(126002)(11346002)(80596001)(36906005)(446003)(2906002)(42186006)(316002)(54906003)(36756003)(86362001)(14444005)(6862004)(1076003)(68736007)(336012)(16586007)(85426001)(26826003)(356004)(81166006)(6666004)(105606002)(50466002)(53936002)(4326008)(498600001)(8936002)(87636003)(48376002)(97736004)(81156014)(2351001)(26005)(106466001)(51416003)(76176011)(305945005)(8676002)(50226002)(47776003)(107886003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0701MB1933; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Fail; LANG:en; PTR:InfoDomainNonexistent; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; BY2NAM05FT037; 1:UsvFYory2IDkrK47RdFen/jQZtweVAKc8Ux/YHLt29Heq8a4q8/VrIhUYwCD4CFu4t0++fEl2tArPz+ww9Kmb2zL2EDs69A6hI+c1K75hEn3hR+cWdgFuKliTvnqW0CfzhH4/xiq5QNqBM+Z/lqT+l3LkLq8xnJp5RnYUsQSVts= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e83a63e1-b0dc-4652-b77f-08d6854b7860 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(5600110)(711020)(4605077)(2017052603328); SRVR:SN1PR0701MB1933; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1933; 3:tUNkouY6R8oDpdC3icQhwM1bH3fQXHvjynTQGxXPLXWewes7bzFaKd6ZWB55ftyCFUssCS1xl3CIUKWtJ+PkeKxY0szSCDBDAVClhEbacsmpJCTYDfX22kE3L/+tmNSxJdYmdTpJ3Y+s8KoKc784n0UdJhJrPKm1+Jn10h9ITHxRH44+MkGYqSkFE4VcHuzytUS/rOnGpXlZKATYSvZTrEypBrF6P14uWq8g/pcIvQQCVqjbED1Cs41vi4kxdxkdkwFMQF2vvtkMgpwhtsGyNrOuXJLaWBNbwpcKxZy16LGWfoc8dtz06bVkXrbljacPdotamOAErFrnuVcBc9ah6TcMWnBj+xRKcmcW5X1NmJENOMjqojZV+AsO1ajpIjhz; 25:mr1pB61jrFHoUbUUhoof1OJBisAN2AtIfiZiVb1hJL5ycQCW8qkZoGAbIvoLZPsFWwSrUalWhwVsp1wmd27akeCqa2oO7jNNFHfPxV+5TZpFVYC/s1HYIThZGb3fL6COaiCSbz8kjbSnUkBufTW7/KHI00PMzvsRYmRtHIOJg8wvPDkO8hhWsgoYzeOYkYJNMsEWsbPoWNvooDW1GPH6Xiwh5a85kL7Df7vq/N7AgoSHLsjez0paxleETyiTjn9x3jk9mpHsoSlS0dpw4GWPAN/3bTvjtjraT++preHgIn6CW7mD/EqPu0x0ysnCOWuOJcg/vrbFUtUnplRWWM1bjA== X-MS-TrafficTypeDiagnostic: SN1PR0701MB1933: X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1933; 31:MxfEJayKRqVuFbnA2hEqXQbkHVv5YXrQPhB6k/dGLNgwwZYkDYsmree8X+tIAqMa/iKfuLGhiT/op4PKAvQHlRGOR9eK5LJwJWELIDJUWU49zMHe/8fcgRl15AWcPtWkqk4seC0XFr/5mEq93BdvWAsZfKL3Ws/TbQ/21LxZ+MIF69a1fzw+qlIIeWpFW9Ez9DzsBpOJ9jHLOTMiUHvsoMcjEQYDcWUY+6wQPN0k3yo=; 4:421FL0R9rKqKmTjxUHLxFp3NAURrh/D32rMoY5KlGJ3NKQsnfl7LUq4cCj+X3/lfy3w6CHo+bNoXjIHhe+bgdeFFmUJsBxdd5EM3oOo18/AtVigqR8kiN1xXC6PJHBmv6VCbaduKoyzZiLRSqu8O4GoHLf9Dj+IU7W2Uuv6OGD8rMmmnupyDLr6MEa6DbcTe4W+awrsXW0ekB5YSou4Yx27gkr6PGAkTBi6Lz4CsawEIQkxQSqLZ5ynLKpnhPxfFThvhMVMSSmWf1jz72RJvPc5doZIWvyQZsJqIWen5N7vp90q+clf2k9se0+wAFgF4 X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 0931CB1479 X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1933; 23:bdgYDwXSwWzTHnr8Sgf3EeO/mrl2DdohZCHtJDuIExzaQFTrhdAGdYO6grcT7SA2eUJ2P8UaE2nX1CHcIGqkG+qRgEcBbEDnYSSdIMWkG5X3PvC27PBxzyIHuN2b/vUAXy5XPglGK/lK8R06+ttobgPGw++iCRWxtg8Zbqmgeskdzn7eJU4RX/3Z6j+7jHuGPEwaRVMiZ4D5euMYrubzi2lYMnLPhBAqi3bFw/dF6JMMRPJ/cGL9UYXdjYgnqXodqsWgi+W2rn5DP8qFhTQn/X1PkP2ICFzQfpVzY+z98D9JTjeXw77h0CEDa13s/1AfA/xNMzXBgw9FlVCdwMtzKf4kA3GsjKl0wP5j65bmd6FG5NmHgm7vbSb6AFOwZk+HrzJCbMU4gT013prn0Qo5rgYEPH+IGjO6n/YGpid8sUv1LgBFDtjIRbpIbyQ4ECYOhlKryoPBRmSgHt1HyPeH6yDxbbNNquUDr+UHJ5GL+SkJDG68FYS24Ng4KpXwJq3g1zLx8TVsNJ9iLrr5kukIw4vKnkXD1aq9Rc2CcGlDd+GWPKLw8EOYK7zzMYr50+YrvK7dBQ2zXjnEKO3Dy+/ETUyPX06bHd1mFqaPSFRt4Y9t8LGirINozui0ECytlLCg2WJyW8ls6tFIhKoaboR38Qz6yGcXgaInr4KppKvLMS5YDjLn6w7ezGm+8Zht+HZjPGc2Te+lvbRTSaxLmDxvM8DHxDyHVS6B7lkCKqZmDb7mLV+3+tCxJDBbUqoEcAOmIJTkq0N+gfLlzU0Ym3wQdSbVaNzIoiXDI3blnpQKiAkE2MTL9Ti2ENCPY2KxE18DFtpztW7B/fcNwpVDsQFi80sioAozsYnjSFZVXuOLHjVA51kbd9OVZQgAhKC2eMYxvYBQsXaWLxljvsqQh1FWypA+HiqTPrj48PdkrlTGTe0J/qahgxpwEL/5FxAPh2uNb6Z7zysFi0dONYj8F3AsowFrI2zOiHehH/Sxqp3F4CGLiSKbPjq1J5agXAI+xnv2Ho6hXtDlLiN9W9c8C8decnxp8J1uOhmDYOkXbOZPlYdZ3iUOYQ0yYCuAS5+0ucP1ZulxSdDZU0ZK0UA44uXJWGNs/iSSssN+1OI/+Zm2Q6OiJ2dXsZAO2HzMzTStSdGexkSmNVkD+0rWdGLPD//fmMOqEwJmKoqDxQMkJ5OuLqQcdB2QT3OTD7grd2tOucqHpBd6BHGmqqOw65fXG2ddctkZu+5+zaLXSAANnREk3oEgYVqdSHA+/6UmOPc4UhKx X-Microsoft-Antispam-Message-Info: a08ljSs9zSf+H+tvrTFIadSj4Arf0A0cf3PaKB6nFzfu1Deqz+sVArIJxVWWrXqJa1t7LXzT3KlQY5SVytb5ijwHuxoe5lZhAerEJ5XhxSlshHw79Vvlmx800BiLe1P71Jo9vDYCmsqPSiEBd1sKAgAraGIG/yIujM4lA83y9zTcB2cF5xdoVCM7pqBtRw6Hr+4eDkgBhXg3i7FmlOoI2ex7wcRFF0hviJFouAFzZMkwf+4LYKvtBdDXuZIhD7++vHRWlBFzJ+9xchUvawQGFNMyGCDl5v9nfq5effFt3ApSAxeP/MheuDk4g669vAh94P074aji+5bx3XGgTQFVY/rta/BEj3E8jg8Ny3rIs2BJK870zSy7DfVmn9T+hLc7CnDp33qEO9FA5AW2q3aGN23HiugsKvwYiQokza7IUJE= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1933; 6:RD+tVFhG0DKgOpJICj4xif0di29CCnpsZUiEFnDzlBL7b+igTKTy3lDPHKj7WhAP5FZqL9JGG0SAr8hWuD1SMt+CHHTM3GW15D2xBerkzpuxm1dhot1ngGI9iKY0PlTE2kBvsaDFBeMk5GMEvlpM29XcdLVfGtgbWEvI0ROLK7psuApnumt0Scw2Dzb6QeDbvMqPz3TIbYkxt/ajvV+SbQh/UsWt1XuFmh/VrfkyPEFF2SOQePnRqse4+NNFtn4NWQ5s6qywAmgqgyHfZJgHx486i4nALe9hrxw3Y4ELqiV7H4IzGXfP9jrjSVhEE4TQ0EFs0o43Vfjz2K7hlxvcREypuliLNkgz4uPFg0RjEVN4Z4QjaJtzq1tS4FZVEZnYatyPUjqzPdn4PVs3zpeGhuknE6d9vww49IaGac/dNNjmM7eCIZZTl9nipo+vKDFPUoSJhKbGWd/bo5lF+RsenA==; 5:DiOSbM0KH2LHzkyLXRyZt3t3LwdaxMtjAlosr1LKQx6F6aBBWUA+wrUzySYouhTzsqAEINcYQh6qXp5tdjTRO6WmPDUWynY5fLaJB0Mdt8r1VhepBKqdvQ2ttJA2pgBaXRYIi6NqG63Pb1rBW4N0Cycx+bWi3y1byS5wkH7uMV6P+VDOR5NVqw+BnMD8H/5WbiEwNSLNRhCBJY9VicnRPQ==; 7:kBp5koM/FGlbQXUpKYJaZqV16F5Rgyz8kyim9LOHneMwy0YDooahAsJqdf2YLgcPgLwTmzNaE9TiMI+HyAxVNHHf+FCfBsotZmNTbpW2wkmApC0nm4QO/Wvmm1C9NXtPh9yNCQn+GRxRAEYcQnkI6A== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2019 18:07:30.5627 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e83a63e1-b0dc-4652-b77f-08d6854b7860 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[199.233.58.38]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0701MB1933 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org VFs may hit VF-PF channel timeout while probing, as in some cases it was observed that VF FLR and VF "acquire" message transaction (i.e first message from VF to PF in VF's probe flow) could occur simultaneously which could lead VF to fail sending "acquire" message to PF as VF is marked disabled from HW perspective due to FLR, which will result into channel timeout and VF probe failure. In such cases, try retrying VF "acquire" message so that in later attempts it could be successful to pass message to PF after the VF FLR is completed and can be probed successfully. Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_vf.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qed/qed_vf.c b/drivers/net/ethernet/qlogic/qed/qed_vf.c index b6cccf4..5dda547 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_vf.c +++ b/drivers/net/ethernet/qlogic/qed/qed_vf.c @@ -261,6 +261,7 @@ static int qed_vf_pf_acquire(struct qed_hwfn *p_hwfn) struct pfvf_acquire_resp_tlv *resp = &p_iov->pf2vf_reply->acquire_resp; struct pf_vf_pfdev_info *pfdev_info = &resp->pfdev_info; struct vf_pf_resc_request *p_resc; + u8 retry_cnt = VF_ACQUIRE_THRESH; bool resources_acquired = false; struct vfpf_acquire_tlv *req; int rc = 0, attempts = 0; @@ -314,6 +315,15 @@ static int qed_vf_pf_acquire(struct qed_hwfn *p_hwfn) /* send acquire request */ rc = qed_send_msg2pf(p_hwfn, &resp->hdr.status, sizeof(*resp)); + + /* Re-try acquire in case of vf-pf hw channel timeout */ + if (retry_cnt && rc == -EBUSY) { + DP_VERBOSE(p_hwfn, QED_MSG_IOV, + "VF retrying to acquire due to VPC timeout\n"); + retry_cnt--; + continue; + } + if (rc) goto exit; From patchwork Mon Jan 28 18:05:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Chopra X-Patchwork-Id: 1032114 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=marvell.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43pHfN66wLz9sDB for ; Tue, 29 Jan 2019 05:07:40 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726879AbfA1SHj (ORCPT ); Mon, 28 Jan 2019 13:07:39 -0500 Received: from mail-eopbgr680080.outbound.protection.outlook.com ([40.107.68.80]:3200 "EHLO NAM04-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727035AbfA1SHi (ORCPT ); Mon, 28 Jan 2019 13:07:38 -0500 Received: from DM5PR07CA0083.namprd07.prod.outlook.com (2603:10b6:4:ad::48) by CY4PR07MB2901.namprd07.prod.outlook.com (2603:10b6:903:26::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.18; Mon, 28 Jan 2019 18:07:36 +0000 Received: from BY2NAM05FT053.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::209) by DM5PR07CA0083.outlook.office365.com (2603:10b6:4:ad::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1558.18 via Frontend Transport; Mon, 28 Jan 2019 18:07:35 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by BY2NAM05FT053.mail.protection.outlook.com (10.152.100.190) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1580.2 via Frontend Transport; Mon, 28 Jan 2019 18:07:34 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Mon, 28 Jan 2019 10:05:24 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x0SI5NME009955; Mon, 28 Jan 2019 10:05:23 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x0SI5NWb009954; Mon, 28 Jan 2019 10:05:23 -0800 From: Manish Chopra To: CC: , , Subject: [PATCH net 4/5] qed: Fix system crash in ll2 xmit Date: Mon, 28 Jan 2019 10:05:07 -0800 Message-ID: <20190128180508.9902-5-manishc@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190128180508.9902-1-manishc@marvell.com> References: <20190128180508.9902-1-manishc@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131931724553437378; (abac79dc-c90b-41ba-8033-08d666125e47); (abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38; IPV:CAL; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(136003)(39860400002)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(105606002)(107886003)(2351001)(76176011)(486006)(2616005)(126002)(476003)(47776003)(6862004)(336012)(51416003)(106466001)(14444005)(50226002)(11346002)(446003)(26005)(85426001)(69596002)(80596001)(16586007)(54906003)(42186006)(305945005)(81156014)(87636003)(8936002)(53936002)(81166006)(316002)(97736004)(2906002)(8676002)(86362001)(26826003)(48376002)(498600001)(4326008)(36756003)(50466002)(68736007)(1076003)(6666004)(356004); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB2901; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Fail; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BY2NAM05FT053; 1:4VFNUceh0aevd7cbrDMAcMDjM1eT4uSbmaAMNpjFpaWMyMJtkdrNU25LLmUIKwdzwr5vHQ5ucaSz39XyzyZiZv5XMOPOVQvrJi+jbGC7rkudBQZuCpfsTaxOmXMLLT1fNBiYcPH/xHrQx+I7S42YmyUzZKBdpJzqmFoyudfNyp4= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3345e38d-42b6-4d18-b48e-08d6854b7b05 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(5600110)(711020)(4605077)(2017052603328); SRVR:CY4PR07MB2901; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB2901; 3:UsJ1fcztsFCnQVtlc9GcfWpJqBPUzaABdAcSC854Tld3oJ8/fprmPTlVb/JdN6b+JEcx+DiiAdWElzW1ck8eIPM4XbOb6pqS7hLkvPt6gE88qyabenEVPQwu7mua4r8cLywWFKMmYreDc87DzW1cm/U1/53Z/0KT4GbWmAYSsVQ2XKhMeE0ULJ5ClNKgLBYJIQ6AHRogjyqy9PDNEhjsrW98Ni3CCD4+jCbR2E8AhFBLKrkVIrs/0d0EacaPT8t1bPW/UpNDCfeKNovJ5nQBFnY6IGsIIGWDa2a1d9Pod8+Ne7f301izYIcTL4YPHPNfz8Pmd/QNeOEVP8FSuWNKuU4TjPKENsHLWAVW7kOR5oaQv7lYqzdp6EfjZhrrc3gV; 25:ILx2nSuHWfFVHUdVWLbVpT2drPZrJWdoTT9HPEH3KKR5BiwVv/RJefF0eLNBOXq+trT3Fi6iG/rmpDd1reEvTGPjCv4ww9ss5ILCJaaFYv1fQ+KvX1Njl4+Cz/oexs47sMqGNs3r1JkYXkpXOkkZDudAVqR9p7mfV2tECRAYdfQiNvct66hhIkjUHme5MWO1TKLAGdTl5Q5ct0jcekEg+YeR+WK8xA4c9At4y5Yp/DffoZgOulPNZWv4TBCI9jivbrLKVTyNixlQ9XNVVoqB+ub0o7Od8afNfA9s6CH8mHhsKxgA4GvFI5tm/Evub7Ths3Sg2YGWKLtCw1UAasiASA== X-MS-TrafficTypeDiagnostic: CY4PR07MB2901: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB2901; 31:amoV9SlIUrmK0oat5Hr16qcMEFJcWH7rnWwk3VhuKwjRVEHxDSCXmACP1jwzBFxVrszMYiYGpspmBKKrvvDvxFqM0YFbHbRpxyINfZ5Cjw6cFqgwBSIVSHgzFoqLYUKcg1jI17+FsSMu9GAkJ7MQlZvtZdC6T9RyNeEAcUptohwAeBebroC/KX77KJMmrulnekiCFUDdYjrp8mvSyjALcPOxe7lLANfjlSjOuEuxQTs=; 4:ufF5AnnxQTFSAbzbNUjBdK/qLP396JtEb53/zagA2PVMBynFuujQJ0WvQCg9mff5Jr2WyphGyrSba/6QS1uWk5ad1itx4ZaVBPdgFi3WwBtoAJZdEbj2r6H9cPhv1AR4QGK9rvoylDpjmXQoBGJhVlVogCmD5ZIoaTwUMHF2m/3jWKiFsBRQEv65X3Xam5ea0T7w/0ndQyJEenMAv2Qfg5vOaXnW+mMogfCO/DUiaItDFG07gOx5aD0eubw9xVdYxm9vtjDhQvqSsHCMb8nXqq48QGPn8RQJJ0lUxve4toA= X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 0931CB1479 X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB2901; 23:dcSHQSSmeQq8zRyhchFkCNXPGgyc0cnZW4wjl4IZDF9dZD1Daw/0dZYLMn2pPzXROCRA1YmBV3oPQxtYAWCca5t9btXV//HOIEK8FGdkKab+sDcTM0g2uWXu2Qm+9M8hNsV7ZbkQtl2iFfR967Opg5UVO5obNtn6yVXFx962LtTctQbTRqMwHBXxcL9jFpCFDm9Hv+/RoBoY3gCzp80AztSGoaWAUFX6mltfSSxWnQygT2oW9f+sUYYOSzpBbowrevD3vdoKAvOWvhdGYRvsfbk93Y8xhCbvDQogMiRDfx9RvZS9bgMb7C1hmL4qsNqY5fZUZXyN448ZgxJsvjkGm5MwqEGDoXSlP1KPeKrxvKSnO2aOvKtHhK9ydHNtl97mHHtNEX6FaoC0Z/cheW9DldS45RTYAoMWq25tAFWGWbAXhbT1ljsMUu7bYwFbo4RiEkI7c6/Ck+Xh67dSletbJ4jnBm2aojXBUPbzB9Kt4mQdZfycTLnUWhjqMOGLRgpUwaiu0NChy9md7l99htesll4Sn/NYO9XHkDVwlu0+R40j6Z4tRaTkJFKTo1FTosJPhxw1KYWjPGLCR+1G+4ddo4k0j1PSE6iIdZSmHFckMfy8wMETAQQgYPXnJy5d4yeYeLAs8nhQpNdpZvk0wekyWSTn0yoyrgRYbdZa5CyJRNmPEWD0yoME09N9gnkRP6noXMEnWDY95nVc/a7qwWEOQey+Tx0TniGUJXDv+AXoQ3M0fHSiIWRcXV1skkXKMAOJ0O0rAkDUI05VWCSAFwlxkbrQVMkOMd3lwT/6R9tseruqJDz5/9sv7L7gxFbKiNEyLlL5tjCYpF+1J8i+mjW8ypJm7rj6+YSdPDp3jUZUAX5PgflhbUCwphci94zTqrMX50ja/0w+RKaFfdSmaUKxq002BlUIK17uSKZwzM2LNIW1bZWH8xXG657rE2a1sAXeuJKNeZtz5FS6fZM+pO/C6jHJ/++XpWWqBFzZv8XKUwDfv78cMbywCbYlBJVpnCGqstLuVEO5iWX/xCkYoiaEiejwb4kVhSSajFn1WAi9KXZa1DqLUlZnpIHKS9s65Q2hFPjjIhGrfO9oRi85ACBJoXJqmgS+drByvWiHpxtaKhvzXQ1IhGOCJJCe9c2ctU/fuj/RlxWhgIDQP+8mYqBNX7UKz5o999Sc0fv/jcWbS8UkdZUN+MLqsmKMhisNe1lwX0DQnSwCrrAg+xqihxXux2h8Ec7lNWX7nE0dFBuWV1Q= X-Microsoft-Antispam-Message-Info: 6868dCo9rrbk1gwpIkkXy5RADHj74YZItNM7Q+O4AiWTE9qSlc01uiXEeKDgvnbSvVAzucrLN9NP+p8bfwS4pn0hj3U/4hyVv3hbGlgOOiIQyKC3Kafm8ieiuxYLafOUTvgVtU8TPgOWIEy+44kLNcRa81U7F7PHOnx78OgKUy/f4Nv2ClGtvuTpuX9zH6WZu1TNTgfKC0bngRePucJr2dggTKmGZwMfzRzBBPvo+vx7LcD5a83wLweTT6xBvwu2EHL+Hk1mstlZaTa3FQ9Ftt1cFbBTA1+vPrk7XmwuTNLCqN9gfoQn9LWNYMFCGXca4yoC0XeiROGzjhjNFo6RRMQpCGKTd1VOQFIaBo0Z0Ls/L3uhqhbw8O11AMFDpWWtDFz4Mk2w7VtHOhS1t3Yr1p0EXNpdyCEHLbRFeOfXCKs= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB2901; 6:S+ZGnI1mdhbVJdrmJ830QkYCmQZvKhYV+kP8Y9SiUPY1MTxWDLAsjy9ltVgm6PlE5nLmWwaS7oq9NeFGleMyGjlU1QsncK1Bx0cuQ0OMFTIePJ0+eM+0I3hINjQZxEt0blAhMbDvLK93I8hFzQF/AEVCAJ0amG8wpGB2FHxLivJjpwv0sqldiddf+DYVJetiZbqmvZvd9ga7I2jM2MjI4rbDvk8dCkYac/zKbrEGD6clI+YRJ6kezO0M5cDNNSbDnN8PZghF3QkBd9t6XBYcQaTb+UjR12u4BPofkqvD4dcQPBHiShVU4sIZluPaRSE1C9TbcgPexh/rktLyvDJ/UIAE4ECHf99XU0htQ8wK9RWrChgtxSBd38nG0pv/y2jVscNzly1PjnaY2iuLOeCI0d4YOYfJ4kYK5E6kEXSObc+003kg8Peb51/NyqYUNPkunorJo72ygLZ/JPC9AzbW6Q==; 5:nJGhJVopNYMZGXDVwrkj/rYF6oJNMYHDBcd2xEOU22RR+BhvC9V/bSNFbMhet+SqOnYQFYXJcZiWuCB/zyifLX3qzT1nSCFw76mxEjUPao8ZIgXk5etszFDgk1LUTrCz8nLrDp1Xy4TZ9iVMqcYlz+xeZC0go1YijAwCW41c/kBcZNkBfwiZMzRuDRSGWCHs8VBpZeE45OB6sF3AFxK1ng==; 7:hEAcoZQclelWQzruRC9cmGGTE76dnv/LgKNsYggVrPbL8/KzeAUw6n/OJiv2OQdVBLBgrN6N4EqU3MdCbLH/8FnRkpDQiZdVUf6Bqm1HMwdBkhNihXEYUoM4LLfGOIApR1KE59fVa23dYOnLeVYhUw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2019 18:07:34.8603 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3345e38d-42b6-4d18-b48e-08d6854b7b05 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[199.233.58.38]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB2901 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Cache number of fragments in the skb locally as in case of linear skb (with zero fragments), tx completion (or freeing of skb) may happen before driver tries to get number of frgaments from the skb which could lead to stale access to an already freed skb. Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_ll2.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c index d9237c6..b5f419b 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c +++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c @@ -2451,19 +2451,24 @@ static int qed_ll2_start_xmit(struct qed_dev *cdev, struct sk_buff *skb, { struct qed_ll2_tx_pkt_info pkt; const skb_frag_t *frag; + u8 flags = 0, nr_frags; int rc = -EINVAL, i; dma_addr_t mapping; u16 vlan = 0; - u8 flags = 0; if (unlikely(skb->ip_summed != CHECKSUM_NONE)) { DP_INFO(cdev, "Cannot transmit a checksummed packet\n"); return -EINVAL; } - if (1 + skb_shinfo(skb)->nr_frags > CORE_LL2_TX_MAX_BDS_PER_PACKET) { + /* Cache number of fragments from SKB since SKB may be freed by + * the completion routine after calling qed_ll2_prepare_tx_packet() + */ + nr_frags = skb_shinfo(skb)->nr_frags; + + if (1 + nr_frags > CORE_LL2_TX_MAX_BDS_PER_PACKET) { DP_ERR(cdev, "Cannot transmit a packet with %d fragments\n", - 1 + skb_shinfo(skb)->nr_frags); + 1 + nr_frags); return -EINVAL; } @@ -2485,7 +2490,7 @@ static int qed_ll2_start_xmit(struct qed_dev *cdev, struct sk_buff *skb, } memset(&pkt, 0, sizeof(pkt)); - pkt.num_of_bds = 1 + skb_shinfo(skb)->nr_frags; + pkt.num_of_bds = 1 + nr_frags; pkt.vlan = vlan; pkt.bd_flags = flags; pkt.tx_dest = QED_LL2_TX_DEST_NW; @@ -2496,12 +2501,17 @@ static int qed_ll2_start_xmit(struct qed_dev *cdev, struct sk_buff *skb, test_bit(QED_LL2_XMIT_FLAGS_FIP_DISCOVERY, &xmit_flags)) pkt.remove_stag = true; + /* qed_ll2_prepare_tx_packet() may actually send the packet if + * there are no fragments in the skb and subsequently the completion + * routine may run and free the SKB, so no dereferencing the SKB + * beyond this point unless skb has any fragments. + */ rc = qed_ll2_prepare_tx_packet(&cdev->hwfns[0], cdev->ll2->handle, &pkt, 1); if (rc) goto err; - for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) { + for (i = 0; i < nr_frags; i++) { frag = &skb_shinfo(skb)->frags[i]; mapping = skb_frag_dma_map(&cdev->pdev->dev, frag, 0, From patchwork Mon Jan 28 18:05:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Chopra X-Patchwork-Id: 1032115 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=marvell.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43pHfV306xz9s3q for ; Tue, 29 Jan 2019 05:07:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726945AbfA1SHo (ORCPT ); Mon, 28 Jan 2019 13:07:44 -0500 Received: from mail-eopbgr680057.outbound.protection.outlook.com ([40.107.68.57]:64791 "EHLO NAM04-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727050AbfA1SHn (ORCPT ); Mon, 28 Jan 2019 13:07:43 -0500 Received: from BYAPR07CA0030.namprd07.prod.outlook.com (2603:10b6:a02:bc::43) by MWHPR07MB2911.namprd07.prod.outlook.com (2603:10b6:300:1f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.16; Mon, 28 Jan 2019 18:07:40 +0000 Received: from BY2NAM05FT031.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::206) by BYAPR07CA0030.outlook.office365.com (2603:10b6:a02:bc::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1558.16 via Frontend Transport; Mon, 28 Jan 2019 18:07:40 +0000 Authentication-Results: spf=temperror (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=temperror action=none header.from=marvell.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of marvell.com: DNS Timeout) Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by BY2NAM05FT031.mail.protection.outlook.com (10.152.100.168) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1580.2 via Frontend Transport; Mon, 28 Jan 2019 18:07:39 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Mon, 28 Jan 2019 10:05:27 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x0SI5Q48009959; Mon, 28 Jan 2019 10:05:26 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x0SI5QAA009958; Mon, 28 Jan 2019 10:05:26 -0800 From: Manish Chopra To: CC: , , Subject: [PATCH net 5/5] qed: Fix stack out of bounds bug Date: Mon, 28 Jan 2019 10:05:08 -0800 Message-ID: <20190128180508.9902-6-manishc@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190128180508.9902-1-manishc@marvell.com> References: <20190128180508.9902-1-manishc@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131931724599611350; (abac79dc-c90b-41ba-8033-08d666125e47); (abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38; IPV:CAL; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(376002)(346002)(136003)(396003)(2980300002)(199004)(189003)(51234002)(54906003)(336012)(2906002)(8936002)(446003)(105606002)(2351001)(80596001)(26005)(50226002)(42186006)(69596002)(53936002)(36756003)(316002)(81156014)(16586007)(2616005)(305945005)(11346002)(51416003)(36906005)(81166006)(126002)(8676002)(106466001)(63350400001)(63370400001)(76176011)(97736004)(14444005)(86362001)(87636003)(26826003)(107886003)(486006)(4326008)(47776003)(6862004)(68736007)(6666004)(1076003)(50466002)(48376002)(356004)(476003)(498600001)(505234006); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB2911; H:CAEXCH02.caveonetworks.com; FPR:; SPF:TempError; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BY2NAM05FT031; 1:46+4EnLBwqs2knUI6C7NVzqdz9xwWAKAaNg0aDR3gq5N8OKilrq079rtonc+RFRqEBq7czXMQj47wQVIELAgKOY9lDHzHkEY9dsdWKAu4kUb0rdQL7iLGbUqANNsmp9RhWoFnwVZhTG/OucVlNy/RdwjhISWCpNsTZw4WCRzLDw= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 228d5182-b2b7-4950-b249-08d6854b7dbf X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(5600110)(711020)(4605077)(2017052603328); SRVR:MWHPR07MB2911; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB2911; 3:DL0olFq03y89IBF9T1/EyKRmxV1S8wh7m72rkPVxkGXb/3ImgXpE+lHDOlccEAJMkyvKXnOvi3DOh5UZ8us+tk4gQvAJWKuNV34AaZu7+s4DblNQW/n4xeJJZ2ZY/LdEfEGTPapZhIKjWikLUozy9Dthy2mQtN/CGF3LNYT9GxCNV4eBjusqPDY+LNvAKh3XxP/CIfbzy8V1kXCqeVXuYHJAyDRcY5gCv3ijegnkKNNMyk5t81cHwLeWhj6GUkXmmb5XBkD0xOgl7XxVldFp6XaQ+w2jfGmklEg6ZLoqwKDsqdrX2nfSzvrdC2t19sxp+6dH7x+xG3tnOgNo32Mu7kImrH72fWCrsnHs46I/c7BLL6S1Yuo+Q2GGI8uztiqp; 25:Hj5xO/OogGxg+VKtS3bySz5t050sktCooQT31CFkUwyLc5h9mRNn9GH7KkCuftF20Md2hbFDcLGd6NVRmKe+rLZswU4xRiqD+HrCymzHuF4XC3g0xUlBW0Xpp7FL430jMX8zr0xzkxf4LTG5LstGmLiC4vD3kOYaVIFBBpJxiRcdwlgOJrcftFbGTt150zQNmz/j8C5c/7iUj9Jf630FAg5D36UpunNMXYsbvxM00w7NX0DxNuTGNijLMrp4UvUAO3ZPT4uArL5zQOjZlo730ZGePV67iV47gn8RVDp8L0qrlokxMZRi2nNRibAffyfpAM0JfAZuFsr+sRlv512kxg== X-MS-TrafficTypeDiagnostic: MWHPR07MB2911: X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB2911; 31:G5vDWoL39jeFzi3lYZv+Xj7OIvfj2lzJ418KnxKDTSN6rj+Xx7QFOS0PDLtJujrTv4B2CnfWfaSKbMLX1pr+iP1XathXoFU2qaMI/NT/ia9Lo22OpYDQMTiKzXpbBoflUk38WT94H32R1h2Mk3D+tGRC9I2EIiVlyW2AcVk55g+0C7ME4tnzRfeBTFyeW3+nBifxf6L6yuqpvC5Q9CLWTKfNKR+tZd8vV4k1UsxN2Qw=; 4:tRkIDPIKIBBjqDPDvs3iSlyhx2n+AaRtyGms/zVA6wX9lUUuVFurKd0NnDoBIDiFgHuV+M9b289wJ7TY2c3mKLVEMnCReqqzhzn74xppE9W+ntePg7eOhl0cP4CkKECSRxxEfxDFNu1XJBvuyYJxQH3YBA9+JE+Y+XMJtVBsLk37tRVo6Hu2gLAWEuDyBWZZiylfZ3wOwvizJX8dbPMPR0SL1o4QmChf9IuTIHmLgQ13Yjo5KBki8YCd2FRccFdt7E/qIwIwpB/5YO4spFHeG+J6EaFQWIMrk68OhZ37FVo= X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 0931CB1479 X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB2911; 23:2lkXg3sKctrGK5vEMwryYihVshLSSOR0kOV2D7wx9dJpQVSJW3w6yC32bHd3JVA9w6G8hz+Y3dmwn6ZAK+k3fzvy6UAsh72RgisySOqrMvP3VdH6AC4Ie1gwkB5sF8j1DmSSA4wrSYHckOT7j6YpDnbtN4TFnL4cUalCKVPOFZkBZLUOzCIO+n9CKOnb3bwfPZAEwcgaoFKzy0VcR8hKF/fIWHtwQMRIvpSL/H+WLxlKJRA0gbiru+7B4KIr1uKHw2/guLVBu8AVTiq+wlN1U89q7vKO8yoQPclGZHj+HY8GNqILb2dkAgTBMKpQioRXzb3mTYL4FB4GZiMpQjB+uxtXypMo+DkGvLWtZsF/9g0Kw6L/r6u/FekOwl84Nz6junCnBVgthh9SKfIQz3CHRKmaAhiX1OJYQHfIKF6wLU2dBhvpNji/UlJrxKIHb10yLOK5BrowX8MWrdsB+FgfUfza5WA2HTe2U3EaG90iSYTPBpBqVw2j94zyrxR8UkcEpgki7F+9EiJTVwzcjo2SqZYiPj7ykIgGg26W94i8QvNuqCXuS9cm/48pHKtF+hh6925t6UmZsw/E9M4YZHDchzf95hmbBN8tImBVKg96KxII92o0UsjPlU4kp9Q/KYaL08NvCOIQknYNtEL0CpQijSKEZrR0RErsHeq/Wql6kZ25XhrpQ08pb3BKcMQoWyjmuNvKyPX4zqOD0DsQQLomXSSe7o8hED8Mrnx4CUPnIA664FGKJaQtEDbbICNHqaFIghmxhBvQRsSKFRZsUIYjbRHfumgraSjMteQi05D7ADTZ4F5SMtaPBR0e1Qeg7x3Mb+fDWGGvWFHey+rRwK+EXrh2VHaIAAHeFkIvWfeWJtMVbvqsj5UNgjy6MOH0CIvPnQL+lymkheyLhWIzjaiChs+I9KQhPPqOZlStS9pNuLVBNl49+1A1D6lgIPvXtjnnrdv7QjptUTboR+DUvf7xjDBIbteMlpL3D+IhHrJNpwdUqVi46szdT/4Rn8tM9LKxVHptGpsR62nhcTEjTYoDO+er80XBxnU/3y8QPr+Gil0P7/P7NIZasoFmKV8RHSxAx2oUnybiJ7P8CkaQpQtngZN/oOxXwVlBYJCMo5JcgX6je8jac0fARSfJtqoX2SOwCz1wuHujLwxQNBuF5cvn7bbfBcJZPQGcmy18L7mR9kafZZPxpytbwnaIEjYlzFsptT9uczs/pNqaMLz4m+Bw2t9YBd6y3nB3fn6QdHXrBKIxYXiSjZ0feyy3wf+gngpP X-Microsoft-Antispam-Message-Info: jzivlbyicOmvpFZiNIYmD2i706nadaYo1TUbttYMRM5xwf8+jsU4MZO0izVaRTTcT8DLS3GDXSvVEZWGrt8Vfi+JnphdrMmSvFzLx1hLFaoqrOAwpeqRir2eI0TU41COjUsiqQVBbp5ucUn2yhlgmmIeANaLVJXkCMiz2wRIHOjce5KtkoTdhVucOFBo5/3r1mX6UeXMRKDJxbDm0Z7Pvbceno5zfrXsmK2cmVS8v3n1k+DwtqLwScXY70E0C3rq5R49gBX2YmMIC8/ohl14K9NaNLxCb6cD2oipfAwp20FKVN2sMrnGl1eBlCb9S7gfOmRLQeNRxNJtkTyLqcGxZzNT/H+BzWp/MFJ4iUOd3GD6GK6dGGwKqaCGf45QAmpWAG5StAUg/K2HzfBO2zZ2RrTEBVaLGbWfDDQEAV925Lw= X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB2911; 6:em2jWWbuJiu2sMY4D+m8ckB+8WSkhU/m45VgiMIU5bw7bm05s5eVoNu+zKHt1E+ESDE0fUejC0sLreAq0nc8r4HXF/lVsYOIx0hGi9c+QA2W7/bBUHOcq4PjUqx/ckNNE+yNoLPIu3hnjk6JqhAsCFkze7FFW+vklzvjKUTbKLo069yTVEPFJ3nQdOvbTYdoBrKJ4yW2ayxcXQebbyOdEfipVYpBx+DO+d2nF+N+Gm8yb2SZev9Ugk+VeRkUarNfiMj8tnnubOkr3L5J6pFZS+mEslLdX9SbAlPzZm6S93qrnUxaLkzvpuPWvOhx/oR8aSIf9wlIyzAMK3+i3jP3pXgi5wslvGAZ+A2eqIFNo56vTwEPmvAtVZQniNpKTe77X7ZGkP+4HUs2J7q4Jo5+nySDHw+NjA99dQ87JTUZUDJ4E4gbl2hazPg+Mfhd4mPqKzGtfLSe18y+kQMvcatfIg==; 5:oZNmfb1av9Ce7crP1x5JL4Dbju21RbFUYUH9HMl83NuN8vH5N2/SyT1xH6mv3fb4SV3zHt2d5VoifsfqQwkyW0FGJRc7FvftFiimMU3riRPW91/xMfVfpj2sRFb/a43/rsw2Imh7Hl87b+cKv9G9pyBZAtuGf+H1oD3yxbDNv2Hz5lSjEI6XmEEheEk369mW0815Sg+KUrh76Wdd5ZVCJg==; 7:ZdsiLSlySWqCyuaTNmZpFuST/Jk8cBWdZgCEJ9z7DQYtYC1OcWVobQ7X/648Hy0eXUO45EM6dDA7QMKHq7t63koF74lKPNQUosl3YTIXM9itV3CnvkTfHFAVCZAftpQG5ZaiZpuL0lW4nMuHyHBYkA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2019 18:07:39.5438 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 228d5182-b2b7-4950-b249-08d6854b7dbf X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[199.233.58.38]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB2911 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org KASAN reported following bug in qed_init_qm_get_idx_from_flags due to inappropriate casting of "pq_flags". Fix the type of "pq_flags". [ 196.624707] BUG: KASAN: stack-out-of-bounds in qed_init_qm_get_idx_from_flags+0x1a4/0x1b8 [qed] [ 196.624712] Read of size 8 at addr ffff809b00bc7360 by task kworker/0:9/1712 [ 196.624714] [ 196.624720] CPU: 0 PID: 1712 Comm: kworker/0:9 Not tainted 4.18.0-60.el8.aarch64+debug #1 [ 196.624723] Hardware name: To be filled by O.E.M. Saber/Saber, BIOS 0ACKL024 09/26/2018 [ 196.624733] Workqueue: events work_for_cpu_fn [ 196.624738] Call trace: [ 196.624742] dump_backtrace+0x0/0x2f8 [ 196.624745] show_stack+0x24/0x30 [ 196.624749] dump_stack+0xe0/0x11c [ 196.624755] print_address_description+0x68/0x260 [ 196.624759] kasan_report+0x178/0x340 [ 196.624762] __asan_report_load_n_noabort+0x38/0x48 [ 196.624786] qed_init_qm_get_idx_from_flags+0x1a4/0x1b8 [qed] [ 196.624808] qed_init_qm_info+0xec0/0x2200 [qed] [ 196.624830] qed_resc_alloc+0x284/0x7e8 [qed] [ 196.624853] qed_slowpath_start+0x6cc/0x1ae8 [qed] [ 196.624864] __qede_probe.isra.10+0x1cc/0x12c0 [qede] [ 196.624874] qede_probe+0x78/0xf0 [qede] [ 196.624879] local_pci_probe+0xc4/0x180 [ 196.624882] work_for_cpu_fn+0x54/0x98 [ 196.624885] process_one_work+0x758/0x1900 [ 196.624888] worker_thread+0x4e0/0xd18 [ 196.624892] kthread+0x2c8/0x350 [ 196.624897] ret_from_fork+0x10/0x18 [ 196.624899] [ 196.624902] Allocated by task 2: [ 196.624906] kasan_kmalloc.part.1+0x40/0x108 [ 196.624909] kasan_kmalloc+0xb4/0xc8 [ 196.624913] kasan_slab_alloc+0x14/0x20 [ 196.624916] kmem_cache_alloc_node+0x1dc/0x480 [ 196.624921] copy_process.isra.1.part.2+0x1d8/0x4a98 [ 196.624924] _do_fork+0x150/0xfa0 [ 196.624926] kernel_thread+0x48/0x58 [ 196.624930] kthreadd+0x3a4/0x5a0 [ 196.624932] ret_from_fork+0x10/0x18 [ 196.624934] [ 196.624937] Freed by task 0: [ 196.624938] (stack is not available) [ 196.624940] [ 196.624943] The buggy address belongs to the object at ffff809b00bc0000 [ 196.624943] which belongs to the cache thread_stack of size 32768 [ 196.624946] The buggy address is located 29536 bytes inside of [ 196.624946] 32768-byte region [ffff809b00bc0000, ffff809b00bc8000) [ 196.624948] The buggy address belongs to the page: [ 196.624952] page:ffff7fe026c02e00 count:1 mapcount:0 mapping:ffff809b4001c000 index:0x0 compound_mapcount: 0 [ 196.624960] flags: 0xfffff8000008100(slab|head) [ 196.624967] raw: 0fffff8000008100 dead000000000100 dead000000000200 ffff809b4001c000 [ 196.624970] raw: 0000000000000000 0000000000080008 00000001ffffffff 0000000000000000 [ 196.624973] page dumped because: kasan: bad access detected [ 196.624974] [ 196.624976] Memory state around the buggy address: [ 196.624980] ffff809b00bc7200: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 196.624983] ffff809b00bc7280: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 196.624985] >ffff809b00bc7300: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 04 f2 f2 f2 [ 196.624988] ^ [ 196.624990] ffff809b00bc7380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 196.624993] ffff809b00bc7400: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 196.624995] ================================================================== Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethernet/qlogic/qed/qed_dev.c index 8f65514..2ecaaaa 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_dev.c +++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c @@ -795,19 +795,19 @@ static void qed_init_qm_pq(struct qed_hwfn *p_hwfn, /* get pq index according to PQ_FLAGS */ static u16 *qed_init_qm_get_idx_from_flags(struct qed_hwfn *p_hwfn, - u32 pq_flags) + unsigned long pq_flags) { struct qed_qm_info *qm_info = &p_hwfn->qm_info; /* Can't have multiple flags set here */ - if (bitmap_weight((unsigned long *)&pq_flags, + if (bitmap_weight(&pq_flags, sizeof(pq_flags) * BITS_PER_BYTE) > 1) { - DP_ERR(p_hwfn, "requested multiple pq flags 0x%x\n", pq_flags); + DP_ERR(p_hwfn, "requested multiple pq flags 0x%lx\n", pq_flags); goto err; } if (!(qed_get_pq_flags(p_hwfn) & pq_flags)) { - DP_ERR(p_hwfn, "pq flag 0x%x is not set\n", pq_flags); + DP_ERR(p_hwfn, "pq flag 0x%lx is not set\n", pq_flags); goto err; }