From patchwork Thu Jan 17 10:01:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 1026497 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="dUjA89z3"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43gKPP0Jz5z9sD4 for ; Thu, 17 Jan 2019 21:02:17 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727142AbfAQKCP (ORCPT ); Thu, 17 Jan 2019 05:02:15 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:42569 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725990AbfAQKCP (ORCPT ); Thu, 17 Jan 2019 05:02:15 -0500 Received: by mail-pf1-f196.google.com with SMTP id 64so4588645pfr.9 for ; Thu, 17 Jan 2019 02:02:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=pyUhv8FWHrdFfJFMWGit/8HtkPmGReLP1f+/Dxn6VsQ=; b=dUjA89z3lSPmqO8u4JKxqlSffrEM7GiC7ePetVNcQFIJWHHnO11Hn2WDI4MDJKrsSY qzHMx4BmI+qC1FjcjOH780w3Boc8mWeSLvJBz52OdODGH2GBPD47pQ0b3csyIgk2vAOi uTfwITCsYe3ULeJL9PYu0DS860Eae18Xv49VD7t3OU/h3ALPr0H1tTGeotBBzptyeZ+R TYUBl2w/JEpAHe+eqG7jnlU4yMYBYwVwE3tWthvG+nS7s7fXcvdjvBDT+I6Li9OWCk46 NLBndKU9DGnDw8dG6tnghyeyBKl/HnQA832TOYRX5OKaBHAwAwfWM9ZFxjXKQEXehK8Y H62g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pyUhv8FWHrdFfJFMWGit/8HtkPmGReLP1f+/Dxn6VsQ=; b=GeRPVxVkzHicTmSfNj/obc+ljndbJwZAoScNFXf4EzmqCtWC3AhfL+DTs4uNZEYg9Z EeKHhMo+NNaJW1S5AyNV56q+oHa6qBRldneDWwSDAhiZn6BOObjT+mns/IeMUKBeVQxk 5vvTYZobm3kzzPiQBWdlOMDQl5jb6vsExZf2Vxx/60FENTwOmhDLpeRHvV+Ko5xQgkOb TwjR9bR2oRCS1IMsng4Qp3Fvlrd4067QRdcWoF9rX8Tc9uOqNp92DbK+INVFalU58Vza 1cvfjg5DsuIi1+mPzzgljz+eEeBMjh6J9XQLuqSnrufHyErp3yXf+ardWWDUHDmjHTwc /w5Q== X-Gm-Message-State: AJcUukfRFxukxBP1sVenODm6otT9vDwnVcxvzAcHJyjX7F2ahrxZ2bGG /Oc7t6IeX/z+nQrxzAY7pv4= X-Google-Smtp-Source: ALg8bN6MJaC6R2qeL59GNpn9HXv/dXDRwPRw3zAhNxo1c7GzAXZZHNoZ/1cboO8rBwlJF7H+2/XGdw== X-Received: by 2002:a62:6303:: with SMTP id x3mr14660004pfb.110.1547719334987; Thu, 17 Jan 2019 02:02:14 -0800 (PST) Received: from localhost.localdomain ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id h134sm3124496pfe.27.2019.01.17.02.02.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Jan 2019 02:02:14 -0800 (PST) From: Yafang Shao To: davem@davemloft.net, edumazet@google.com Cc: netdev@vger.kernel.org, shaoyafang@didiglobal.com, Yafang Shao Subject: [PATCH net-next] net: sock: do not set sk_cookie in sk_clone_lock() Date: Thu, 17 Jan 2019 18:01:50 +0800 Message-Id: <1547719310-1007-1-git-send-email-laoar.shao@gmail.com> X-Mailer: git-send-email 1.8.3.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The only call site of sk_clone_lock is in inet_csk_clone_lock, and sk_cookie will be set there. So we don't need to set sk_cookie in sk_clone_lock(). That can save an atomic operation. Signed-off-by: Yafang Shao Reviewed-by: Eric Dumazet --- net/core/sock.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/sock.c b/net/core/sock.c index f00902c..21e2a84 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -1726,7 +1726,6 @@ struct sock *sk_clone_lock(const struct sock *sk, const gfp_t priority) newsk->sk_err_soft = 0; newsk->sk_priority = 0; newsk->sk_incoming_cpu = raw_smp_processor_id(); - atomic64_set(&newsk->sk_cookie, 0); if (likely(newsk->sk_net_refcnt)) sock_inuse_add(sock_net(newsk), 1);