From patchwork Wed Jan 16 11:34:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlo Caione X-Patchwork-Id: 1025909 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="rmxYgcnh"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43fpvq0S0jz9sD9 for ; Thu, 17 Jan 2019 01:08:22 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 94917C220A6; Wed, 16 Jan 2019 14:06:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id C11A4C220A2; Wed, 16 Jan 2019 14:05:36 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id EA965C21C57; Wed, 16 Jan 2019 11:35:41 +0000 (UTC) Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by lists.denx.de (Postfix) with ESMTPS id 98738C21C29 for ; Wed, 16 Jan 2019 11:35:41 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id a20so5124517edc.8 for ; Wed, 16 Jan 2019 03:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Wjyk91Od83sfIuBjh9nXzgFyBOa8J3XFEoLvNR59eXs=; b=rmxYgcnhmDwd+1GoVPvqya+jYWM25PXwHMS4Vbga68wfZCbKSKoXYdW2DEtOcaJpYD OIRg/xlJ7W23ccVDohmFDJ+zUIVP37BYczHV61KfKGmmVYBfNrTvVKzruUMQF2Iz7jh9 pq13v+zn6RIawkvpV1bXcOP+/STOxSgGHxmLuxyi4XjiJaLQ3gK4z9IbzicuqA1R7AH9 +WLqG+7yyCHjKetM0zPzyFp8579zcYeW6rgpA/72gu11ZaKVuFp9LagIkpOPj9A/2Upm Xi9NDmvJwjDxN55NWdi92JBbcCTvAtMKTlrwZRrlGO+hLwJZ3sr0llHBRSE/J9gxOXRV jw5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Wjyk91Od83sfIuBjh9nXzgFyBOa8J3XFEoLvNR59eXs=; b=FQKnGs/DkaEhWKJ7kFzpAwYDVrdrGd8hzd7m+rPK72OS96kHzuikjAbvg7mYKLOlmj qpEEnbAXvdgRvxT0YLJtDf9Gk85225JwnukEpv1To99DJz/hVQC1SP/2N58XCP7f84Fc w4/hs2tnr+IAdb5Ck5rU/ISWttvqN93brwW6hqjEo4lWcOYAilk4XitKE3gwd7X/nyG5 B4vI9QBECfD7hEak7xUIgZMqmJeWXBde4JJiK8twbNhCE/ptUa3/rkRbt+Em8RxNhalF dQL7ZfjRaL7FB0izVX7L+7e5mHSXjHKcSnjLFwPW9U79ADYjVaqY59lGiX+PamU39iwn jlFw== X-Gm-Message-State: AJcUukdgjY+3tN44+96gI/VPJagFdJ7rXjMSkVY3EKZuLWQ3JF5dB65C P4KWRLG8EPI5YKzrXuXgqnPbvTjeP6FIgA== X-Google-Smtp-Source: ALg8bN5TH6Xa/gcud5yIgNmG7v8HNLMdHEGSnMfPEBRgeZMX3Ciad+3DYVtXxKGhuXL1/dIbegzulQ== X-Received: by 2002:a50:e610:: with SMTP id y16mr7105838edm.163.1547638541191; Wed, 16 Jan 2019 03:35:41 -0800 (PST) Received: from localhost.localdomain ([2a00:23c4:f7a1:ce00:5105:4b7b:c922:7c6]) by smtp.gmail.com with ESMTPSA id e35sm5563276eda.13.2019.01.16.03.35.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jan 2019 03:35:39 -0800 (PST) From: Carlo Caione To: joe.hershberger@ni.com, u-boot@lists.denx.de, linux-amlogic@lists.infradead.org Date: Wed, 16 Jan 2019 11:34:50 +0000 Message-Id: <20190116113450.27238-1-ccaione@baylibre.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 16 Jan 2019 14:05:32 +0000 Cc: Carlo Caione Subject: [U-Boot] [PATCH u-boot] net: phy: realtek: Add functions to read PHY's extended registers X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" According to the datasheet to access the extended registers we have to: 1. Write Register 31 Data = 0x0XYZ (Page 0xXYZ) 2. Read/Write the target Register Data 3. Write Register 31 Data = 0x0000 or 0xa42 (switch back to IEEE Standard Registers) Hook the missing functions so that we can use the `mdio rx/wx` command to easily access the extended registers. Signed-off-by: Carlo Caione Acked-by: Joe Hershberger --- drivers/net/phy/realtek.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c index b3e6578df9..3bea1fa9d0 100644 --- a/drivers/net/phy/realtek.c +++ b/drivers/net/phy/realtek.c @@ -57,6 +57,31 @@ #define MIIM_RTL8211F_TX_DELAY 0x100 #define MIIM_RTL8211F_LCR 0x10 +static int rtl8211f_phy_extread(struct phy_device *phydev, int addr, + int devaddr, int regnum) +{ + int oldpage = phy_read(phydev, MDIO_DEVAD_NONE, MIIM_RTL8211F_PAGE_SELECT); + int val; + + phy_write(phydev, MDIO_DEVAD_NONE, MIIM_RTL8211F_PAGE_SELECT, devaddr); + val = phy_read(phydev, MDIO_DEVAD_NONE, regnum); + phy_write(phydev, MDIO_DEVAD_NONE, MIIM_RTL8211F_PAGE_SELECT, oldpage); + + return val; +} + +static int rtl8211f_phy_extwrite(struct phy_device *phydev, int addr, + int devaddr, int regnum, u16 val) +{ + int oldpage = phy_read(phydev, MDIO_DEVAD_NONE, MIIM_RTL8211F_PAGE_SELECT); + + phy_write(phydev, MDIO_DEVAD_NONE, MIIM_RTL8211F_PAGE_SELECT, devaddr); + phy_write(phydev, MDIO_DEVAD_NONE, regnum, val); + phy_write(phydev, MDIO_DEVAD_NONE, MIIM_RTL8211F_PAGE_SELECT, oldpage); + + return 0; +} + static int rtl8211b_probe(struct phy_device *phydev) { #ifdef CONFIG_RTL8211X_PHY_FORCE_MASTER @@ -336,6 +361,8 @@ static struct phy_driver RTL8211F_driver = { .config = &rtl8211f_config, .startup = &rtl8211f_startup, .shutdown = &genphy_shutdown, + .readext = &rtl8211f_phy_extread, + .writeext = &rtl8211f_phy_extwrite, }; int phy_realtek_init(void)