From patchwork Wed Jan 9 17:06:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ioana Ciornei X-Patchwork-Id: 1022553 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="w48cvGZH"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43ZbCB2pLsz9sBQ for ; Thu, 10 Jan 2019 04:07:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726516AbfAIRHA (ORCPT ); Wed, 9 Jan 2019 12:07:00 -0500 Received: from mail-eopbgr130059.outbound.protection.outlook.com ([40.107.13.59]:13243 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726422AbfAIRHA (ORCPT ); Wed, 9 Jan 2019 12:07:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jOsi2PycXTJwxW2d62q37/LH6oWUTVug2Z6nlS0vjBY=; b=w48cvGZHm0jWuw5lOMfpwkS+TyseC8km2SfUroDG1NrygCvjyE+7FVDfCExZtL9CH/t495X2SEbhqVI09HklJiQmbJJjd8Vx6dttxgySpbgz8gRW4pRN3bCxttRCy0BmLCW2UND0mc5i90KxAxes1hFXTuFiKO39p4fHKJ7/jIQ= Received: from VI1PR0402MB2800.eurprd04.prod.outlook.com (10.172.255.18) by VI1PR0402MB3693.eurprd04.prod.outlook.com (52.134.15.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.14; Wed, 9 Jan 2019 17:06:55 +0000 Received: from VI1PR0402MB2800.eurprd04.prod.outlook.com ([fe80::8c7b:7d91:36c7:1426]) by VI1PR0402MB2800.eurprd04.prod.outlook.com ([fe80::8c7b:7d91:36c7:1426%6]) with mapi id 15.20.1516.010; Wed, 9 Jan 2019 17:06:55 +0000 From: Ioana Ciornei To: "netdev@vger.kernel.org" CC: "ast@kernel.org" , "daniel@iogearbox.net" , "mcroce@redhat.com" , Ioana Ciornei Subject: [PATCH] samples: bpf: user proper argument index Thread-Topic: [PATCH] samples: bpf: user proper argument index Thread-Index: AQHUqD25o1ZkJc4wTEq4zGjri6tDSA== Date: Wed, 9 Jan 2019 17:06:55 +0000 Message-ID: <1547053600-13817-1-git-send-email-ioana.ciornei@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR08CA0257.eurprd08.prod.outlook.com (2603:10a6:803:dc::30) To VI1PR0402MB2800.eurprd04.prod.outlook.com (2603:10a6:800:ad::18) authentication-results: spf=none (sender IP is ) smtp.mailfrom=ioana.ciornei@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 1.9.1 x-originating-ip: [86.34.165.90] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0402MB3693; 6:wwAJrVpfQAvvVciY1i9U4YvvRZ7WbMUqw0rA8wzOoo+P3K9LSy7QILd0eYt2M097C3tqBus43A5nC2WXqrwtfxVbeoru+MSCG0ePnFW5on0rUswiPBt1i91nQ0TwzQfB4QMm8jaYqSHeH2iIcNzGo1rsc5CXdA6njsMWtGY8NcxfT9JLnLYIvDarM44gz5RyP3LvbXrDimtPB2fIuseVs2gEDE2fNrb1+sjh2CjHmy1zp4PajypRrXBrpDsj+CEs4e5ApnFUVfp35kFTs6SLpEmIZc4tsmJjzFHImnnVgxsrjdMbssgpGWJFbVxhoaWSZ9ldE8Sl5WID1ZEJ4nE5vJRcRWnskE1UuiGmA4dVPXJ5tAC4KsMBzgJpmBP7V2NQrsD+wfUZHUOpnYbqet3tspp08cDhMM8euzz+dKrrtm4gvs7F+FAB56Ga1udk6QNdNhMYkqnW4eu32SyQJvFPSQ==; 5:T3SgnKACYcRumSZ+GRw1N0qjCSVtxKFq8sZJ5+OpDDoDvyLDyhJ8rzRdK/mTPmATsGVsa1KcN6DUvSmW6/JHMkNUE/3CFdJNHVoKC4LNHUNIkOBhSOuandqWi4qhDsGhQzDnsMqlYXN5mWzMnNxzUzShrnsJGcQterrYZ2ibO3yfZQYwC8uRCVaYRPo58gxnRdCvROvbIkaYUHdRPOI87A==; 7:1FYomttu3bTRdPIzgJoZBQ5mitpEmpWpz1AbpTm4NT+egDmMfBf8QwtNRSjbdbo5eBEbnGi9gDC0BK2n3X7IbKgWM/uv3xQRooha4cZBe59jT+RC5OrVSLQTaS+J2n2AICjKKCBJZQULCoxFwkjnQA== x-ms-office365-filtering-correlation-id: 0464fb23-bb7a-4121-a128-08d67654db8f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0402MB3693; x-ms-traffictypediagnostic: VI1PR0402MB3693: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(3002001)(3231475)(944501520)(52105112)(10201501046)(93006095)(93001095)(6055026)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:VI1PR0402MB3693; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0402MB3693; x-forefront-prvs: 0912297777 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(346002)(376002)(136003)(39860400002)(199004)(189003)(6436002)(6916009)(4326008)(7736002)(305945005)(8936002)(53936002)(6486002)(3846002)(6116002)(105586002)(316002)(68736007)(54906003)(5640700003)(6512007)(66066001)(5660300001)(81166006)(1730700003)(8676002)(81156014)(50226002)(97736004)(71200400001)(25786009)(71190400001)(14454004)(186003)(26005)(478600001)(256004)(14444005)(36756003)(2501003)(52116002)(102836004)(386003)(6506007)(2616005)(476003)(106356001)(2906002)(99286004)(2351001)(44832011)(486006)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0402MB3693; H:VI1PR0402MB2800.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 4AEmvYElIF2pG1S0Iea0C3bBYdTDmTNhnnDuinCdpqG/tc8SADrkHUJ0ty7i7IWs22I42N+P7KXp4jFCzOvrdinGlMG+umuVwJzvxo24B5deW/e6V+tr/LDKWFFA05vyVBsa55h1wPoN/12TID/lFcjQE6bUJWGHjcnnpVG4I5h7jcnlAP1coG3bMEd4wjz2kEtbd2v6+XtmI0vuSOrl+Xc2NDNH0mFe+Psi0wKSe9je9+jJ/Z33e3rBeKaguI/9S8Ct33NdurJLQLj+3AZzW7JvAYPH2j+DkY/mIH9wryo4oB27VHQMMES9Mc3m0d86 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0464fb23-bb7a-4121-a128-08d67654db8f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2019 17:06:55.1051 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3693 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use optind as index for argv instead of a hardcoded value. When the program has options this leads to improper parameter handling. Fixes: dc378a1ab5b6 ("samples: bpf: get ifindex from ifname") Signed-off-by: Ioana Ciornei --- samples/bpf/xdp1_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/bpf/xdp1_user.c b/samples/bpf/xdp1_user.c index 0a197f8..8bfda95 100644 --- a/samples/bpf/xdp1_user.c +++ b/samples/bpf/xdp1_user.c @@ -103,7 +103,7 @@ int main(int argc, char **argv) return 1; } - ifindex = if_nametoindex(argv[1]); + ifindex = if_nametoindex(argv[optind]); if (!ifindex) { perror("if_nametoindex"); return 1;