From patchwork Tue Jan 8 16:05:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Wunderlich X-Patchwork-Id: 1021980 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=public-files.de Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43YxvK5Bzqz9sN8 for ; Wed, 9 Jan 2019 03:06:05 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729058AbfAHQGA (ORCPT ); Tue, 8 Jan 2019 11:06:00 -0500 Received: from mout.gmx.net ([212.227.15.15]:45063 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728238AbfAHQF7 (ORCPT ); Tue, 8 Jan 2019 11:05:59 -0500 Received: from localhost.localdomain ([91.14.64.214]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M9sa0-1gaKJm3hyC-00B6US; Tue, 08 Jan 2019 17:05:39 +0100 From: Frank Wunderlich To: Felix Fietkau , John Crispin , Sean Wang , Nelson Chang , "David S. Miller" , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Frank Wunderlich Subject: [PATCH] net: ethernet: mediatek: fix warning in phy_start_aneg Date: Tue, 8 Jan 2019 17:05:26 +0100 Message-Id: <20190108160526.18928-1-frank-w@public-files.de> X-Mailer: git-send-email 2.17.1 X-Provags-ID: V03:K1:l+mp37KjOVJSmnrQlklK3mKCAchMZ0EQQ1Llijw3B/XrLPiw3H4 pOSn9+778/b+5mU0T8R1EsXyplHgEa4Uf9cFOtH8POmcB9x/j+VQ1arrIlQJIcVlwjX/q32 4U25wQ6UJUVLIG4k6pnHp8ZVpQn+MRwvCImbC0HquhrZPvHXo1dznYJRJDTbTfNmWBK8FTh MqL5VH7rd2XvOzJpsOq5A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:b0FwHQ8FA68=:Vr1q3Owek51B+r7KjzVsdQ AsWui84BV/olgwdOhBXrd7NaMIBs3nYcNtlRXcxhsiM1d8fviE60zlkEbHuFBDUFh9Zeko/ik gQsTRzr736En38FNIh6Xu3j+787mYdCTkF/QNIU//SalsgtAYeZBUnZniUnAUoSJbT+wF552h gpUHWVHnz4k6J8gV5+6ORh5lnBmYbFqHJlD1LL90tX9hPJ8Ow0ADGKc9XUzJr32LHMhwoYt3H t7lGWh7w2edioj62WC1P0jjxBeqW0UPtC08Llk/X/3UikeLJuGCqn2RBdnd+XqdNt476s3/wk 7PcO9PYGEPeQ/DDnhAklTm1nU7F772IhJb/B0FtK5iqgNR3ExowgmVUHcRExlb5jOVaYwnB3L aJPjGXuYGgbaMHwqQUit+RkKXpcinECV2nJAwZYLYmbl4K5Ovg0oXdb6CEgFqI/7R8HzapoR0 ECWuBIYZw+ZJ/AlPFvUXFCHnha50mr5xQ7SJ275Tuw0Glez4q+LZ8PZ926huDFQ+GgI9PKvKV GuNSqaPoRkpDSgjdD+qGtn+rGE1dbfZj3KikUzkt0VfgaIfDDrqLKFxjbgJj6v/OYNWsOid8P k8tEFU4kysTU2Z4gheyGlgQU1rrvaXSjHaXWB7W7AwqAiNpaDyK7xbtKnSthhmk13RO2Fh7Ay 7Uf2IFOpttTtUEHEbgY7KxuY5E+pxpnh3hrFAgf+gjl75+Ij49HAjuS+IGeZ6pyXZTi++d9nl U10LeTvFhqpWP74GEjSR6IpfeHUbOCDSslW/gMzrIuw/vv5zvylnPGISrQUOks4yW3OlHi4KG +V23+beMlEWwbAeRz6IjAuqpELkUToDZuUFgCCEiuqZTWnX/J8Trkh2rFBN9arslnqDCdal6n LNvxpddiiYKeWjj2POJjxccHS0qB6VZeI3K+p+rXJorxveqwBGnpCORCaji93G Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Sean Wang linux 5.0-rc1 shows following warning on bpi-r2/mt7623 bootup: [ 5.170597] WARNING: CPU: 3 PID: 1 at drivers/net/phy/phy.c:548 phy_start_aneg+0x110/0x144 [ 5.178826] called from state READY .... [ 5.264111] [] (phy_start_aneg) from [] (mtk_init+0x414/0x47c) [ 5.271630] r7:df5f5eec r6:c0f08c48 r5:00000000 r4:dea67800 [ 5.277256] [] (mtk_init) from [] (register_netdevice+0x98/0x51c) [ 5.285035] r8:00000000 r7:00000000 r6:c0f97080 r5:c0f08c48 r4:dea67800 [ 5.291693] [] (register_netdevice) from [] (register_netdev+0x2c/0x44) [ 5.299989] r8:00000000 r7:dea2e608 r6:deacea00 r5:dea2e604 r4:dea67800 [ 5.306646] [] (register_netdev) from [] (mtk_probe+0x668/0x7ac) [ 5.314336] r5:dea2e604 r4:dea2e040 [ 5.317890] [] (mtk_probe) from [] (platform_drv_probe+0x58/0xa8) [ 5.325670] r10:c0f86bac r9:00000000 r8:c0fbe578 r7:00000000 r6:c0f86bac r5:00000000 [ 5.333445] r4:deacea10 [ 5.335963] [] (platform_drv_probe) from [] (really_probe+0x2d8/0x424) maybe other boards using this generic driver are affected Signed-off-by: Frank Wunderlich --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 399f565dd85a..e48c06874a85 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -356,6 +356,7 @@ static int mtk_phy_connect(struct net_device *dev) linkmode_copy(dev->phydev->advertising, dev->phydev->supported); linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, dev->phydev->advertising); + phy_start(dev->phydev); phy_start_aneg(dev->phydev); of_node_put(np); @@ -1821,7 +1822,6 @@ static int mtk_open(struct net_device *dev) else refcount_inc(ð->dma_refcnt); - phy_start(dev->phydev); netif_start_queue(dev); return 0;