From patchwork Mon Oct 16 11:17:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander A Sverdlin X-Patchwork-Id: 826238 X-Patchwork-Delegate: cyrille.pitchen@atmel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UW4aN8kn"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nokia.onmicrosoft.com header.i=@nokia.onmicrosoft.com header.b="LqG/hxBi"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yFwmz0H87z9sNc for ; Mon, 16 Oct 2017 22:18:43 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=d6dSznZ5oQ7QwRQ8uYLc7a4K8HgTSA9fmp82nHiLoyo=; b=UW4aN8knuYGMCM PpAt1B6EXtcT6zrl3EZdu18HiOWzapipZVaTASwi4GVDUuw7H43/9NgTVaUkCZ/YUJXmHCJpziNzN Gv1xoQoAk4KPwWz7hmrhn/1JwH47EHQGIm4E/U9HkTBVyAVhvNmU4U29hvkbdny2W9nTVnOv77+D7 uRSzU3r2SxZXvvMMFfSOqCW4j8hKNQTlVhRG5+CMCemFucBtJX0o6Ag9E13dfVuU96WQ0eeG5Wu9/ sAIdl3oZF7ZlR+hjYMh3+yzz4qp319njwb3pHISqGBuHmf52QLD/LZQptCvBexVfBiVlH7s2hiM1G 8HhhnHc42LYSaAoNsoMw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1e43PS-0000Qw-Gk; Mon, 16 Oct 2017 11:18:14 +0000 Received: from mail-ve1eur01on0126.outbound.protection.outlook.com ([104.47.1.126] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1e43PO-0000Ny-GQ for linux-mtd@lists.infradead.org; Mon, 16 Oct 2017 11:18:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=RYSQBhJAofIThU2FhHfgxOMXmLgTtgXQOH3D6AQtKP8=; b=LqG/hxBi5/d3Df2ynsR2BqSjSDA30ZzH9m6t522Kur4n+GfFOz+XQ6WeacgmRgQ3wnvVZdrbgqRO5B3ytBNybvthyjuqyaGMt3E7jxYvVmBn+GXisBCpG8a7bhS6Lo7YPVrCnHgDIS9S0MGElDjJ0O8Dh6l722w43rTUddvwcgM= Received: from ulegcpsvdell.emea.nsn-net.net (131.228.2.20) by HE1PR07MB1321.eurprd07.prod.outlook.com (2a01:111:e400:59b0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Mon, 16 Oct 2017 11:17:34 +0000 From: Alexander Sverdlin To: linux-mtd@lists.infradead.org Subject: [PATCH] mtd: spi-nor: Enable stateless 4-byte opcodes for N25Q256A/N25Q512A/N25Q00 Date: Mon, 16 Oct 2017 13:17:12 +0200 Message-Id: <20171016111712.16783-1-alexander.sverdlin@nokia.com> X-Mailer: git-send-email 2.13.2 MIME-Version: 1.0 X-Originating-IP: [131.228.2.20] X-ClientProxiedBy: HE1PR0802CA0007.eurprd08.prod.outlook.com (2603:10a6:3:bd::17) To HE1PR07MB1321.eurprd07.prod.outlook.com (2a01:111:e400:59b0::11) X-MS-Office365-Filtering-Correlation-Id: 29fcbbf1-96f4-4fd7-a86f-08d51487802a X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603219)(201703131423075)(201703031133081)(201702281549075); SRVR:HE1PR07MB1321; X-Microsoft-Exchange-Diagnostics: 1; HE1PR07MB1321; 3:6x098sN9dbnjI8s2Kt6CtOOUQvjuG2piPsfS9omkfRIm4ZHdp6wDgSiGRtvNBlzjPqdmPd1dZcTw61iNgxw46ij5lnsHTK8QNsIPWG1VtzwrnvePkAgXX53vBzm2Mkcv1G3pPEAxZzAby7vYTobtws7QXDyaexLtZ5S0IxImpgAo2apYnkqDO71mGwRXzwTih+wn2ffaE48udEvo1D585j7hPBzNDgM6R8XnbqqzMgyfl5vVCm+VvPN9ekboxExl; 25:wfQoBI1syHaS5hi45LspV6vmuik7jnOkH49d21FcZ391tZWLAW/TydQfU+LxhQo9Ra57EBhpnq0EnVTUQKf2bB4cjxMRw9Bz1wLVZq7svQ3x4JMm6S+x5kIoPdhuxuQLaGncwgEmjVcJdJNeyVlcuoQOVxbT2SH7HbZlmSqR5AVJjYEhwSBQm3ELZ7+jLOb686AamRk9siDTFfANDIAB3zWW5ih+oIe+0EU+QS4k0ckSD6CVxTq77dE1VUPBZ1Peh3qFQSPavgt3XeQK7rup11EXOmIu8i8TccVSejwtfViSLS8l9EXb5Fd/AQhnfN7QchCUjhCgtqYKbG8A6JsCGw==; 31:07VekFleVUUxGpAuTiLd6LbweDw+Z8KmDXnLA19z4orGFi0O6F2HBH8A+fpl+KTcqiIp7qBiZjzCGVaB/UAAN/tC30WWzN21rUUkl9bJViV/mLlQZtLFeS77WASTQbHKTZBfUvMrrbzZerEuQxseoPMn/WJa9waj5jmnumOmHnqr712F+fwefwKib38E3IJ+rPXhAFflau4Grl3DxVlbHftPvUnJVg9IU+3ljI0DLuQ= X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR07MB1321: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=alexander.sverdlin@nokia.com; X-Microsoft-Exchange-Diagnostics: 1; HE1PR07MB1321; 20:Csnu3rwthO2HICXNfaSl05FrFsvlFEmAKjnau6oBZGVEiCwJz4gJ1m8GH7Fd1bl13zHaUnXXWAzRzrh2OEZGyTw0ABocgdAXVqOFT0VPkmAPHfxXDvYr5XnOBl0/5tf/Kco51K9VJj+YprWXHHk70Ek780A96V8MDaJ63ypcJW1/ZafSl0uf/uHxce9uTzSJp0cQogLZ7TnFPUTaHEJ0JLGjbZWUQUS6fMPZX/wUEgEnvRD3MY6aBeZ7tZJ4Opovj1yVGEAQ/Kuvwzn3vXl/nyZs/58rErEviDFzmVhlK95d1ZoXnZb5aZYMRiSBfvDkwpfA0B1ufD2entFP1ehlDOwVQf7teKAHISLCtAF2pHZe67PhQ/9QlNY6c9yxAxUD64AUOgPmEUl48StJVTmlcqiwJIolFHca4thyjPZhOKO7rp/sHimM1pkvn5c2Cx4KWErc/TTXwrPhb0s25X2w+10Hv01LUwxwe9DblGA3qdvBX8lYajHKQBYNYml8sOLFTSt4IRbOTqJNoQuD1l6MUTBJuHRNsmLSeE4W7dB1ZP9BMA0IyHuPol662fVfU6lUWwroUZgg2BpF4rHkmoU5jcZ6dZ2tIzYNHgQYTZgQhWI=; 4:1ha0S3q0vuPWmqGdfpPd3LsVuLQyOdjuIpaN9U9dL954YvuiB3PXptYZClcZg5yN5U3c5iIuX3MnZw3qOvWG65hs3vbE3HivZdxanjPsWg2s+BK1cXxwI+p3sCMCcCRGaz2Z7FbMJsRa5ImKtwTIOIxWf6+0RSa131cD9AllUDxOIRwXzm3S91liEExCcFyjsQjZ/3cmCU1FIndZth9k+3B9HgO93xdt/68Mn4+dZICnLdl5fN1wGEYjJSWMONArXGTcAiFGfHP3jN8/aN2MaZrbSjAkryL6sHZ2l1BaxY8= X-Exchange-Antispam-Report-Test: UriScan:(82608151540597); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123558100)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR07MB1321; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR07MB1321; X-Forefront-PRVS: 0462918D61 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(376002)(39860400002)(346002)(199003)(189002)(39060400002)(86362001)(189998001)(53936002)(7736002)(478600001)(316002)(97736004)(5660300001)(305945005)(6506006)(33646002)(4326008)(6486002)(2906002)(6116002)(101416001)(3846002)(6916009)(50986999)(68736007)(8936002)(1076002)(16586007)(50226002)(6512007)(48376002)(47776003)(54906003)(36756003)(6666003)(66066001)(8676002)(16526018)(105586002)(81166006)(81156014)(106356001)(2361001)(2351001)(50466002)(25786009)(5003940100001); DIR:OUT; SFP:1102; SCL:1; SRVR:HE1PR07MB1321; H:ulegcpsvdell.emea.nsn-net.net; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nokia.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR07MB1321; 23:IRUuiV8ziupEsuuZo+IioKXV6fk2aa+an+7A1tqsz?= JZdxn71h94AmKnaot3qE54ALcQxlL3M6qDYf1U2ppdoEl7SmaFPQzkXCbOobcCX/dOzuf5wzVsHKMq2gk7QDInK4S9aEtgp+lLRbPqVR4mHxTepF2d/AY5PiZHLqjy/f324uJYDvRQfU1MAB7SFQj8Ol/CJFMPAHYPO+BzQ3qMwevIGtoYrSM+PwbrV51sX4wK75wLiYLXRz79HVIt6HWmmFl6wMT/NsdLJxBDD32zinUVOjyenNfEwThmxt+TyK7D8b4zSHf37Ig0QqV85FNjfziT61Yk9BozljUJxcBO3Ovtj4oNp8RdzNAL/W6pDULVDljxo5Y+X3YOw6hw9cfqBs5EVYjdCYvAEzIDzseAVyqeP4a9JMeoGtU3nJZcj5smRNn54a2Hzx48o0hbciAVkQHSv9kH0qgxfqCdX4MzM3YXn9qENSrFyEfgrD3CclCsLHLYkGkb1i5oOEXRut6hcEN3V+/jyak4gz1XcNPdOcjJeFDTWsupDAlzzb0RGodQRQXDqqVvEh0umkkRDR5nN67QGaTHaFAJzum5xN6cgI3ANCgHhgo05MWCZTR9m7rMku+meTHsTlryAAcijpI0NwfibBuun4m8elAWe/gv7zT00PxxDdx/IgB7VEAv8xREgtg6fpb8NEU8EsjzBjXfwq/6yUUZMNrwyguwbz+pAJEjHPw1k1FNH0S3NXyEyEh47WQdHrUDvYITjDAYz+dnUlWMNLosV7L1zKe35v89s06joPT7RFd9DsddcLQtaxZSIEnxTW88RGRdn/hkYqfZVYObvRuD3lCG9W7DbwIb9d+Sx+9gJlSQs73HaJayzwbHGI9bOfUHoo4uT95c1V5VePGBhERygpq5ACmztDb4uxNx5sme+eB+ZFoFyX4uktsjEyCpDw96GaLNQWhRVIkjULBT4/w3wJPt6YbedbpjdFPVEabNxqUBPoa7MdZP+E2hfGsQAfRh6IrXJT3+BEovAfnV6S4jJnOFkiOsFdenJiEX8z7Je39Fqw7IKFOffvT20ErUWwdkIwlYDsAefWlaP4zbJD4Rq4sxHR7tyi8Vc1Uc8X35iMExN+zojxRpy8D8YaNr83PUTMyaGHqKak8aF X-Microsoft-Exchange-Diagnostics: 1; HE1PR07MB1321; 6:G86w6idGiDSJS1uY+EFNp1fbT8ZjeHlxlbPsZ9muNWRTZoAmd8IcASFV99QBe+YCaQRWXv3U4jPYJn+V5lqCP7sUuaX1hbmlmMSQgJsu5eVqOVOEvIC+oR1T2vjbbaKNb41P9sAPZX8FtTaC85EkYKcVkUH2M0N7PRv5If0Q4d/E7HTdZSyQr1fT2tgMrc+XFyoVXSqtNhdiiMzZO2xxTVyAJLNiaKkaKYYPq7If3aB01dY3olNuFk6gx0ntuUvZFHmrEgF6De6Bmcslo8Uutc47Wc0HtdbeEHr58rFFNNJC5yAYpybGJ/2OHnrAIxIlPxQgFQaU9gVse6eNfg9/cw==; 5:bSRarziWrRAyR8k5lfL6ExKfmtDKEf6d0Y891OoSe7xxjc1mJf0KWW1jot63GDs+jkUoFKQU9DUYpjsCmV42nDshk/leq01sGkKZW0fwAsE03+YkYPKVGNfYn1xL7Isd7lk7lr2brrI2z9eppsJiC+O8sj7cpZsZIUx8dyv2Uxk=; 24:k/OfMlYYeCAYQuEzcYdV0Lq+dGIx20V2xGmm5WJbsdXVYFXLKLwqsW/ffIAf43Nal28sYKV+OgZ2LfjJkbY1y/VTEYWfvIGTbyJu9UtNjtQ=; 7:86N7za2gIwiQF3Fz02/k8acryUz10+BHHCDK+4eTzn9V9hy5I8SnuaHCCo082zq3BMkiue7FJ41BTufEeQ74logPqkDR0mlC3DdEex//cblNt86CKtTczPJD0xFktKjh37x+C089eFyXdCKpatN51mUWwl2Cl3QMqC6hckGcsdadRlnfyizr2+Qyj3RP1ZDZQarEh7xwbx1zRKC4ibWKl2TuapO52DjJFyyLh2+jhiA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2017 11:17:34.2775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB1321 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171016_041811_051820_B5BDF945 X-CRM114-Status: UNSURE ( 8.74 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [104.47.1.126 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [104.47.1.126 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Richard Weinberger , Marek Vasut , Alexander Sverdlin , Cyrille Pitchen , Brian Norris , David Woodhouse Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The datasheets explicitly state that the stateless opcodes are supported and that they "do not need to be set up in the addressing mode". The stateless mode is clearly more beneficial, because there are boot ROM code versions not able to cope with the chip left in 4-byte state. Tested with Micron N25Q512A. Signed-off-by: Alexander Sverdlin --- drivers/mtd/spi-nor/spi-nor.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 3128d8c..85670b1b 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -1052,12 +1052,12 @@ static const struct flash_info spi_nor_ids[] = { { "n25q064a", INFO(0x20bb17, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_QUAD_READ) }, { "n25q128a11", INFO(0x20bb18, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_QUAD_READ) }, { "n25q128a13", INFO(0x20ba18, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_QUAD_READ) }, - { "n25q256a", INFO(0x20ba19, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, - { "n25q256ax1", INFO(0x20bb19, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_QUAD_READ) }, - { "n25q512a", INFO(0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) }, - { "n25q512ax3", INFO(0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) }, - { "n25q00", INFO(0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, - { "n25q00a", INFO(0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, + { "n25q256a", INFO(0x20ba19, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, + { "n25q256ax1", INFO(0x20bb19, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, + { "n25q512a", INFO(0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, + { "n25q512ax3", INFO(0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, + { "n25q00", INFO(0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE | SPI_NOR_4B_OPCODES) }, + { "n25q00a", INFO(0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE | SPI_NOR_4B_OPCODES) }, /* PMC */ { "pm25lv512", INFO(0, 0, 32 * 1024, 2, SECT_4K_PMC) },