From patchwork Tue Dec 18 19:29:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Vorel X-Patchwork-Id: 1015577 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.cz Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43K7PR0r5Dz9rxp for ; Wed, 19 Dec 2018 06:29:15 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727193AbeLRT3N (ORCPT ); Tue, 18 Dec 2018 14:29:13 -0500 Received: from mx2.suse.de ([195.135.220.15]:58532 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726614AbeLRT3N (ORCPT ); Tue, 18 Dec 2018 14:29:13 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A401CAE10; Tue, 18 Dec 2018 19:29:11 +0000 (UTC) From: Petr Vorel To: netdev@vger.kernel.org Cc: Petr Vorel , Stephen Hemminger Subject: [PATCH iproute2 1/1] testsuite: Fix colorize Date: Tue, 18 Dec 2018 20:29:04 +0100 Message-Id: <20181218192904.18309-1-pvorel@suse.cz> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org bash and dash require for escape sequence to use 'echo -e' or printf (but working on zsh). Choosing printf as it's implementation is IMHO more portable than echo implementations. dash also require to use \033[0; as escape sequence instead of \e[0; NOTE: \e[0; kept in lib/color.c as it's not problematic for C code (working when run ip on various shells). Fixes: 7e2f71b4 ("testsuite: colorize test result output") Signed-off-by: Petr Vorel --- testsuite/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/testsuite/Makefile b/testsuite/Makefile index 9b0f1c15..7f247bbc 100644 --- a/testsuite/Makefile +++ b/testsuite/Makefile @@ -85,11 +85,11 @@ endif TC="$$i/tc/tc" IP="$$i/ip/ip" SS=$$i/misc/ss DEV="$(DEV)" IPVER="$@" SNAME="$$i" \ ERRF="$(RESULTS_DIR)/$@.$$o.err" $(PREFIX) tests/$@ > $(RESULTS_DIR)/$@.$$o.out; \ if [ "$$?" = "127" ]; then \ - echo "\e[1;35mSKIPPED\e[0m"; \ + printf "\033[1;35mSKIPPED\033[0m\n"; \ elif [ -e "$(RESULTS_DIR)/$@.$$o.err" ]; then \ - echo "\e[0;31mFAILED\e[0m"; \ + printf "\033[0;31mFAILED\033[0m\n"; \ else \ - echo "\e[0;32mPASS\e[0m"; \ + printf "\033[0;32mPASS\033[0m\n"; \ fi; \ rm "$$TMP_ERR" "$$TMP_OUT"; \ sudo dmesg > $(RESULTS_DIR)/$@.$$o.dmesg; \