From patchwork Thu Nov 29 08:43:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ioana Radulescu X-Patchwork-Id: 1005218 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="knavUdnT"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4359zQ6PRrz9s3l for ; Thu, 29 Nov 2018 19:43:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726933AbeK2TsU (ORCPT ); Thu, 29 Nov 2018 14:48:20 -0500 Received: from mail-eopbgr30074.outbound.protection.outlook.com ([40.107.3.74]:12416 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726766AbeK2TsT (ORCPT ); Thu, 29 Nov 2018 14:48:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R2oaNJKZrwj8lRojk/6Fj8xg9D66UXa/tkfIpptQ/6A=; b=knavUdnTyan06tPN5tD/EfLg5uS4kZvlXBFkQCqEMEDbU0bVZIBRQI+g9Q+0EGxiqnmPhhwJU11d4eDINa1Myf1KQLPlcy633sJnmz/oc7e2ScYrZMPqkCYlTIWb5/dtXG3f6dQ4+vikvDutqSYvWnVeTw9VcmqVJpQWAckK19g= Received: from AM0PR04MB4994.eurprd04.prod.outlook.com (20.177.40.15) by AM0PR04MB5009.eurprd04.prod.outlook.com (20.177.40.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1339.25; Thu, 29 Nov 2018 08:43:40 +0000 Received: from AM0PR04MB4994.eurprd04.prod.outlook.com ([fe80::c426:6b56:b6d2:c8f2]) by AM0PR04MB4994.eurprd04.prod.outlook.com ([fe80::c426:6b56:b6d2:c8f2%3]) with mapi id 15.20.1361.019; Thu, 29 Nov 2018 08:43:40 +0000 From: Ioana Ciocoi Radulescu To: "netdev@vger.kernel.org" , "davem@davemloft.net" CC: Ioana Ciornei , "sfr@canb.auug.org.au" Subject: [PATCH net-next] dpaa2-eth: Add "fall through" comments Thread-Topic: [PATCH net-next] dpaa2-eth: Add "fall through" comments Thread-Index: AQHUh7+gjuiD89IaFkGkbr+B7sdaqA== Date: Thu, 29 Nov 2018 08:43:40 +0000 Message-ID: <1543481014-18259-1-git-send-email-ruxandra.radulescu@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1P189CA0021.EURP189.PROD.OUTLOOK.COM (2603:10a6:802:2a::34) To AM0PR04MB4994.eurprd04.prod.outlook.com (2603:10a6:208:c7::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=ruxandra.radulescu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [86.34.165.90] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR04MB5009; 6:q6iTKzEAC17t+mllblFjraT8kVL0MD38KEnQwLpHE0bMXFca9uvTnVvf8l6Ns7yMRZ+5994K7gprhGUPcNpAxQHlHgHjG9Tu6nyxUPalhBM20Z0SWAniXZH9onvrSguuCp982tA01PM6Epoh6WmHl6xxlDI1yyCQ6g9alz9PbEsucfCFSl6l46sop4YCMPRIRSoWBzjH6B9Eupa1CzZgU4zUlqp/O4mk4HsXSjPCZ5yByQ2C3KY8Ta4C8EfUfMYdiJEasnOEyTpY73MNn6xNUZEGoqtB+d4P7DlPXV0eQ+ql6zYzQrjIxd4AlE89wTBWvSUrgzSmzsr+v5S0KaE4uSjT0SvlL0NrR1DwxXZ4wu5vueCZKw0eVv3nnre4SFdFM/LZ3rUbxSwxn/K5fwg0BMhdR/7Vx3sWpMHvHS2fofASYg13fl8TGOYWR4e9iER78YBT6jIrytKk5K1xcDvZYA==; 5:8PacVw+Ycv4I59Eiekuq3pXjg2Y5ljIlhBd+h59x9zzeXvYZBm5CJxt6USEHjkLoausOmoHKXrHkIEIIQBQJHFr9QbYDXkEed7wTlK8HIQQe+j1KlziD9lPsSgFQXAXeDpEetTYBxk6MkNszEJKzk7vNjJVX30csZNIxsi40WsE=; 7:3VEuEwzTJpCTO8DoDLfmiy+cZuWFQaE3pGb0TnWpTnjlnJlZrVwcC3y2Z+IiwQUsuvEQ2uwoY3WK9+JCt2VwwW1gbvEx1dSByakW9ZZuZ8LbLd9nSpVw7JrUjI8fvEfu7FuRrUcR1EZkEUbDm1vJ/Q== x-ms-office365-filtering-correlation-id: 33c6ec7d-333f-406e-62c7-08d655d6c2eb x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB5009; x-ms-traffictypediagnostic: AM0PR04MB5009: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231453)(999002)(944501410)(52105112)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:AM0PR04MB5009; BCL:0; PCL:0; RULEID:; SRVR:AM0PR04MB5009; x-forefront-prvs: 0871917CDA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(39860400002)(136003)(396003)(189003)(199004)(71200400001)(71190400001)(66066001)(478600001)(81156014)(81166006)(36756003)(6486002)(6512007)(53936002)(5660300001)(8936002)(6436002)(256004)(25786009)(8676002)(14454004)(105586002)(305945005)(102836004)(386003)(6506007)(2906002)(7736002)(316002)(110136005)(86362001)(54906003)(486006)(2501003)(4326008)(99286004)(52116002)(68736007)(106356001)(186003)(476003)(6116002)(3846002)(2616005)(97736004)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB5009; H:AM0PR04MB4994.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: leaKv+zEQO3wISr65VR8H6uD8Xhc5QlxAkNIGK0k9zv+NoPMPYu+ErrO8Xoearj5ANIswGoEcYrOsZVmAGDo5AtBuDE9G9ebpdQw+OakiRkEkoOnP7g/4cSJp6A0j7HagLtcMLn2yJ/QTQiAARY6kYFURzY4VP19OiRKBTKX8Uy8ZHDSe2r5VltbuRTyeXwgzXC1R9vxqD3wsIlQ7jKRiCwYaSFidnyaTrgXKUB4nEnf0Au/ViWT5wXSmEARQ4RLd5rD0VVhGcbNGfr8LtYnt9X0VzSWHuW9OKIxWCo/bPP3wXykRf/LiR9PjOcx+WAdZMAm3s8SlI6+WQJHKTHugNYmmo1gE6Sk1FOP8h+soKw= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33c6ec7d-333f-406e-62c7-08d655d6c2eb X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2018 08:43:40.4124 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5009 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Add comments in the switch statement for XDP action to indicate fallthrough is intended. Signed-off-by: Ioana Radulescu --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c index be84171..1ca9a18 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c @@ -322,8 +322,10 @@ static u32 run_xdp(struct dpaa2_eth_priv *priv, break; default: bpf_warn_invalid_xdp_action(xdp_act); + /* fall through */ case XDP_ABORTED: trace_xdp_exception(priv->net_dev, xdp_prog, xdp_act); + /* fall through */ case XDP_DROP: xdp_release_buf(priv, ch, addr); ch->stats.xdp_drop++;