From patchwork Tue Nov 13 05:52:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 996795 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CK8D1MgM"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="AgCXq1EY"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="X0jAwG5E"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42vGxk3ycQz9sNr for ; Tue, 13 Nov 2018 16:52:58 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=T7+nKJk1dmnm4bs6RMLhBBteJu2nSExu8I0WRpmNukw=; b=CK8D1MgMgXVJqmv/pbZw3UgFGE E0Mjj6rjsEMqbrWwz4kRHqed6O8nNvNxIVNCSFvkdVjo0yjXYRigw3VXnXCpe3NjLNLBo6gKt49T2 wDEEts2GJK2qjD/v2RZYR5HXEp9aQ3CsfVz1PXnpYZPcLZp3sm30Eau0CgNwfWjK6IbFrbGwgz0Y5 3ANFF5Cw6A/aTNicJfbk6HChD20gnCjTZyzF9n4BHE1nErZgm+sjftsyfjnMfzaoU/Mmzz85rYi26 U1WDA08Yad7QMD30e8l/R4wJkYe3D7q80imR9Vkc279KSjcmGeUxODA63TFReimoIofm1oHqPLYKm v9bvuNGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMRd5-0005fJ-Jc; Tue, 13 Nov 2018 05:52:51 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMRd3-0005eQ-IY for linux-um@bombadil.infradead.org; Tue, 13 Nov 2018 05:52:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yQsVyJt/rkr5tuZZqtgUOAWAWu7iWuY2dChASHi5GUg=; b=AgCXq1EYFa/QkcmU3cFENSqG9 3uD6Iw44MwJYciKhU8AQONg11vAM8bFGQW7F6C8LhH8DQ+TZp2KXBOjwZOCj5yIZg0sGlj1JX1kMs goA/4ICxkJBayXHBcmdWEXr2pqbjoQJzLmHbKfFB8mGYGCF6U6dZ82XA6kYEhQJW8gJ/VZP1Ki9j7 cuWEi5iqkYkmhgMCfKICsTInkFD5pC3EkTcrUGexu42p8dr0wERGew+AFnLM+bPlb22DnQ6K/schb XWWHf69coX3CyytdXKPAA/HXu7E9OQf7c5AJkZNUJetKOPd0zGHV7HLdBsz0xumanVa04LOIkeEyA Eu/BSK8Yw==; Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMRd0-0000vP-Me for linux-um@lists.infradead.org; Tue, 13 Nov 2018 05:52:47 +0000 Received: from sasha-vm.mshome.net (unknown [64.114.255.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE43322510; Tue, 13 Nov 2018 05:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1542088355; bh=O3jg4NgJzk7rsRQIy5RZoxYXQG7qSISPMntgICFBUaA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X0jAwG5E76190El1wjfabBvUlRPcL1zLm9g6ig5XnW7aQbcu9O77yADF6soibEl7O g1MvIX4+uG1tNydSGuP+WKJ3g8Rl61vu7OpeyUen0osZttlOJ2vTZeFYPjJ4KKqNgP wgMXI9Dk0I2nl8gs0t65Gy9togWEgXk/LXxd4aZI= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 07/17] um: Give start_idle_thread() a return code Date: Tue, 13 Nov 2018 00:52:13 -0500 Message-Id: <20181113055223.79060-7-sashal@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181113055223.79060-1-sashal@kernel.org> References: <20181113055223.79060-1-sashal@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181113_005246_826633_7C8078F5 X-CRM114-Status: GOOD ( 10.83 ) X-Spam-Score: -5.8 (-----) X-Spam-Report: SpamAssassin version 3.4.2 on merlin.infradead.org summary: Content analysis details: (-5.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [198.145.29.99 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.6 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Richard Weinberger , linux-um@lists.infradead.org MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Richard Weinberger [ Upstream commit 7ff1e34bbdc15acab823b1ee4240e94623d50ee8 ] Fixes: arch/um/os-Linux/skas/process.c:613:1: warning: control reaches end of non-void function [-Wreturn-type] longjmp() never returns but gcc still warns that the end of the function can be reached. Add a return code and debug aid to detect this impossible case. Signed-off-by: Richard Weinberger Signed-off-by: Sasha Levin --- arch/um/os-Linux/skas/process.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/um/os-Linux/skas/process.c b/arch/um/os-Linux/skas/process.c index 23025d645160..0a99d4515065 100644 --- a/arch/um/os-Linux/skas/process.c +++ b/arch/um/os-Linux/skas/process.c @@ -578,6 +578,11 @@ int start_idle_thread(void *stack, jmp_buf *switch_buf) fatal_sigsegv(); } longjmp(*switch_buf, 1); + + /* unreachable */ + printk(UM_KERN_ERR "impossible long jump!"); + fatal_sigsegv(); + return 0; } void initial_thread_cb_skas(void (*proc)(void *), void *arg)