From patchwork Sat Nov 10 00:53:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Kossifidis X-Patchwork-Id: 995803 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ics.forth.gr Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42sJTT3HXVz9sDJ for ; Sat, 10 Nov 2018 11:55:09 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727730AbeKJKiP (ORCPT ); Sat, 10 Nov 2018 05:38:15 -0500 Received: from mailgate-4.ics.forth.gr ([139.91.1.7]:33198 "EHLO mailgate-4.ics.forth.gr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727210AbeKJKiP (ORCPT ); Sat, 10 Nov 2018 05:38:15 -0500 Received: from av1.ics.forth.gr (av3in.ics.forth.gr. [139.91.1.77]) by mailgate-4.ics.forth.gr (8.14.5/ICS-FORTH/V10-1.9-GATE-OUT) with ESMTP id wAA0rTeD037544; Sat, 10 Nov 2018 02:53:31 +0200 (EET) X-AuditID: 8b5b9d4d-91bff70000000e62-b5-5be62c0943d7 Received: from enigma.ics.forth.gr (enigma.ics.forth.gr [139.91.1.35]) by av1.ics.forth.gr (SMTP Outbound / FORTH / ICS) with SMTP id 2F.6D.03682.90C26EB5; Sat, 10 Nov 2018 02:53:29 +0200 (EET) Received: from trampakoulas.ics.forth.gr (dell-desktop.ics.forth.gr [139.91.92.59] (may be forged)) (authenticated bits=0) by enigma.ics.forth.gr (8.15.1//ICS-FORTH/V10.5.0C-EXTNULL-SSL-SASL) with ESMTPSA id wAA0rO0E024479 (version=TLSv1.2 cipher=DHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Sat, 10 Nov 2018 02:53:29 +0200 X-ICS-AUTH-INFO: Authenticated user: mick@ics.forth.gr at ics.forth.gr From: Nick Kossifidis To: devicetree@vger.kernel.org Cc: robh+dt@kernel.org, frowand.list@gmail.com, linux-riscv@lists.infradead.org, palmer@sifive.com, Nick Kossifidis Subject: [PATCH] OF: Add a warning in case chosen node is not present Date: Sat, 10 Nov 2018 02:53:17 +0200 Message-Id: <20181110005317.5631-1-mick@ics.forth.gr> X-Mailer: git-send-email 2.16.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGJMWRmVeSWpSXmKPExsXSHc2orMup8yza4Op/fov5R86xWsx885/N YtvnFjaL5nfn2C02T1jAatG69wi7A5vHzll32T0ebrrE5LFpVSebx+Yl9R6Xmq+ze3zeJBfA FsVlk5Kak1mWWqRvl8CVMWv7f9aCCxwVD9Y9ZGtgnM/excjJISFgIvH4wW/GLkYuDiGBw4wS 53afY4dwzjJJPLp9lRWiyk3i9v2dYDabgKbE/EsHWUBsEQE5iZtf77KB2MwCMxklnr/yALGF BVwlru2+wwxiswioSpxedQ2shlfAVGL9jPdQM+Ulfj3/zDyBkXsBI8MqRoHEMmO9zORivbT8 opIMvfSiTYzg0Jjru4Px3AL7Q4wCHIxKPLw/lj+NFmJNLCuuzD3EKMHBrCTCK7sFKMSbklhZ lVqUH19UmpNafIhRmoNFSZz38IvwICGB9MSS1OzU1ILUIpgsEwenVAOjgbroHNG377+zHavj 03t+/0FCeuyGcFXrUPG2pNlqsaEHmr9dNeTx/TSRjaPVsEoo1eHml8wWfd+Zq0IXTLT8HKM0 WVXlQO9nPiulRZ/4V7ToCj6zF0tq0XKvzora5aqjG8iytVLKxXaz7YHss7+L/M7etHh7V0ds d7V4/QFrOc35dSUXDimxFGckGmoxFxUnAgDJEOJaCQIAAA== Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On architectures that only get their bootargs through devicetree's chosen node (such as RISC-V), that node is mandatory. After a discussion with Rob [1] I'm adding a warning in case chosen node is not present, to let users know about it. [1]: https://patchwork.ozlabs.org/patch/984224/#2016136 Signed-off-by: Nick Kossifidis Reviewed-by: Palmer Dabbelt --- drivers/of/fdt.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index bb532aae0d92..7ff67bf1f6d6 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -1200,8 +1200,12 @@ bool __init early_init_dt_verify(void *params) void __init early_init_dt_scan_nodes(void) { + int rc = 0; + /* Retrieve various information from the /chosen node */ - of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line); + rc = of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line); + if (!rc) + pr_warn("No chosen node found, continuing without\n"); /* Initialize {size,address}-cells info */ of_scan_flat_dt(early_init_dt_scan_root, NULL);