From patchwork Wed Oct 31 16:19:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 991529 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VsI2xICA"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42lYSx1xkTz9s1x for ; Thu, 1 Nov 2018 03:19:45 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729785AbeKABSZ (ORCPT ); Wed, 31 Oct 2018 21:18:25 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:34996 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729320AbeKABSY (ORCPT ); Wed, 31 Oct 2018 21:18:24 -0400 Received: by mail-pg1-f193.google.com with SMTP id 32-v6so7621491pgu.2 for ; Wed, 31 Oct 2018 09:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KOfYSw/pc3o5VV4Lb2ZdIjZy0lm+KRH5j97IigYXFsM=; b=VsI2xICAGuSSzLgYLqOM+pOzS/k2JIGeHkJJ48ISYPbFKTDove5vnA6i+Pi2lDbI4I u3cnSiCjDSW1dCYRmrJKWpi8Hqcv/O520ekZyHObj4vKHWa114uYSt/TL7VEAG22eCcs BvjiXpy67vqAUw43t4tDYcfIsY2o2qVwZXB2ef0m+jOqM1/KhrS60IS8B2CqDAc1aa+e mfwU5TlgFo2vRYZlrOYyQwBrnSo3y7KfRqY/9QDn21vD1BmVyFBnOoAR3hQ+7qNI84C2 /vHcOX9O42rjhUtlkT7EtZm2aA2L0mv+jZU6QxshR9bdknQpaldf8FQgO17ZiJnBeuHL avxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KOfYSw/pc3o5VV4Lb2ZdIjZy0lm+KRH5j97IigYXFsM=; b=s/i6osdHDADq2d9oaQv8ESKhIYfXcD9r2R13BcC0VCSBgr+YYRSzXlYL/wEcjzHk0H iTYfDbQH2/qfmJ4wEdrqu5k5x1TQfMg0rcqSspeo2vCsTtlRObAHLSbvGjzYIL7T2mnS RS+Qf0nuE42OoL/WlIooCkrpk95xnnVapfE+55Hl7vNaavnlfKC5iyQXiRmsrjAc4M03 L/mGS1lW2riBzfDlE4dec1LSdaTgYmAW7GkcCCCDkB3IldJW87xQLPpE0gvG2DcMvykU VDW0NFimvRg+R8ykG+Ix8uhOGC5+rwZtCpSoJXUIJ16tD/P6iVnnVHDMGXOcGcUdxqjT umOw== X-Gm-Message-State: AGRZ1gJ9LYoiSNIqkNC7JPA4gWB3+6i07EbLerJSW93O7mvFGBlP8xCI YXsQ8iTtzdBoUAuCMDZx/DY= X-Google-Smtp-Source: AJdET5fznRZV9hgKtNkILlnnDGqikYMsv/o3MMKv7WGh4/5k82Btw4YrLqGpwiBxpJADIGvrebLqbQ== X-Received: by 2002:a63:1066:: with SMTP id 38-v6mr3835545pgq.254.1541002783100; Wed, 31 Oct 2018 09:19:43 -0700 (PDT) Received: from Inspiron.nitk.ac.in ([106.193.104.195]) by smtp.gmail.com with ESMTPSA id i21-v6sm33812969pgj.55.2018.10.31.09.19.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 31 Oct 2018 09:19:42 -0700 (PDT) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, tahiliani@nitk.edu.in, dhavaljkhandla26@gmail.com, hrishihiraskar@gmail.com, bmanish15597@gmail.com, sdp.sachin@gmail.com Subject: [PATCH net-next 1/8] net: sched: pie: change value of QUEUE_THRESHOLD Date: Wed, 31 Oct 2018 21:49:25 +0530 Message-Id: <1541002772-28040-2-git-send-email-lesliemonis@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> References: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" RFC 8033 recommends a value of 16384 bytes for the queue threshold instead of 10000 bytes. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index d142937..56c9e4d 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -31,7 +31,7 @@ #include #include -#define QUEUE_THRESHOLD 10000 +#define QUEUE_THRESHOLD 16384 /* 16KB i.e. 2^14 bytes */ #define DQCOUNT_INVALID -1 #define MAX_PROB 0xffffffff #define PIE_SCALE 8 From patchwork Wed Oct 31 16:19:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 991530 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="f2tc0eia"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42lYT05V2xz9s1x for ; Thu, 1 Nov 2018 03:19:48 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729790AbeKABS2 (ORCPT ); Wed, 31 Oct 2018 21:18:28 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:42617 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729287AbeKABS2 (ORCPT ); Wed, 31 Oct 2018 21:18:28 -0400 Received: by mail-pf1-f194.google.com with SMTP id f26-v6so7848843pfn.9 for ; Wed, 31 Oct 2018 09:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2XCXcp0dpJhQNTNXvCoQVzaQKqoyPPrXatPg4wqItq8=; b=f2tc0eiad/h9YT6cjbNxvCsgBhPDrM/O/4nT44kZk8bdG5JZICGXAM2EuaXmcXrM/5 E/sTX/RgO86BRGw4SIokUym1yKRmvBJyO/F8Hh82/jl7x/ht0Ol44KRBRGlBkmMa6OO5 qXalIiaE7krR9jOOAXeHaIe2o70Rk+kwXAN49BCs0issTL6u+sgWSKCyAoMaQihlu/F5 UsvnPYGfurEjUQ7LAgMyfhZBCUYkyZnV0O1KXRl4ne3tut3L2viRGFajZLYRcZcfqDTE /XMTMZl0a0ewwOL/8qndkxF7Ykgocv714XruaibfEBKbk7fBKMi2BIYBQN7lfYVS0WAu Mmmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2XCXcp0dpJhQNTNXvCoQVzaQKqoyPPrXatPg4wqItq8=; b=ZKDVYwSgZeznaNATWmsGhXYlKvsbkI5hkp0q2kc9K8IFA4tsUdWNDj/H5tp/B9CJtc yty6hq9keiYqiSPLu6vUbL7bFyTb/vjal9r/13nvVKUUu6BuZBI6Mdg47eCQZOYltAci KuOv/KeH3rTgSyoaKwat+CLP+X2Xgqzc3MXEYPZQ9Q83ft4YSHaSZnkXXbonwxO0Egx/ 0JLuheOer6plzaEiveoU3vvvysTRA0fxEZn4BTQrpR5wKQKHjAM0EolwFKQZrbsvZuNA tSmvOjlfpJyYy+Yj+4s7rIO+yHTGWCszdwqGsm3SbDTB3esvGfAatQzpj7gQS8N3Seta UTdQ== X-Gm-Message-State: AGRZ1gLXru8/1Se589vjS1Ogcdqf03iTTqDdDLINrpOaR9J5+rV26rEx EEY3byUop3f+R9dAfwGuG30= X-Google-Smtp-Source: AJdET5cSd31UBkRxm6sbGamKJHkmowz92uyK942OGRmXoYT/NiFTOyKrztpsoTVjcvwp4HV36448Hw== X-Received: by 2002:a65:5a89:: with SMTP id c9-v6mr3719030pgt.216.1541002786630; Wed, 31 Oct 2018 09:19:46 -0700 (PDT) Received: from Inspiron.nitk.ac.in ([106.193.104.195]) by smtp.gmail.com with ESMTPSA id i21-v6sm33812969pgj.55.2018.10.31.09.19.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 31 Oct 2018 09:19:46 -0700 (PDT) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, tahiliani@nitk.edu.in, dhavaljkhandla26@gmail.com, hrishihiraskar@gmail.com, bmanish15597@gmail.com, sdp.sachin@gmail.com Subject: [PATCH net-next 2/8] net: sched: pie: change default value of pie_params->target Date: Wed, 31 Oct 2018 21:49:26 +0530 Message-Id: <1541002772-28040-3-git-send-email-lesliemonis@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> References: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" RFC 8033 suggests a default value of 15 milliseconds for the target queue delay instead of 20 milliseconds. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 56c9e4d..c5d6d6b 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -83,7 +83,7 @@ static void pie_params_init(struct pie_params *params) params->beta = 20; params->tupdate = usecs_to_jiffies(30 * USEC_PER_MSEC); /* 30 ms */ params->limit = 1000; /* default of 1000 packets */ - params->target = PSCHED_NS2TICKS(20 * NSEC_PER_MSEC); /* 20 ms */ + params->target = PSCHED_NS2TICKS(15 * NSEC_PER_MSEC); /* 15 ms */ params->ecn = false; params->bytemode = false; } From patchwork Wed Oct 31 16:19:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 991531 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UXD8EKEu"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42lYT51YFzz9s1x for ; Thu, 1 Nov 2018 03:19:53 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729795AbeKABSc (ORCPT ); Wed, 31 Oct 2018 21:18:32 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:44670 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729287AbeKABSc (ORCPT ); Wed, 31 Oct 2018 21:18:32 -0400 Received: by mail-pg1-f194.google.com with SMTP id w3-v6so7599110pgs.11 for ; Wed, 31 Oct 2018 09:19:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DUV9Z5+wQnbmqJs5O2CccT352vpeZKiybKlvOCzJpz4=; b=UXD8EKEupIXY3Txza4IXprxK3AVRM4bYUYiXbnr1BVeHHPFmSU3MnJqHEYH0Mp3l5n j6nDP4DpmaCSCcmn2ctyKUbGQovN4Z/zdzRbyJuWntEXwN1oFHYItS+7QX9HnpCn6NHR JmgxvwJNwqhVdIL2T/rALvQBJrztKMVX13+BQEftwQxnirSG7auCDqb7NrycGFZj6saE cRq8NV2hpq1qj0ebSyHouc7THf4CiC5fm8FMPLzp2JiALOEPQJDR0SO+pQS0ZQ0njenp 6zn2SQxDh09RcyAGnPmqC6p1w2CTk6R53rlU6I/RCi5NvvPLbgRRY4W7maJBQwsaZV0U wipQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DUV9Z5+wQnbmqJs5O2CccT352vpeZKiybKlvOCzJpz4=; b=rU/BNu8VJ5WqA+0SgwoSTo7SWaLsYjgJ4AjY+tUxTR34z0eSehRaCGeVUogWY3tj9Z s0i4UHLtjcm1MfTnngN6YrKY0inJGbLOjyDGTY6GCzhiLWzVs+i24jKEbYlAPw8nIywy fj8bmzLYvH/+F4P1oY2HLKkB7jyvFvtUhQ3b18yTs/6NxyaOKZfKzhx+PsvqelHil0B9 cyA0Ux/GwYyLqYiWJTZF1NH3tg5VwoXqohYFzEU5O98i7zPp5UnlH5WgnGiCCgod5v5n xo2F9B/FLdYXruinTEWvNr79QKYPwi8fy3fjTIgdB4vUNJhAL7nYa3ny88boA8GjyVLO jh2Q== X-Gm-Message-State: AGRZ1gL3GqDD/iZ93RlrI8L9cKlBo2q7eplv2n5b7oxKCyyltf1Fz7OU C6XN/LXy9Ex6D37HRz1osgY= X-Google-Smtp-Source: AJdET5e9AbyjI4cbQRfusw9qgGFLc3sZTaKAUVxlvzw1PVQwBG/W0NY3Dj1rqgvLnhGNv3aFhoD5yg== X-Received: by 2002:a62:d148:: with SMTP id t8-v6mr4059239pfl.212.1541002790196; Wed, 31 Oct 2018 09:19:50 -0700 (PDT) Received: from Inspiron.nitk.ac.in ([106.193.104.195]) by smtp.gmail.com with ESMTPSA id i21-v6sm33812969pgj.55.2018.10.31.09.19.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 31 Oct 2018 09:19:49 -0700 (PDT) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, tahiliani@nitk.edu.in, dhavaljkhandla26@gmail.com, hrishihiraskar@gmail.com, bmanish15597@gmail.com, sdp.sachin@gmail.com Subject: [PATCH net-next 3/8] net: sched: pie: change default value of pie_params->tupdate Date: Wed, 31 Oct 2018 21:49:27 +0530 Message-Id: <1541002772-28040-4-git-send-email-lesliemonis@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> References: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" RFC 8033 suggests a default value of 15 milliseconds for the update interval instead of 30 milliseconds. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index c5d6d6b..9912d9cc 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -81,7 +81,7 @@ static void pie_params_init(struct pie_params *params) { params->alpha = 2; params->beta = 20; - params->tupdate = usecs_to_jiffies(30 * USEC_PER_MSEC); /* 30 ms */ + params->tupdate = usecs_to_jiffies(15 * USEC_PER_MSEC); /* 15 ms */ params->limit = 1000; /* default of 1000 packets */ params->target = PSCHED_NS2TICKS(15 * NSEC_PER_MSEC); /* 15 ms */ params->ecn = false; From patchwork Wed Oct 31 16:19:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 991532 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="s1FlvB/B"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42lYT90Lwmz9s1x for ; Thu, 1 Nov 2018 03:19:57 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729800AbeKABSg (ORCPT ); Wed, 31 Oct 2018 21:18:36 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:42516 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729287AbeKABSg (ORCPT ); Wed, 31 Oct 2018 21:18:36 -0400 Received: by mail-pg1-f195.google.com with SMTP id i4-v6so7608017pgq.9 for ; Wed, 31 Oct 2018 09:19:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=n1RmVY6hQkthBP+tibnz0/semgTGAIgqNiRlkasX8uI=; b=s1FlvB/Bv6UEboqkEq6ZdMlCrJD1L5j2IYxutKscO2GDsnZbhB7VLevr/DH6ZewU52 00btEEqcVL5ODcKbPQeY+pJGs0qql80dUE/ZAt9TNUSXjGWR2Plxhwz5anbVwta+OAld MQWwRV60/76om+puevJrX0EyfuxaZdbOsphmjzgNCUAKAF9ttblgjnaAIwdO3rVhPb3q GmlDVLYhQoZ3fPaYrVbuYFppK8WP5ir7SSZ3rU8hxU7N2XrhFKj0ATkJoSbcE2FD4nrk ztpHviKEk9neEkXS8LzPAKu0nqbdwy2UrAZDODwplyuXUs9mFpsj8uidbGdMOfmy6yL3 xxpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=n1RmVY6hQkthBP+tibnz0/semgTGAIgqNiRlkasX8uI=; b=NdikslOg7xjuVzTrd/QvetBHznT7LUkw6RKjrOdwbXJY+5eHcZJOz3/qxlMTJpYo93 wl5HBpR0sN/x0Y3BkJWbE87xowILAzzbFtSqD5bHrWIRXyTDoTQhJ/JpsExkO0AZGMpf QuJUJ24Fi9ET2IsuvUebLKGC7m3ycGT8Fe0fqMCfQgo3uFTxaRzllcH1+GTB7CdRRwFi D/iKgsawsSLNmbcp0m+yBK9LbwNL2cd40uIU1ICNUoujyBifpyUbXH6hLlFzOP44LUDI sgeHCaxSPmgKrx+11NVBshtLn6/pg4Su2oO+BFOQYuoZ8CnycL6eOJn9M/RuinTTNRJ5 3j2Q== X-Gm-Message-State: AGRZ1gLuOPIylo4YLbfeCbLb+7n0+NYqTmaWPt39YIJCROd0B6Vy1tLN XehhwpBgXVzA+d9cLiQ3YnE= X-Google-Smtp-Source: AJdET5cmyQgRMm3zi9i46Hmmz6OVPvxwm9BhGs/cd8/FBgYSamQfJZzz5rCFqpKF3puswKTSHF/fNA== X-Received: by 2002:a62:6c4:: with SMTP id 187-v6mr3988142pfg.109.1541002794246; Wed, 31 Oct 2018 09:19:54 -0700 (PDT) Received: from Inspiron.nitk.ac.in ([106.193.104.195]) by smtp.gmail.com with ESMTPSA id i21-v6sm33812969pgj.55.2018.10.31.09.19.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 31 Oct 2018 09:19:53 -0700 (PDT) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, tahiliani@nitk.edu.in, dhavaljkhandla26@gmail.com, hrishihiraskar@gmail.com, bmanish15597@gmail.com, sdp.sachin@gmail.com Subject: [PATCH net-next 4/8] net: sched: pie: change initial value of pie_vars->burst_time Date: Wed, 31 Oct 2018 21:49:28 +0530 Message-Id: <1541002772-28040-5-git-send-email-lesliemonis@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> References: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" RFC 8033 suggests an initial value of 150 milliseconds for the maximum time allowed for a burst of packets instead of 100 milliseconds. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 9912d9cc..f4e189a 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -92,8 +92,8 @@ static void pie_vars_init(struct pie_vars *vars) { vars->dq_count = DQCOUNT_INVALID; vars->avg_dq_rate = 0; - /* default of 100 ms in pschedtime */ - vars->burst_time = PSCHED_NS2TICKS(100 * NSEC_PER_MSEC); + /* default of 150 ms in pschedtime */ + vars->burst_time = PSCHED_NS2TICKS(150 * NSEC_PER_MSEC); } static bool drop_early(struct Qdisc *sch, u32 packet_size) From patchwork Wed Oct 31 16:19:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 991533 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="mrhM9VuU"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42lYTD1hGxz9s1x for ; Thu, 1 Nov 2018 03:20:00 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729807AbeKABSj (ORCPT ); Wed, 31 Oct 2018 21:18:39 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:36192 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729287AbeKABSj (ORCPT ); Wed, 31 Oct 2018 21:18:39 -0400 Received: by mail-pl1-f193.google.com with SMTP id y11-v6so7531740plt.3 for ; Wed, 31 Oct 2018 09:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=16VmbFUwZMcja/rI4CfYBtBCM20EdngJ6EDVbZgmYSM=; b=mrhM9VuUk8U4CNG0dadDJHzy81oELBTesdei3TUlq8mmmrU/5Y7oczggVxz7iURxuT yy49tBq3irj7RVMHEQAf3cOgvMzk3TBlesBzMRrCheasFofgXy0IOFUzoJuFW3Z8oLQf 8o7LwfpWdMSoOgAIWvkcsXdq1t8voV89YZrE8Hkot7UE0I8pI36ulfsdPkU123a7Nvrc GV7U3TAIo/GevBUxMy8yvpYaivutkDMUI5iVc9rILMCcEb14RY8/3L0iIAba+1S2h8o+ GQFKNtF4FiW5luCp210asb2Jy2xo9QwJZeiOMRc2sTJHEQQ3hC34n+tlqeaJ1pM7NJfN jirA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=16VmbFUwZMcja/rI4CfYBtBCM20EdngJ6EDVbZgmYSM=; b=YsTRyqcFNuXeNmqbmI7mPH6gx2SgKeZxLA/ZjUpHNlRQ7vwsohC9ZqbRSoIztqLkPy 2e322h7H78ZsWdS4M+hjqYSLwKz+5iKojA+fMwYozwK+3uh4F7PIpDeNxG+jB3Y8Exlp xy5dR4454Xtl47/gnBpecvDqLYVjyOcEkyKZOkB3ePyc1w7J6qwkGtzc7zm/gKtZwZDT gLg3vbfSlWdgr14qYEcvSLO16gA9C+2s+quDuLLNfmjhGTPNXD212b4R7A0DBprf+7yd qW2p7lo6pavTu24McHE8s9hHT+4rs7adDz8ENHAAfV2TL3V1xGgIhobOirZTqNlXLmSR PuAg== X-Gm-Message-State: AGRZ1gKPqG65+PcTIQChstj6IWSGRrr9YjX5nglWfsUvTahO9Q9UCrRG xYnv2AfY45ZAzsCk2IW0Cks= X-Google-Smtp-Source: AJdET5e8M1i+v+R2MYujZ7Uswxl2LXlfP0N4S1cnj4ONRwiXimKdawQjd/VX0J/Nli7oRRxrH7mbRQ== X-Received: by 2002:a17:902:b485:: with SMTP id y5-v6mr3943720plr.122.1541002798194; Wed, 31 Oct 2018 09:19:58 -0700 (PDT) Received: from Inspiron.nitk.ac.in ([106.193.104.195]) by smtp.gmail.com with ESMTPSA id i21-v6sm33812969pgj.55.2018.10.31.09.19.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 31 Oct 2018 09:19:57 -0700 (PDT) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, tahiliani@nitk.edu.in, dhavaljkhandla26@gmail.com, hrishihiraskar@gmail.com, bmanish15597@gmail.com, sdp.sachin@gmail.com Subject: [PATCH net-next 5/8] net: sched: pie: add more conditions to auto-tune alpha and beta Date: Wed, 31 Oct 2018 21:49:29 +0530 Message-Id: <1541002772-28040-6-git-send-email-lesliemonis@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> References: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" The update in drop probability depends on the parameters alpha and beta, which in turn reflect the current congestion level. However, the previous if-else cases were recommended when the supported bandwidth was up to 12 Mbps but, current data links support a much higher bandwidth, and the requirement for more bandwidth is in never-ending demand. Hence, RFC 8033 suggests using more if-else cases for better fine-tuning of parameters alpha and beta in order to control the congestion as much as possible. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index f4e189a..c84e91e 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -343,10 +343,30 @@ static void calculate_probability(struct Qdisc *sch) * appropriately 2) scaling down by 16 to come to 0-2 range. * Please see paper for details. * - * We scale alpha and beta differently depending on whether we are in - * light, medium or high dropping mode. + * We scale alpha and beta differently depending on how heavy the + * congestion is. */ - if (q->vars.prob < MAX_PROB / 100) { + if (q->vars.prob < MAX_PROB / 1000000) { + alpha = + (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 15; + beta = + (q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 15; + } else if (q->vars.prob < MAX_PROB / 100000) { + alpha = + (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 13; + beta = + (q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 13; + } else if (q->vars.prob < MAX_PROB / 10000) { + alpha = + (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 11; + beta = + (q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 11; + } else if (q->vars.prob < MAX_PROB / 1000) { + alpha = + (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 9; + beta = + (q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 9; + } else if (q->vars.prob < MAX_PROB / 100) { alpha = (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 7; beta = From patchwork Wed Oct 31 16:19:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 991534 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="rEuve2Eu"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42lYTH6QFSz9s1x for ; Thu, 1 Nov 2018 03:20:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729815AbeKABSn (ORCPT ); Wed, 31 Oct 2018 21:18:43 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:36402 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729287AbeKABSn (ORCPT ); Wed, 31 Oct 2018 21:18:43 -0400 Received: by mail-pg1-f196.google.com with SMTP id z17-v6so7616396pgv.3 for ; Wed, 31 Oct 2018 09:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TqAN3cFCW3Vc/fEYQsjI5YOcX1B5xnqaewBaVa9115k=; b=rEuve2EucXfb2m4yARoYBh0+G1Ue3Oo3bLfEh1FEaCFP0HLzWxO9tD91X9YLIz25Ua Nx1QcV54ugdhinVKAEaZ8MRRVWCZYOZunOO3ZE6vQbqA7m65+GTEimRRBQZVBZbtuDE+ 4BW2mrR4sdMaaaVvwOhraq6OvVZ0lAaAouQPPubYHL7CaTBZB9senI4A2hJWUYXlY+px sjHXq046RAV5M3AwCoGf3PQOOUwMnKLPglZCD2jpI2aluXOdtJzjlORpTO0Qbu9bbs94 8FL9zDFYuHGRkFZ8DMxa7XOKnmL1fFWe3G1oCDbBVUQ9BIIBvQ1faJeMkQRJJyydFjNG VuVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TqAN3cFCW3Vc/fEYQsjI5YOcX1B5xnqaewBaVa9115k=; b=U45ZEUumGGx+Zcdi5mVyecKF0Q9icsRWYP9hhPz0TIq+V6mqXYfutY5IIhyTvjk8IV 9loGmqcu+3zgeJRW3SejJV8Yv7Wrc5g3g/scKzMMpEjfwbneTiEbSQExVVOz+vedDAWu YewQWO8emhrhHlxRI0vrvx+uMxA+qFzNJ7QUeKoYLKQ025kVQo5USZJWOwnWPSl8ufPt s8nw2qBJU2lWINpRAiFz0MUR/yaUhhobz95v5/b9O73i7cme3qskYg5OhNaH8llv0NLb /x7BQxYVqDwjVQVWc/6DnMh+uuvAgmFJ1OdNS4XZVt9kYC/0XmOODMjOx+FGFbMMXmlN JWvw== X-Gm-Message-State: AGRZ1gLrIfMtAoaXc/VkqziaHTojbkpyaeTI9c2U4RQAeqIKAaMpD0Yy W1Jyaf5wJzYFIGLe5ZpJUT4= X-Google-Smtp-Source: AJdET5dX/8x/d+OFicoRSqmoAwRjENSCQznB2KDv3VE6DP+wP7eTlYO6z6dcd1n8VuAw/zcCJ8e7eQ== X-Received: by 2002:a63:584a:: with SMTP id i10-v6mr3832540pgm.178.1541002801749; Wed, 31 Oct 2018 09:20:01 -0700 (PDT) Received: from Inspiron.nitk.ac.in ([106.193.104.195]) by smtp.gmail.com with ESMTPSA id i21-v6sm33812969pgj.55.2018.10.31.09.19.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 31 Oct 2018 09:20:01 -0700 (PDT) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, tahiliani@nitk.edu.in, dhavaljkhandla26@gmail.com, hrishihiraskar@gmail.com, bmanish15597@gmail.com, sdp.sachin@gmail.com Subject: [PATCH net-next 6/8] net: sched: pie: add mechanism to set PIE active/inactive Date: Wed, 31 Oct 2018 21:49:30 +0530 Message-Id: <1541002772-28040-7-git-send-email-lesliemonis@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> References: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" To overcome unnecessary packet drops due to a spurious uptick in queuing latency caused by fluctuations in a network, PIE can choose to be active only when the queue occupancy is over a certain threshold. RFC 8033 suggests the value of this threshold be 1/3 of the tail drop threshold. PIE becomes inactive when the congestion ends i.e., when the drop probability reaches 0, and the current and previous latency samples are all below half of the target queue delay. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index c84e91e..b68b367 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -57,6 +57,7 @@ struct pie_vars { psched_time_t dq_tstamp; /* drain rate */ u32 avg_dq_rate; /* bytes per pschedtime tick,scaled */ u32 qlen_old; /* in bytes */ + bool active; /* inactive/active */ }; /* statistics gathering */ @@ -94,6 +95,7 @@ static void pie_vars_init(struct pie_vars *vars) vars->avg_dq_rate = 0; /* default of 150 ms in pschedtime */ vars->burst_time = PSCHED_NS2TICKS(150 * NSEC_PER_MSEC); + vars->active = true; } static bool drop_early(struct Qdisc *sch, u32 packet_size) @@ -141,12 +143,23 @@ static int pie_qdisc_enqueue(struct sk_buff *skb, struct Qdisc *sch, struct pie_sched_data *q = qdisc_priv(sch); bool enqueue = false; + if (!q->vars.active && qdisc_qlen(sch) >= sch->limit / 3) { + /* If the queue occupancy is over 1/3 of the tail drop + * threshold, turn on PIE. + */ + pie_vars_init(&q->vars); + q->vars.prob = 0; + q->vars.qdelay_old = 0; + q->vars.dq_count = 0; + q->vars.dq_tstamp = psched_get_time(); + } + if (unlikely(qdisc_qlen(sch) >= sch->limit)) { q->stats.overlimit++; goto out; } - if (!drop_early(sch, skb->len)) { + if (!q->vars.active || !drop_early(sch, skb->len)) { enqueue = true; } else if (q->params.ecn && (q->vars.prob <= MAX_PROB / 10) && INET_ECN_set_ce(skb)) { @@ -431,7 +444,7 @@ static void calculate_probability(struct Qdisc *sch) q->vars.qdelay = qdelay; q->vars.qlen_old = qlen; - /* We restart the measurement cycle if the following conditions are met + /* We turn off PIE if the following conditions are met * 1. If the delay has been low for 2 consecutive Tupdate periods * 2. Calculated drop probability is zero * 3. We have atleast one estimate for the avg_dq_rate ie., @@ -441,7 +454,7 @@ static void calculate_probability(struct Qdisc *sch) (q->vars.qdelay_old < q->params.target / 2) && q->vars.prob == 0 && q->vars.avg_dq_rate > 0) - pie_vars_init(&q->vars); + q->vars.active = false; } static void pie_timer(struct timer_list *t) @@ -451,7 +464,8 @@ static void pie_timer(struct timer_list *t) spinlock_t *root_lock = qdisc_lock(qdisc_root_sleeping(sch)); spin_lock(root_lock); - calculate_probability(sch); + if (q->vars.active) + calculate_probability(sch); /* reset the timer to fire after 'tupdate'. tupdate is in jiffies. */ if (q->params.tupdate) From patchwork Wed Oct 31 16:19:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 991535 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="gXm1XGxy"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42lYTM6tqpz9s1x for ; Thu, 1 Nov 2018 03:20:07 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729823AbeKABSr (ORCPT ); Wed, 31 Oct 2018 21:18:47 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:33704 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729287AbeKABSr (ORCPT ); Wed, 31 Oct 2018 21:18:47 -0400 Received: by mail-pf1-f196.google.com with SMTP id a15-v6so7873129pfn.0 for ; Wed, 31 Oct 2018 09:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QvOinuQ6ETSN1mLVrCbA5b7aOdllwP2VtcWdZ2PwhUw=; b=gXm1XGxytD5b/lBXaxV4MNOcIkHDyrE1xU+YqcRTap+6wqT3POWLDw53EXUZqzn3hA m3AiOtyvg2bKGuHE1KaNpmgtmby3EPou5GION2YsOVecmuVWYQQ8Z47li6aBIv9aHJaZ I43GHgbjP95PyKW/D32k7Z/JFuIpByHXnJly5acCjjYjxZ7/vlU58gpudmu5CZpm/0+v F2RxS273A2BaMqrEDsVPwWOHEZa257J0Cfc0gaPyx9aNTmr9VctcvIk7QmEIsD0s8Q4v yU71XQcdXLs1UFNV69dQ4bKAE8gXuNCqmQBpZLmtg4tbrrL70CT6VAPyO1UCg/xqQiyH 5sCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QvOinuQ6ETSN1mLVrCbA5b7aOdllwP2VtcWdZ2PwhUw=; b=mmkYiamHCZJSFtXSd0xeX/vUrGON/XOYsFnv1vr/0T3iDz0X5Fnx2NOyyvjI69JtoQ 681YVm7S3oKhwsFvvBsfs6VqFo80U75dNLAYpEeQheUxBvOMc6cgQBGM+AKM0YnYqXb2 lMiyTKHSFVCn/ynAmiXqAeebppOcpMe+/SYnVRsFgZ0ASuq5KosqI4PvAIvAtokL9MLK lJ/Ltr4kQKEjap30EMtxGIQvMuHHeWalC6p5vqWZFXGvAjrr1989fWbdw4NAcjszf1ca Q6ALUQXUQyIvwSX0j9u1uofIj5eB1zNxh6Smkh9eQFhUow6vWKlZvxM1T/5lZORYRzqS nNFA== X-Gm-Message-State: AGRZ1gLHfxtKkotlMtNm1qS711c1CDz590f8V6nNBCcUAY4FWpQs/7Sy Kk711mE1gjd6NuWwtXs0mPo= X-Google-Smtp-Source: AJdET5e8fZfj5pZUCWsY+O7WtZ94q3R9TefXYiVj0U9K1E6BmHL/5zmWBCZ/9dt/DCK1wQodcKtNHQ== X-Received: by 2002:a63:1066:: with SMTP id 38-v6mr3837005pgq.254.1541002805514; Wed, 31 Oct 2018 09:20:05 -0700 (PDT) Received: from Inspiron.nitk.ac.in ([106.193.104.195]) by smtp.gmail.com with ESMTPSA id i21-v6sm33812969pgj.55.2018.10.31.09.20.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 31 Oct 2018 09:20:05 -0700 (PDT) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, tahiliani@nitk.edu.in, dhavaljkhandla26@gmail.com, hrishihiraskar@gmail.com, bmanish15597@gmail.com, sdp.sachin@gmail.com Subject: [PATCH net-next 7/8] net: sched: pie: add derandomization mechanism Date: Wed, 31 Oct 2018 21:49:31 +0530 Message-Id: <1541002772-28040-8-git-send-email-lesliemonis@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> References: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" Random dropping of packets to achieve latency control may introduce outlier situations where packets are dropped too close to each other or too far from each other. This can cause the real drop percentage to temporarily deviate from the intended drop probability. In certain scenarios, such as a small number of simultaneous TCP flows, these deviations can cause significant deviations in link utilization and queuing latency. RFC 8033 suggests using a derandomization mechanism to avoid these deviations. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index b68b367..88e605c 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -58,6 +58,7 @@ struct pie_vars { u32 avg_dq_rate; /* bytes per pschedtime tick,scaled */ u32 qlen_old; /* in bytes */ bool active; /* inactive/active */ + u64 accu_prob; /* accumulated drop probability */ }; /* statistics gathering */ @@ -96,6 +97,7 @@ static void pie_vars_init(struct pie_vars *vars) /* default of 150 ms in pschedtime */ vars->burst_time = PSCHED_NS2TICKS(150 * NSEC_PER_MSEC); vars->active = true; + vars->accu_prob = 0; } static bool drop_early(struct Qdisc *sch, u32 packet_size) @@ -130,9 +132,21 @@ static bool drop_early(struct Qdisc *sch, u32 packet_size) else local_prob = q->vars.prob; + if (local_prob == 0) + q->vars.accu_prob = 0; + + q->vars.accu_prob += local_prob; + + if (q->vars.accu_prob < (MAX_PROB / 100) * 85) + return false; + if (q->vars.accu_prob >= ((u64)MAX_PROB * 17) / 2) + return true; + rnd = prandom_u32(); - if (rnd < local_prob) + if (rnd < local_prob) { + q->vars.accu_prob = 0; return true; + } return false; } @@ -181,6 +195,7 @@ static int pie_qdisc_enqueue(struct sk_buff *skb, struct Qdisc *sch, out: q->stats.dropped++; + q->vars.accu_prob = 0; return qdisc_drop(skb, sch, to_free); } From patchwork Wed Oct 31 16:19:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 991536 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FJjA4hOW"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42lYTR5RZdz9s3q for ; Thu, 1 Nov 2018 03:20:11 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729828AbeKABSv (ORCPT ); Wed, 31 Oct 2018 21:18:51 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:34133 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729287AbeKABSv (ORCPT ); Wed, 31 Oct 2018 21:18:51 -0400 Received: by mail-pl1-f194.google.com with SMTP id f10-v6so7535253plr.1 for ; Wed, 31 Oct 2018 09:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TQ+PzXCaTpSxIQoOZdZUyRacBk1z+satviY/G99sEC0=; b=FJjA4hOWWfcNzCz3lfMGMjfl9ugo0JwKDWscIYZQguH05U/Fssgk7yIhLaSyY1J0uE ixtjyL5LUfbCRGbrM9J2LirpPg/SD7xpe9m5ocKiLilKKsZdAaBfh0J1kVtHPQC2qWAx n5q67IEJIrMWKNDr8xM0r/jYj2myd9Qd1yc0Fo2gXIIsl48I91ismXpztxa11/zjGPsR /yIjtefJ8A1nDIeN6oaiEZIDFNeakXi/p4E6Qm16L7an3D5PGaoEb2xC2XNSShNhG+Kf DDmJ+TUo+Jd7Gbhc7VTwA56s5mYVAdzF3Ap8Z8Xz0ig0c8PwgZ/Grx/aAXvkXeqWYeTO WkFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TQ+PzXCaTpSxIQoOZdZUyRacBk1z+satviY/G99sEC0=; b=dzFdbUCBktJb4QWtbpHRspyH6G3TgU4QUV/jQrZSGf2Zu1imMXvPHzpG98Nn3IJqev ltaBMJMVqCgL4Z7jm9j8dHxomVLz122HYOy9P2V/2zcg24dyRbMTNIhV3p8Rd95WG5DS X0hFHyfS37oAZ2HijFZOe7ORSs8KIdiIipiY8yjIeqb1cWwZNA/rhXq8inXOnaigYvlx d0d0+CYcGL7vpcgW7ADKjXazgW3i37tHrOymU3pEiGzAMkwV0Y+JIXg7OzueaPmoFOOq UviTODdEC62n1UOVUDzn7kCkUj+TZUu2SNbNzEIPi1+iKv91NL+lZs5ZOBWOlBPcr0hy +PKA== X-Gm-Message-State: AGRZ1gJvSA7qcxLGdWzaIdXMi/E9gAsrjCTCcawRM/QeVHKED1dn6lEB yL0MBV6f5gYvpYP8noabEfE= X-Google-Smtp-Source: AJdET5crSmAlm5/hzaD2Az5V4C2TF8VsLAgbo/IJBlPoJs3RjS5zJYUestdqF621he/0Ng2VeyEJuw== X-Received: by 2002:a17:902:ab8a:: with SMTP id f10-v6mr4084575plr.203.1541002809627; Wed, 31 Oct 2018 09:20:09 -0700 (PDT) Received: from Inspiron.nitk.ac.in ([106.193.104.195]) by smtp.gmail.com with ESMTPSA id i21-v6sm33812969pgj.55.2018.10.31.09.20.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 31 Oct 2018 09:20:09 -0700 (PDT) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, tahiliani@nitk.edu.in, dhavaljkhandla26@gmail.com, hrishihiraskar@gmail.com, bmanish15597@gmail.com, sdp.sachin@gmail.com Subject: [PATCH net-next 8/8] net: sched: pie: update references Date: Wed, 31 Oct 2018 21:49:32 +0530 Message-Id: <1541002772-28040-9-git-send-email-lesliemonis@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> References: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" RFC 8033 replaces the IETF draft for PIE Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 88e605c..708e8ad 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -17,7 +17,7 @@ * University of Oslo, Norway. * * References: - * IETF draft submission: http://tools.ietf.org/html/draft-pan-aqm-pie-00 + * RFC 8033: https://tools.ietf.org/html/rfc8033 * IEEE Conference on High Performance Switching and Routing 2013 : * "PIE: A * Lightweight Control Scheme to Address the Bufferbloat Problem" */