From patchwork Mon Oct 29 21:14:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shannon Nelson X-Patchwork-Id: 990543 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=oracle.com header.i=@oracle.com header.b="p8pNC0pN"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42kS6w21wbz9s55 for ; Tue, 30 Oct 2018 08:15:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727115AbeJ3GFn (ORCPT ); Tue, 30 Oct 2018 02:05:43 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:53610 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726683AbeJ3GFn (ORCPT ); Tue, 30 Oct 2018 02:05:43 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9TLDBcC101518; Mon, 29 Oct 2018 21:14:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id; s=corp-2018-07-02; bh=rZh4jrhXO6SBJt2AO4bVGIXLvRaG+1YSoGo0o43XJaw=; b=p8pNC0pNuemRtQxwLG5trYrGHWT26+KEmIplFKOm5DNgGn/MHHNiRvkKRjupNNuwMaSB 7qjZxu3j95xW3vAJTKKyjXAh2lVqCOzhIOQSDNrBL+Ykx5u79uNjvxQzO+1RAL/P101S l0CNQNqp8tQibY+2whjG/VsspWpRo/TKFxZXJFw+U4vYAklP0FG9suwsyD3lrGFuJHRI 7/aUcKtjwyUWcbZ6WKzXO6Gno7Hkzck/00JcwR7yG8/frBzbOXhm/oGvXjgt1Zt3MJb6 ZHMgmQawlZuLMj245N+PrmrarGcv+O0CIktM6ahc9XREn8lV16O25AZb3ffqBEfUZff6 dw== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2ncfyprc9j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Oct 2018 21:14:57 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w9TLEoJv022632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Oct 2018 21:14:51 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w9TLEoeh002696; Mon, 29 Oct 2018 21:14:50 GMT Received: from slnelson-mint18.us.oracle.com (/10.159.138.154) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 29 Oct 2018 14:14:50 -0700 From: Shannon Nelson To: ast@kernel.org, daniel@iogearbox.net Cc: netdev@vger.kernel.org, shannon.lee.nelson@gmail.com Subject: [PATCH bpf-next] bpf_load: add map name to load_maps error message Date: Mon, 29 Oct 2018 14:14:41 -0700 Message-Id: <1540847681-3273-1-git-send-email-shannon.nelson@oracle.com> X-Mailer: git-send-email 2.7.4 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9061 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810290190 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org To help when debugging bpf/xdp load issues, have the load_map() error message include the number and name of the map that failed. Signed-off-by: Shannon Nelson Acked-by: John Fastabend Acked-by: Song Liu --- samples/bpf/bpf_load.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/bpf/bpf_load.c b/samples/bpf/bpf_load.c index 89161c9..5de0357 100644 --- a/samples/bpf/bpf_load.c +++ b/samples/bpf/bpf_load.c @@ -282,8 +282,8 @@ static int load_maps(struct bpf_map_data *maps, int nr_maps, numa_node); } if (map_fd[i] < 0) { - printf("failed to create a map: %d %s\n", - errno, strerror(errno)); + printf("failed to create map %d (%s): %d %s\n", + i, maps[i].name, errno, strerror(errno)); return 1; } maps[i].fd = map_fd[i];