From patchwork Fri Oct 26 17:35:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evan Green X-Patchwork-Id: 989686 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="I2+lbxXK"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42hWPH01Ptz9sLt for ; Sat, 27 Oct 2018 04:36:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727627AbeJ0CNz (ORCPT ); Fri, 26 Oct 2018 22:13:55 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:34517 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726815AbeJ0CNy (ORCPT ); Fri, 26 Oct 2018 22:13:54 -0400 Received: by mail-pf1-f193.google.com with SMTP id f78-v6so897840pfe.1 for ; Fri, 26 Oct 2018 10:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xuYKlm6mh0oPqnrGGq1xfr15WJea0AO3HvLc6Hnl/C0=; b=I2+lbxXKANGIQ3QjKx+MmLq1lxCOH9pQJTaAWBcKr8RgwmvdqzwJIQuXNpo25WJofH +9V/BlP6QDRsl1owXDLppxvefLMum1FVeC+AS5sQ6tcXYojpDOnv6T0sCBn+f/bntIZ5 3SKOVkTerNk2Ep+VuC5pyE9F07U37zWGPvmZA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xuYKlm6mh0oPqnrGGq1xfr15WJea0AO3HvLc6Hnl/C0=; b=rHACQ9ZZqnCC4Gd4ihJPg332fm2sSc2pLLO4nVA3BPhAm+uTt1T7BxRjO4V/3xd9Ru AARsPJBODPKXh9MmSgBB29q2vZYgKOWxcDgiHf+XYtR8CJYqzynfRmrGV5+HKuHZ7slu w7MxR4oEbxdaH/qxGly0Ww0Fgow6PHPdsPLcPDgrq6owioAPLhF7FgYnWUZV0qzZ+7Ng YLDXOs0gTddRi3m1V/myxpI9doxaKUAJEyyz66yCtjEpGVhASd8GAYMarnvXGr0Iixf2 fvnmw+YukcSPUW6DsFLEcaa/qMlDLvLvqyNfbB9zZj5kqHFNiJeYvlhKoNgUqatOB2iX KEFg== X-Gm-Message-State: AGRZ1gLZZO+TztPmEp3alyzxJpK4c+CmTLb6ts5HpZM/7IOX+bz42ZdW ykzgzZoDgeYHuAivV6JT3rRmcQ== X-Google-Smtp-Source: AJdET5cTSLKNWa5YK0n4Zov7ogvIL4q3Dpq9n1IZKezlYrxSzURiUHdG83JtcqZRrchVbinh7ZWPxw== X-Received: by 2002:a62:7d81:: with SMTP id y123-v6mr4602647pfc.245.1540575361130; Fri, 26 Oct 2018 10:36:01 -0700 (PDT) Received: from evgreen2.mtv.corp.google.com ([2620:15c:202:201:e418:c825:76cf:5f64]) by smtp.gmail.com with ESMTPSA id b29-v6sm20164448pfj.183.2018.10.26.10.35.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 26 Oct 2018 10:36:00 -0700 (PDT) From: Evan Green To: Rob Herring , Andy Gross , Kishon Vijay Abraham I Cc: Douglas Anderson , Stephen Boyd , Evan Green , devicetree@vger.kernel.org, Can Guo , linux-kernel@vger.kernel.org, Manu Gautam , Mark Rutland , Rob Herring Subject: [PATCH v5 1/5] dt-bindings: phy-qcom-qmp: Fix register underspecification Date: Fri, 26 Oct 2018 10:35:40 -0700 Message-Id: <20181026173544.136037-2-evgreen@chromium.org> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20181026173544.136037-1-evgreen@chromium.org> References: <20181026173544.136037-1-evgreen@chromium.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add register regions for the second lane of dual-lane nodes. This additional specification is needed so that the driver can stop reaching beyond the tx and rx register allocations to get at the second lane registers in a dual-lane PHY. While in there, document #clock-cells as optional for PHYs that don't provide a pipe clock. Also, document the pcs_misc register region, which was being quietly supplied and used. Signed-off-by: Evan Green Reviewed-by: Douglas Anderson Reviewed-by: Rob Herring --- Changes in v5: - Fix incorrect register value in example, copied from real life! Changes in v4: - Remove "status" from DT binding example (Rob) Changes in v3: None Changes in v2: - Added dt bindings change, corresponding driver fixup, and USB PHY fixup .../devicetree/bindings/phy/qcom-qmp-phy.txt | 70 +++++++++++++++++++--- 1 file changed, 62 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt index fbc198d5dd39..f7b532125a4d 100644 --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt @@ -25,7 +25,7 @@ Required properties: - For all others: - The reg-names property shouldn't be defined. - - #clock-cells: must be 1 + - #clock-cells: must be 1 (PCIe and USB3 PHYs only) - Phy pll outputs a bunch of clocks for Tx, Rx and Pipe interface (for pipe based PHYs). These clock are then gate-controlled by gcc. @@ -82,23 +82,26 @@ Required nodes: - Each device node of QMP phy is required to have as many child nodes as the number of lanes the PHY has. -Required properties for child node: +Required properties for child nodes of PCIe PHYs (one child per lane): - reg: list of offset and length pairs of register sets for PHY blocks - - - index 0: tx - - index 1: rx - - index 2: pcs - - index 3: pcs_misc (optional) + tx, rx, pcs, and pcs_misc (optional). + - #phy-cells: must be 0 +Required properties for a single "lanes" child node of non-PCIe PHYs: + - reg: list of offset and length pairs of register sets for PHY blocks + For 1-lane devices: + tx, rx, pcs, and (optionally) pcs_misc + For 2-lane devices: + tx0, rx0, pcs, tx1, rx1, and (optionally) pcs_misc - #phy-cells: must be 0 -Required properties child node of pcie and usb3 qmp phys: +Required properties for child node of PCIe and USB3 qmp phys: - clocks: a list of phandles and clock-specifier pairs, one for each entry in clock-names. - clock-names: Must contain following: "pipe" for pipe clock specific to each lane. - clock-output-names: Name of the PHY clock that will be the parent for the above pipe clock. - For "qcom,ipq8074-qmp-pcie-phy": - "pcie20_phy0_pipe_clk" Pipe Clock parent (or) @@ -150,3 +153,54 @@ Example: ... ... }; + + phy@88eb000 { + compatible = "qcom,sdm845-qmp-usb3-uni-phy"; + reg = <0x88eb000 0x18c>; + #clock-cells = <1>; + #address-cells = <1>; + #size-cells = <1>; + ranges; + + clocks = <&gcc GCC_USB3_SEC_PHY_AUX_CLK>, + <&gcc GCC_USB_PHY_CFG_AHB2PHY_CLK>, + <&gcc GCC_USB3_SEC_CLKREF_CLK>, + <&gcc GCC_USB3_SEC_PHY_COM_AUX_CLK>; + clock-names = "aux", "cfg_ahb", "ref", "com_aux"; + + resets = <&gcc GCC_USB3PHY_PHY_SEC_BCR>, + <&gcc GCC_USB3_PHY_SEC_BCR>; + reset-names = "phy", "common"; + + lane@88eb200 { + reg = <0x88eb200 0x128>, + <0x88eb400 0x1fc>, + <0x88eb800 0x218>, + <0x88eb600 0x70>; + #phy-cells = <0>; + clocks = <&gcc GCC_USB3_SEC_PHY_PIPE_CLK>; + clock-names = "pipe0"; + clock-output-names = "usb3_uni_phy_pipe_clk_src"; + }; + }; + + phy@1d87000 { + compatible = "qcom,sdm845-qmp-ufs-phy"; + reg = <0x1d87000 0x18c>; + #address-cells = <1>; + #size-cells = <1>; + ranges; + clock-names = "ref", + "ref_aux"; + clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + + lanes@1d87400 { + reg = <0x1d87400 0x108>, + <0x1d87600 0x1e0>, + <0x1d87c00 0x1dc>, + <0x1d87800 0x108>, + <0x1d87a00 0x1e0>; + #phy-cells = <0>; + }; + };