From patchwork Fri Sep 21 10:35:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 973137 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="buLyyQYw"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42GqlW0nYVz9s4V for ; Fri, 21 Sep 2018 20:36:39 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 6602DC21E42; Fri, 21 Sep 2018 10:36:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 110B2C21C4A; Fri, 21 Sep 2018 10:36:33 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 4E407C21C38; Fri, 21 Sep 2018 10:36:31 +0000 (UTC) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by lists.denx.de (Postfix) with ESMTPS id ECE43C21BE5 for ; Fri, 21 Sep 2018 10:36:30 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id v16-v6so12347466wro.11 for ; Fri, 21 Sep 2018 03:36:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZgemdbtnPeF9dAAwj+Z9Kkn8JlpDqJTnUlFHNm8U7Y4=; b=buLyyQYwHs+8ig546BVJ4qEjREQGmM9xEE1X2ev4OYw+GGIuDmNBSrUP7v+W0bdgDR gIN8V3mZ6gyl6EYuoOkY5YNgZjeuf6/i4H9VoVuGiVKpov4F/hR1u4byqP3mYrZRlez6 Od3TMOQNonwK/w0hiUwjIvDH8F/H6o2QqK1dHe4pvETrSrNzMb3m6wcxDi6MDkfLuTTJ 4MzLq01t2J7cH/D9wGDgdNsbWbBllGlL9kdV8jzgWiv6EDaL8oIxIvXYhf7YRJeN2grf 1oHaMrHp+D6JMTQSVlpPS21u6o3r1/Y4nHICdu+hKfWgo3R6vZ7d+O2fnPeaGQO7dPko CjzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZgemdbtnPeF9dAAwj+Z9Kkn8JlpDqJTnUlFHNm8U7Y4=; b=t/ckErP5RZxQBBPH9Q09VowxhK6JqK1DrJD3JO/gY4MIor4onQZM09pEXhwFSERDmO RHbBgCGVZ8tlawH/ztKtO9gjoUJC1G1hc14e4Q+0PKjlkt97xU9OrK3El4P6qSJOCjHn QiWo1+wcdp2y2XzTmLugkcUJ8c6/t7W1F4lM6Vdd1+8CqZ9sd63KkrVBruHkSUWVueeC 05aBJiayJ8PzlJN8RccsrUm33HxxIwPEAFwLezi8FMidhngOpczE69ReRum3I/uL5ykX N7qu92Emytu81zlHvQK6CwlLW7I3lxs/eT1jDZO0NIIw3PB1MTjanTzDuxl5ESx+IPB3 wKTw== X-Gm-Message-State: APzg51BfLlWO6ouJHPhBqFS1biu0GlllOCV37oA5sAUk6uXNGwg0Vaxs MfWtmG5/d6c6nUy1alT/+DyVIzHyH+mZhQ== X-Google-Smtp-Source: ANB0Vda2iOMBL6MkncLwUK62qa63tsdL6S/I0+bcmKF2qUdFlkbBEfKUJqVB0IR4VjgmXiI9dUXCqw== X-Received: by 2002:a5d:5450:: with SMTP id w16-v6mr39174715wrv.4.1537526190266; Fri, 21 Sep 2018 03:36:30 -0700 (PDT) Received: from localhost.localdomain ([5.102.238.49]) by smtp.gmail.com with ESMTPSA id 204-v6sm6770843wmh.25.2018.09.21.03.36.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 03:36:29 -0700 (PDT) From: Ramon Fried To: u-boot@lists.denx.de Date: Fri, 21 Sep 2018 13:35:43 +0300 Message-Id: <20180921103555.16240-2-ramon.fried@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180921103555.16240-1-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> Cc: Marek Vasut Subject: [U-Boot] [PATCH v2 01/14] ehci: Replace board_prepare_usb with board_usb_init X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Use standard board_usb_init() instead of the specific board_prepare_usb. Signed-off-by: Ramon Fried --- Changes in v2: None board/qualcomm/dragonboard410c/dragonboard410c.c | 4 ++-- drivers/usb/host/ehci-msm.c | 9 ++------- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/board/qualcomm/dragonboard410c/dragonboard410c.c b/board/qualcomm/dragonboard410c/dragonboard410c.c index 53e231e55a..e8a3ed0450 100644 --- a/board/qualcomm/dragonboard410c/dragonboard410c.c +++ b/board/qualcomm/dragonboard410c/dragonboard410c.c @@ -44,7 +44,7 @@ int dram_init_banksize(void) return 0; } -int board_prepare_usb(enum usb_init_type type) +int board_usb_init(int index, enum usb_init_type init) { static struct udevice *pmic_gpio; static struct gpio_desc hub_reset, usb_sel; @@ -93,7 +93,7 @@ int board_prepare_usb(enum usb_init_type type) } } - if (type == USB_INIT_HOST) { + if (init == USB_INIT_HOST) { /* Start USB Hub */ dm_gpio_set_dir_flags(&hub_reset, GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE); diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index 17bfa7c02f..db982624dc 100644 --- a/drivers/usb/host/ehci-msm.c +++ b/drivers/usb/host/ehci-msm.c @@ -38,11 +38,6 @@ struct msm_ehci_priv { struct ulpi_viewport ulpi_vp; /* ULPI Viewport */ }; -int __weak board_prepare_usb(enum usb_init_type type) -{ - return 0; -} - static void setup_usb_phy(struct msm_ehci_priv *priv) { /* Select and enable external configuration with USB PHY */ @@ -102,7 +97,7 @@ static int ehci_usb_probe(struct udevice *dev) hcor = (struct ehci_hcor *)((phys_addr_t)hccr + HC_LENGTH(ehci_readl(&(hccr)->cr_capbase))); - ret = board_prepare_usb(USB_INIT_HOST); + ret = board_usb_init(0, USB_INIT_HOST); if (ret < 0) return ret; @@ -124,7 +119,7 @@ static int ehci_usb_remove(struct udevice *dev) reset_usb_phy(p); - ret = board_prepare_usb(USB_INIT_DEVICE); /* Board specific hook */ + ret = board_usb_init(0, USB_INIT_DEVICE); /* Board specific hook */ if (ret < 0) return ret; From patchwork Fri Sep 21 10:35:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 973140 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="hYuEAmmj"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42Gqn5134nz9s89 for ; Fri, 21 Sep 2018 20:38:00 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id BF65EC21D65; Fri, 21 Sep 2018 10:36:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id D16A6C21E47; Fri, 21 Sep 2018 10:36:35 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 56CCFC21DA1; Fri, 21 Sep 2018 10:36:33 +0000 (UTC) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by lists.denx.de (Postfix) with ESMTPS id F0302C21BE5 for ; Fri, 21 Sep 2018 10:36:32 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id j8-v6so8626908wrw.5 for ; Fri, 21 Sep 2018 03:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=d4GynXsF2ssuDHbaYMjKiM4IQf6OAowKLVtTtoeDklI=; b=hYuEAmmjQ3d1xNy8xM29s7L0rRr618VCiDcxE9O+YSzC5gjnOfV7CFOHaq1Os7+T9W LIh6VVEVTwMAlJLbLGW9/3xpWZXQuUCSlgJiccT9Rmd1ZECErFmSvFYLejprmCd9ov0E Wfh27C87sd3xTvyA6K+DPOFWRkn1rOSpKGHks3oyY8QV7ok8n/BP/7Cpe/Cmcq2rNWXg q4idItzJpfqJyoUANG+4+pz9lNJvuX4RPZe5pdCa20b/wOeUuq4gmDe9fCYBCc47w2oD 4fRP7xHtLj9ze4WNrjz+Bt7A6vfLDPkX9V9DvBGp1+J9FgYHfvJSABJ+lklv6avgCumz n0Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=d4GynXsF2ssuDHbaYMjKiM4IQf6OAowKLVtTtoeDklI=; b=cGz2IXhmhCY4ZDCvBc0ZwlehCHnA/hE4WDwje4EGcvC+YS+eDA/8R0LypsKIe9OUZ/ ZliTB9dbE3iWvcJuZBiWAYDIYJ6IIyeKyy8nWW0i3AaWEJwpXNUFtpaagMMyLp8DmypH v4SeTEXvOT742ZYHW9JWvtV4vnELFUAcjDzsNHaJrueJhv9GytFdAM1BIxxntZIFi10P PNc/j5NfvX4glOUi6AnY7FKmFIGNhY1tqksNtjwlfBoV7xpafVsXQ59mtQG50g8GxAzS 44ZJ6aHFvj8x/JAFDQaDYGZ0GiJH3r26NZV3I8K9gicggAXobCNIk3liMUehiA7pM0Q0 InZw== X-Gm-Message-State: APzg51CcYNKUFFrSofs5APt+2ZFPcQ3PKG+qAiDmzRwDsqlhsdTKzM+R ykptz+2TpfPnRTAhAUW+JU7hDWcQ97IbWA== X-Google-Smtp-Source: ANB0VdaOFgWtEnZ8EhIQmQ6Wy7ZzrTLAMjUba9bFnmSGN8ZtfY+PEbfOTbuxZS8zLeRTxEqI5EMupw== X-Received: by 2002:adf:f28c:: with SMTP id k12-v6mr38568530wro.263.1537526192240; Fri, 21 Sep 2018 03:36:32 -0700 (PDT) Received: from localhost.localdomain ([5.102.238.49]) by smtp.gmail.com with ESMTPSA id 204-v6sm6770843wmh.25.2018.09.21.03.36.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 03:36:31 -0700 (PDT) From: Ramon Fried To: u-boot@lists.denx.de Date: Fri, 21 Sep 2018 13:35:44 +0300 Message-Id: <20180921103555.16240-3-ramon.fried@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180921103555.16240-1-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> Cc: Marek Vasut Subject: [U-Boot] [PATCH v2 02/14] ehci: msm: Add missing platdata X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" platdata_auto_alloc_size was not initialized in structure. Caused null pointer dereference when configuring device as gadget. Signed-off-by: Ramon Fried --- Changes in v2: None drivers/usb/host/ehci-msm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index db982624dc..e7fb76d6da 100644 --- a/drivers/usb/host/ehci-msm.c +++ b/drivers/usb/host/ehci-msm.c @@ -167,5 +167,6 @@ U_BOOT_DRIVER(usb_ehci) = { .remove = ehci_usb_remove, .ops = &ehci_usb_ops, .priv_auto_alloc_size = sizeof(struct msm_ehci_priv), + .platdata_auto_alloc_size = sizeof(struct usb_platdata), .flags = DM_FLAG_ALLOC_PRIV_DMA, }; From patchwork Fri Sep 21 10:35:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 973141 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SX1NH4VV"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42Gqnx1qwDz9s7T for ; Fri, 21 Sep 2018 20:38:45 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id ECC80C21E76; Fri, 21 Sep 2018 10:37:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 63107C21E85; Fri, 21 Sep 2018 10:36:47 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 08186C21E30; Fri, 21 Sep 2018 10:36:37 +0000 (UTC) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by lists.denx.de (Postfix) with ESMTPS id 76A92C21E1E for ; Fri, 21 Sep 2018 10:36:34 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id v16-v6so12347629wro.11 for ; Fri, 21 Sep 2018 03:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=U9lmHRzRWF+7ppbsLmKl3nfjp7iUkhs3bqQjA2lgBHY=; b=SX1NH4VVbTQWU+h8eHCbDr+JiQ2gmUxA6kvoPu1QCCtJRLXtg9FAiK1/EL23/qY2xY yuwvrQh+11kkZDiDAVxTubKb77GN6flnHc7ZGECi6ms+ArfUxPPRvtX3F8AWlJSLBTTG P0ympc4pRA7I/jGlGUYZQU4fPo/cYm9wPAFZjFLQsuBE9qXQJm/oSpksJ8g5McYsPUC5 z9SlYN2ZizvEDaPGliAq9Jkoox3bmmx+j7WlzhK3s9VsR+xlkvjBeBY8qeuwy8bumfVx 3Jg1JlQHDYJJxTNNLly+m4Wpj9/bkNAipUfftQ5ouwnOoLppYMIR9lR6nDoZpULdpxTS f+/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=U9lmHRzRWF+7ppbsLmKl3nfjp7iUkhs3bqQjA2lgBHY=; b=ojMv7gW0REWz/3mspAkCHwk8cPtKC2vjGTga0foYGgrpobAvIlw2OENtfyHr6vwpEJ 8LwGjiT4LIqG7SXoIOq1eZQNIeh539UeQfdr/3GzDi5TVVxaUAA854DgM8NsoSX5qoVb sGcQT5UkowDymjPb5aB3yRvQiy8oC96Exom1OTbcey+ZoUTvDlff0xuzNRjPqMg6/RJc 6TPerWNpLCdiLX8zhUP1yE1HukPBF78r4cEhyNRMMjQdnHZ0LVA3PNFtfEdOBosXGcx4 +zhZWCPDSjlvkJk2bJpAhEKKByC4Y3JE/hOrjd7kvhvtWXGxHjXe/ELKN+vSzzeyIkQ7 g8Zg== X-Gm-Message-State: APzg51CbMzUmjmKfp0KfnEYgWsTwA9ZOgvow4e7Y6G8XirvWzB7LJ5Zu e2EUanL2CZuOwtAa3QYsEa+3F7b2ViXMVQ== X-Google-Smtp-Source: ANB0VdaKNrO1ubdbZNrz6yzntjA1HM0LWdT4xbuUBRV3SfPYpXDMYnGFpocw83bHFtEookFK+Pee1g== X-Received: by 2002:adf:9306:: with SMTP id 6-v6mr38936926wro.211.1537526193805; Fri, 21 Sep 2018 03:36:33 -0700 (PDT) Received: from localhost.localdomain ([5.102.238.49]) by smtp.gmail.com with ESMTPSA id 204-v6sm6770843wmh.25.2018.09.21.03.36.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 03:36:33 -0700 (PDT) From: Ramon Fried To: u-boot@lists.denx.de Date: Fri, 21 Sep 2018 13:35:45 +0300 Message-Id: <20180921103555.16240-4-ramon.fried@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180921103555.16240-1-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> Subject: [U-Boot] [PATCH v2 03/14] dts: db410c: add alias for USB X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Alias is required so req-seq will be filled. Signed-off-by: Ramon Fried --- Changes in v2: None arch/arm/dts/dragonboard410c.dts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/dragonboard410c.dts b/arch/arm/dts/dragonboard410c.dts index f4f7c350ec..75f28300b7 100644 --- a/arch/arm/dts/dragonboard410c.dts +++ b/arch/arm/dts/dragonboard410c.dts @@ -18,6 +18,10 @@ #address-cells = <0x2>; #size-cells = <0x2>; + aliases { + usb0 = "/soc/ehci@78d9000"; + }; + memory { device_type = "memory"; reg = <0 0x80000000 0 0x3da00000>; From patchwork Fri Sep 21 10:35:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 973143 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SOq2tX4Z"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42Gqq11vwSz9s7T for ; Fri, 21 Sep 2018 20:39:41 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id D1B84C21E52; Fri, 21 Sep 2018 10:37:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 9F78AC21DCA; Fri, 21 Sep 2018 10:36:44 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 73E2BC21E12; Fri, 21 Sep 2018 10:36:39 +0000 (UTC) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by lists.denx.de (Postfix) with ESMTPS id E70BFC21E4E for ; Fri, 21 Sep 2018 10:36:35 +0000 (UTC) Received: by mail-wm1-f46.google.com with SMTP id s12-v6so2555835wmc.0 for ; Fri, 21 Sep 2018 03:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dAFI4VDa/D6G8Rb1quZZYrZbaWuA6ajBdbuhX0cXpxo=; b=SOq2tX4Z1WbWouerYIITVY5P5PVdgkTOoPihtLF+1/srqZ4iz7SgB4v9PXwLi3w5kk V1Mzv/DYs3dOlut9RkCv1mxfQEOjgRzttTC1u5pMDt/GbLbFAex1LWaLd1QWgRDCDQCd oPb6+VgeN4nbI+QlPoe3kjqhypAgjz6pxgiYZG4Ta6rBiVVvIGRMNeHPPA1Wfo1Lhk/8 Zag9nssYvKs+zloa8j/VoqMhmEsMr4b6/KaZNmcLKJ3VweGYo2onRaLWtbEzzJcZGsGA 5VSZUlASV3NqB+paEu4EbFOvfvHBl5+HjKL2OWRfVIw95D92nNJyM50cBP8daWNunisa bcOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dAFI4VDa/D6G8Rb1quZZYrZbaWuA6ajBdbuhX0cXpxo=; b=hThWgsJ/zPpUSVm+SFbJExe2qlRiB26MuXYdW3IiX92Sor4+TxPsKqOJmfUlqYT1j9 YppXMasPGqnLR0IyRpUb2zFKYrlBFcIPiCBNw5el35hj5OMjEVHUbZ920b9/IaYiJpeW eFDET5+ofbgQUhRwbey20pyaH6+apPatTtACaNI37JfO+x1AjQ6h70cthCKSnim3ae9B /HJSIeCtuiq+MxRfwtDRD30uXbIuBnGbFxygsLVoxhVxB4iDLavI8n/yCNZuMLY2ruib sVuTIScku7O/qfGkHULsqJ11F2lrSll4ukQfxcBApRivC/m5LAL/UF4Ws3DdnT4Uhl6G u7gg== X-Gm-Message-State: APzg51Dgz6gtHVXNWgzDCK+jwItRIXDLZUt9HsC6zKJNKwYKkymnFXxA HNZ/53bgKY4PzoaCwJKQPPCbGznHsfMhqA== X-Google-Smtp-Source: ACcGV63aHbWL68E1rq1MDKd1W/WkAJVhsjeWKD/KZKiU5J3WzZZ+/NpiL3yyoIH7LwtZNozFZDmEXA== X-Received: by 2002:a1c:1b0c:: with SMTP id b12-v6mr6561937wmb.157.1537526195258; Fri, 21 Sep 2018 03:36:35 -0700 (PDT) Received: from localhost.localdomain ([5.102.238.49]) by smtp.gmail.com with ESMTPSA id 204-v6sm6770843wmh.25.2018.09.21.03.36.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 03:36:34 -0700 (PDT) From: Ramon Fried To: u-boot@lists.denx.de Date: Fri, 21 Sep 2018 13:35:46 +0300 Message-Id: <20180921103555.16240-5-ramon.fried@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180921103555.16240-1-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> Subject: [U-Boot] [PATCH v2 04/14] db410c: serial# env using msm board serial X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The serial# environment variable needs to be defined so it will be used by fastboot as serial for the endpoint descriptor. Signed-off-by: Ramon Fried --- Changes in v2: None arch/arm/mach-snapdragon/Kconfig | 1 + board/qualcomm/dragonboard410c/dragonboard410c.c | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/arch/arm/mach-snapdragon/Kconfig b/arch/arm/mach-snapdragon/Kconfig index bfd99db6e2..e562d693c6 100644 --- a/arch/arm/mach-snapdragon/Kconfig +++ b/arch/arm/mach-snapdragon/Kconfig @@ -14,6 +14,7 @@ choice config TARGET_DRAGONBOARD410C bool "96Boards Dragonboard 410C" + select BOARD_LATE_INIT help Support for 96Boards Dragonboard 410C. This board complies with 96Board Open Platform Specifications. Features: diff --git a/board/qualcomm/dragonboard410c/dragonboard410c.c b/board/qualcomm/dragonboard410c/dragonboard410c.c index e8a3ed0450..b2a72bce38 100644 --- a/board/qualcomm/dragonboard410c/dragonboard410c.c +++ b/board/qualcomm/dragonboard410c/dragonboard410c.c @@ -151,6 +151,16 @@ int board_init(void) return 0; } +int board_late_init(void) +{ + char serial[16]; + + memset(serial, 0, 16); + snprintf(serial, 13, "%x", msm_board_serial()); + env_set("serial#", serial); + return 0; +} + /* Fixup of DTB for Linux Kernel * 1. Fixup installed DRAM. * 2. Fixup WLAN/BT Mac address: From patchwork Fri Sep 21 10:35:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 973142 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EvamItFP"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42Gqp80rZSz9s7T for ; Fri, 21 Sep 2018 20:38:56 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id A86D9C21D65; Fri, 21 Sep 2018 10:37:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 69DB9C21E30; Fri, 21 Sep 2018 10:37:01 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 82899C21C4A; Fri, 21 Sep 2018 10:36:42 +0000 (UTC) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by lists.denx.de (Postfix) with ESMTPS id 94BADC21E68 for ; Fri, 21 Sep 2018 10:36:38 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id y2-v6so2551637wma.1 for ; Fri, 21 Sep 2018 03:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UxRLijFpNhwdz9G9FHmjto9Eqdb4JMSrH9blp/fSnW8=; b=EvamItFPw8ch6jRzjq3xwJdSantR9ntBwcrch2UBCQzFP9vaeit/lFu+oO0OcjjfZC 2HuwBbkLuV+UskQGWJE3x2Mx0OSDPhVamssl5OTeTvR4Koz5NrkjZMLm1qojK5MKZ7ot UxOxg5yYYm5d4jAFR+QewoK0SXgUTTLkp76Sclgnn1MqA2Kzz1Kd3GS5kht0NfrGuHFO +OSbY66GDV/U7WtHzQRT0M/U8n8dO+Shq0mwflViacutIhJCC6QPtHHgz6y2oPN8SN0u ZabBf9fu91+usMQeTf1Z+hhaVhEXNWIwruxhIBwki1XsLgaJgHsFKaEPTkHuiOwmHSqm QNvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UxRLijFpNhwdz9G9FHmjto9Eqdb4JMSrH9blp/fSnW8=; b=kqzNZw2avH5Z+JN+57P1NXZ1SAlH+Qu4zxVoA1RE9icGRbFWdHxsEfGB2AMC8mbEXa uCshtWSZV/FeZH45XwQpxAw7DqIiJTYTLKsBuoWE/KcCOrMtnp2H1XDRA5G2H9/COlFv dj8fw1OVXjzI7JHgYRNLBHODr/qVkAUBTQ070nrcO2bx0a6E8/VdjpaHPBPWUOKNYUha mIUsZmd6ELFGpP+w1OmicZzANIYjBDCR1Hqvf7kgh8+SmJujMa1M+GGBkuzIWKmlsG2S OgbgFbTZlWOYCBBUo/GIpAVx4x0gY48ul+pk8aQiESL5tX2XJv/dl6CHxpAQjU/N6ujV 3FiA== X-Gm-Message-State: APzg51CujesqwX4oDzINKMUprkwN+XqrrJzFR6jvUZ3pHIVMYujC4WKV i2KfpTjsw7sAR/M56eqopyjY1eg7cbBH2w== X-Google-Smtp-Source: ANB0Vdaj1d7/CVl66Aaz/4qtATFXGGxTxy0HpcmtrO9UEGglhMSfhkygY3nn9oiUMbOwGT/IAj5JgA== X-Received: by 2002:a1c:7305:: with SMTP id d5-v6mr6626482wmb.53.1537526197828; Fri, 21 Sep 2018 03:36:37 -0700 (PDT) Received: from localhost.localdomain ([5.102.238.49]) by smtp.gmail.com with ESMTPSA id 204-v6sm6770843wmh.25.2018.09.21.03.36.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 03:36:37 -0700 (PDT) From: Ramon Fried To: u-boot@lists.denx.de Date: Fri, 21 Sep 2018 13:35:47 +0300 Message-Id: <20180921103555.16240-6-ramon.fried@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180921103555.16240-1-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> Cc: Amelie Delaunay , Heinrich Schuchardt , Alexander Graf , Joe Hershberger , Stefan Roese , Eugeniy Paltsev , Michal Simek , Marek Vasut Subject: [U-Boot] [PATCH v2 05/14] phy: db410c: Add MSM USB PHY driver X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Add a PHY driver for the Qualcomm dragonboard 410c which allows switching on/off and resetting the phy connected to the EHCI controllers and USBHS controller. Signed-off-by: Ramon Fried --- Changes in v2: None MAINTAINERS | 1 + drivers/phy/Kconfig | 8 +++ drivers/phy/Makefile | 1 + drivers/phy/msm8916-usbh-phy.c | 109 +++++++++++++++++++++++++++++++++ 4 files changed, 119 insertions(+) create mode 100644 drivers/phy/msm8916-usbh-phy.c diff --git a/MAINTAINERS b/MAINTAINERS index 39d28e5d45..1a5b543dc7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -209,6 +209,7 @@ S: Maintained F: arch/arm/mach-snapdragon/ F: drivers/gpio/msm_gpio.c F: drivers/mmc/msm_sdhci.c +F: drivers/phy/msm8916-usbh-phy.c F: drivers/serial/serial_msm.c F: drivers/smem/msm_smem.c F: drivers/usb/host/ehci-msm.c diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index e0822bb775..bcc8e22795 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -139,4 +139,12 @@ config MESON_GXL_USB_PHY This is the generic phy driver for the Amlogic Meson GXL USB2 and USB3 PHYS. +config MSM8916_USB_PHY + bool "Qualcomm MSM8916 USB PHY support" + depends on PHY + help + Support the USB PHY in msm8916 + + This PHY is found on qualcomm dragonboard410c development board. + endmenu diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile index 178fb4530e..1e1e4ca11e 100644 --- a/drivers/phy/Makefile +++ b/drivers/phy/Makefile @@ -15,3 +15,4 @@ obj-$(CONFIG_STI_USB_PHY) += sti_usb_phy.o obj-$(CONFIG_PHY_RCAR_GEN2) += phy-rcar-gen2.o obj-$(CONFIG_PHY_STM32_USBPHYC) += phy-stm32-usbphyc.o obj-$(CONFIG_MESON_GXL_USB_PHY) += meson-gxl-usb2.o meson-gxl-usb3.o +obj-$(CONFIG_MSM8916_USB_PHY) += msm8916-usbh-phy.o diff --git a/drivers/phy/msm8916-usbh-phy.c b/drivers/phy/msm8916-usbh-phy.c new file mode 100644 index 0000000000..2c90738fca --- /dev/null +++ b/drivers/phy/msm8916-usbh-phy.c @@ -0,0 +1,109 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2018 Ramon Fried + */ + +#include +#include +#include +#include +#include +#include + +/* PHY viewport regs */ +#define ULPI_MISC_A_READ 0x96 +#define ULPI_MISC_A_SET 0x97 +#define ULPI_MISC_A_CLEAR 0x98 +#define ULPI_MISC_A_VBUSVLDEXT BIT(0) +#define ULPI_MISC_A_VBUSVLDEXTSEL BIT(1) +#define GEN2_SESS_VLD_CTRL_EN BIT(7) +#define SESS_VLD_CTRL BIT(25) + +struct msm_phy_priv { + void __iomem *regs; + struct usb_ehci *ehci; /* Start of IP core*/ + struct ulpi_viewport ulpi_vp; /* ULPI Viewport */ +}; + +static int msm_phy_power_on(struct phy *phy) +{ + struct msm_phy_priv *priv = dev_get_priv(phy->dev); + + /* Select and enable external configuration with USB PHY */ + ulpi_write(&priv->ulpi_vp, (u8 *)ULPI_MISC_A_SET, + ULPI_MISC_A_VBUSVLDEXTSEL | ULPI_MISC_A_VBUSVLDEXT); + + return 0; +} + +static int msm_phy_power_off(struct phy *phy) +{ + struct msm_phy_priv *priv = dev_get_priv(phy->dev); + + /* Disable VBUS mimicing in the controller. */ + ulpi_write(&priv->ulpi_vp, (u8 *)ULPI_MISC_A_CLEAR, + ULPI_MISC_A_VBUSVLDEXTSEL | ULPI_MISC_A_VBUSVLDEXT); + return 0; +} + +static int msm_phy_reset(struct phy *phy) +{ + struct msm_phy_priv *p = dev_get_priv(phy->dev); + + /* select ULPI phy */ + writel(PORT_PTS_ULPI, &p->ehci->portsc); + + /* Enable sess_vld */ + setbits_le32(&p->ehci->genconfig2, GEN2_SESS_VLD_CTRL_EN); + + /* Enable external vbus configuration in the LINK */ + setbits_le32(&p->ehci->usbcmd, SESS_VLD_CTRL); + + /* USB_OTG_HS_AHB_BURST */ + writel(0x0, &p->ehci->sbuscfg); + + /* USB_OTG_HS_AHB_MODE: HPROT_MODE */ + /* Bus access related config. */ + writel(0x08, &p->ehci->sbusmode); + + return 0; +} + +static int msm_phy_probe(struct udevice *dev) +{ + struct msm_phy_priv *priv = dev_get_priv(dev); + + priv->regs = dev_remap_addr(dev); + if (!priv->regs) + return -EINVAL; + + priv->ehci = (struct usb_ehci *)priv->regs; + priv->ulpi_vp.port_num = 0; + + /* Warning: this will not work if viewport address is > 64 bit due to + * ULPI design. + */ + priv->ulpi_vp.viewport_addr = (phys_addr_t)&priv->ehci->ulpi_viewpoint; + + return 0; +} + +static struct phy_ops msm_phy_ops = { + .power_on = msm_phy_power_on, + .power_off = msm_phy_power_off, + .reset = msm_phy_reset, +}; + +static const struct udevice_id msm_phy_ids[] = { + { .compatible = "qcom,apq8016-usbphy" }, + { } +}; + +U_BOOT_DRIVER(msm8916_usbphy) = { + .name = "msm8916_usbphy", + .id = UCLASS_PHY, + .of_match = msm_phy_ids, + .ops = &msm_phy_ops, + .probe = msm_phy_probe, + .priv_auto_alloc_size = sizeof(struct msm_phy_priv), +}; From patchwork Fri Sep 21 10:35:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 973157 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IUmslLa2"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42GqwW0jmhz9s89 for ; Fri, 21 Sep 2018 20:44:27 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id C95CAC21D65; Fri, 21 Sep 2018 10:38:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 6DEC5C21E1D; Fri, 21 Sep 2018 10:37:02 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id D6C62C21DFB; Fri, 21 Sep 2018 10:36:43 +0000 (UTC) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by lists.denx.de (Postfix) with ESMTPS id 4F1B6C21E2F for ; Fri, 21 Sep 2018 10:36:40 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id 20-v6so12344256wrb.12 for ; Fri, 21 Sep 2018 03:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nz0umVa1Umfau8gVZm+Bh5pj+Rrzzr5CKXBrqw+wfM4=; b=IUmslLa28kMfbNHP6t/Lm7laxPDWPcxuUs7Cawe0swdlubEFzKnWkT3To1+64Twafe 3kVu241rgzBTucByKlGA46b576/OFOyuWL2rU1hazzw1KXTTZ62gQzIhULg7cMcR4MfY jT77TTb3N4Gb/mbjBSslED9IgkiR0S3ljHV1/W1s0/sWC+QvcGrNsnHBWEM10MU89kAd R9OM9vUPKsyknl7EM/QfFjtUdJAdpWC2kr/X3ZptaZsGTBRwOJRwAoSp+FTLbXnCoo3U i5N5SB/fnNYzy1Ajk7wGk5Td/wA1OLCsLzpgTTIuEPHrRGKrVfHIWYndKGGDmhvwyj2R c2JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nz0umVa1Umfau8gVZm+Bh5pj+Rrzzr5CKXBrqw+wfM4=; b=R+Rl2v15/Ti6DWvQpsdpt0KOUBTl70WY7dUxaYMyR3VMBIlnsqqW2e5QFC9DSRRvZE q2A/xV/tT4wcDGuYedkH5GXOPmbbU3eGc1Uywz09D+fJsqYnbAGmhyW4bS/kCGG+urpV wdmjXXVm5W/sP2xj9lZpDiHpV94DIsUX5un9WIgc1jv/ZqfXuUwy7pVYP6+kPPuAIH0V yOAzgXYfqkfaPYm6MQWJqXOkvk3N7WsoBojknRK4aVKSGtjpL7BRmgoz09YRmyoBUvhL rilWwfOIFaMpDbgqrSZFX2wVy1LGpLnwo9jjQH9T3GfjSpSHyXoAnY7tEzJC5KSL/iN4 4YVw== X-Gm-Message-State: APzg51Cv7qgrCkKf7dhH20m1SFW9tiK/opzu5d2W/qO7ecM1uLSOyj2T LUAoeCGKAk4aokrql7bc/XpdvoyvqPbnmA== X-Google-Smtp-Source: ANB0VdYtf4SXFMREU0W/2RV3qS7uKCR4pzvaW3bQ7ma8b7Fa7QDjO3Oa7MvAnD0lW/iBynuFlwovog== X-Received: by 2002:a5d:4849:: with SMTP id n9-v6mr18146664wrs.234.1537526199703; Fri, 21 Sep 2018 03:36:39 -0700 (PDT) Received: from localhost.localdomain ([5.102.238.49]) by smtp.gmail.com with ESMTPSA id 204-v6sm6770843wmh.25.2018.09.21.03.36.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 03:36:38 -0700 (PDT) From: Ramon Fried To: u-boot@lists.denx.de Date: Fri, 21 Sep 2018 13:35:48 +0300 Message-Id: <20180921103555.16240-7-ramon.fried@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180921103555.16240-1-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> Subject: [U-Boot] [PATCH v2 06/14] dts: db410c: Add bindings for MSM USB phy X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Signed-off-by: Ramon Fried --- Changes in v2: None arch/arm/dts/dragonboard410c.dts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/dts/dragonboard410c.dts b/arch/arm/dts/dragonboard410c.dts index 75f28300b7..fa348bc621 100644 --- a/arch/arm/dts/dragonboard410c.dts +++ b/arch/arm/dts/dragonboard410c.dts @@ -97,6 +97,13 @@ ehci@78d9000 { compatible = "qcom,ehci-host"; reg = <0x78d9000 0x400>; + phys = <&ehci_phy>; + }; + + ehci_phy: ehci_phy@78d9000 { + compatible = "qcom,apq8016-usbphy"; + reg = <0x78d9000 0x400>; + #phy-cells = <0>; }; sdhci@07824000 { From patchwork Fri Sep 21 10:35:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 973146 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Yaa4viIZ"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42Gqqs6x78z9s89 for ; Fri, 21 Sep 2018 20:40:25 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 84C71C21E2F; Fri, 21 Sep 2018 10:38:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id F1B3DC21E6C; Fri, 21 Sep 2018 10:37:05 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id F2B3AC21E6C; Fri, 21 Sep 2018 10:36:45 +0000 (UTC) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by lists.denx.de (Postfix) with ESMTPS id E1041C21E29 for ; Fri, 21 Sep 2018 10:36:41 +0000 (UTC) Received: by mail-wm1-f47.google.com with SMTP id b19-v6so2539795wme.3 for ; Fri, 21 Sep 2018 03:36:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=08vCTqqRQRH5osjznh+A4LCVtqBsvsNPZihl2//d24U=; b=Yaa4viIZDl2itpbROtu1gykiQcM9Aaybg5zhRJYe2k1XjSm2+T8NHlQZaBpt76whJX 2zMPuDCG6Vatyafv0pUa6yMbRuSFFUaqBFgzvknqC6vk5w0cUlQzsRHqpY3efIxlyFUe NIOMRxUO4tsgxe08lYOOxVP+Qqskt0nrkRmpvxCoNbWUuLDq5ejdDSkbfFbfZ4Roi5bY 1V30eOCOJ2SvhvCpVozBMz3Gsqx9T8A0XCAJwh5R+5BLFOjYdVlup59tDG4K1DZ6hK8H CwoIIU1ealOSio/fVP3NP6mmCVbxyzredmTm3s5lq4ly0Q567Fp60R9tsPNQXA69e7KV KvuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=08vCTqqRQRH5osjznh+A4LCVtqBsvsNPZihl2//d24U=; b=CAQYwr7mzp7/UkNpgWd9Ufk80zueD2vvHh+CIkKzoiKk326w6UCDomCWMcaznkWlfk fYthIvtuT0Qrgf/x3AjpkXj3a6mc8dq0lNfgfTkRk2NLWsPFKuFQLh0lJhUKNRs9jQI/ wH2sJVTqSr8JJGiaNv5MpC2sKD1n4+gFRVeqOcVwPAac10LBl+vXipag42SdZ5HQ56qD GoeQJypgshi7j5bYeIh48kQMfNPEDByVwtj9apnPL+ChRDeN9b1mKVT3HMuecwfuxgPJ mB1ZATRXgOBCDOfNUnb+S/c6qhIvAwlDN8p78PFieL2wfbf8VMGGxgjVEl3bFyqCaeQK pLzA== X-Gm-Message-State: APzg51DbLuoyCqjIuTo0Nj33RjJAsp/zFQ+HWVlkPDgi/kWTlk0Rafzd QYlj9ozsfcJAarHryR6xJNKEf/dYwfwo6w== X-Google-Smtp-Source: ANB0VdZOx0pVHIVpVbUhNRpAexWNpfxj9OYCJxM3PqT20M8qMU+7rinVIxzJl6L+AK8LbE3LJrLTCQ== X-Received: by 2002:a1c:808b:: with SMTP id b133-v6mr6265239wmd.151.1537526201057; Fri, 21 Sep 2018 03:36:41 -0700 (PDT) Received: from localhost.localdomain ([5.102.238.49]) by smtp.gmail.com with ESMTPSA id 204-v6sm6770843wmh.25.2018.09.21.03.36.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 03:36:40 -0700 (PDT) From: Ramon Fried To: u-boot@lists.denx.de Date: Fri, 21 Sep 2018 13:35:49 +0300 Message-Id: <20180921103555.16240-8-ramon.fried@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180921103555.16240-1-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> Subject: [U-Boot] [PATCH v2 07/14] configs: db410c: Enable USB PHY X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Enable USB PHY driver. Also fixed the alphabetically ordering of the config. Signed-off-by: Ramon Fried --- Changes in v2: None configs/dragonboard410c_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/dragonboard410c_defconfig b/configs/dragonboard410c_defconfig index 96a831443a..0d9008deb7 100644 --- a/configs/dragonboard410c_defconfig +++ b/configs/dragonboard410c_defconfig @@ -29,6 +29,7 @@ CONFIG_LED_GPIO=y CONFIG_DM_MMC=y CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_MSM=y +CONFIG_PHY=y CONFIG_PINCTRL=y CONFIG_PINCONF=y CONFIG_DM_PMIC=y From patchwork Fri Sep 21 10:35:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 973149 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="iV0mtjle"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42Gqrh18VDz9s89 for ; Fri, 21 Sep 2018 20:41:07 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id B9187C21D9A; Fri, 21 Sep 2018 10:38:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 47034C21EA7; Fri, 21 Sep 2018 10:37:21 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 85482C21D9A; Fri, 21 Sep 2018 10:36:47 +0000 (UTC) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by lists.denx.de (Postfix) with ESMTPS id A09ADC21E62 for ; Fri, 21 Sep 2018 10:36:43 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id s12-v6so2556276wmc.0 for ; Fri, 21 Sep 2018 03:36:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XsW/txmFgxNrg7Ika2OGMJ5V/ZVw4EaavKfrg7QdYUM=; b=iV0mtjleDEmrntRXa5+XhiQ9O6fO2TRRKFowp8iqIob2NtZ8kDt7CRqqMM17Tast5f AK4X2ybLI2lfMeD/GUgWRAfP7VxAWgDWTzwb10QfxXkdD4jzO2ZLPPfOS4IxrKXGFtuJ IQOLOO7U6FBFTcebHQUGbNAo+1FJXtK0voeNHrAmf5ezElfABmwMD+H9I5v8xA8LcAKF zEJiKmhc6HFGtsLUtnG7l8BTzR0sMO2ukx2tek5gdcsXtcg1PxrUOosGufZIfK/6Ouxt ER80r6H1YPM6OIQZoKJSHOkRsl7XF6jumwrvY8nFnib6KCDy7cmPWsc/yVLDK8H6uEyK vH8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XsW/txmFgxNrg7Ika2OGMJ5V/ZVw4EaavKfrg7QdYUM=; b=FI3lq7b4O6yv6Nae+sG23wQwAsLkdX4eYl8zZSllGfAEzRoSRgRosMqSM3IMHQ+qQq etChB6uJd/OfOO19buKbzBDZeNPXQ/3pjbtScbZ0xlLEgonARVORKIecfR8VfVajehdR iMrk3lpE8aJb+L4Cbhu+T4WCYQBLrc/El7uF4Rv2H6Qdx4DSTOQBK4R2rOTsdAdthWnY I9+kD4EhAFd90aseyKjw/2uY3Gy4jbv3CKxIJHcnzuMjiszZ9rsz4044GFZeKMvDxUCx ZPpWSdve2X6DxaZzcDCk66mIpYTxeRdKf0crkUZ+0+svToperqr31qV6WPGPyXwEHRf4 adrw== X-Gm-Message-State: APzg51DzX3U3kiT4oElTWwWK9FVc02cOMiuh4wKAuP754zq5ypNpjiP4 fq1agteKhrtPkxWpnq26r/fqwHL3yRQu4g== X-Google-Smtp-Source: ANB0Vdb8mXnekSWWCi311Q5+7IKb1k2rU2Q94jHSZ+UAeRaIymGkXoAvfKvMSd0X23sIDTH/Qtm02w== X-Received: by 2002:a1c:e581:: with SMTP id c123-v6mr6587749wmh.85.1537526203011; Fri, 21 Sep 2018 03:36:43 -0700 (PDT) Received: from localhost.localdomain ([5.102.238.49]) by smtp.gmail.com with ESMTPSA id 204-v6sm6770843wmh.25.2018.09.21.03.36.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 03:36:42 -0700 (PDT) From: Ramon Fried To: u-boot@lists.denx.de Date: Fri, 21 Sep 2018 13:35:50 +0300 Message-Id: <20180921103555.16240-9-ramon.fried@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180921103555.16240-1-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> Cc: Marek Vasut , Alexey Brodkin , Michal Simek , Ran Wang Subject: [U-Boot] [PATCH v2 08/14] ehci: msm: switch to generic PHY uclass X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" All the underlying USB PHY was handled in the ehci driver. Use the generic phy API instead. Signed-off-by: Ramon Fried --- Changes in v2: None drivers/usb/host/Kconfig | 3 +-- drivers/usb/host/ehci-msm.c | 52 +++++++------------------------------ 2 files changed, 10 insertions(+), 45 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index b4dd005651..a213c918bc 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -167,12 +167,11 @@ config USB_EHCI_MSM bool "Support for Qualcomm on-chip EHCI USB controller" depends on DM_USB select USB_ULPI_VIEWPORT + select MSM8916_USB_PHY default n ---help--- Enables support for the on-chip EHCI controller on Qualcomm Snapdragon SoCs. - This driver supports combination of Chipidea USB controller - and Synapsys USB PHY in host mode only. config USB_EHCI_PCI bool "Support for PCI-based EHCI USB controller" diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index e7fb76d6da..a27a5833dd 100644 --- a/drivers/usb/host/ehci-msm.c +++ b/drivers/usb/host/ehci-msm.c @@ -21,59 +21,19 @@ #include #include "ehci.h" -/* PHY viewport regs */ -#define ULPI_MISC_A_READ 0x96 -#define ULPI_MISC_A_SET 0x97 -#define ULPI_MISC_A_CLEAR 0x98 -#define ULPI_MISC_A_VBUSVLDEXTSEL (1 << 1) -#define ULPI_MISC_A_VBUSVLDEXT (1 << 0) - -#define GEN2_SESS_VLD_CTRL_EN (1 << 7) - -#define SESS_VLD_CTRL (1 << 25) - struct msm_ehci_priv { struct ehci_ctrl ctrl; /* Needed by EHCI */ struct usb_ehci *ehci; /* Start of IP core*/ struct ulpi_viewport ulpi_vp; /* ULPI Viewport */ + struct phy phy; }; -static void setup_usb_phy(struct msm_ehci_priv *priv) -{ - /* Select and enable external configuration with USB PHY */ - ulpi_write(&priv->ulpi_vp, (u8 *)ULPI_MISC_A_SET, - ULPI_MISC_A_VBUSVLDEXTSEL | ULPI_MISC_A_VBUSVLDEXT); -} - -static void reset_usb_phy(struct msm_ehci_priv *priv) -{ - /* Disable VBUS mimicing in the controller. */ - ulpi_write(&priv->ulpi_vp, (u8 *)ULPI_MISC_A_CLEAR, - ULPI_MISC_A_VBUSVLDEXTSEL | ULPI_MISC_A_VBUSVLDEXT); -} - - static int msm_init_after_reset(struct ehci_ctrl *dev) { struct msm_ehci_priv *p = container_of(dev, struct msm_ehci_priv, ctrl); struct usb_ehci *ehci = p->ehci; - /* select ULPI phy */ - writel(PORT_PTS_ULPI, &ehci->portsc); - setup_usb_phy(p); - - /* Enable sess_vld */ - setbits_le32(&ehci->genconfig2, GEN2_SESS_VLD_CTRL_EN); - - /* Enable external vbus configuration in the LINK */ - setbits_le32(&ehci->usbcmd, SESS_VLD_CTRL); - - /* USB_OTG_HS_AHB_BURST */ - writel(0x0, &ehci->sbuscfg); - - /* USB_OTG_HS_AHB_MODE: HPROT_MODE */ - /* Bus access related config. */ - writel(0x08, &ehci->sbusmode); + generic_phy_reset(&p->phy); /* set mode to host controller */ writel(CM_HOST, &ehci->usbmode); @@ -97,6 +57,10 @@ static int ehci_usb_probe(struct udevice *dev) hcor = (struct ehci_hcor *)((phys_addr_t)hccr + HC_LENGTH(ehci_readl(&(hccr)->cr_capbase))); + ret = ehci_setup_phy(dev, &p->phy, 0); + if (ret) + return ret; + ret = board_usb_init(0, USB_INIT_HOST); if (ret < 0) return ret; @@ -117,7 +81,9 @@ static int ehci_usb_remove(struct udevice *dev) /* Stop controller. */ clrbits_le32(&ehci->usbcmd, CMD_RUN); - reset_usb_phy(p); + ret = ehci_shutdown_phy(dev, &p->phy); + if (ret) + return ret; ret = board_usb_init(0, USB_INIT_DEVICE); /* Board specific hook */ if (ret < 0) From patchwork Fri Sep 21 10:35:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 973152 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LldcnopA"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42Gqsb1t7Kz9s7T for ; Fri, 21 Sep 2018 20:41:55 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 01B77C21E47; Fri, 21 Sep 2018 10:39:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 180C9C21E12; Fri, 21 Sep 2018 10:37:46 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 6603DC21E3A; Fri, 21 Sep 2018 10:36:52 +0000 (UTC) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by lists.denx.de (Postfix) with ESMTPS id 3660AC21E12 for ; Fri, 21 Sep 2018 10:36:45 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id q8-v6so2680292wmq.4 for ; Fri, 21 Sep 2018 03:36:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1ZHwHoebd9rgK5k/5A+32Jyj5u+Ndg70EvwG5lbr/gA=; b=LldcnopAtTnRG4zalshM8Orf3nyGd714PlJ4iuT9hAN9Js5M0y+j/428Prdf6OfrLC Ihe4UuFbQTvPSuCZt+Rck1E0MsTmyaKIp0mOahcQ1sIefQq22dxcqYzpQQIbWsPTdkI6 taXpmSsU0yh2YdxZr5fx99H8/1pP8mV8GM54oh+XiDINCrt6JVjPYGw4spjKqyqTpcXy yy/Pj/OCkKvHrDjmxR7iHjh+QevqOja4ZCOTQibIO+kRIwbiUMS2L5kAoy/mpIDMqlqx 4sMgJNw0pq1/5Dkglk78zow5Ncq6psmjCvSu0BtgGuG0fL8lib1wmGOcY/TLDrh98KAi 1vXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1ZHwHoebd9rgK5k/5A+32Jyj5u+Ndg70EvwG5lbr/gA=; b=QJFuGhTDYNhNfZ4HI82zwFD5yy5LowF+HVj6221+MCKXzZgWbXYLDvxxf02FDI92Px n+NG4J5r9XzLZx7KwPN1NsPtiaZgww+RUIvPJIWhwHo0sjJoylWYAoTth489F9WjxDQz zWoJJwU18xVfacN+imSxFCC8h3D/tmVRRB0zestJWLO8niL+wHDVmHFTOy2dRFKNcLVy sZzLQT3phoDzg9p5+b8s0NuKWK2sEj3JxMrqtGYfd+UM/j6VoyIwjsX+Jw0P8yEuV/p4 oKo+s6jVTCM1HVdpBcsVh7ATtE0RWrKVynCflBiKytz2/tO18d2UmV8uSW546NZl7jJd GjKw== X-Gm-Message-State: APzg51B2myguX4so/VGk/W9UNB1GyryEvvofS0fq91ojOyIKcxde0K8H bND6iTm3S5FyuwZtTFFRfnpJFYrCNhkl0A== X-Google-Smtp-Source: ANB0VdaVS6ZQSOLJY27QTVgCaDocd2qVkrOuyOHeoQoXn7AoVPI4vMIbULTW3VfUJ/+nm6SuJXAyOg== X-Received: by 2002:a1c:e141:: with SMTP id y62-v6mr2568171wmg.138.1537526204522; Fri, 21 Sep 2018 03:36:44 -0700 (PDT) Received: from localhost.localdomain ([5.102.238.49]) by smtp.gmail.com with ESMTPSA id 204-v6sm6770843wmh.25.2018.09.21.03.36.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 03:36:43 -0700 (PDT) From: Ramon Fried To: u-boot@lists.denx.de Date: Fri, 21 Sep 2018 13:35:51 +0300 Message-Id: <20180921103555.16240-10-ramon.fried@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180921103555.16240-1-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> Cc: Marek Vasut Subject: [U-Boot] [PATCH v2 09/14] ehci: msm: use init_type in probe X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Change ehci_usb_probe() function to initialize the USB according to the init_type provided. Signed-off-by: Ramon Fried --- Changes in v2: None drivers/usb/host/ehci-msm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index a27a5833dd..00d6bb8231 100644 --- a/drivers/usb/host/ehci-msm.c +++ b/drivers/usb/host/ehci-msm.c @@ -49,6 +49,7 @@ static int ehci_usb_probe(struct udevice *dev) { struct msm_ehci_priv *p = dev_get_priv(dev); struct usb_ehci *ehci = p->ehci; + struct usb_platdata *plat = dev_get_platdata(dev); struct ehci_hccr *hccr; struct ehci_hcor *hcor; int ret; @@ -61,11 +62,12 @@ static int ehci_usb_probe(struct udevice *dev) if (ret) return ret; - ret = board_usb_init(0, USB_INIT_HOST); + ret = board_usb_init(0, plat->init_type); if (ret < 0) return ret; - return ehci_register(dev, hccr, hcor, &msm_ehci_ops, 0, USB_INIT_HOST); + return ehci_register(dev, hccr, hcor, &msm_ehci_ops, 0, + plat->init_type); } static int ehci_usb_remove(struct udevice *dev) From patchwork Fri Sep 21 10:35:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 973156 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="cCaXumKJ"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42Gqw41tm9z9s89 for ; Fri, 21 Sep 2018 20:44:04 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id E1AF6C21E6C; Fri, 21 Sep 2018 10:40:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id C448EC21EC3; Fri, 21 Sep 2018 10:37:58 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 297A8C21EB9; Fri, 21 Sep 2018 10:36:53 +0000 (UTC) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by lists.denx.de (Postfix) with ESMTPS id B72E9C21E2F for ; Fri, 21 Sep 2018 10:36:46 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id 207-v6so2658883wme.5 for ; Fri, 21 Sep 2018 03:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0mMQzzH+TNiYV/SMLjy4GZnOq6es2ybsOT7Qxa4+I8w=; b=cCaXumKJVbie75qYxKbwbJMorMjzf9HclCU8uZma3+oTZcj/v701UJGDhHyBfKs14i DaAbHuFiep/CJy42COR2bkqeRKZ/8CVX/oSgEwqC3eKnNALIpSIQGwtyZPDJFfPpvUgy XnsrWMLXUXtcFPbNPUx5iVr1P/uEViXHz5CxvAjDcLK0NbHO6GpvT3ivZ8zj0DeJeABt tyT2gIwIE9jT1K4KFZ5vaOvJ7Q7f0SNIs7A6Zw9ECGjDZzORqWp17upM+gMyUQXeOjTO oBEnEmnyNyZ13xTglaZqYDi7grV13pB29urATHezRX/d5DJ9t+nNOqYDd0f8eFVaHX6Z DrVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0mMQzzH+TNiYV/SMLjy4GZnOq6es2ybsOT7Qxa4+I8w=; b=UZxyRs3OlF2nqWVOaE4bzQUgq3SzOR5VDGKOcFYOIP+wZNsA4pFscOZrUvH8Dnvldy 2v02SJed9eRfZBEATaoZY3QHc5cNn7PvwmSC/15JXTeXR4dxFop2en55nPxNH3/vxWUQ jlhcxe1UU3FG94jEQ0h0dx2IfVqYLDcnacVYmYQsZaSCWdbXPlao/0WJUty2WP3YTiEV h/yYxQXWzpG2+OWqIw34/h7nmzeWIPGPrrhN4YroIJN25/1h6qtcWxzXjp9L7NL4STQ0 Np/OjaFbiLZfYR1ccBNIhcNFZM6oVyMLvJpLUd4WW1nehRWBN0CLmjEXAIQSLXRqVlyJ NaSA== X-Gm-Message-State: APzg51DnSdGMpMT7etGqRRrULGx8vqUz+LAlr//ce/Sa79Zd9Qw+Kytn BEmp25oy5Tu0vFohT98rHvKqM/9PfnYCrQ== X-Google-Smtp-Source: ANB0VdbU9VSXshfCCvNdr/EWyHwg67g/D3QrLdJ7bEUrlkxT8oXZBtc7iXWr9VOlefSwHUzpBB2yew== X-Received: by 2002:a1c:6705:: with SMTP id b5-v6mr6740250wmc.78.1537526205975; Fri, 21 Sep 2018 03:36:45 -0700 (PDT) Received: from localhost.localdomain ([5.102.238.49]) by smtp.gmail.com with ESMTPSA id 204-v6sm6770843wmh.25.2018.09.21.03.36.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 03:36:45 -0700 (PDT) From: Ramon Fried To: u-boot@lists.denx.de Date: Fri, 21 Sep 2018 13:35:52 +0300 Message-Id: <20180921103555.16240-11-ramon.fried@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180921103555.16240-1-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> Cc: Marek Vasut Subject: [U-Boot] [PATCH v2 10/14] usb:ci_udc: Introduce init_after_reset phy function X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" MSM variant of Chipidea must reinitalize the phy after controller reset. Introduce ci_init_after_reset() weak function that can be used to achieve the above init. Signed-off-by: Ramon Fried Reviewed-by: Lukasz Majewski --- Changes in v2: None drivers/usb/gadget/ci_udc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c index 2b9dbf06b9..8d23fab3b7 100644 --- a/drivers/usb/gadget/ci_udc.c +++ b/drivers/usb/gadget/ci_udc.c @@ -104,6 +104,10 @@ static struct usb_ep_ops ci_ep_ops = { .free_request = ci_ep_free_request, }; +__weak void ci_init_after_reset(struct ehci_ctrl *ctrl) +{ +} + /* Init values for USB endpoints. */ static const struct usb_ep ci_ep_init[5] = { [0] = { /* EP 0 */ @@ -887,6 +891,8 @@ static int ci_pullup(struct usb_gadget *gadget, int is_on) writel(USBCMD_ITC(MICRO_8FRAME) | USBCMD_RST, &udc->usbcmd); udelay(200); + ci_init_after_reset(controller.ctrl); + writel((unsigned long)controller.epts, &udc->epinitaddr); /* select DEVICE mode */ From patchwork Fri Sep 21 10:35:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 973151 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HrNnAU8M"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42GqsT6LFcz9s7T for ; Fri, 21 Sep 2018 20:41:49 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 5F600C21E9F; Fri, 21 Sep 2018 10:38:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 2E146C21E3B; Fri, 21 Sep 2018 10:37:11 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 3B795C21D65; Fri, 21 Sep 2018 10:36:53 +0000 (UTC) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by lists.denx.de (Postfix) with ESMTPS id 34C65C21E75 for ; Fri, 21 Sep 2018 10:36:48 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id j25-v6so3840887wmc.1 for ; Fri, 21 Sep 2018 03:36:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VYVoe+89bGclbRH/bLzi3e5YWxaR8JTuxj5qKmbJuDE=; b=HrNnAU8MOrzHKJnmzf0WFB6o0XTY6ZWMu3J0m1LsfIjqBWhScMRKZ90v51jGXZYH+M ruIiCcS1Gp0oZ3GfoV8qlzS9oCWIdV6FM44nkt79HqlAFWo9VaFntTWTFRxG4WKXi3iu 0YupH7BPDWFNZKTy9QpGL+OmrCMA3M1EQTVRC7y6pKVI1mXSPIVBqqowLiZdb3gN/xkg JnJB8TRwNknXSfFfECPWd8UnUncLrcK/QYmrTuejuDoBgFbt4fme/wd0Gl9e1VfbMla+ 4G7ISWV+XnTrIiwJW+Tpr7qY5N/U2r+W53SwYtQgURpjM/f2s6ePg3FrYTzY7tqKy79T A67Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VYVoe+89bGclbRH/bLzi3e5YWxaR8JTuxj5qKmbJuDE=; b=ee+aL9ixLgX7QGY9w0arIcWa4fz4Q1WcBzFDv8xcFvijGh1Dl0xUuca/8/sh88lqax 3MF79vRUj48+zwO8ZynzfPjFhEsA8iWt0A0kTnZWSQmnWEYyBy+1cHxslYZEuoiZdBrr iCItaTiXREn36tmHp1kikilB4yMRimZrtwtfWGl463nXpIQaLMmCAi3amR5QqocUbtll ZEZBvNrQq7+vR4pPiP50/AtOlDLxtJw1VhkMC+9hdzIf5B3diwAUDHiQZ59s62iLnw7I TzPa7z1wNF7G2l0lTS5XpSQmfkV6VH+ijr8niWMqt6XHUd5E0RazlCl3bMyPg64/SZGs musQ== X-Gm-Message-State: APzg51CCYAEA8LvGXtEVjGuMXk7+srYkRWGdhxO2NKlzj8SmpElfcp1t Por+YfEd4Ty1pyaZlmkBkZ1Pv1PL5jMMkA== X-Google-Smtp-Source: ACcGV61M0MnrKoN0KdTpNmRtOaXXUeZ+LGHuELVgDTjQtV8Ye62fa9Lq7K4j0/KDXTRXoeiKtyADrQ== X-Received: by 2002:a1c:7fc6:: with SMTP id a189-v6mr6153846wmd.42.1537526207494; Fri, 21 Sep 2018 03:36:47 -0700 (PDT) Received: from localhost.localdomain ([5.102.238.49]) by smtp.gmail.com with ESMTPSA id 204-v6sm6770843wmh.25.2018.09.21.03.36.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 03:36:46 -0700 (PDT) From: Ramon Fried To: u-boot@lists.denx.de Date: Fri, 21 Sep 2018 13:35:53 +0300 Message-Id: <20180921103555.16240-12-ramon.fried@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180921103555.16240-1-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> Cc: Marek Vasut Subject: [U-Boot] [PATCH v2 11/14] usb: ehci-msm: Add init_after_reset for CI_UDC X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" MSM uses the chipidea controller IP, however it requires to reinit the phy after controller reset. in EHCI mode there's a dedicated callback for it. In device mode however there's no such callback. Add implementaion of ci_init_after_reset() to implement the above requirement in case CI_UDC driver is used. Signed-off-by: Ramon Fried --- Changes in v2: None drivers/usb/host/ehci-msm.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index 00d6bb8231..5c257ccf4d 100644 --- a/drivers/usb/host/ehci-msm.c +++ b/drivers/usb/host/ehci-msm.c @@ -121,6 +121,18 @@ static int ehci_usb_ofdata_to_platdata(struct udevice *dev) return 0; } +#if defined(CONFIG_CI_UDC) +/* Little quirk that MSM needs with Chipidea controller + * Must reinit phy after reset + */ +void ci_init_after_reset(struct ehci_ctrl *ctrl) +{ + struct msm_ehci_priv *p = ctrl->priv; + + generic_phy_reset(&p->phy); +} +#endif + static const struct udevice_id ehci_usb_ids[] = { { .compatible = "qcom,ehci-host", }, { } From patchwork Fri Sep 21 10:35:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 973150 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="NGYdk0vW"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42Gqrj113kz9sB5 for ; Fri, 21 Sep 2018 20:41:08 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 961CDC21E1E; Fri, 21 Sep 2018 10:39:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=FREEMAIL_FROM, T_DKIM_INVALID, UPPERCASE_50_75 autolearn=no autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 13955C21D9A; Fri, 21 Sep 2018 10:37:34 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 631CEC21E1E; Fri, 21 Sep 2018 10:36:55 +0000 (UTC) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by lists.denx.de (Postfix) with ESMTPS id 96247C21E7E for ; Fri, 21 Sep 2018 10:36:49 +0000 (UTC) Received: by mail-wm1-f48.google.com with SMTP id b19-v6so2540199wme.3 for ; Fri, 21 Sep 2018 03:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vWtIYRmJlaKDkg9NrTkASS4UqgmkOH/oPSianlC70V8=; b=NGYdk0vWNjLzdwe98eOjabMK4eUDYUQhDigpZZwfOkRPxtJTyQE9a8vce+MKeslqMi TK2mSBQDDI5BACdqS17ClgxOh84NSdexhq+8cQxjTpEWj04RTGHtS710gsVjh5FWF1yw J1057HxQwt26o9vTdJS8nES4qQz+Bk2jsNbxbKRR7xH/a8yxji+cg5VRmSugkshfPWVD YPKHMQVmIiF0z991SrpsOsp6BSOVX1OP44tB+idfd+R7Pk8c8uPxjslXH19l7XausggE jdd/76Orz5A6qjglryScYUFf8XVfWX5NEMxN4iOIUzTUoaR0EfFxsO6tsWEX0ip4hZku uxgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vWtIYRmJlaKDkg9NrTkASS4UqgmkOH/oPSianlC70V8=; b=Qx02HpOkr5fKIC73WEp+H9fDOL+wf7AOa3yYRcz63l7nwWasqxq5XOvY09t8a/QGHp 5EqPkeimC8UcvZ0vHE0gW4cLTS7j//JzV22rA+LZuUuT5Otmi4l62mHO4TTu4atAW2H+ EyArBb2F4SaDg1VVhOHmVssEfFFrYLxCUBKjB0w6c+WqAYKSoq12yNVeUjiiTVdFOy+x OM0+6OTGZBH7rl5sS7oFKneviX0kx2TvZSembubODQjkLeA7Gi7GOocnp75vqLPG/ah4 HecF9f8wZL9qOro4I87vUBtqybJOQIkuG7nvLOcmOLX+mSq5GIj7M9GzsoXEy5u3dDuf 9miA== X-Gm-Message-State: APzg51AmzHaSdW2/hWrw30DMZmCJe+EtTkcnimfkRMy3gsxAmKZ3zkWS /r0G0qkAGc6DyXzXG+z58ugh8XFQ2ZUdtw== X-Google-Smtp-Source: ANB0VdauzTKjTCaXtKVNXrpYRUllqjbNliC5Fzljk4Kb1z8G0Pc77gPLT86Ibd5J+nWDpjO23Epxiw== X-Received: by 2002:a1c:a90:: with SMTP id 138-v6mr6328232wmk.98.1537526208953; Fri, 21 Sep 2018 03:36:48 -0700 (PDT) Received: from localhost.localdomain ([5.102.238.49]) by smtp.gmail.com with ESMTPSA id 204-v6sm6770843wmh.25.2018.09.21.03.36.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 03:36:48 -0700 (PDT) From: Ramon Fried To: u-boot@lists.denx.de Date: Fri, 21 Sep 2018 13:35:54 +0300 Message-Id: <20180921103555.16240-13-ramon.fried@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180921103555.16240-1-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> Subject: [U-Boot] [PATCH v2 12/14] DB410c: Enable fastboot support X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Signed-off-by: Ramon Fried --- Changes in v2: None configs/dragonboard410c_defconfig | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/configs/dragonboard410c_defconfig b/configs/dragonboard410c_defconfig index 0d9008deb7..a55abaf8df 100644 --- a/configs/dragonboard410c_defconfig +++ b/configs/dragonboard410c_defconfig @@ -4,6 +4,7 @@ CONFIG_SYS_TEXT_BASE=0x80080000 CONFIG_IDENT_STRING="\nQualcomm-DragonBoard 410C" CONFIG_DISTRO_DEFAULTS=y CONFIG_NR_DRAM_BANKS=1 +# CONFIG_ANDROID_BOOT_IMAGE is not set CONFIG_FIT=y CONFIG_OF_BOARD_SETUP=y CONFIG_MISC_INIT_R=y @@ -22,6 +23,10 @@ CONFIG_CMD_TIMER=y CONFIG_DEFAULT_DEVICE_TREE="dragonboard410c" CONFIG_ENV_IS_IN_MMC=y CONFIG_CLK=y +CONFIG_USB_FUNCTION_FASTBOOT=y +CONFIG_FASTBOOT_BUF_ADDR=0x91000000 +CONFIG_FASTBOOT_FLASH=y +CONFIG_FASTBOOT_FLASH_MMC_DEV=0 CONFIG_MSM_GPIO=y CONFIG_PM8916_GPIO=y CONFIG_LED=y @@ -43,6 +48,11 @@ CONFIG_USB_EHCI_MSM=y CONFIG_USB_ULPI_VIEWPORT=y CONFIG_USB_ULPI=y CONFIG_USB_STORAGE=y +CONFIG_USB_GADGET=y +CONFIG_USB_GADGET_VENDOR_NUM=0x18d1 +CONFIG_USB_GADGET_PRODUCT_NUM=0xd00d +CONFIG_CI_UDC=y +CONFIG_USB_GADGET_DUALSPEED=n CONFIG_USB_HOST_ETHER=y CONFIG_USB_ETHER_ASIX=y CONFIG_USB_ETHER_ASIX88179=y From patchwork Fri Sep 21 10:35:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 973155 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OXG9ML5M"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42Gqty0bCPz9s7T for ; Fri, 21 Sep 2018 20:43:05 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id B7EF4C21E52; Fri, 21 Sep 2018 10:39:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id D75A0C21C4A; Fri, 21 Sep 2018 10:37:38 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 14FC2C21DFD; Fri, 21 Sep 2018 10:36:55 +0000 (UTC) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by lists.denx.de (Postfix) with ESMTPS id 12E0FC21E60 for ; Fri, 21 Sep 2018 10:36:51 +0000 (UTC) Received: by mail-wm1-f54.google.com with SMTP id q8-v6so2680650wmq.4 for ; Fri, 21 Sep 2018 03:36:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7OmStvICLVScY52pey1u0AuAOX3NmqL5M+SsAea67e8=; b=OXG9ML5M6n6OAYa49wc+90f7zKTv9nKyd9ExZYLBmxsJIeU4fgvWl/KmKjPmpTAfNu 5R8LwxD4lCIdvTp43vP27yqroo418rzuJAir7VaL2b6W7qdLqRHOUy05fLGTf6lxEiDp GPHGVHXGOqpEe0tdfI1Hh4g4sieg7Sc2eXwcO+yyB9aODq3q929HeiV99x9DniwISjhH KKNz0wP7kYcf0+MC53Meoa5OkPo4KAq9ArlUDwtk+cNk6SK1/taD8Lz90Ctudk2cxOkf oKoIwCfjvqsmGCpojteBR2khKn7NOK+KALHdXO8HU9abZaJM78k6aEomV3LEuu3Z9t0m e5sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7OmStvICLVScY52pey1u0AuAOX3NmqL5M+SsAea67e8=; b=JulAPBkDPfNQl9XEx/Hc/uGWM5yyNzyM2TDsENi/0plHLbTIw8Df5j3l47TXTg1DDa 1UnTQJB6eheOZPm0JVM9R7q5G5k9I393wDN3+NqiSY6KeUxxVr5hpMPrFIt4/B/GXGyc 9qeyKnXih6X8KWZ7hGogv+Xe3X0TA/pGc0Ul6vO16key5tU70wuxoXUxatWPf7ofoajf w+0ahMCzmF1nQkV1X6vxthxUr/nWsgRFVv8V/P+JxZ2uLIr4izBH/9zBycvODYNSLzz3 R+Z6AQ375QxHfoCjisgmvGmN0LB6cyQA4aTuyzRF5R6KaeRXpCBJ6SBZPIbGGmH73Wcz 7Hlg== X-Gm-Message-State: ABuFfogkMT+gStybq29AHL5J2wZAtDJT9QgGdUd6XvFekVicngOXPWjw BH02umvwTKlIgmHUpdWvuiFFUxnfeWeG3A== X-Google-Smtp-Source: ANB0VdbfkRtEThCGKhzwWpu63bBXcQCtlb/al3J9qHBxU2+cq8qcv1KEkRK20H5bSHmMAZ2LPmCXFw== X-Received: by 2002:a1c:545d:: with SMTP id p29-v6mr6303907wmi.94.1537526210374; Fri, 21 Sep 2018 03:36:50 -0700 (PDT) Received: from localhost.localdomain ([5.102.238.49]) by smtp.gmail.com with ESMTPSA id 204-v6sm6770843wmh.25.2018.09.21.03.36.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 03:36:49 -0700 (PDT) From: Ramon Fried To: u-boot@lists.denx.de Date: Fri, 21 Sep 2018 13:35:55 +0300 Message-Id: <20180921103555.16240-14-ramon.fried@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180921103555.16240-1-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> Subject: [U-Boot] [PATCH v2 13/14] db410c: automatically launch fastboot X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" If during boot the key-vol-down press is detected we'll fall back to fastboot. Signed-off-by: Ramon Fried --- Changes in v2: None board/qualcomm/dragonboard410c/dragonboard410c.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/board/qualcomm/dragonboard410c/dragonboard410c.c b/board/qualcomm/dragonboard410c/dragonboard410c.c index b2a72bce38..9ceed3ad9b 100644 --- a/board/qualcomm/dragonboard410c/dragonboard410c.c +++ b/board/qualcomm/dragonboard410c/dragonboard410c.c @@ -140,7 +140,8 @@ int misc_init_r(void) if (dm_gpio_get_value(&resin)) { env_set("bootdelay", "-1"); - printf("Power button pressed - dropping to console.\n"); + env_set("bootcmd", "fastboot 0"); + printf("key_vol_down pressed - Starting fastboot.\n"); } return 0; From patchwork Fri Sep 21 10:35:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 973154 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="T8xGkjJf"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42Gqth5Gyvz9s7T for ; Fri, 21 Sep 2018 20:42:52 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 4FE5FC21C38; Fri, 21 Sep 2018 10:40:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 825E8C21E68; Fri, 21 Sep 2018 10:37:50 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 3154BC21E7E; Fri, 21 Sep 2018 10:36:56 +0000 (UTC) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by lists.denx.de (Postfix) with ESMTPS id 6BA8DC21E96 for ; Fri, 21 Sep 2018 10:36:52 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id j8-v6so8627734wrw.5 for ; Fri, 21 Sep 2018 03:36:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kzDh9Qz73hzx1L4NgQ7mHjYuLyCAZOaLERqHf/RepGw=; b=T8xGkjJfHGpaOiCDhOJ5wQRW4Ohii2FiXRDGB+G3ne7oeBFZCQjU6OkbEHFaImcGie 2NRSTaHPZZOdgDvur7nY+3CLmkJjV0zDwKc+A4IukibxWfPehedz8ti0cq+IOys4tK3c TpB0VULd9wypWvFFSn/tX9bgSLGGlmfq+yfI5rkwcW5GDCmPMHhDMHHUoYOHmuia4oh6 8Q4vpkhmOECHYcXAu2NPKkwZb4+SxO4Lp/O42FIxIIRRMO/uP0DfRIKBNVLguKoYRECk W138W3znIailJZSNbgOFUCkA3N5RXbB+UIOdtcAignYhBLjVHlV7MlY+TZO3QRHpQBh5 OA9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kzDh9Qz73hzx1L4NgQ7mHjYuLyCAZOaLERqHf/RepGw=; b=e0Xqh7NXgbeuN9B0/97w7Xj/yYtM/166QLDarnhmvLJULnfJw6Uqfc3zeM3ftqPOR7 DHQnSTYWBAvsE6qZp8SXeQt9QM5kFuSzMRxnZvqz5GJESsv2W5KnAxuPdlPBsLe6ZWEX IzpkPJuQ/Sa8hEEQAVlZnC9yF1lSv6ARbopxoTY1/P3cmOM1HgCv1tycy+ItJStDVS46 9yYtpRvvttieGcECw8FxJnhY1UfKql109wv3oV8fd2dSSY5Ye5RJcbH3/qS1NM7Jnwx2 UpTxmknSVxI/RgmrfOGiyA+yA6Z0AHpOr+RGpa9wqlSgHj0lU+LFduKp9BY/1PrGAZQB A2jw== X-Gm-Message-State: APzg51DARFZracLwXkb9XAqRbQSPcBv+xdu3U7AINEufMftGyzxicyW2 UXawBHc7ZtdIcdmh2924TEUEIy5n+rSiqA== X-Google-Smtp-Source: ANB0VdaVnxUC0NzKUlwGo1nbyQMRiKP+GIhZMQbwZPRPV8TsYaufVFUmK/dJEsfEHrGMYnrCr/X+/g== X-Received: by 2002:a5d:62c2:: with SMTP id o2-v6mr11951738wrv.83.1537526211836; Fri, 21 Sep 2018 03:36:51 -0700 (PDT) Received: from localhost.localdomain ([5.102.238.49]) by smtp.gmail.com with ESMTPSA id 204-v6sm6770843wmh.25.2018.09.21.03.36.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 03:36:51 -0700 (PDT) From: Ramon Fried To: u-boot@lists.denx.de Date: Fri, 21 Sep 2018 13:35:56 +0300 Message-Id: <20180921103555.16240-15-ramon.fried@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180921103555.16240-1-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> Cc: Marek Vasut Subject: [U-Boot] [PATCH v2 14/14] usb:ci_udc: don't overwrite configuration on pullup X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" change writel to writebits32 in ci_pullup() in order to keep phy configuration in tact. Signed-off-by: Ramon Fried Reviewed-by: Lukasz Majewski --- Changes in v2: Patch introduced drivers/usb/gadget/ci_udc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c index 8d23fab3b7..0a84f6850d 100644 --- a/drivers/usb/gadget/ci_udc.c +++ b/drivers/usb/gadget/ci_udc.c @@ -906,7 +906,8 @@ static int ci_pullup(struct usb_gadget *gadget, int is_on) writel(0xffffffff, &udc->epflush); /* Turn on the USB connection by enabling the pullup resistor */ - writel(USBCMD_ITC(MICRO_8FRAME) | USBCMD_RUN, &udc->usbcmd); + setbits_le32(&udc->usbcmd, USBCMD_ITC(MICRO_8FRAME) | + USBCMD_RUN); } else { udc_disconnect(); }