From patchwork Thu Oct 5 16:55:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 821955 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-85473-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="ELoOJ9Lu"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3y7Jnd2b3Qz9t3v for ; Fri, 6 Oct 2017 03:56:20 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=R140uU2dUERze69UyVgNUAQuaGneBkD dgwcfHkVQwhz11E5ugPuODW00O1cxakY62OXqMAakWhEfWQrSMx4m73u/Ll3hqzv 82S8YBCQwrcUWkDUsNr5ouUJIiVYpodqBw15DekKDa1aMCaavsTIKnj1YPnCvnqH M7B3Ep79kYBc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=qIdskw0DCsoI9XookL59L4n86W8=; b=ELoOJ 9Lu3ZCqEu10S5Nz9LyXVHu2wf4ZuoF2vMyFzyQJCkDEcFQQKMMBC4DMSHaP1gz2j QIjrMH4ilaNmuVAQwHWa2VgqCEOA5LVHqfmzcNhZCdJzO+6gxYd9U7lL2CDGeuDt hwSziFHadF4onk5iDhRTKnEcqz/QZ5qIHwcQkM= Received: (qmail 42881 invoked by alias); 5 Oct 2017 16:55:52 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 42828 invoked by uid 89); 5 Oct 2017 16:55:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_NEUTRAL autolearn=ham version=3.3.2 spammy= X-HELO: homiemail-a51.g.dreamhost.com From: Siddhesh Poyarekar To: libc-alpha@sourceware.org Subject: [COMMITTED 2/3] benchtests: Memory walking benchmark for memset Date: Thu, 5 Oct 2017 22:25:35 +0530 Message-Id: <1507222536-3809-2-git-send-email-siddhesh@sourceware.org> In-Reply-To: <1507222536-3809-1-git-send-email-siddhesh@sourceware.org> References: <1507222536-3809-1-git-send-email-siddhesh@sourceware.org> This benchmark is an attempt to eliminate cache effects from string benchmarks. The benchmark walks backward through a large memory area and sets different sizes of memory and alignments one at a time instead of looping around in the same memory area. This is a good metric to have alongside the simple memset benchmark (which is only really useful for smaller sizes) especially for larger sizes where the likelihood of the call being done only once is pretty high. * benchtests/bench-memset-walk.c: New file. * benchtests/Makefile (string-benchset): Add it. --- ChangeLog | 3 + benchtests/Makefile | 2 +- benchtests/bench-memset-walk.c | 138 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 142 insertions(+), 1 deletion(-) create mode 100644 benchtests/bench-memset-walk.c diff --git a/ChangeLog b/ChangeLog index a86faeb..5821c5d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2017-10-05 Siddhesh Poyarekar + * benchtests/bench-memset-walk.c: New file. + * benchtests/Makefile (string-benchset): Add it. + * benchtests/bench-memcpy-walk.c: New file. * benchtests/Makefile (string-benchset): Add it. diff --git a/benchtests/Makefile b/benchtests/Makefile index d086cc6..5a07639 100644 --- a/benchtests/Makefile +++ b/benchtests/Makefile @@ -38,7 +38,7 @@ string-benchset := bcopy bzero memccpy memchr memcmp memcpy memmem memmove \ strncasecmp strncat strncmp strncpy strnlen strpbrk strrchr \ strspn strstr strcpy_chk stpcpy_chk memrchr strsep strtok \ strcoll memcpy-large memcpy-random memmove-large memset-large \ - memcpy-walk + memcpy-walk memset-walk # Build and run locale-dependent benchmarks only if we're building natively. ifeq (no,$(cross-compiling)) diff --git a/benchtests/bench-memset-walk.c b/benchtests/bench-memset-walk.c new file mode 100644 index 0000000..59d2626 --- /dev/null +++ b/benchtests/bench-memset-walk.c @@ -0,0 +1,138 @@ +/* Measure memset function throughput with large data sizes. + Copyright (C) 2017 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#define TEST_MAIN +#ifndef WIDE +# define TEST_NAME "memset" +#else +# define TEST_NAME "wmemset" +#endif /* WIDE */ +#define START_SIZE (1) +#define MIN_PAGE_SIZE (getpagesize () + 32 * 1024 * 1024) +#define TIMEOUT (20 * 60) +#include "bench-string.h" + +#ifndef WIDE +# define MEMSET memset +# define CHAR char +# define SIMPLE_MEMSET simple_memset +# define MEMCMP memcmp +#else +# include +# define MEMSET wmemset +# define CHAR wchar_t +# define SIMPLE_MEMSET simple_wmemset +# define MEMCMP wmemcmp +#endif /* WIDE */ + +#include +#include "json-lib.h" + + +typedef CHAR *(*proto_t) (CHAR *, int, size_t); + +CHAR * +inhibit_loop_to_libcall +SIMPLE_MEMSET (CHAR *s, int c, size_t n) +{ + CHAR *r = s, *end = s + n; + while (r < end) + *r++ = c; + return s; +} + +IMPL (SIMPLE_MEMSET, 1) + +static void +do_one_test (json_ctx_t *json_ctx, impl_t *impl, CHAR *s, CHAR *s_end, + int c __attribute ((unused)), size_t n) +{ + size_t i, iters = MIN_PAGE_SIZE / n; + timing_t start, stop, cur; + + TIMING_NOW (start); + for (i = 0; i < iters && s <= s_end; s++, i++) + CALL (impl, s, c, n); + TIMING_NOW (stop); + + TIMING_DIFF (cur, start, stop); + + /* Get time taken per function call. */ + json_element_double (json_ctx, (double) cur * n / i); +} + +static void +do_test (json_ctx_t *json_ctx, int c, size_t len) +{ + json_element_object_begin (json_ctx); + json_attr_uint (json_ctx, "length", len); + json_attr_uint (json_ctx, "char", c); + json_array_begin (json_ctx, "timings"); + + FOR_EACH_IMPL (impl, 0) + { + do_one_test (json_ctx, impl, (CHAR *) buf1, + (CHAR *) buf1 + MIN_PAGE_SIZE - len, c, len); + realloc_bufs (); + } + + json_array_end (json_ctx); + json_element_object_end (json_ctx); +} + +int +test_main (void) +{ + json_ctx_t json_ctx; + size_t i; + + test_init (); + + json_init (&json_ctx, 0, stdout); + + json_document_begin (&json_ctx); + json_attr_string (&json_ctx, "timing_type", TIMING_TYPE); + + json_attr_object_begin (&json_ctx, "functions"); + json_attr_object_begin (&json_ctx, TEST_NAME); + json_attr_string (&json_ctx, "bench-variant", "walk"); + + json_array_begin (&json_ctx, "ifuncs"); + FOR_EACH_IMPL (impl, 0) + json_element_string (&json_ctx, impl->name); + json_array_end (&json_ctx); + + json_array_begin (&json_ctx, "results"); + for (i = START_SIZE; i <= MIN_PAGE_SIZE; i <<= 1) + /* Test length alignments from 0-16 bytes. */ + for (int j = 0; j < i && j < 16; j++) + do_test (&json_ctx, 65, i + j); + + for (i = START_SIZE; i <= MIN_PAGE_SIZE; i <<= 1) + for (int j = 0; j < i && j < 16; j++) + do_test (&json_ctx, 0, i + j); + + json_array_end (&json_ctx); + json_attr_object_end (&json_ctx); + json_attr_object_end (&json_ctx); + json_document_end (&json_ctx); + + return ret; +} + +#include