From patchwork Wed Sep 5 22:00:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Angelo Compagnucci X-Patchwork-Id: 966702 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RVRAFLLU"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 425Hh14lp7z9sCq for ; Thu, 6 Sep 2018 08:00:33 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D83A887870; Wed, 5 Sep 2018 22:00:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xqysSN0Kb2Od; Wed, 5 Sep 2018 22:00:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3BEF687869; Wed, 5 Sep 2018 22:00:31 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id E40F11C2D27 for ; Wed, 5 Sep 2018 22:00:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id E15C387845 for ; Wed, 5 Sep 2018 22:00:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EknbxlswousY for ; Wed, 5 Sep 2018 22:00:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 0315E87746 for ; Wed, 5 Sep 2018 22:00:29 +0000 (UTC) Received: by mail-wm0-f48.google.com with SMTP id y139-v6so9378808wmc.2 for ; Wed, 05 Sep 2018 15:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DTaWeiy2jL4jCe7g/LvwWs2CIrO4uIAlyScoz5TUoak=; b=RVRAFLLUjtMOPXV8uTqQo+qLngao961Pre/CgMO1BHrrugaORWs+LMlrdsEb9cm6kO E6GH5PUtXeFi2TebRP5u8MB8snwx8J0L+PjcsIYHlTRXJ+GLIFWk695W71KA5WACxGjl ehbhkhpQEi5b2lNQkPaqeq3C+hXMXxuVNqyVDstW32TN0cBnBWYz6p1vFtimHcnFQZh8 CyeUmVh44wgUPUVWFi2L4AqLYk1deBZY1YfjZrYxE64Kp/h0u20UA53eVNIO44KYV+TT P4BH62fU0vKU/J00aCI4SNkedVniKqthpucmkSNz01Ld/gGaGh3XjdEkD9RKSsYtF+LE LWHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DTaWeiy2jL4jCe7g/LvwWs2CIrO4uIAlyScoz5TUoak=; b=Lm/w2bgmTXchCsnPTQlIPelvFmtvGtIRVRH28ozzOKr+9KzlsLMcRoHJ2tIO6Da6sN bovzh/c1aHrAOe0UyoAF1mu3B/T8JefaSWRINnk/sYs4/u+77GqfZJgpeEYdYc1swhii oj9/wuGs+bOQXeHWtkd9atoY3FXvw3sstldzZccUoNQNQD4O5Qk45NmN/hyrdIuS2leP FKsf52sAsiRPKadShQKhZ/tzz0Q+pXwnWtf5Ef9+1tTMwjRpPLsl3qs/MR/U+/bjXxpy bFmrUJAj6fpu0FOaBLwtcpdrVXCTH47+3jV6SBeRrDc212Df+yLP1VmChQRPKG6+9rYU KlKA== X-Gm-Message-State: APzg51BgOlZaQnGcBmmtCRFtso3D59FBp0BRbKK+smAxmyGkO5mJmmiK 8v9GLv2ZoouSFAw/Je2CKL1daHV3 X-Google-Smtp-Source: ANB0VdYKYhKvcJ9q6+SigkOMcWNEGjhBFVQJ0sHXR7hglymeAY8mKrDA/G+B4dR4i//gwb3Kyx9dZQ== X-Received: by 2002:a1c:4904:: with SMTP id w4-v6mr256524wma.0.1536184827300; Wed, 05 Sep 2018 15:00:27 -0700 (PDT) Received: from localhost.localdomain ([37.162.44.87]) by smtp.gmail.com with ESMTPSA id h82-v6sm3029168wme.11.2018.09.05.15.00.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 05 Sep 2018 15:00:26 -0700 (PDT) From: Angelo Compagnucci To: buildroot@buildroot.org Date: Thu, 6 Sep 2018 00:00:06 +0200 Message-Id: <1536184808-9085-2-git-send-email-angelo.compagnucci@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536184808-9085-1-git-send-email-angelo.compagnucci@gmail.com> References: <1536184808-9085-1-git-send-email-angelo.compagnucci@gmail.com> Subject: [Buildroot] [PATCH v4 1/3] Makefile: add tainting support X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Angelo Compagnucci MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Packages who harms the build reproducibility or licensing can declare FOO_TAINTS variable. If a package taints the build it will be added to a list of tainting packages. The build ends with a warning if the tainting packages list is not empty. Moreover, legal info will show a warning in presence of a tainting package. Angelo Compagnucci Signed-off-by: Angelo Compagnucci Signed-off-by: Angelo Compagnucci --- Makefile | 10 ++++++++++ package/pkg-generic.mk | 12 ++++++++++++ 2 files changed, 22 insertions(+) diff --git a/Makefile b/Makefile index 9d66bba..ad61130 100644 --- a/Makefile +++ b/Makefile @@ -758,12 +758,21 @@ endif touch $(TARGET_DIR)/usr +.PHONY: check-tainted +check-tainted: +ifneq ($(BR2_TAINTED_BY),) + $(error Your buildroot configuration is tainted by: $(BR2_TAINTED_BY)) +else + @echo "Your buildroot configuration is not tainted" +endif + .PHONY: target-post-image target-post-image: $(TARGETS_ROOTFS) target-finalize @rm -f $(ROOTFS_COMMON_TAR) @$(foreach s, $(call qstrip,$(BR2_ROOTFS_POST_IMAGE_SCRIPT)), \ $(call MESSAGE,"Executing post-image script $(s)"); \ $(EXTRA_ENV) $(s) $(BINARIES_DIR) $(call qstrip,$(BR2_ROOTFS_POST_SCRIPT_ARGS))$(sep)) + $(if $(BR2_TAINTED_BY),@echo "WARNING: Your buildroot configuration is tainted by: $(BR2_TAINTED_BY).") .PHONY: source source: $(foreach p,$(PACKAGES),$(p)-all-source) @@ -1070,6 +1079,7 @@ help: @echo ' source - download all sources needed for offline-build' @echo ' external-deps - list external packages used' @echo ' legal-info - generate info about license compliance' + @echo ' check-tainted - check if any selected package harms build reproducibility or licensing' @echo ' printvars - dump all the internal variables' @echo @echo ' make V=0|1 - 0 => quiet build (default), 1 => verbose build' diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index 91b61c6..5bb0b25 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -870,6 +870,12 @@ else $(2)_KCONFIG_VAR = BR2_PACKAGE_$(2) endif +ifdef $(2)_TAINTS +ifeq ($$($$($(2)_KCONFIG_VAR)),y) +BR2_TAINTED_BY+=$$($(2)_RAWNAME) +endif +endif + # legal-info: declare dependencies and set values used later for the manifest ifneq ($$($(2)_LICENSE_FILES),) $(2)_MANIFEST_LICENSE_FILES = $$($(2)_LICENSE_FILES) @@ -909,6 +915,12 @@ else $(Q)$$(foreach F,$$($(2)_LICENSE_FILES),$$(call legal-license-file,$$($(2)_RAWNAME),$$($(2)_BASENAME_RAW),$$($(2)_PKGDIR),$$(F),$$($(2)_DIR)/$$(F),$$(call UPPERCASE,$(4)))$$(sep)) endif # license files +ifeq ($$(call qstrip,$$($(2)_TAINTS)),YES) +ifeq ($$($$($(2)_KCONFIG_VAR)),y) + $(Q)$$(call legal-warning-pkg,$$($(2)_RAWNAME),unknown license for additional modules or dependencies) +endif +endif + ifeq ($$($(2)_SITE_METHOD),local) # Packages without a tarball: don't save and warn @$$(call legal-warning-nosource,$$($(2)_RAWNAME),local) From patchwork Wed Sep 5 22:00:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Angelo Compagnucci X-Patchwork-Id: 966704 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="NU+DiKmS"; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 425Hh75fX6z9sCq for ; Thu, 6 Sep 2018 08:00:39 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5DE8988D90; Wed, 5 Sep 2018 22:00:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kVW1ruuhMFod; Wed, 5 Sep 2018 22:00:34 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id E9B8C88D8E; Wed, 5 Sep 2018 22:00:33 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 688351C2D27 for ; Wed, 5 Sep 2018 22:00:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 6581B8786F for ; Wed, 5 Sep 2018 22:00:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LTLEwV-0cWXj for ; Wed, 5 Sep 2018 22:00:30 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by fraxinus.osuosl.org (Postfix) with ESMTPS id A2BFA87746 for ; Wed, 5 Sep 2018 22:00:30 +0000 (UTC) Received: by mail-wm0-f67.google.com with SMTP id y139-v6so9378870wmc.2 for ; Wed, 05 Sep 2018 15:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aZM0igE/6hUdFD6NlB7u8kZ9/Vx/ldBrGGis32HAhHw=; b=NU+DiKmSp4tuPfIeC0+XdAqD915JHdDEGzpsVXhwxYXbFPKhRicLmi5bGM/4eRkJes RdypS8ViXTehUKOHkAKzyE5jEIIqpM4v+pzKmFxuUvoFJhCsvC74pxJPA7HGwZtZWWts j+MSJYgfgYhPkSttYQzCMQCNanQB9efoPGS2cdPN7w1U0u6usVnI3OTLp09iw7wI6z1a s/BvimlUbcEnrxRxJjV3n9uyLkxenlsfulgYL2rUuV6ZLiFKFdwpZkHmc2kLDhVnnbDu gR5LK+XiJFRMzVWc0FQR0l/dcfKJC2pr3vyHEt/lDArETPVQcz9vvGl2ssGwJYZtwKwE WR1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aZM0igE/6hUdFD6NlB7u8kZ9/Vx/ldBrGGis32HAhHw=; b=ddCggpBTlTMjFGtl95zJT7fabXsjbeiYFbr/vMCZhViWRmIaBMvMAfTmvP5iFkP2rY lm2xizoW0QzvJPiumsszZKXiIbLF7WcYHCc5t/ZrkTw2mZuGwXz0bjGEQ8NI6HTT43t9 zfLMro2k63HIjf2EGIOz1Ao6G2NqGANTRt0cIEoGDVqSu4uvckj4Sjq/ekAmCPY08Av9 DYHEyvda6otin7s1K0qlDOzI16+jhWp1erFPu+GrjsvkUSONDK/UB7l6ncfru3qKv4Oj 4i5XFyqpXVmDqMU4H0/4mhLlfE880Qk+SDiH2ImySJRZkexu2iH9Ln9d6najuoBIrTsW tsjA== X-Gm-Message-State: APzg51Ct9e1E9Q5rDsBTAQMycoB1PFbX2d9j5hoOXveeHlC0eCX9GPc8 Nvi4dgZhqVmAXwNnNNhib29TZKGC X-Google-Smtp-Source: ANB0VdbtaWAhZqtY8/dsMpC+hASgg1KMv3VLUkGwvfH7Tg7wmNRr+GJciNdfDR6hF2HmAn+4K7JlgA== X-Received: by 2002:a1c:114:: with SMTP id 20-v6mr220830wmb.4.1536184828948; Wed, 05 Sep 2018 15:00:28 -0700 (PDT) Received: from localhost.localdomain ([37.162.44.87]) by smtp.gmail.com with ESMTPSA id h82-v6sm3029168wme.11.2018.09.05.15.00.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 05 Sep 2018 15:00:28 -0700 (PDT) From: Angelo Compagnucci To: buildroot@buildroot.org Date: Thu, 6 Sep 2018 00:00:07 +0200 Message-Id: <1536184808-9085-3-git-send-email-angelo.compagnucci@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536184808-9085-1-git-send-email-angelo.compagnucci@gmail.com> References: <1536184808-9085-1-git-send-email-angelo.compagnucci@gmail.com> Subject: [Buildroot] [PATCH v4 2/3] docs/manual: adding infos about tainting X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Angelo Compagnucci MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Angelo Compagnucci Adding documentation about the usage of LIBFOO_TAINTS and "make check-tainted". Signed-off-by: Angelo Compagnucci Signed-off-by: Angelo Compagnucci --- docs/manual/adding-packages-generic.txt | 6 ++++++ docs/manual/legal-notice.txt | 12 ++++++++++++ 2 files changed, 18 insertions(+) diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt index 7be1754..6495157 100644 --- a/docs/manual/adding-packages-generic.txt +++ b/docs/manual/adding-packages-generic.txt @@ -445,6 +445,12 @@ not and can not work as people would expect it should: to let you know, and +not saved+ will appear in the +license files+ field of the manifest file for this package. +* +LIBFOO_TAINTS+ shoud be set to YES if a package taints a Buildroot + configuration. A Buildroot configuration is tainted when a packages uses + external dependencies for which Buildroot cannot clearly recover licensing + informations. If a configuration is tainted, it means that the licensing + information produced by +make legal-info+ could not be accurate. + * +LIBFOO_ACTUAL_SOURCE_TARBALL+ only applies to packages whose +LIBFOO_SITE+ / +LIBTOO_SOURCE+ pair points to an archive that does not actually contain source code, but binary code. This a very diff --git a/docs/manual/legal-notice.txt b/docs/manual/legal-notice.txt index 6975328..7fde09a 100644 --- a/docs/manual/legal-notice.txt +++ b/docs/manual/legal-notice.txt @@ -73,6 +73,18 @@ distribution is required). When you run +make legal-info+, Buildroot produces warnings in the +README+ file to inform you of relevant material that could not be saved. +Furthermore, a Buildroot configuration could be tainted from a package that uses +some custom external dependencies from the Buildroot tree. An example could be +a package manager for a software stack that downloads the required dependencies +during the building of a package. In such cases, Buildroot cannot check the +licensing of the downloaded software and thus giving accurate licensing +informations. +To check if your configuration is tainted, run: + +-------------------- +make check-tainted +-------------------- + Finally, keep in mind that the output of +make legal-info+ is based on declarative statements in each of the packages recipes. The Buildroot developers try to do their best to keep those declarative statements as From patchwork Wed Sep 5 22:00:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Angelo Compagnucci X-Patchwork-Id: 966703 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="JxpvKt8x"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 425Hh54plrz9sCq for ; Thu, 6 Sep 2018 08:00:37 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 534A887746; Wed, 5 Sep 2018 22:00:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Rt7kS9pwA1B2; Wed, 5 Sep 2018 22:00:34 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id CF5F18786F; Wed, 5 Sep 2018 22:00:34 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 473FE1C2D27 for ; Wed, 5 Sep 2018 22:00:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 44376887C5 for ; Wed, 5 Sep 2018 22:00:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LcyPcN4zSRrE for ; Wed, 5 Sep 2018 22:00:32 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by whitealder.osuosl.org (Postfix) with ESMTPS id 3FD3388731 for ; Wed, 5 Sep 2018 22:00:32 +0000 (UTC) Received: by mail-wm0-f51.google.com with SMTP id o18-v6so9256675wmc.0 for ; Wed, 05 Sep 2018 15:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pxGvoUBlCIYpwmVLZusX7NR95JkJMDUqfqalHQ9MDWI=; b=JxpvKt8xB86hK7gSra7jUFBfUAbRxFkz9fHxnWqq4jJrpZnYqXqQCgMJUXZxltzF26 Y/XiB0M0t6iLYPrWTdTSjT8naNSIDoAMwwT7shiwIn20ZFJAx9N+Sv4XAjBW/VHNu2yC hvP6tiC46iiy0kVNwjCX1Q5ehflrI43aK+V4rZEuhxs8SRjOrZJxO3AeBjn8q2rd6P/p L1ExxcRqlhQzqjCCkFvTGY2bgP/K5h87ba6XZEfVShdN2p+n3Gf8oL8H0r56O3Tj848J VpTi3/T6jlwCYbJH2v9vTT7TejFvUuNkNvlhceHAGDDMaSFWCWAvTSMgLQ7GSAzdkg2e U1hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pxGvoUBlCIYpwmVLZusX7NR95JkJMDUqfqalHQ9MDWI=; b=ExlAMOTHd0iLwAGdHVgv/qfU08PsUcIcAjlGS17KUgWbFqPx/tJbbORQ9CzA1uUiul 3icy2yyLW6325wZGlbzMyzzTjVnyA/dgCIMmOGnkDQhq3NyQK/XabHy0252LFYnBhQqq RO2qGAqlCuAaK0Oj5h0Wq6OgDUl/yiOnlAypRa7pSG4oENZVfoCCzU5vxsPhJ1HW9S7a XY7HiPg1nLXZAvVpN8NEu3ZYzWukMyjPeYO1tOv908UFCd2aecGMU3rqosLSflLh5/fO 90Abi/DhJnTw/Sz9O95KIY8w0ivzmCX/MzIxyJwQ+cAHCFXuUFpjCEVHYpSNBoi/xF0E QQ7g== X-Gm-Message-State: APzg51DD6mIgAa5qg6eOSMPdszKBYXnA9eAtbsu0AHqjeM6qgrjIqc+3 K04s84jXRzKtp/OOYDq5ounyDj09 X-Google-Smtp-Source: ANB0Vda3av5bcmcnbmj5tjYM5hQSoVSjAUgHo++p30KtJKHET/rGfYoH13kztST3LestNRNlMUXjXQ== X-Received: by 2002:a1c:ef0f:: with SMTP id n15-v6mr221590wmh.116.1536184830622; Wed, 05 Sep 2018 15:00:30 -0700 (PDT) Received: from localhost.localdomain ([37.162.44.87]) by smtp.gmail.com with ESMTPSA id h82-v6sm3029168wme.11.2018.09.05.15.00.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 05 Sep 2018 15:00:29 -0700 (PDT) From: Angelo Compagnucci To: buildroot@buildroot.org Date: Thu, 6 Sep 2018 00:00:08 +0200 Message-Id: <1536184808-9085-4-git-send-email-angelo.compagnucci@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536184808-9085-1-git-send-email-angelo.compagnucci@gmail.com> References: <1536184808-9085-1-git-send-email-angelo.compagnucci@gmail.com> Subject: [Buildroot] [PATCH v4 3/3] package/nodejs: taint the build on external modules X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Angelo Compagnucci MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" This patch enables the tainting of the build when an external module is added. Signed-off-by: Angelo Compagnucci Signed-off-by: Angelo Compagnucci --- package/nodejs/nodejs.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk index e2c94ba..322a1ec 100644 --- a/package/nodejs/nodejs.mk +++ b/package/nodejs/nodejs.mk @@ -160,6 +160,7 @@ NPM = $(TARGET_CONFIGURE_OPTS) \ # We can only call NPM if there's something to install. # ifneq ($(NODEJS_MODULES_LIST),) +NODEJS_TAINTS = YES define NODEJS_INSTALL_MODULES # If you're having trouble with module installation, adding -d to the # npm install call below and setting npm_config_rollback=false can both