From patchwork Thu Aug 30 14:38:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florent Fourcot X-Patchwork-Id: 963911 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=wifirst.fr Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 421QL66Kv5z9s2P for ; Fri, 31 Aug 2018 00:46:38 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729973AbeH3StF (ORCPT ); Thu, 30 Aug 2018 14:49:05 -0400 Received: from fourcot.fr ([217.70.191.14]:51620 "EHLO olfflo.fourcot.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729391AbeH3StE (ORCPT ); Thu, 30 Aug 2018 14:49:04 -0400 From: Florent Fourcot To: netdev@vger.kernel.org Cc: Florent Fourcot Subject: [PATCH iproute2] tc/htb: remove unused variable Date: Thu, 30 Aug 2018 16:38:54 +0200 Message-Id: <20180830143854.24928-1-florent.fourcot@wifirst.fr> X-Mailer: git-send-email 2.11.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Since introduction of htb module, this variable has never been used. Signed-off-by: Florent Fourcot --- tc/q_htb.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/tc/q_htb.c b/tc/q_htb.c index b93d31d4..c8b2941d 100644 --- a/tc/q_htb.c +++ b/tc/q_htb.c @@ -109,7 +109,6 @@ static int htb_parse_opt(struct qdisc_util *qu, int argc, static int htb_parse_class_opt(struct qdisc_util *qu, int argc, char **argv, struct nlmsghdr *n, const char *dev) { - int ok = 0; struct tc_htb_opt opt = {}; __u32 rtab[256], ctab[256]; unsigned buffer = 0, cbuffer = 0; @@ -127,7 +126,6 @@ static int htb_parse_class_opt(struct qdisc_util *qu, int argc, char **argv, str if (get_u32(&opt.prio, *argv, 10)) { explain1("prio"); return -1; } - ok++; } else if (matches(*argv, "mtu") == 0) { NEXT_ARG(); if (get_u32(&mtu, *argv, 10)) { @@ -161,7 +159,6 @@ static int htb_parse_class_opt(struct qdisc_util *qu, int argc, char **argv, str explain1("buffer"); return -1; } - ok++; } else if (matches(*argv, "cburst") == 0 || strcmp(*argv, "cbuffer") == 0 || strcmp(*argv, "cmaxburst") == 0) { @@ -170,7 +167,6 @@ static int htb_parse_class_opt(struct qdisc_util *qu, int argc, char **argv, str explain1("cbuffer"); return -1; } - ok++; } else if (strcmp(*argv, "ceil") == 0) { NEXT_ARG(); if (ceil64) { @@ -186,7 +182,6 @@ static int htb_parse_class_opt(struct qdisc_util *qu, int argc, char **argv, str explain1("ceil"); return -1; } - ok++; } else if (strcmp(*argv, "rate") == 0) { NEXT_ARG(); if (rate64) { @@ -202,7 +197,6 @@ static int htb_parse_class_opt(struct qdisc_util *qu, int argc, char **argv, str explain1("rate"); return -1; } - ok++; } else if (strcmp(*argv, "help") == 0) { explain(); return -1; @@ -214,9 +208,6 @@ static int htb_parse_class_opt(struct qdisc_util *qu, int argc, char **argv, str argc--; argv++; } - /* if (!ok) - return 0;*/ - if (!rate64) { fprintf(stderr, "\"rate\" is required.\n"); return -1;