From patchwork Tue Aug 28 14:27:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Bader X-Patchwork-Id: 962975 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 420B113vQFz9rvt for ; Wed, 29 Aug 2018 00:27:33 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728329AbeH1ST0 (ORCPT ); Tue, 28 Aug 2018 14:19:26 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:52962 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727950AbeH1STZ (ORCPT ); Tue, 28 Aug 2018 14:19:25 -0400 Received: from 1.general.smb.uk.vpn ([10.172.193.28] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1fuext-0002Hu-RG; Tue, 28 Aug 2018 14:27:29 +0000 From: Stefan Bader To: netdev@vger.kernel.org Cc: Stephen Hemminger , Luca , Christian Ehrhardt Subject: [PATCH] iprule: Fix destination prefix output Date: Tue, 28 Aug 2018 16:27:29 +0200 Message-Id: <1535466449-24190-1-git-send-email-stefan.bader@canonical.com> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When adding support for JSON output the new code for printing the destination prefix adds a stray blank character before the bitmask. This causes some user-space parsing to fail. Current output: ...: from x.x.x.x/l to y.y.y.y /l Previous output: ...: from x.x.x.x/l to y.y.y.y/l Fixes: 0dd4ccc5 "iprule: add json support" Signed-off-by: Stefan Bader Acked-by: Luca Boccassi --- ip/iprule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iprule.c b/ip/iprule.c index 8b94214..744d6d8 100644 --- a/ip/iprule.c +++ b/ip/iprule.c @@ -239,7 +239,7 @@ int print_rule(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg) print_string(PRINT_FP, NULL, "to ", NULL); print_color_string(PRINT_ANY, ifa_family_color(frh->family), - "dst", "%s ", dst); + "dst", "%s", dst); if (frh->dst_len != host_len) print_uint(PRINT_ANY, "dstlen", "/%u ", frh->dst_len); else