From patchwork Fri Aug 10 06:58:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 956019 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=synaptics.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Synaptics.onmicrosoft.com header.i=@Synaptics.onmicrosoft.com header.b="EawaHYOJ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41mwzk6r8Gz9s4Z for ; Fri, 10 Aug 2018 17:02:26 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727408AbeHJJay (ORCPT ); Fri, 10 Aug 2018 05:30:54 -0400 Received: from mail-cys01nam02on0079.outbound.protection.outlook.com ([104.47.37.79]:16738 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725746AbeHJJay (ORCPT ); Fri, 10 Aug 2018 05:30:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Synaptics.onmicrosoft.com; s=selector1-synaptics-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=49XGrwfcyqiezRCPcn/o3+Q1DWki9s+FhOIvS2n/yaM=; b=EawaHYOJG/1wCJlJuB9I8sl0yWohC21a+y2Im5MmykWGy9X/FvMioyoAAYFVe7UePjPs6wRFkGddFbqWPE7WsJQPSDaUauEHHa/1FPMEVXsfwNhvz6hR/b8TAW1ohhiwgN++EKIx23gOdFbKBs34exaiP7pk++OQwHYRBEZAW74= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jisheng.Zhang@synaptics.com; Received: from xhacker.debian (124.74.246.114) by SN1PR0301MB1584.namprd03.prod.outlook.com (2a01:111:e400:5232::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.18; Fri, 10 Aug 2018 07:02:16 +0000 Date: Fri, 10 Aug 2018 14:58:28 +0800 From: Jisheng Zhang To: Gregory CLEMENT , Andrew Lunn , Yelena Krivosheev , "David S. Miller" , Thomas Petazzoni Cc: Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Marcin Wojtas , netdev@vger.kernel.org Subject: [query] about recent mvneta patches Message-ID: <20180810145828.6d05b776@xhacker.debian> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Originating-IP: [124.74.246.114] X-ClientProxiedBy: TY2PR06CA0026.apcprd06.prod.outlook.com (2603:1096:404:2e::14) To SN1PR0301MB1584.namprd03.prod.outlook.com (2a01:111:e400:5232::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88527362-c0b2-434c-b458-08d5fe8f3681 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN1PR0301MB1584; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB1584; 3:5+AuRxqk3iYfjfkt9ARkgWWj2fIL8RFrdm/zMR9kUE3DyNczQZwKwnjciCzwkRd4cbdP2eClifJ+Tg3AzlL9kIfxrIqM5pgKFAc/T4JszN67Y+LORa59ipY6xDvO+xzvNtublDA7fClVcH3KZZ9czJD9uCV9ZpQlqJhKd/tTAd4N+RzBSILIbJGHD7+Nuw2lGDlJLSXTQyQi9AlFyln97K5zZiylJVdSm16UI2+k/FGBkN+rXNtL9bDuMrrPgTXb; 25:ac5tghXqIooO6A3GhTgdUvJdsuk1Z49dZJw8HPEcPefL5b+y2VnBlQIlFII11X8PKkOS/JXW2rjN4jrTTdcu0EHgFTB3ka0gS8arBrkMklQvvAeXPu7XAusKXfSR4jvPzkorvGjDp3x/azuujgkUa6wjlpMtjn55xpmjuaUXDnb5Cs+UsbokboEbK7tFCv1NQkX7dclWaIMG1+aJ82B5+XHDe3yfl5Xqu0okmg8YvGj5A4jINvbkKLZaxq8KhXCp9KyruufPBP5F6+DE9tGohaWdBDqeQMuobrTo9ZahHMyemXFzylI0cytKCXjM2QJ6vj4//iJ5L4hRC57iYUzF+A==; 31:wTjanh7QB5YMBJY0Mb4MtuGRGJFlwpdi0IH0bQHFRsm7uAXuXTSGjLumzfQXnpeWN+hUPgUDaT3qMD3T+BX3KB3fC7Z8aDlGUApWhUEr5BCtrKIGl9yuc+uP7sk+7RxEAy9/acPmBrBlKb/dOofDbHYy44hbu+sHM8K/TrpJQK3nR8FqTslf0Y6HpODDG/Epaqbw1r+n3jbGLzUGS319VfI10/zSLVPpENGZkT/9pj8= X-MS-TrafficTypeDiagnostic: SN1PR0301MB1584: X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB1584; 20:jJMnZYq5DlaaaLEADfzbhleEHuh9H6gL5j1kiQb9uxWU0XCWWvBrXrv0076t9sGVBNkujy0RNB7mRedROK98gH9/a04C0HO8ctj2GsTGpRowkMWRc7++jFfbqm3qHn69rxSrdJ01qJmnRRH4W17L5iw5ECnPTIuDy34hnBidVJz67XcYRTIBAyKQVhepcGOmalfrjYc2E1nufHv71QS4ycAWlrK93bGe7PJsXsk/ZA13u8fDhmVkTojaK0w3/v6+CcbTxTGkl9J7qsMZlxGWwIAyX7YGjag1XnIXHw/j8kmmrU4mWoYBykH2SFMTj34rTV3yNrd8E6hB2lMN5es5wdoRG14LmDXlhs+tVjFr8SGgV93wS9seBE0KVtNahCFNqvJCaEclqzCNubsLiWCk1hy4vb7q2d+E79f2t+pdB4cwaz2XDb5CohTPxrjLdjypqGRzp2JQrFnaIKZhyONu4E6cwCVsq85vxjokNQ1BWQfAyiWtzB7AFt8DJQk71Pzz; 4:8i3j5G/Jec4HfJXnGhreQ7Z5cpegiXHkxYW/ze6u9vaj6JBPbocyb1ZM+ckknBXi8CtizzolA5wbt+iFCUc+3Oc//1KgttuChCwEpoQxna1spcJ05Yv/IfruG4ko5VeIxlOWt4ChSkbWaH1mq83UxT4yCCbSPBPVyRjMX58CM59YFB1iKowkdG5OJnhD662LBA2ld69R1Das8ndrMgIbYbFqtKMf5u7pgMXqWEnU2Ql68BCAd/g4i3qW00XFKLZPeFRuhWv67fobOjIBoiflmQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:SN1PR0301MB1584; BCL:0; PCL:0; RULEID:; SRVR:SN1PR0301MB1584; X-Forefront-PRVS: 07607ED19A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(136003)(376002)(39860400002)(366004)(396003)(199004)(189003)(105586002)(5660300001)(316002)(6666003)(54906003)(50466002)(39060400002)(25786009)(110136005)(4326008)(478600001)(106356001)(72206003)(97736004)(53936002)(81156014)(55016002)(9686003)(2906002)(50226002)(81166006)(305945005)(230700001)(66066001)(14444005)(68736007)(7696005)(486006)(186003)(6506007)(52116002)(8676002)(386003)(476003)(16526019)(33896004)(26005)(956004)(8936002)(86362001)(23726003)(1076002)(1857600001)(7736002)(47776003)(6116002)(3846002)(39210200001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0301MB1584; H:xhacker.debian; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: synaptics.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB1584; 23:gxWQ7HfOsA4kl5moTnhzwXe2UMESNdO0uzJyC+IUkg9JEjk1XvtvsAPT1TRs6xw9IDeK4MffRK8k1NmEotcls4+yygCiPrqwjtWfj5YRkwILAbEZ6cNCFJh/gUvdeZh/UssH4URigMXjmZdKmN8Brmo3pcRdi1gTEhffZdBg3VDJpsmEw8wSEyEuOFfUPGO+p+6nh1Hkhx4R47JsShzLU7sfsveJ8qdYHLuaVV+WuOmWSksdkhmJFCIugmjLimFc3NeINYPUezgnCW4R5sgPeZ7ZiMif0E/7fp+iGG1x3vEG7T3iLJxlHfRF4OjFGO18C+Z3/8IE0oZLm6PG+t5Vvl3SBGpMPxXtSMgGZ3N/VHX2aCjq+mPY3omYomrMrvVuvzBRp6L2B1rpkO1hsvY5bBqcC7PnsF+LG8lrAkFPpy7rJ1cXNbD3HgvgW0PGCSxpjT0TkxhZl5XzPp00DEeDXEEUHxW5VdthUR+gYRNN/nLN6Ta/0yq6kL7ZBEEVvvQV25bJjHQn9eB0YD9jtGjGMCr+FkMQdqHwB+dEIG1uXPKc6BtcQ5ywWaLRE4muSc2cznefsfAHzAaZulZhSbLuvToOlZpTJuJELATjvF9jR7lwswwK8XhWWjhUsXjNAo63u7d8Ug6s+6C6vbZ5ZXfo/g2YZe8muV73g0BnWQxfE91G7Vy0XU2i7eFU75tizMPN73MfQNGwG7FcZxFo4Imq5BjBs0kHWeqZEzR87+74EBLATAZYjn9iGf0xzR8cCQMrZ22jctTHhETIoflzY/lpwP/cm7k2Wi13h1C9TVtxglvnrmAp2a82FfdFuZ8P+0XS4tFGoOS+6t6+9b0mTxmuU73ClsfMdMVOZk5vVfHD/+b8bhx5pSzKgDxBNWmPoA8GboOSiQiyKtiAO25BhMjLVs742Od+gAkmvzwS49FaqwMLA/2K8G6TokFYCgmq4XnRs373D4IDerQsEVR3wpUHoplWob/4kYWyPQVYpUdow89fwwivQ3r3e8Ov+BAMfIDFUp6PFlfRKZwl+HOXgLfwInF7QKCIKN5PSatWfYfnHImvaNwCwdyjTjFklJeYdhfRz9FV6TD5oZMAKYHd4h1rlM/ikjw2bgWfs0kBKm/tXSpKPtJEw9DppIuvsilZzrpwvjW5HrPg5TtrjRsOVqhhj1UZxBpnb1mEINT/V3zrQoYuGZO9HABQoR6zsXqmZn2CB/NBxDO71Dpm//Nxg0FHDzmR+IlMibHkKI0WiEaDSgQ= X-Microsoft-Antispam-Message-Info: 4s3ik2A0eNaqUjwM1f41cPINUU+6SOXV5EZTTS+xeQIdQlLNY+DyxRMTUXPYPDYzPlSZhyuAEdAHiQJyoORi7jTMYNqZ950jDXoRm1MgBi1/D6pdeANfltHGBqpsuZtGXlcOg+bIYa1sgucX1yJoyI+ZGuJpXTO9eW1OdVg6pmujp55jmVt9HPkxpBg5Co+EVAJ0nLma9BfLSIz16FnFz3trmm3FeoUpr8WW68m75TYXGO3A8QQesQKrJmhGMa0fSVqMXBJlwP2Qu3OuzMLkuHXbIbBkUi1r4PVfTx1iMknVJs5nQ0h79HOJufkLhZaB/BsC5RQQI4oTq38kJPlh49oinSTSKGEhSf89QRJpEvc= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB1584; 6:zYXnXcJeHMSCFdmIoaN6RoxQtYuFBCaEPo4DDgRoue5wflwDOmc7RtbLN81rJKKqTgHY7SvtbqQHzg79GTP10CKf5sTlKx7F8p06r+euiegyYlVp6oPxP2CN0S92N+RhI/aFCKb31cvk4dgIsTg6PMUiHgbVxMQFMenC1e7mPL8XX0A3zeHjfwVyK7VPyAak38wnMJZLNbSjVjUddWe8TFKdu2Mmr6Z1Hd6scP3MkZXM25Vy6b0EcVH9vM6lZ/uC+10cFeWnR3EdIloH9K9JOO+jrdboemHSpZEvTLFTKqczaF/iKcP7/HtW8PGRdfEEewCLnSHR/LphSYO+j9PXccGFtgGGsTBHnUQwv63/HKaqUujCgmtGhKZQJIJZU3oC/E130x8RvK56pbmzFafYvFspKsHbEcCdnvHhgwm6R6AV2z9lKLDqkFeNq+9uXDnYfX+Mng4iHQCfJPZQKOgRlg==; 5:42tmsF97ka/NPU+bh4MgKJkd5XD9xQ+qiQv+dl2I9jAkBC28Gs/w4GFkkBfWuKaqXgCSjb5snRBDdoa1tONQzqfa8tvnH2eWk5eaQshlvpJzBQv3MMJ9KV0AQRfSX453BfcmM3bYc6UVz9abHnT4KA8BHjIMkq3lYw/dOsvVSu0=; 7:8q+NNZP5v3Xd3jT1aT0A+NLyBcDibTqviWdgLxyu35oxBgQhV5QyavFz5oamROV9XmFUBpCQEJTdXe6JlO77lBXIFg4R+sB0rfevcPOdybDqzLMd2/PL88cP8i/EgDSnJhjCcIagMd8Hf+HqNlzs1YP292pwOzjZRMlY+rzhzZlCD9ZGWNpdZOuGn7wdH7MS3hyhC1HDZ0eTUObeUuz6gqBD4WP0QHHLW2zi15aCifoqRGIkSpuoEIPljL/xDY3J SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2018 07:02:16.7912 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88527362-c0b2-434c-b458-08d5fe8f3681 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB1584 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, Today I have a look at recent mvneta patches in net-next, I worried two patches: 1. commit 562e2f467e71 ("net: mvneta: Improve the buffer allocation method for SWBM") sets rx_offset_correction as 0 for SW BM, but IIRC, the offset is introduced to support 64bit platforms. So in theory the commit could break arm64 platforms with mvneta SW BM. Fortunately, commit d93277b9839b ("Revert "arm64: Increase the max granular size") makes arm64 L1_CACHE_BYTES equal to 64 again, thus NET_SKB_PAD is 64 too, so the commit 562e2f467e71 doesn't introduce regression, but it hides the bug we tried to fix in commit 8d5047cf9ca ("net: mvneta: Convert to be 64 bits compatible) IMHO, this patch need to be updated to not introduce regression even the L1_CACHE_BYTES is larger than 64B, what do you think? 2. commit f945cec88cb ("net: mvneta: Verify hardware checksum only when offload checksum feature is set"), I agree with the point. But MVNETA_RX_CSUM_WITH_PSEUDO_HDR bit is always set, so the RX CSUM is always generated no matter we set NETIF_F_RXCSUM or not, so IMHO, we should always set NETIF_F_RXCSUM. And since we enabled GRO, so what about something as below: diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index bc80a678abc3..a5043b27bf37 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -4598,7 +4598,8 @@ static int mvneta_probe(struct platform_device *pdev) } } - dev->features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | NETIF_F_TSO; + dev->features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | + NETIF_F_RXCSUM | NETIF_F_TSO | NETIF_F_GRO; dev->hw_features |= dev->features; dev->vlan_features |= dev->features; dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;