From patchwork Sat Jul 28 13:30:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 950484 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-94899-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="LPqvKAh/"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41d6DB1RMvz9ryt for ; Sat, 28 Jul 2018 23:31:05 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id; q=dns; s= default; b=d00JJgC8ZDuE8sUEvJcIUbug7U8dhaUlOef5gAoXBQfsDZcyDkefl 6NOK18Rmp8btI3IiTujNAWAMVecMKaTa0CYkKt/DTClibtRj9ugn4xWX6BwG6ua8 duxMKLvzClvoFexsD76VnzXkgtmdt3WMkBWC5f4JqvguWbC46xsreA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id; s=default; bh=6q9uVygUTHKf1YW1QlhCDrhzcbM=; b=LPqvKAh/FZkvbk8VBTOYMv+Qm/3m tLiqrFRgG14xjrKLX9QcsgROSbww1bAEoOM4w2IR01S0IRn7SRwvDrbWCdDPH0fg EcR8hvoIRLQ+Jx+5G7d2FkSkJ5NHszyghs0kVwrdEn2sSPa4sbxNpRgYM3hLVDAb e/BdEvdsa7TNtu8= Received: (qmail 33144 invoked by alias); 28 Jul 2018 13:30:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 31926 invoked by uid 89); 28 Jul 2018 13:30:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL autolearn=ham version=3.3.2 spammy=Hx-languages-length:2489, 2017-2018, 20172018 X-HELO: hera.aquilenet.fr From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault Subject: [hurd,commited] hurd: Fix some ld.so symbol override from libc Date: Sat, 28 Jul 2018 15:30:10 +0200 Message-Id: <20180728133010.28445-1-samuel.thibault@ens-lyon.org> ld.so symbols to be overriden by libc need to be extern to really get overriden. * sysdeps/mach/hurd/not-errno.h: New file. * sysdeps/mach/hurd/i386/localplt.data: Update accordingly. --- ChangeLog | 1 + sysdeps/mach/hurd/i386/localplt.data | 2 +- sysdeps/mach/hurd/not-errno.h | 21 +++++++++++++++++++++ 3 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 sysdeps/mach/hurd/not-errno.h diff --git a/ChangeLog b/ChangeLog index 5885a61901..5f82d00b69 100644 --- a/ChangeLog +++ b/ChangeLog @@ -2,6 +2,7 @@ * sysdeps/mach/hurd/dl-unistd.h (__access, __brk, __lseek, __read, __sbrk): Do not set attribute_hidden. + * sysdeps/mach/hurd/not-errno.h: New file. * sysdeps/mach/hurd/i386/ld.abilist: Update accordingly. * sysdeps/mach/hurd/i386/localplt.data: Update accordingly. diff --git a/sysdeps/mach/hurd/i386/localplt.data b/sysdeps/mach/hurd/i386/localplt.data index 78f8c877c6..a5b5241b84 100644 --- a/sysdeps/mach/hurd/i386/localplt.data +++ b/sysdeps/mach/hurd/i386/localplt.data @@ -33,7 +33,7 @@ ld.so: __mmap ld.so: __fxstat64 ld.so: __xstat64 #ld.so: __access -#ld.so: __access_noerrno +ld.so: __access_noerrno ld.so: __getpid #ld.so: __getcwd ld.so: __sbrk diff --git a/sysdeps/mach/hurd/not-errno.h b/sysdeps/mach/hurd/not-errno.h new file mode 100644 index 0000000000..838a5abc69 --- /dev/null +++ b/sysdeps/mach/hurd/not-errno.h @@ -0,0 +1,21 @@ +/* Syscall wrapper that do not set errno. Generic version. + Copyright (C) 2017-2018 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +/* The __access_noerrno stub mustn't be hidden in ld.so on Hurd since it needs + to be preempted by __access_noerrno from libc.so after bootstrap. */ +extern __typeof (__access) __access_noerrno;