From patchwork Fri Jul 27 09:31:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 950063 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="TUbKMExv"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41cNyY3jkkz9s0R for ; Fri, 27 Jul 2018 19:31:49 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730340AbeG0Kwp (ORCPT ); Fri, 27 Jul 2018 06:52:45 -0400 Received: from mail-pl0-f67.google.com ([209.85.160.67]:37579 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbeG0Kwp (ORCPT ); Fri, 27 Jul 2018 06:52:45 -0400 Received: by mail-pl0-f67.google.com with SMTP id 31-v6so2088563plc.4; Fri, 27 Jul 2018 02:31:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=U2bUIY3jlZNqRQT7LBCuDAObxV24OjoUZQ6VoM6FH/M=; b=TUbKMExvB3PzUOI4/JEYUW9LtrXSDaxJ34XGmxBEsL3L+NSDwChs4m4gRh8yT4qG9s EwNvpJLXpdtlQGHzaGc3dd8+lnekXBPUSHApFcqWa0VM9TpQIJPKdfkDmL+p+i+qYE9B e6oA0ga7SOB8qZ8MRdfrGJvJAhUD7t1+N7MlYjJDvHFRqObKOhQPgvyV9hmBXzjYGuDw /C08E5/HOL8zvafDh35yU5bcpN7wyiBJ0xP/WFUsnDyFH5X9DZYyJtFkEZBAR1zRw82G oPCtUUINh0rArZBK1wGrH7YYuXBW54aIoYHbvVPPO7dxePlIh/o/jZq6A1EydjBKjjwU f9Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=U2bUIY3jlZNqRQT7LBCuDAObxV24OjoUZQ6VoM6FH/M=; b=BdIDBC/dLbatnNpJ2l3IMJ2RyYN2wHwxbgc7+mkjhHH+VrkwA9mZ9AvxhuqZiZRs7h +ZAA8QIodxBBo3ipTHwtZE0JiEe8E+fqv+X9hugaxSiUYDYm+EwufWzUxc3Jk946l/3P CAZUeC/0RMXqpgwkS68W/WOdyXQABDqi3669scK1s6pM2l7TkAV06RoOd0ikYVjS+B1x kC/urwrghSkWGXKjZilvMGVZd3zkXGpVzAd5pyHNyGcWcqITbPS6PR+r1r2E5V+FkLWV +GPf0e3Ix/wP4IQeumMKcOfguLqkCTyXhSTkDBZtjC7xafZFUGIeB8hJQVRQLjQ9h85I qzlw== X-Gm-Message-State: AOUpUlEu/vS9AWNU2tUcp/sTD7vGoOg8PBoPjFfuz4kqa+b3XeEFvBz2 F09KSatJY1t669Y3pZq/vUE= X-Google-Smtp-Source: AAOMgpfpnAX+HAj90pZ3c+AGL6lCUtOfL1ya8iw4MuITTP/GHRHWB3JuZuj9nkzSa0bYQJTjQ8S1RQ== X-Received: by 2002:a17:902:6a83:: with SMTP id n3-v6mr5321171plk.246.1532683903086; Fri, 27 Jul 2018 02:31:43 -0700 (PDT) Received: from localhost.localdomain ([2402:f000:1:4414:8ca7:1cde:b1e6:2647]) by smtp.gmail.com with ESMTPSA id n18-v6sm9331893pfa.50.2018.07.27.02.31.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Jul 2018 02:31:42 -0700 (PDT) From: Jia-Ju Bai To: jon.maloy@ericsson.com, ying.xue@windriver.com, davem@davemloft.net Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] net: tipc: bcast: Replace GFP_ATOMIC with GFP_KERNEL in tipc_bcast_init() Date: Fri, 27 Jul 2018 17:31:35 +0800 Message-Id: <20180727093135.7469-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org tipc_bcast_init() is never called in atomic context. It calls kzalloc() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai --- net/tipc/bcast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index f3711176be45..9ee6cfea56dd 100644 --- a/net/tipc/bcast.c +++ b/net/tipc/bcast.c @@ -512,7 +512,7 @@ int tipc_bcast_init(struct net *net) struct tipc_bc_base *bb = NULL; struct tipc_link *l = NULL; - bb = kzalloc(sizeof(*bb), GFP_ATOMIC); + bb = kzalloc(sizeof(*bb), GFP_KERNEL); if (!bb) goto enomem; tn->bcbase = bb;