From patchwork Fri Jul 27 08:25:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 950040 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FoS9EI8P"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41cMTz3vDKz9s0n for ; Fri, 27 Jul 2018 18:25:27 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729519AbeG0JqC (ORCPT ); Fri, 27 Jul 2018 05:46:02 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:34716 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729445AbeG0JqC (ORCPT ); Fri, 27 Jul 2018 05:46:02 -0400 Received: by mail-pg1-f193.google.com with SMTP id y5-v6so2816826pgv.1; Fri, 27 Jul 2018 01:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=3jlmpDi3pSMTdz6KTum7rjiXC4zJCibhSFCAK3K7xuA=; b=FoS9EI8P/dpjTwRRG3tWmdxp9FMxfpMY5tbSqVH1NGyRo44jSNxd7gJGfsBywD2gui gFhdRV3DBy2Vn+ySA8LHMxYozqfXO8TjiZZI2kYzAnpHnil+nymCbzdqbWaNDMkB4jtf a+vrwl7KpkyNGrT97YrqfEAYMnLIc0Q4ExX2gnWUAuPYPvqR8xuYaqRofkNfKuUHJAjA 5ngXC7a+O/tBZb8IIbJiGZ1aF6UpqxvPdlD7Ewo9rApzsnWkd9dA+DsF/ltihi7lp8bK SAO2sINNGLoXbioknJ/IDpsesXfc932RN+i9Q2QRHzBSCY84t1gImP1m85HObmq9Xa2T mhWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=3jlmpDi3pSMTdz6KTum7rjiXC4zJCibhSFCAK3K7xuA=; b=pOw3+3QxQ7nPt+XWLk5DYzXHt8w4ppDQVnJhTHWAaD8EMc4kaNViZf7692Z40MrkIx 0ecDo9e0x1h9Lo1QPZYTpbtVyiNiNr/40Kjk7237RAULPbiTSoMtI34VtUD5tjFlThNa rXh5qeSCEQ3saRQ/LAkFRWeZth8wYeHS4r+m68aQmsVZ75evpeikoTNgv8CTagodSHuJ kntAeKqk8HPujEfzKqLW7i78hfeQZ5jEPvQgKYAZSAKNckpm0yHthjH2kDzWRzG8A42b 64jBrY9c2SP9gcZk0sH4XJjDyh1TzhMqJaDfG0UVV3Rq9MZOvzqSm4rpagnCgfQHCDq+ QdlQ== X-Gm-Message-State: AOUpUlEKhMBvlSjj8uqeIGodrHCwSVSmRPHT4xVeBGGZdONAHVfkMLhA eldqJ/5nbkDpTd8Tq75Afmg= X-Google-Smtp-Source: AAOMgpdxti9L0mA1jgjIBHUysp8LTHZd8nYuJXLp8fwteytxnTEIptL+zMMNiGNE2zIIoJj1/9/pkQ== X-Received: by 2002:a63:ed56:: with SMTP id m22-v6mr5178830pgk.148.1532679915463; Fri, 27 Jul 2018 01:25:15 -0700 (PDT) Received: from localhost.localdomain ([2402:f000:1:4414:6c14:7712:e625:1be4]) by smtp.gmail.com with ESMTPSA id v7-v6sm5060830pgh.57.2018.07.27.01.25.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Jul 2018 01:25:15 -0700 (PDT) From: Jia-Ju Bai To: cooldavid@cooldavid.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] net: jme: Replace mdelay() with msleep() and usleep_range() in jme_wait_link() Date: Fri, 27 Jul 2018 16:25:07 +0800 Message-Id: <20180727082507.3917-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org jme_wait_link() is never called in atomic context. It calls mdelay() to busily wait, which is not necessary. mdelay() can be replaced with msleep() and usleep_range(). This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai --- drivers/net/ethernet/jme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c index 8a165842fa85..de5ed09212b0 100644 --- a/drivers/net/ethernet/jme.c +++ b/drivers/net/ethernet/jme.c @@ -1909,10 +1909,10 @@ jme_wait_link(struct jme_adapter *jme) { u32 phylink, to = JME_WAIT_LINK_TIME; - mdelay(1000); + msleep(1000); phylink = jme_linkstat_from_phy(jme); while (!(phylink & PHY_LINK_UP) && (to -= 10) > 0) { - mdelay(10); + usleep_range(10000, 11000); phylink = jme_linkstat_from_phy(jme); } }