From patchwork Fri Jul 27 02:41:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 949968 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Gx4p44DH"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41cCrz4czzz9s1x for ; Fri, 27 Jul 2018 12:41:23 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725828AbeG0EAz (ORCPT ); Fri, 27 Jul 2018 00:00:55 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:46211 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725778AbeG0EAy (ORCPT ); Fri, 27 Jul 2018 00:00:54 -0400 Received: by mail-pf1-f194.google.com with SMTP id u24-v6so1207253pfn.13; Thu, 26 Jul 2018 19:41:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=lhLdPSEjtof4PARL+jbQIELKrc8oApgcCwcTjMgi6lY=; b=Gx4p44DHIITEfz0JssWbN9Ri2R4PqAW4PQPfpRs9qLzFwmCVsJ2mrRxk3ei7aYJJuS /PHmnBiuqywk5SRxSNsnz7CC7VWW1atACA6bC8nspjwC/Z8xJ1Eyb60bNy8IPx7gjli3 K3Vvnle7tNt+fZhnfHWagFr+HmDzeOI4BtS5fZ/JE7pXtTIZ6mYVNjNvzGFb3s5kB9is eGwIxFiSb3Ce7SU8dj4In9c7qiJDKX0YRJQUJ87Lwr5fsYU0wzWGMFdNKoc3DkpIWmcu zJPttklfSCE8RcuUVwL9s+QBhxgukS86vsIOoj5cA56UkqksPs3ddr+/tsfrO92dzQvX tDHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=lhLdPSEjtof4PARL+jbQIELKrc8oApgcCwcTjMgi6lY=; b=o06lP1jv3vqa7wdsI9AtTTDsLeLxpm/Ei+XWdCuSXUjWAkINiticP1hcK4myaCTWvY O2l+BCyiCrbAkC9iWw6FkSvL5riKlc5xWe9a9p221GFQ38fnFj+DzRtV9acy2o28kQwm W8q/gUvFT83YnL9SuzMfdJKmqIYn5j2Ph98c9wiL2z01DwwAR2JD8tZBIKsvqNdBOZfw lxF8W/DNhfOsXeGopQz63yEWyMfLGc63lKf3T+wqzQrStz3hT/qSayLqBBt7aCgNcHCL TxXjmz+7tlLgAbS2TK5Qv0TM7HkMqHw4vuYjaN2huZefFnFiZITEvMhnHkxtrbpGXtGx 6Lcw== X-Gm-Message-State: AOUpUlFPl07+K/q8DawUvPsTBbwHrP9RBbRlow0kPKpXdYu63q3YgzV0 GffWz4N7dc5unfbwyTbvi3Yn2YrB X-Google-Smtp-Source: AAOMgpe/WYr5W2ukDvh70MikeNOYSKto94ZgAWUoLfIlULEjdMw2Jo3qiCXVnJgFXTes1XIxcqhInw== X-Received: by 2002:a62:4695:: with SMTP id o21-v6mr4655827pfi.176.1532659277361; Thu, 26 Jul 2018 19:41:17 -0700 (PDT) Received: from localhost.localdomain ([2402:f000:1:4414:6c14:7712:e625:1be4]) by smtp.gmail.com with ESMTPSA id c88-v6sm4257552pfe.132.2018.07.26.19.41.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jul 2018 19:41:16 -0700 (PDT) From: Jia-Ju Bai To: isdn@linux-pingi.de, keescook@chromium.org, jeyu@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] isdn: mISDN: netjet: Replace GFP_ATOMIC with GFP_KERNEL in nj_probe() Date: Fri, 27 Jul 2018 10:41:09 +0800 Message-Id: <20180727024109.1702-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org nj_probe() is never called in atomic context. It calls kzalloc() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai --- drivers/isdn/hardware/mISDN/netjet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hardware/mISDN/netjet.c b/drivers/isdn/hardware/mISDN/netjet.c index 89d9ba8ed535..2b317cb63d06 100644 --- a/drivers/isdn/hardware/mISDN/netjet.c +++ b/drivers/isdn/hardware/mISDN/netjet.c @@ -1084,7 +1084,7 @@ nj_probe(struct pci_dev *pdev, const struct pci_device_id *ent) return -ENODEV; } - card = kzalloc(sizeof(struct tiger_hw), GFP_ATOMIC); + card = kzalloc(sizeof(struct tiger_hw), GFP_KERNEL); if (!card) { pr_info("No kmem for Netjet\n"); return err;