From patchwork Thu Sep 28 21:36:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalyan Kinthada X-Patchwork-Id: 819747 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="wXkQk6oo"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3y37Km3D9Gz9s7f for ; Fri, 29 Sep 2017 07:36:12 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751816AbdI1VgK (ORCPT ); Thu, 28 Sep 2017 17:36:10 -0400 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:54562 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751485AbdI1VgJ (ORCPT ); Thu, 28 Sep 2017 17:36:09 -0400 Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 05BC68365F; Fri, 29 Sep 2017 10:36:07 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail; t=1506634567; bh=InaAEPHoi0Gb63PKTS6zupqlQd8KD987LtG/Dq/ZpYE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=wXkQk6ooMV+6sDmAAK+IjtcQWcl43ot70V2MSBhPUDZeSvwokTfKvC5U3lIiR8hnK YRAd53bLamb9OP6Y2JitxSIDCzht6Hx+aw8zxOlzC5Hj8VbX4Sgcz5KhgOldjJW8gQ 5+kMGHaA8tJ2iK5uV/4H805rA9XJJcDorxhnQr/Y= Received: from smtp (Not Verified[10.32.16.33]) by mmarshal3.atlnz.lc with Trustwave SEG (v7, 5, 8, 10121) id ; Fri, 29 Sep 2017 10:36:05 +1300 Received: from kalyank-dl.ws.atlnz.lc (kalyank-dl.ws.atlnz.lc [10.33.14.14]) by smtp (Postfix) with ESMTP id 5ADCB13EFA0; Fri, 29 Sep 2017 10:36:18 +1300 (NZDT) Received: by kalyank-dl.ws.atlnz.lc (Postfix, from userid 1628) id C2CA5C045C; Fri, 29 Sep 2017 10:36:06 +1300 (NZDT) From: Kalyan Kinthada To: jason@lakedaemon.net, andrew@lunn.ch, gregory.clement@free-electrons.com, sebastian.hesselbarth@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, wsa@the-dreams.de, devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Chris Packham , Kalyan Kinthada Subject: [PATCH v2 1/2] ARM: dts: Fix I2C repeated start issue on Armada-38x Date: Fri, 29 Sep 2017 10:36:04 +1300 Message-Id: <20170928213605.22874-2-kalyan.kinthada@alliedtelesis.co.nz> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170928213605.22874-1-kalyan.kinthada@alliedtelesis.co.nz> References: <20170928213605.22874-1-kalyan.kinthada@alliedtelesis.co.nz> Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org All the Armada 38x(380, 385, 388) have a silicon issue in the I2C controller which violates the I2C repeated start timing (errata FE-8471889). i2c-mv64xxx driver handles this errata based on the compatible string "marvell,mv78230-a0-i2c". This patch activates the "marvell,mv78230-a0-i2c" compatible string for the I2C controller on armada-38x SoC based devices. Signed-off-by: Kalyan Kinthada --- arch/arm/boot/dts/armada-38x.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi index 7ff0811e61db..4960722aab32 100644 --- a/arch/arm/boot/dts/armada-38x.dtsi +++ b/arch/arm/boot/dts/armada-38x.dtsi @@ -178,7 +178,7 @@ }; i2c0: i2c@11000 { - compatible = "marvell,mv64xxx-i2c"; + compatible = "marvell,mv78230-a0-i2c", "marvell,mv64xxx-i2c"; reg = <0x11000 0x20>; #address-cells = <1>; #size-cells = <0>; @@ -189,7 +189,7 @@ }; i2c1: i2c@11100 { - compatible = "marvell,mv64xxx-i2c"; + compatible = "marvell,mv78230-a0-i2c", "marvell,mv64xxx-i2c"; reg = <0x11100 0x20>; #address-cells = <1>; #size-cells = <0>; From patchwork Thu Sep 28 21:36:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalyan Kinthada X-Patchwork-Id: 819749 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="svYoLnbq"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3y37LH4DMsz9s7f for ; Fri, 29 Sep 2017 07:36:39 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751438AbdI1VgM (ORCPT ); Thu, 28 Sep 2017 17:36:12 -0400 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:54569 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbdI1VgJ (ORCPT ); Thu, 28 Sep 2017 17:36:09 -0400 Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id F0B3B83651; Fri, 29 Sep 2017 10:36:06 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail; t=1506634566; bh=2GNXW7f1DgI6slv1tS2Ble/C0YPXxHHXgMqKvQoRUwo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=svYoLnbqDNpmfQ3W1dCtOIiIB/Emb+THCGBRPWQenXp1WLtkdb3zy2rc20kj9Qhas Bj3Xpo+H+GTIfXOpydYWbMNfARtLAYJt3dy5eM8EU/Aim/D0u22YrC0qboQ/6g4hrs cDE0spDbdWF2y6XNM6dbSFhwRcGO27MB0N3EHHyA= Received: from smtp (Not Verified[10.32.16.33]) by mmarshal3.atlnz.lc with Trustwave SEG (v7, 5, 8, 10121) id ; Fri, 29 Sep 2017 10:36:05 +1300 Received: from kalyank-dl.ws.atlnz.lc (kalyank-dl.ws.atlnz.lc [10.33.14.14]) by smtp (Postfix) with ESMTP id 5D25013F01F; Fri, 29 Sep 2017 10:36:18 +1300 (NZDT) Received: by kalyank-dl.ws.atlnz.lc (Postfix, from userid 1628) id C53C3C06D5; Fri, 29 Sep 2017 10:36:06 +1300 (NZDT) From: Kalyan Kinthada To: jason@lakedaemon.net, andrew@lunn.ch, gregory.clement@free-electrons.com, sebastian.hesselbarth@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, wsa@the-dreams.de, devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Chris Packham , Kalyan Kinthada Subject: [PATCH v2 2/2] dt-bindings: i2c: Update documentation for "mv78230-a0-i2c" Date: Fri, 29 Sep 2017 10:36:05 +1300 Message-Id: <20170928213605.22874-3-kalyan.kinthada@alliedtelesis.co.nz> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170928213605.22874-1-kalyan.kinthada@alliedtelesis.co.nz> References: <20170928213605.22874-1-kalyan.kinthada@alliedtelesis.co.nz> Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org This commit modifies the documentation for "marvell,mv78230-a0-i2c" compatible string. The "marvell,mv78230-a0-i2c" compatible string enables the workaround for an i2c repeated start timing violation, but unlike "marvell,mv78230-i2c" it disables the i2c offload support. This is applicable to a number of SoCs such as early revisions of the Armada XP and the Armada 38x. Signed-off-by: Kalyan Kinthada --- Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt index 5c30026921ae..c6cbab17ed0a 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt +++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt @@ -10,10 +10,12 @@ Required properties : - "marvell,mv64xxx-i2c" - "marvell,mv78230-i2c" - "marvell,mv78230-a0-i2c" - * Note: Only use "marvell,mv78230-a0-i2c" for a - very rare, initial version of the SoC which - had broken offload support. Linux - auto-detects this and sets it appropriately. + * Note: Use "marvell,mv78230-a0-i2c" for + controller which do not support offload + but still have the i2c repeated start + timing violation issue, such as the + ones found in the Armada XP A0 and the + Armada 38x SoCs. - interrupts : The interrupt number Optional properties :