From patchwork Thu Jun 28 13:11:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 936146 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="J35/mqTh"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41GgFj6SqWz9s31 for ; Thu, 28 Jun 2018 23:13:29 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966138AbeF1NNV (ORCPT ); Thu, 28 Jun 2018 09:13:21 -0400 Received: from mail-cys01nam02on0065.outbound.protection.outlook.com ([104.47.37.65]:10496 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964921AbeF1NMK (ORCPT ); Thu, 28 Jun 2018 09:12:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6sgsJDrV0QdYNur4PUcM7BPlQYSZB6O904uKUyD9dPw=; b=J35/mqTh5/nBuoIODVpYf45LZIGNcSpmOpwkC70cZKo811cS5sOKTpbxDERIH+eIL8ECph9yT7UBS9VbbH8hvSSJyoJlcFFpXkVlEgcQLLvsOYWz+stMMBOoZeFXnTbOTjL0UCNVQZ5fVPMfaU6ckLSEaEryyjRCaKkzH9vfjjw= Received: from BYAPR02CA0026.namprd02.prod.outlook.com (2603:10b6:a02:ee::39) by BLUPR02MB164.namprd02.prod.outlook.com (2a01:111:e400:849::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.884.21; Thu, 28 Jun 2018 13:12:06 +0000 Received: from CY1NAM02FT018.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::201) by BYAPR02CA0026.outlook.office365.com (2603:10b6:a02:ee::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.906.24 via Frontend Transport; Thu, 28 Jun 2018 13:12:03 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by CY1NAM02FT018.mail.protection.outlook.com (10.152.75.183) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.906.15 via Frontend Transport; Thu, 28 Jun 2018 13:12:02 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:53400 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1fYWiQ-0007GP-DD; Thu, 28 Jun 2018 06:12:02 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fYWiL-0001yd-AQ; Thu, 28 Jun 2018 06:11:57 -0700 Received: from xsj-pvapsmtp01 (smtp.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5SDBsW9027432; Thu, 28 Jun 2018 06:11:54 -0700 Received: from [172.23.37.80] (helo=xhd-paegbuild40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fYWiH-0001xp-Ti; Thu, 28 Jun 2018 06:11:54 -0700 Received: by xhd-paegbuild40.xilinx.com (Postfix, from userid 13245) id 18BECB20895; Thu, 28 Jun 2018 18:41:53 +0530 (IST) From: Radhey Shyam Pandey To: , , , , CC: , , Subject: [PATCH v3 net-next 1/5] net: emaclite: Use __func__ instead of hardcoded name Date: Thu, 28 Jun 2018 18:41:46 +0530 Message-ID: <1530191510-10310-2-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1530191510-10310-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1530191510-10310-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(136003)(346002)(376002)(39860400002)(2980300002)(438002)(199004)(189003)(2906002)(316002)(47776003)(110136005)(16586007)(14444005)(81156014)(36756003)(42186006)(50226002)(52956003)(50466002)(54906003)(2201001)(356003)(8936002)(81166006)(8676002)(48376002)(106002)(305945005)(90966002)(486006)(36386004)(106466001)(76176011)(26005)(575784001)(186003)(63266004)(336012)(6666003)(51416003)(11346002)(5660300001)(426003)(446003)(476003)(2616005)(4326008)(6266002)(126002)(103686004)(478600001)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR02MB164; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; LANG:en; PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT018; 1:IkYVBiklk1pGMKjEX5ZN6Xl/FWWpB2+i8h5FP1/zIer2gYMiP/JsBf1+HRy04BK252Kg9unuSPqKqdv7OjTwtvbRer4kiVfansRSPUR54eXurLHrrJWQUqnNQjfkHoFU MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0c0be348-d19e-4993-605d-08d5dcf8bd8d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:BLUPR02MB164; X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB164; 3:5nxKgR2yC/qhmm7p40vcocANX7Xoi7TuwIlQwHT30L9OOv3ApQitvT6P/Y8ZGLK9mCWIPc65T8IiBttqdIMf8bgtShUuAJ5nvzNXJFmgyZ2qlaVWgoPO7gGXBbUqcCAsA9IKvudtgu30A/Hkuv/Oxrwe9URFyB77V4cuo0MDCQp2mYpahHDhi0j8YGJVlqzcoVoXF8SrFjxubKu9Z8drtZWpzQ2TOT8aoh/jlbrSDaHaqLkVxaNmAURv+u3ltaRJ/feiikgH7SVRxxds9rRv9V2/gGZfDV50hJiuwD5lvvi5sgiMylQIiQZca1RSCQ4C2DXbYl8FS8gTgvDU1q3opAklr1/bnI9N62dgjTQY+ww=; 25:zJ+vYXhAilzn4eA04BNtBWjThpVD5CxdXDiYliwN1uuRrlEWpHEayL/Ur2P12+ZCiUd4+Eckoh/bZuw7X3BXzjHmx/kKk20vcbQpDO9P4Qmo0L1S+1+B/M4LUJngDCgyB/WZM3sOp3L9LhPG9eCfz3A91qPyuzBxSRGRk0DkhKbnw4BGqLW6pt9yaJvEUyaBjOWjMLdEOwnqBg/SERrsMTa7TlPE7WVAVKtkgPlIIKMKFij+q2Fauc+6UoeBi8lT6Ztv5t+LzkXml1mlOJZkyT3gP/PyuSG1cNbVXJ5aJz329Rz6njzrtUctpVNlqy7sCcyjg8/CbtjJhv3BP3SETg== X-MS-TrafficTypeDiagnostic: BLUPR02MB164: X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB164; 31:B+kQlNFfia3fx0JngsSq1zw6TmCQDK4Mp7yDpIXFrYbK6EgSkQsz+hg1zwQdFwwnPAJrbwT1184fryNwyWbAkrezShdKy0nvB4vmhGCrjDWecpIuNkwv1i6fKYWU6Xb0IfeL0nolnOM3/FVZW/4Ui+kT8s503pKkj1MywF77IUucSKNt+YnsYOB0AkBSYQWVTaF2iEcoT+Kum1xWbv7ML8EyWTEprmr8gXabCQuVmS8=; 20:6uFjRT9x6HdxF/7PAISH1Ri+ZlkYwAu21rhw+Hv6oA+uypryW8NwiqC7asiZ9HTd7WEcq8GUXWcIRrw9xV8VacvdcMm5GU0nLVZIesSQ1aS5sNP1hta+UT3rfOlaCesn/hUGo+M0/ACtqIXFOxobHBJQZdAf+q0y7yR+LOLzlQrSb3NNJrgml5A6lHKAB4aX0baQ3kmW43S0IdVw+g+W+2BIU0XgoWNgj0IpzlV5reVAurqSdfAvWamQl1MLIe1GeSKwuZJVwsS83/0IsspvtXEs6NHoLurODYq7/5g9PPLnyiWZAQplcCt4FH7xzj8sPxe36CWVbh2o9wxBkxyzev9inxiCkrrsR17Xr9RUgHs5C3hZRFILKWgvymz8vcc9LiBkBWD+xv/IXSfAt4fLKw/mE7qUPDdqI51yHDat+Z+DFyIjUk4BXA2cZfqs5v/oFX9HhsrtQ3OOv9KDPqUVTsz6ohTbxvgF+FJBZdR1yaUnGHcTVHc4m8V/Aw+beeae X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231254)(944501410)(52105095)(93006095)(93004095)(6055026)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BLUPR02MB164; BCL:0; PCL:0; RULEID:; SRVR:BLUPR02MB164; X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB164; 4:sH5tShsK5MeZVFhOPMvWPXdT0B6pWxZsT8i8okzuTchYa7HWm0rNogTnKEZidG66jJga78xD/rhH1apoLnf/kTCrnC6hGtFQ79E+xFe3Pu7scgyMAxmDUwRdmB4MThKnxeXKUo3M5EKw8XJVuVCpAKVOl/nzPd1X1ooo1EjbyyRmZdZzRX6wjcW6Jposfz8Mc83RSrsOUC6raWYHAOk1gDQ4Cf3/ZKkTLed2/Fzrcg/6s8N+7eOJwi29uO2AeK1BzaP+eM9m4I5qwcD006HUPq5/FK5Va/uq8eYvllWlAQzAG3XkHCR+a8qeOL+kaTyJ X-Forefront-PRVS: 0717E25089 X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB164; 23:r2VaTZVs2n4Ar8SWhMxOjgU7oNKMsg7mtDSnDaa2S4e8C6ORHxq2yIac9j4wKcIrdlcJzmSMxJ5QAEIyw6Nmjq19hfEreDvX9VrkJ3QjVdKUl/2JwI2We5d5peQ8CmJ7eo+2fUM2zii3UfdmLobwXnC0vxti9pme+YHLUkgsL6XnFVUsNeN7ahKRmXslff5Xg7fM7//Kc18ahqYbTRae9L8Q0+fNufwaTOb7e5PApGWlikGC3VnBDvYkhwDVJ87Sp9vPORmyM5qlcEopwGDqNJ0Qsiwa0u06HTDjLrLWBbAW2JGj75QWY+/7V3EjImuAzFax4UxNGyCV09H0l5s60dpSN+1QdkjbKgAyHADsCAFeI4Ena94WaGq702xxQcnG+C/fC4r0hyFhj9Z3t9slf+7Ao0NXJS9XsbbT7mOL9VDyciE4qdSNVMA+5wJpsJYcCAnbqQEAmJmdCaetOF0L78puacTae3m30RZbutMOzxcMbBjJ4vbHChdvDv9+CdmyDefCCrm7pIn9Rb88n0phdP+pMIBZMpcyKxsEoPd8SP/zbcrYWw0qDC/bhGL08eo/or8RIETsTtFAx7adn0UhZTxjsT5l1q4T8sOWdZPFbp2YfUg+s2mvYAEb9w4kL9OrTaCX8G5r4v6vLBRyh4TI71a/9UjUrp43GtrGYrzLZmnpzfjnooVJ9roa24r4sDWXtHZZbCGzX4yQe7Z17etESvI56YBNvMPpYKTl7e/8FlwxGeTxaxYjE6opnk4F5fVDyzC5BHjs9CLAZZpop8RxWpPhrxPcUammOFEFdJydE1Wv5NxrAizyb8TWVTQE7daUHA0Imqne5dkbjMjZCXZ62kZtIVxV/dr7qnlsMlKYKngg1FIPVyZR/pOFZGfenJ0rHDotODV6aQAOChBTf4Xcs9ueDUQyPwFTPZ/bg/LUfFUL/QPWbXxmWJHMSumJ4jkhF+FvVHdgukOp/u/gTa/QrY02DyQ7XREpStLbXNNK/Egtkqky/kI2WcSpHwNh8KKForiR+prIiDj5E8mG9OrYuLj0PQkavziStnkzSwMeE2/zeHK1wy9MA9yaJQiWqW5z8/ZKKpEE01eWIFj0dbPgslvoLWia6cfyz9g0/KfRG8sGlEv3/soK4iuCtEmIJ6vl19Zuuy25laI3EfwBqerDrC8NvNZOY+bjXLBA8EcJJ1etJ1enV0K7HZodhjngVvEZdhigLIq3csGOqdTkxbgBLA== X-Microsoft-Antispam-Message-Info: R+qwAs6hiAONXn8avkDDKTTa+cbPhSlcL9LD0C6SmmKCXodLJOZEnMcpwSvUcRPYoV8k/keKeWVlaThqQIESk3jI7x0eIHtDI0AKFnvZra81m2YK6cPPDE52YkLuTJLUOMRCb5dxYnRGeVkJ6KNOGFj5SL94r1Su9S3ir56Vz9DR0YOp2vSy2ivbSEMcdayHzBhibJeFbi8E++WuVwVTLw1DB53s4Ymov1WGcjpR170hxC8DFbS5rrCB2fDR7C0DG20BjrrKcVlnFvjBvuEiHuMkobpLS4M/kNr244y5ZfqpGTMUjRCLEwvQp9xndNY5WsDCw41aX/N81OPtBGkRm2aWfx0AsBWJ9ZdKzd6RxW0= X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB164; 6:OQrYIhDyjMhStNphFB+VVMZtlZi7SmCVAXZwr96mZke0CmeGjmw/bWFOaw3cX5ubGXgrbAb5B8jAnfdH4tMLcVuNO1UluoqMp4LXht5aLzAK6DoPxPFc1za4kQirGv0U6RfIE/eB+1R2ya1PcdEwJZWRICXEWcVhiOq1/A2WqkvTMRRSdoVl4i9R4aVg/y36tMV6s2NnkCcvt64Glp0C//nHXyCNunr8Dwu0Ophuf32gIwdVrIFU65uExgdN5QGIQfOHZGqh8JJLZuMem0QWPRhT7R/X7Qcc7Fh7UkUFluUNZIl3DWxzNMJvq0VDeKMJPiL/1L2fblBJLA0pwteOiBSGgxBxPebi8xzkvHa+WoT3mKZZSZIn2N57qwLkTXOGEqGXrM7g2S2aJ/keOriBrX9X+x8QWspVYC5qQklVQJdVy2rgKr1gNuXWT02C2E8EfR/NMvpMCrYpAd9jCEDVSg==; 5:xF72W/QPwDExYexHm2FexBe6U7m+GxlOH1ozNON6ViH3QjdCbLIztJlcctwPWo+Twdo8qH51qlSqQhfMlFRAdYU1+eRQ3jzO0TXxGEVJVVEkZtrui+iGl1laYlbwcJN24qs7U7wjKCqMcljYkogOqSi9zEAgaZaNApTWKQj5QGo=; 24:7b+lzpv7F3nMl8Vzus3UDalN6BsGo78Map+ycew7h/BzFKAbcAxOtAzbXbeD0ePbAFVBqvNmnmE+6PHkK/jJYfyI7+ZAcunjT42TnP90iAw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB164; 7:a3JuHZdjaHgmA1j+zIt7ULaWpQ4skOpXWR0tv3GHr7VwCWfd/VF39U7RFmeTZu0qSAFk2KBRpaPxOwE0yfJ0beOe8Swa5NRlf/Qv6OdOBPTkTjfUsLUnNG9ZnmCkD4yEDeU2nEJIpcOKI5w5fjfFiiaeF/NscqbKM+bkzOPcYy9sa9jsmakBA+Ndc5f9NHkV+ZRGIRF3o+vxUawik0vZSAGS79aNHA3nhKMT8hWlE2+nW7vzTxC+pnOCHvUUmvbm X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2018 13:12:02.8733 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c0be348-d19e-4993-605d-08d5dcf8bd8d X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB164 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Switch hardcoded function name with a reference to __func__ making the code more maintainable. Address below checkpatch warning: WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_read', this function's name, in a string + "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n", WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_write', this function's name, in a string + "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n", Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- Changes from v2: - None --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 2a0c06e..0544134 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -757,7 +757,7 @@ static int xemaclite_mdio_read(struct mii_bus *bus, int phy_id, int reg) rc = xemaclite_readl(lp->base_addr + XEL_MDIORD_OFFSET); dev_dbg(&lp->ndev->dev, - "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n", + "%s(phy_id=%i, reg=%x) == %x\n", __func__, phy_id, reg, rc); return rc; @@ -780,7 +780,7 @@ static int xemaclite_mdio_write(struct mii_bus *bus, int phy_id, int reg, u32 ctrl_reg; dev_dbg(&lp->ndev->dev, - "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n", + "%s(phy_id=%i, reg=%x, val=%x)\n", __func__, phy_id, reg, val); if (xemaclite_mdio_wait(lp)) From patchwork Thu Jun 28 13:11:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 936150 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="j6llUeP/"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41GgH20x4Yz9s29 for ; Thu, 28 Jun 2018 23:14:38 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966144AbeF1NO0 (ORCPT ); Thu, 28 Jun 2018 09:14:26 -0400 Received: from mail-eopbgr690040.outbound.protection.outlook.com ([40.107.69.40]:14656 "EHLO NAM04-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965388AbeF1NMH (ORCPT ); Thu, 28 Jun 2018 09:12:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kInR19grd0yYewjWCULP428xtVZl23WGktmMZqP0Beg=; b=j6llUeP/2a2duGMqKijFWHHRfw8l3pi0bL6tOukqnRJjb4iJeqXbG1VEY8RiUxnl8C5tC1RQI+BSddY6FxgAyFtNxA+iaKJlBFUvV/F1eAbRNVdZ1uiRQxlS9yUNq/ZCK853yiiX+G5Lu22/zIlQ0DEwjYxFxVK/4t5foYKqmdU= Received: from SN6PR02CA0026.namprd02.prod.outlook.com (2603:10b6:805:a2::39) by BLUPR02MB163.namprd02.prod.outlook.com (2a01:111:e400:849::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.906.21; Thu, 28 Jun 2018 13:12:04 +0000 Received: from CY1NAM02FT043.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::203) by SN6PR02CA0026.outlook.office365.com (2603:10b6:805:a2::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.863.17 via Frontend Transport; Thu, 28 Jun 2018 13:12:04 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by CY1NAM02FT043.mail.protection.outlook.com (10.152.74.182) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.906.15 via Frontend Transport; Thu, 28 Jun 2018 13:12:03 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1fYWiQ-0006cQ-PS; Thu, 28 Jun 2018 06:12:02 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fYWiL-0001yd-MW; Thu, 28 Jun 2018 06:11:57 -0700 Received: from xsj-pvapsmtp01 (smtp.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5SDBskr027434; Thu, 28 Jun 2018 06:11:54 -0700 Received: from [172.23.37.80] (helo=xhd-paegbuild40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fYWiH-0001xq-Ut; Thu, 28 Jun 2018 06:11:54 -0700 Received: by xhd-paegbuild40.xilinx.com (Postfix, from userid 13245) id 20A30B208A9; Thu, 28 Jun 2018 18:41:53 +0530 (IST) From: Radhey Shyam Pandey To: , , , , CC: , , Subject: [PATCH v3 net-next 2/5] net: emaclite: Simplify if-else statements Date: Thu, 28 Jun 2018 18:41:47 +0530 Message-ID: <1530191510-10310-3-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1530191510-10310-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1530191510-10310-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(136003)(346002)(396003)(39860400002)(2980300002)(438002)(189003)(199004)(106002)(103686004)(50226002)(446003)(26005)(6666003)(186003)(4326008)(36386004)(106466001)(11346002)(47776003)(2616005)(2201001)(90966002)(2906002)(126002)(6266002)(52956003)(476003)(5660300001)(486006)(356003)(305945005)(51416003)(336012)(50466002)(76176011)(14444005)(8676002)(478600001)(36756003)(426003)(48376002)(16586007)(54906003)(81156014)(316002)(8936002)(81166006)(42186006)(63266004)(110136005)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR02MB163; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-83.xilinx.com; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT043; 1:vYMgOUXvZN3LvgnvT2f/QnOxipFK2CmCWrtIwYdJ/9624h6Lb4bv0Xji4aYnWghQ3q79ZWx9NyC7f75dhnXVS32YBVtdPFELKE6myCcoyWHBmFod8k/x187tylq50OqX MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0bc447e3-b217-483f-8e0c-08d5dcf8bdc1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:BLUPR02MB163; X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB163; 3:Zpae5itjYdveRu7pZ+muRvc4eKOv06Fgx5ooJ4uA3EesZw/gNbPSRj36tUpBPm0oixvpwY3olWr8MxgNuIE/rG4LXsysc2YgEoAkINtZL/CaEBUTVXg5l+WenZ8mpibKNLJZhS22h7nYZjeTgBFi+/Wd/2Rv3Q2xToX/SRY48nldtZ3DKCh52WUBMfEvB4XGgNyhpw4toXppfB8slFYGROWmsSAfIH0u3AtC737S2XCdpSMkQI7VhtQEOgbCz2U62tcXbpSkzS7e/acSc5IdF+ADcN0tTLOCIzijRB1Hfsy6ThRlLYwfRVErawrAxVdiYK0YeoRzbj6wy0UKRiSQzfFPseozscovq++hKjPlWtI=; 25:3V4ZCGoxaaJkMiOTz8nwNOm7i/B0liiXEdrHuis7rJZSgBlmFU09UQTUuQnFmlEn5A0Pf0hqCuWBGE1w+fPnvBn5ZCpdz9sdxWWCZ8xnyEas/WJ+Ls7wSj6EMpgNgoiwyXeSJMQjIGTl0m7oPMeyj4314/qKzwXRiO1Op5NBHrxyiACg/pnA3QmEAL/4k2h3UxSzeon4uaNaJ2aAdhampzn7Nng4KXNbNQFjiXI4MKrxsSfNbyt/zHHvW6KpIxxDGahg6RYfBb1yOhcjlpaxQqapniXLVAvBGsJ3rL0l11tDi1IBhOOxHVjcff2EXyjwjGfz7uXSdbf8w31zCekjKg== X-MS-TrafficTypeDiagnostic: BLUPR02MB163: X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB163; 31:pZLCvFHrUDPTE8QDRFhBiZ+9bJQDJBJy2KabpHU/P+DIKtzeaGea7VM9i+is2A/T1s6skAk7jlZl5oSOm+s9LtPPtG3YglPOfUJYYKiJd4I8QXuy5atDLA47AbX+6WwHeVmVFZ/s2W5EqR9k5XevQry3NDfvTmyW+D1EMwiGBdGxC4Ebc7SfIrpWHImJQxWkG4ZpS9Ug8GwVZ3lK/0qYrkCAixay2n4sXy5rJykDaOE=; 20:6QBxLSLT6lqI2axxxLaWyRwmbHLOLLv9S8eMhjnFDBfonyZEarDLoNvE+G/IH4gLQYq6ZEOD1ciR23wrvYOgqKfEWj7XAUNdjmjb+fqGAFrvLlRQzdu7YPKg1HuhlsTu7nrhb9oJn8L2yHNQFVqtKCMaWN+EBvVJP1wPkk6B/12j7V6WyU8k08n2cy/c2EKMxRicL8bBoZDPQ0nTQZBV0zJktQPx/HvOcznCF+R6+C2inP0vAcxeCElfgVAH+zsVhcJezpwSByETlCSzEWqkVALFLT8LzbxrHzNUgk9HbcRvbOTWZENuijVzQli552w7WzYOXF6PHl1NS8LGIff9dht5UIsYxXBgpkhtlTr7iozPnKMzW3enr5sZ38UephOjEGbesw/XN9yq6bozBcArfCAdijUlZss0r0adX30sKAs+LyTPwsneW+xgytcp+fzhmlH6pyhmbxSt0NDPgjNIw07OXMLaV9hqPWqVhRRV12JFbxGxsPXAMyouajnZu3ip X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93004095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:BLUPR02MB163; BCL:0; PCL:0; RULEID:; SRVR:BLUPR02MB163; X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB163; 4:m5cz4jPkNDEow2oXI1DOyijPNU2KjR6aEFXbeyAor3X52nzrAE5D23gkNP+TW1TssSkvOFeUjwyxxITeyAWdfbna/3j39WW82etZ0a+O/A6kkvaU3beDjJlIxYlBv1K8vPmubHTXvyySCRXSlMGTIXqDBSfs8XHIoWIEThaFZZkCn95QUbmmeWXWBiE98uCyYGMmGbTPSvX5OekLxJoHkS0QbS9IddaWJLbRXX1S93fM/Cpo2FRjYJafDXOvFFL/z3ehU4Y+M9neGUs2pEFUV/4bAdjOiWNHnbFVfWuTkCZrZmYeBXQXYvQtxELAvR69 X-Forefront-PRVS: 0717E25089 X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB163; 23:CFbBOwoqzaaTkSzOXjdYjkKp98saAiQGyLT4+BpdJG9hTrnm1DgtLEjbfjTMlaN3T10pKjq9ABQo8SHP/Bq7Liatm89a3cEu1bE6VfAqP+0GO1mmmjmQp53yORsABSnwBGALW2CjcR436tsr2xqpxIIE/bo6WHE+OylTRJn6NzgzAbat7rwcigVPgxX9AC2cLoTuXvqPsZQcAJ5AlUYH8AyTSJVwpyY4oABwqFyOhdeGVKQX8t4dZYDaNEdxT+FryVHsx3XGGnGIEhs1eOMkRhRM+6teJMna1CT/I55lRJE8QbNJyGrz6yyXwubvBhD4p4L01TYHQz/3dc3PqwYn9JR9fk1P38pyrYfp766ygaBtiBzglFaMEZcnpcR7irzXVEFDocVObJyhMYJOk1Fqn+o4Ns2H2zG+CgdqXTjBoHstwPUCgY1ZiZ4lE2Suq5Rm+S48QQL+NCiR5Ev8k/9Y0gc4GHXVWq1hZa0wjGABAr8nEJPH89hbSVvjtzBYVlM5g/I8sA+2egqzZZEBZN8W+WeRGEGwoG/s4SMs7xbsOmrbve2SvAf8CiQiYDGp6cyJhzeOA3URcNZ4avRmz2ENP8MH0wiQjDA19jpQL/G9Py4KvLB63Gysaw3+Ov4B81L2FedSgp8FvSNzPWWfOkj5v8CNr5hdM5QxOWn0tC230/ReUHEe4AuODfx4/DCefVuSXfkSwDAbdBixnZFAPq+3RvQuwUys3/69TsCBVtUipvfjKeutBqCwyeLE+IN1yT24Ji5vHlBrz06eNszLzCHF/G3EtrrIz9MeY6SEqE9ZA9ZQ/c2dJehiKVQg1sxJunZmNr2UuvtlGe+sMUHzJH+QjuxnViOJB20AmJkKpxejJu17R1W4vxowIcme3ji5g5a0pwkiy444bmCcpi9Ti44YCX7o7o0ZADDQzGOFtZh9Bht5vsuT+Cc6SAkJt3C6x6CfNJ32/9gl09oR/yJiReePaSnerNHtQV8Ms09Po7JsdTONjFyWO875EHG+WleXXGzJEqkv+NAcGpgodw8e/d+s/7MFpamGoPJynokUQCAn8pafw5OtrlTz6qpXyOod14S5mCFHdS7G0hlsRa9plYn9HlghavakjsgYWtfhdsJl2q7pJmCccjsbaFfFxEz3U4mZ4kWK5glFcYr+Bx4klucuOw== X-Microsoft-Antispam-Message-Info: WlAaiVJX2a9ZhseVGTcsGifi+YsXHWcYFMUywH29SkXk1/EXAkla3DfKEiB2hEN4a7rjU/XW8UUlKJQKC/g0GRqXKhWqDg+LCPI306YvWZOltPLZYbml+q7PjUvSb/k1WXaYU2bC3XJV2sr16aFSDljNr1yXamDkGaqpS2iBL+EY8ffNIyecChuH0DMByaAMAhhkRheCvR56Am7Qeng2cCHK3zRHjXqMGvndDG8NyRM+1OULXMye4n8bNqYIJfxvIuLwFIStWocKUrhIOQXR/06rzf03fZ5ovYCteOcpyfDmIgANnPK5Wf56aRB6cllTpS9T8tpvkjPwsYsVV8dZ4juNSBuKZz4UzkHsgXhskJA= X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB163; 6:zuu0xNMbGMuK+CP2jvqiDlL/A3gcuwUkvlQqxznZeP92dkTpZ7bHmAQ9GKlNS34AlvSDv3H/IeyBS2PnR4wvfe5QdltUL0tEjpm7Sxkg5xT/Uw4bN+ikskOOO0iswwcfpY2wXrl7Fnhokrs+jAk4RCvUmd53sAUt7JXKpRRpJH3NUnL9Dn0cqSkMYjrOfOb5vBgfVu7zt35tozArKUv3Qp38d76X6nJUCfSaqo0UcM8xHuk3OfvaxNAvu3x/pkxt4Y3BS2rFdWWwu2aZMomQ70Fy3YadANNF1uNKcCe/XXEHQZzMI6/t+SeEIfrfAx5khYavFFKs/PUXbLDX7Wab/WDV1SWJhAY6Ox/4kdfflFyXExajIkmYOCd+qS2hseEfaZjtsHWl49u5CnQv3fVDNumm7jdvPiufvblvAYRvKj2CWv/NxlftjIhrBPgJhIJ+DnuIiCQJ2rM0N7W0uaFggw==; 5:PoqKkKU+Vzh9bGfKpllPGA7nTngHYkl/ahP3S327DiZ3NWhfrTabh8MgYNlizTPvPIQRdgX/zxR9E9iyxKB6wmUyTu1kHki7wpWvR2T00e0qcjEdiCunOmYoZcUTIWbLipOQyY7A9b01KcwOhlUlX02We2fILv2QVo7IP3kyT78=; 24:fBr0BuqimwqRfB7KV79NMgLDhDEUp36Jqd0Ujyb2rdpMBw1WOcL3LG0RG+qecGuatHT/aAGM0/BfK6ITG1uZwvLjGegnXUcQ5YC9OXvxVto= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB163; 7:KTlaGZgEuW5RzKp1PEBVlV0OKoPvww+uRM6IPIrDLW8A0n64JLZ7xbtKhzGCuuXYi1rWJeFzRwTgQxaMV4r6dPa0YQA9Flu4EPhnvCpq9DKTk3/XnHfZyftXSmR2eUdqV+pQuJtdZB8XpLP9Ak8jOhP0i0x47J+bMTPHWZv/kSQZ3at4/8I3TPJCW1SXLHT7hf5HOPhIy5woEMXTTVxo0cvapz0UA8dZdXm0E15YXqEX86qgoFQhbnkrLls+U7T5 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2018 13:12:03.2621 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0bc447e3-b217-483f-8e0c-08d5dcf8bdc1 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB163 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove else as it is not required with if doing a return. It also coalesce the format onto a single line and add the missing space after the comma. Fixes below checkpatch warning- WARNING: else is not generally useful after a break or return Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- Changes from v2: - Refactor to make failure path return early as suggested by Joe Perches - Coalesce the format onto a single line as suggested by by Joe Perches --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 34 +++++++++++------------- 1 files changed, 16 insertions(+), 18 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 0544134..b2c7afe 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -564,19 +564,18 @@ static void xemaclite_tx_handler(struct net_device *dev) struct net_local *lp = netdev_priv(dev); dev->stats.tx_packets++; - if (lp->deferred_skb) { - if (xemaclite_send_data(lp, - (u8 *) lp->deferred_skb->data, - lp->deferred_skb->len) != 0) - return; - else { - dev->stats.tx_bytes += lp->deferred_skb->len; - dev_kfree_skb_irq(lp->deferred_skb); - lp->deferred_skb = NULL; - netif_trans_update(dev); /* prevent tx timeout */ - netif_wake_queue(dev); - } - } + if (!lp->deferred_skb) + return; + + if (xemaclite_send_data(lp, (u8 *) lp->deferred_skb->data, + lp->deferred_skb->len)) + return; + + dev->stats.tx_bytes += lp->deferred_skb->len; + dev_kfree_skb_irq(lp->deferred_skb); + lp->deferred_skb = NULL; + netif_trans_update(dev); /* prevent tx timeout */ + netif_wake_queue(dev); } /** @@ -1052,13 +1051,12 @@ static bool get_bool(struct platform_device *ofdev, const char *s) { u32 *p = (u32 *)of_get_property(ofdev->dev.of_node, s, NULL); - if (p) { - return (bool)*p; - } else { - dev_warn(&ofdev->dev, "Parameter %s not found," - "defaulting to false\n", s); + if (!p) { + dev_warn(&ofdev->dev, "Parameter %s not found, defaulting to false\n", s); return false; } + + return (bool)*p; } static const struct net_device_ops xemaclite_netdev_ops; From patchwork Thu Jun 28 13:11:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 936145 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="EJcR0Fp0"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41GgF44yR9z9s29 for ; Thu, 28 Jun 2018 23:12:56 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966088AbeF1NMM (ORCPT ); Thu, 28 Jun 2018 09:12:12 -0400 Received: from mail-by2nam01on0077.outbound.protection.outlook.com ([104.47.34.77]:52034 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965285AbeF1NMG (ORCPT ); Thu, 28 Jun 2018 09:12:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lw2cd3x14LCHrsIbDn+FGB2f3nY1xQfa0Bc9IdyIIOM=; b=EJcR0Fp0QBAPnSf7ygSyVXT9SkKz3QF/4Epe80gG3WwEWzIfFdCRANigT6mOy6tQCPXXlCxNUQ6ecBzOKUHJ0V2Sh8JaCeBirkNLnobWXNfm7PJs5OrCYyrmBQbkPGJE6dDbrt5uHapRu/Fpp04CPmEdXA8Oez6TFszgGETLfLw= Received: from BY2PR02CA0122.namprd02.prod.outlook.com (2a01:111:e400:5261::48) by BN6PR02MB2643.namprd02.prod.outlook.com (2603:10b6:404:57::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Thu, 28 Jun 2018 13:12:04 +0000 Received: from BL2NAM02FT034.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::209) by BY2PR02CA0122.outlook.office365.com (2a01:111:e400:5261::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.906.24 via Frontend Transport; Thu, 28 Jun 2018 13:12:03 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by BL2NAM02FT034.mail.protection.outlook.com (10.152.77.161) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.906.15 via Frontend Transport; Thu, 28 Jun 2018 13:12:03 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:53403 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1fYWiQ-0007GQ-Ez; Thu, 28 Jun 2018 06:12:02 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fYWiL-0001yd-Bx; Thu, 28 Jun 2018 06:11:57 -0700 Received: from xsj-pvapsmtp01 (mailhub.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5SDBsQe027107; Thu, 28 Jun 2018 06:11:54 -0700 Received: from [172.23.37.80] (helo=xhd-paegbuild40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fYWiH-0001xs-Va; Thu, 28 Jun 2018 06:11:54 -0700 Received: by xhd-paegbuild40.xilinx.com (Postfix, from userid 13245) id 25B26B20953; Thu, 28 Jun 2018 18:41:53 +0530 (IST) From: Radhey Shyam Pandey To: , , , , CC: , , Subject: [PATCH v3 net-next 3/5] net: emaclite: update kernel-doc comments Date: Thu, 28 Jun 2018 18:41:48 +0530 Message-ID: <1530191510-10310-4-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1530191510-10310-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1530191510-10310-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(346002)(396003)(39860400002)(136003)(2980300002)(438002)(199004)(189003)(8676002)(5660300001)(2906002)(15650500001)(36386004)(6266002)(103686004)(305945005)(4326008)(6666003)(186003)(336012)(14444005)(26005)(575784001)(48376002)(90966002)(50466002)(52956003)(76176011)(126002)(2616005)(106466001)(63266004)(106002)(47776003)(2201001)(51416003)(446003)(486006)(11346002)(476003)(478600001)(36756003)(356003)(81156014)(81166006)(8936002)(50226002)(42186006)(316002)(110136005)(426003)(54906003)(16586007)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR02MB2643; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; LANG:en; PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT034; 1:iLcz+NoX/2ipdNrGP0FmHup4sotDlaJ0wAU8EzqtzQ6prNh9eWELeGzghKM0caayZ/EtBHGr8fafGpvW0jWTs6SjdejnjPM7ooNbMCJOwILHWm0ijL7kD7c039Rd/rL6 MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 09de18fd-8996-4c46-66dd-08d5dcf8bd90 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:BN6PR02MB2643; X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB2643; 3:hKa1L9eVCgBXqvVWz4txKkP2R3eKHu351Cs0R7mGsbI0pqlsF5V8z8PLuGZnElR4ZvguZRV6hjp/pAV/bYty3YAMrdIT06U5sWuArgiEJQ2zWmssISQhXAwr3tGwee5k/bGUeh58xm/DpAfqnEh5YB99zzdfTkEjTB+fnea5whha2lQ/9Bf3MqPFoLIaCgEOwWPFe/Xa+zqSLo7y8aLT5Mw/AJ4NVLqSlL+7qM4GnzXD5g7rnT4mTYXhEIgQ2nuuON6IIXnuhv0RExrJG+HJo3r4W/WYQJewh52HbjQt97hzOOtx2KiHH2x1QOtg7bSG0CzTk/RsnHWPUltXbVjX5CXUIOiT6zOfkYo4CcBGEbs=; 25:vsUSPoLYLnrUeJZowjZlPxRzLJrdugLw2r8G2f7hozWd9knR1+e4Zwu/ES2aQ7Sfvm40KwAZut/kxstkDIS72NsEqqvmTiAdo3f7JEO299KZucldFojkZFQPolo2tJBZTjQiHNDvRDzgwh4ccP1WtJNlEioadm+UtvCP0RjldSLLsQhEaeRfsu7nRv2gAT4iyXOE8BORlRh9AJ9BkpTynbgiuIXZIF89gXSBfYU5WZsDy8ioXXi2xLpbM0nRdTekXfHCbnVnnH74k1id1UWNShRg2J7lKlxTfVdzBSq6seB6dOjJFTibg6Di//E8wLtwOY0/rjTdKaTjxfZBa2AHXA== X-MS-TrafficTypeDiagnostic: BN6PR02MB2643: X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB2643; 31:Q6MnC/C8gswhvM5hLOVJse/e6+3lDVsXopYF51CRADKJrdGiizvyn6mllFF8FJkH/q/s0XllC6+91PsuKG3TD8tbYrG9qChstBydEUAYC5F0v+h+0iYCmTVCi7TgdwATPIfotCf9CSksjzJ4UxGz1t2xnuIufR2N11Na3QlYPSOX93rjdR1y2aIaRyNLA9x/v8Sk+2rvqcSoN/2XAwYcexgWJxqeRgjzfYtaMRftmDg=; 20:nOPlNO5LB+o2WJO+bwMfSUoZ/YUDCpisIIUV34hlODjTaro/vpgWLtwKMyVlq4mJ67xOqRnh/FZgd2NLwFmPFdD/SKHv0rHz3NiLswCSAmtnIvnKgUmJUVN9xFHIkVYBJtlP9wh5fJdIOcHCVECoqgJlWzDlpMFBoZICVGyL8tD125DbyqYdOuZ6ssg6vKmMG8Y/gUKKfhRKrIja/Cwr7bbkwK4SEg6r1HlMxWhTJHCRKA21e50LYR4D/LAld7goNef/SfmtOx50c+UTlUOdn6+eJV+aGxWgJ74vPpr4iAGOBsqf0FTWz9fnNUiINbTQK6vrqwCiY0CWVlzN6VkUzw5SbJCP/SE2K2/QxPJSr2zupTz4RiID3s47HbamaEWYzXwNC/BrjTuloVTxxel/VF+foYr+3tCDRfv2ND+9OR2xSGRxrFBfcm7ir91OKHQA9L40zZc03ZAoAnJbcwA9o/1AAcnT+khpLv6FprJ4uWb4iPM16C/AanamteSgFkmd X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93004095)(10201501046)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:BN6PR02MB2643; BCL:0; PCL:0; RULEID:; SRVR:BN6PR02MB2643; X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB2643; 4:VVLGt/sx6gvztmF3aovWEFMA5kcklwdpns775QxG/vOvnY4INvKPI2DOA/ZZR842wvgDIhK+YfMXgSY5uFGZi6ggP5NWW7fORpzGmE0FlyZpZgJdeQiF8XEAR+U8vqilYN6r0fYVIa9tGKph2c4LLbnjwvBLwmVyWFzrsR1SeKpASv/TerJ1k6NOrdRjfIT88I/4087mFnXq95JyjGBas5tE5WkL4mLUXvu76HZXGJixpM0vgC6ctzMjJrRARBbmEZ4hIL7H7yr/6tAV1HlHpVMgzvJnpiL7Ba31qw0sneZMsx7ks83ymWIl/McLvetv X-Forefront-PRVS: 0717E25089 X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB2643; 23:TY3IqqgOuW64xVyJauhfUFioe/cPS6S9F6EAqwfk9IWIgBgVwY63yUWF7rhimjFKifkufLXcJaZ2KvUbOgJCYodnhs9U7oUqL+7LNXRx3+Zz9j0nFFwCIxUSi+XafbwDf8xEOhkm/4MLa8SNBDFC2BwIjsqFtGZUGz941Bd18za3Nlv6YdXI3yx6oLxX6qzOhAfcBiIKzIgPKdlZIwoW9K7+0eiSCl3ys9MTH8uNCQ3jlxL5TEB54rINIUlw9zY6s2o94lcyFxrsynkhU2AMZ80rJ9KLaXLCCrTxtTOyESS3sb1ZWekpFjbv0SALkGnLxnUbyNz+pCvx9tROKOETl3Evl6mggVI3VA7IP6B8dEEr7266fV+NsM00UQJoFpy60nXTKtmB4rVUs44vpaCY7q1GBhi3694RMCqDzCC5CgqU68GRP83kNSjlibG6Gt95+Hsz9C4aIHoXf8wWEQuZz0rPn+bLU2Xr7gsizD83d0U350DRwTiL1RRCYVbmy/4L+mbDwJjC2Y3bv8mkJHu7Xb90kI92QU9ofmLjybL/w8vFeoGAjc7elypIPpieNnno6imfl1nFPJ9gmDuQjttI/XymA3DNP528sTBmXsZpu4eQz51WvfcrlDWVYIk63HYurpG/FtQ+EABxo5se48SPzX9f6TOl+XGSPA6wKIC0QM6+mjj7oJaYFXk9XR3hsbIelQ9vaKxx68FD34eloQ2jFbewWLvdMDHo3WIIxuK5uIAWmxna3iBttLPH8Oo5z69R/PlFuZrWuIqgoRnqQnj1rvjtWOxEKl/5pbd1l1aSfaIK8fppRhU/AEGnK5YnA/lTvYHVAxWVxjDVkXpzV9Blx2HtIdbAyzYxDHsMklOPI3GmNUcNtGJ2JrlsJ1+1aBpoXuvRqoQ5ocE/R8ypBkkZpBPsRNZShoIT5JXa2jTS2OkucKLj4bBZk/F66hgjTE+LUyX4wZj8P3SV4A2iaYYm1Eh01owoWIoZrdEnbzPTD3sANfkFhFGFOtvAs5bDuE09FORrRUfsuoIexKPhBHN/87P+lJq9v00DR4me8x8gNmjPRo7andkLiQEzUaSg4Apukq4kso/Gw6w7izZzq1l0HweNFoqGxShkoDysJxXMiM6/TUBc9R1I9pb5oUQZSR1UBrhSD/a+tZahwOgWM7mR9YeoSHVSaKv0VSqpQcrOdsgnqD3rIrWIh+8STskb0YHEWTU0Om5docCE4tJFHm5WRUx/z0aZ24iaq0wlJYdG860= X-Microsoft-Antispam-Message-Info: ui8rWn2qU0B7WBzGWM3hhbIUKzoZuCrza2KE1usyJupGfkSlH/K56YBVRp2JWEKeiLFYCX5b/1C6/VkMvUBLPckZUXNHptc6APTgImVswzyLtxEBH0N0Aii/dZp67FYjjGhM2jzXkvTDbGVUq+jzF1i21s2FogY0c/V6ABazaS4LzJK37lhNER28myga8BIYhSq+iJ7wILTsWbMHxTVKVbG8gbYLn1rcfLd2TWNkoV5/Xiny+G0nlivzLc9y2z8ll80nf3GNAQgh6KJmPLePMDE1dG03F2DiaJWQEZu+xqLD8AbLrBBpAiELHfqsdzVa9j07hyR0pid/T/f4CEDOWWLz/T154vPTYwEbT9jwW0I= X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB2643; 6:ueSftDSRSt+uIVs/8NHYL4Qm6sYbQXXQ5/olqlUWSrfL3LLPEgyLv+Lh8Ir+XFdiPZXQacSPn0ugVBB76cMQQQ0eoRGLZVQML3gqs9b7Ty6csZ/S3P65fXB03CO4dytQ7epMPB7A6bdFyMIk5+1WK42mCd/hbl7zfOnh0JTO0hzwYv9hf0hH/OhWcHFL9UB73SJ3zqSpFMKt5AHEl66sSOALvIuMjS4ijnJpJ4mNNuG4YFosb9Fy6d+f9dV1ru/hdCxt8QCRDx1kyD3u0LA2OX49aJNGFlecJvj/s5SsNqBM/Li5siyHI9ZnvnRLFg0/uC9GR61/3x8MogV/9me/dfNrgyu0z9qApYxmzZb/+8119B4bAGcQPE0yaxbvufg970H4UL356Dgs64rq6b+Mmmkj7T6Hm0+ISN9YpR3E/d+r/vrEumRcK4ZR6FIBwQNISrDU5rcHVg8ht7AJmZVaIg==; 5:znbXayKmB5OCtQHgCmeUk+dJdu/jrx3YycCMjMBs4MCC8JBtJQVjWz8hslPrL7ioArYCxvkLFaLWpsF1/zbfY+0oFPzu6hCAy9/izEiwUM8REWTuURxf9Tjzj+GSgkjW9JplbPAl2L/FTyzHhtLr4cxsum1Qkv5InCc27UTweNo=; 24:7pg76y9HqYLV70V993NFs3NaX+WrKsmb9iAqahANaHQWVwc28KCHTjEH4sON0Olsdm8h+AntxURV9gl/ZfTdwdQeEomeF2EkWevsiaxr4AA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB2643; 7:W6XqAzq7zwmwaAAxaeEb2WbglAafKvKMCDukzEGMrUOOl4LutI6+jCkL6VJRv8taUaFljiKTo3Lj+qCBzC56Tu177QtO1w8XGS/wAcu7vxYOP1KrI3cEoNXdAiuzO/YesYUex0ZpffLx+Vz2lPAXlrPxLwJtdeUVbhvUi5G/1u46vI/aN/1A/P98XU8XFqi5xrXPnrrNL/MTysrYhX3hqsIjy28FJ+U2hufCDooWtEPpMy9CY1BsWNFX7JJoSt1d X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2018 13:12:03.0494 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 09de18fd-8996-4c46-66dd-08d5dcf8bd90 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2643 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes below kernel-doc warnings: Function parameter or member 'maxlen' not described in 'xemaclite_recv_data' Function parameter or member 'address'not described in 'xemaclite_set_mac_address' Excess function parameter 'addr' description in 'xemaclite_set_mac_address' No description found for return value of 'xemaclite_interrupt' No description found for return value of 'xemaclite_mdio_write' Function parameter or member 'dev' not described in 'xemaclite_mdio_setup' Excess function parameter 'ofdev' description in 'xemaclite_mdio_setup' No description found for return value of 'xemaclite_open' No description found for return value of 'xemaclite_close' Excess function parameter 'match' description in 'xemaclite_of_probe' Signed-off-by: Radhey Shyam Pandey --- Changes from v2: - None --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 15 ++++++++++++--- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index b2c7afe..a17f0b6 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -369,6 +369,7 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, * xemaclite_recv_data - Receive a frame * @drvdata: Pointer to the Emaclite device private data * @data: Address where the data is to be received + * @maxlen: Maximum supported ethernet packet length * * This function is intended to be called from the interrupt context or * with a wrapper which waits for the receive frame to be available. @@ -488,7 +489,7 @@ static void xemaclite_update_address(struct net_local *drvdata, /** * xemaclite_set_mac_address - Set the MAC address for this device * @dev: Pointer to the network device instance - * @addr: Void pointer to the sockaddr structure + * @address: Void pointer to the sockaddr structure * * This function copies the HW address from the sockaddr strucutre to the * net_device structure and updates the address in HW. @@ -638,6 +639,8 @@ static void xemaclite_rx_handler(struct net_device *dev) * @dev_id: Void pointer to the network device instance used as callback * reference * + * Return: IRQ_HANDLED + * * This function handles the Tx and Rx interrupts of the EmacLite device. */ static irqreturn_t xemaclite_interrupt(int irq, void *dev_id) @@ -771,6 +774,8 @@ static int xemaclite_mdio_read(struct mii_bus *bus, int phy_id, int reg) * * This function waits till the device is ready to accept a new MDIO * request and then writes the val to the MDIO Write Data register. + * + * Return: 0 upon success or a negative error upon failure */ static int xemaclite_mdio_write(struct mii_bus *bus, int phy_id, int reg, u16 val) @@ -804,7 +809,7 @@ static int xemaclite_mdio_write(struct mii_bus *bus, int phy_id, int reg, /** * xemaclite_mdio_setup - Register mii_bus for the Emaclite device * @lp: Pointer to the Emaclite device private data - * @ofdev: Pointer to OF device structure + * @dev: Pointer to OF device structure * * This function enables MDIO bus in the Emaclite device and registers a * mii_bus. @@ -904,6 +909,9 @@ static void xemaclite_adjust_link(struct net_device *ndev) * This function sets the MAC address, requests an IRQ and enables interrupts * for the Emaclite device and starts the Tx queue. * It also connects to the phy device, if MDIO is included in Emaclite device. + * + * Return: 0 on success. -ENODEV, if PHY cannot be connected. + * Non-zero error value on failure. */ static int xemaclite_open(struct net_device *dev) { @@ -974,6 +982,8 @@ static int xemaclite_open(struct net_device *dev) * This function stops the Tx queue, disables interrupts and frees the IRQ for * the Emaclite device. * It also disconnects the phy device associated with the Emaclite device. + * + * Return: 0, always. */ static int xemaclite_close(struct net_device *dev) { @@ -1064,7 +1074,6 @@ static bool get_bool(struct platform_device *ofdev, const char *s) /** * xemaclite_of_probe - Probe method for the Emaclite device. * @ofdev: Pointer to OF device structure - * @match: Pointer to the structure used for matching a device * * This function probes for the Emaclite device in the device tree. * It initializes the driver data structure and the hardware, sets the MAC From patchwork Thu Jun 28 13:11:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 936148 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="AESaKksb"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41GgGT2dPRz9ryk for ; Thu, 28 Jun 2018 23:14:09 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965790AbeF1NN4 (ORCPT ); Thu, 28 Jun 2018 09:13:56 -0400 Received: from mail-eopbgr720084.outbound.protection.outlook.com ([40.107.72.84]:44560 "EHLO NAM05-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965644AbeF1NMI (ORCPT ); Thu, 28 Jun 2018 09:12:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xNOmq6mOLRXeLtr8fz9bOt812t0/cXQYkwLv9WyDn2c=; b=AESaKksbyXkDqq8/gMu0PIGr0oE/38c3lBuo/aXZzRbF19GepUGUb0gctrp9tY97v7eaNc+V/N8bqBdByNSqHtDJyCVGvS8GZWJZI690EkFQZ84wCwMWvznfdnZeENHmqYK0HA/FoLAW2z20Be/QWK5Dx8f8OO8YAfIScKtmFvQ= Received: from CY4PR02CA0036.namprd02.prod.outlook.com (2603:10b6:903:117::22) by BY2PR02MB172.namprd02.prod.outlook.com (2a01:111:e400:2c20::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.884.21; Thu, 28 Jun 2018 13:12:04 +0000 Received: from CY1NAM02FT048.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::202) by CY4PR02CA0036.outlook.office365.com (2603:10b6:903:117::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.906.21 via Frontend Transport; Thu, 28 Jun 2018 13:12:04 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by CY1NAM02FT048.mail.protection.outlook.com (10.152.74.227) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.906.15 via Frontend Transport; Thu, 28 Jun 2018 13:12:03 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1fYWiQ-0006cP-MK; Thu, 28 Jun 2018 06:12:02 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fYWiL-0001yd-JW; Thu, 28 Jun 2018 06:11:57 -0700 Received: from xsj-pvapsmtp01 (xsj-smtp.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5SDBsli027436; Thu, 28 Jun 2018 06:11:54 -0700 Received: from [172.23.37.80] (helo=xhd-paegbuild40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fYWiI-0001xt-06; Thu, 28 Jun 2018 06:11:54 -0700 Received: by xhd-paegbuild40.xilinx.com (Postfix, from userid 13245) id 2F050B20955; Thu, 28 Jun 2018 18:41:53 +0530 (IST) From: Radhey Shyam Pandey To: , , , , CC: , , Subject: [PATCH v3 net-next 4/5] net: emaclite: Fix block comments style Date: Thu, 28 Jun 2018 18:41:49 +0530 Message-ID: <1530191510-10310-5-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1530191510-10310-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1530191510-10310-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(39860400002)(136003)(2980300002)(438002)(189003)(199004)(50466002)(76176011)(103686004)(26005)(186003)(426003)(48376002)(36386004)(6266002)(11346002)(2616005)(476003)(336012)(446003)(126002)(486006)(478600001)(42186006)(316002)(110136005)(4326008)(54906003)(106002)(51416003)(6666003)(14444005)(2906002)(5660300001)(52956003)(2201001)(16586007)(90966002)(50226002)(36756003)(8676002)(81166006)(356003)(81156014)(575784001)(47776003)(106466001)(305945005)(8936002)(63266004)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR02MB172; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-83.xilinx.com; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT048; 1:Jn8n39cb5JJHxreSML58X5S+Ak06SLpNOi2yZ0wDW/VcTvbMeHRvU8mkM+MlPBuKBlKcwwYsHNO/z9GNE8IFNl9Us0oN420LkZL9NsU+dAdk9cboO96tbsBpa5V0zbRs MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 38dd2f35-55fb-4e3d-fa29-08d5dcf8bdb0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652034)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:BY2PR02MB172; X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB172; 3:P1IqKSvHJCORItEmMVWWNZcLYW8mYaTxGGp9cBbmV1chvufVXLajSuWAD9Zmb1+RaPkjyVseymoeuITTMV+R9Zx+1ZExQaChGy7RJsg/4TojsaPT3byq8p3rPCcXQs1ZoazY0y5u95sjgzeySOw/MeHs/4BKsbVNbFTZb9cPpXOOR5njFe3afNdz4QixAewJCFxCxqP5Vcny63vT0Q7/Y6EuerjPndhXxtDUYvkvc/4lKrmc/sneRBt7qt8neHXWO4ouNNN1QI+xCyXn3TTHgMrEhrZvPeL22souQatYKN3q0kLwUATeC5kpyWDRbygnw6thjz9ygPsSL5xdWSa3XHh8S0b3hYHPEqvc/HD01O8=; 25:5QC+hUMS0YWOLoXSeqgnmEPzcn1WX9uf/qkrgNHjw4OvvODwHleozdzZiJd848xt4YbJQQwuaASQY1Kt529DVE1FOSipLd89PG9PRNFv5Ussd6vvEs5yR3FpFqMXI6aJoljINyZJBIOHATzc5W/K5jrW+w5WrKvWTgFKPbEBBnSn9jARpo8kx+UaHVRmhEW5o+5BLBLTbxnuHbRUo2VOHexvf8tU5m1XwkBvJAfwHJWVYO5H1LHKbKyrOz+PWKb8XemjC+8iZt1EOPWHJfWw2wt1XRBvv9rDoh1jNwPh+aiTgE3ILgSxWMzVkT6yCVJ/wDcx/Fwnq9mnSCshfMegiw== X-MS-TrafficTypeDiagnostic: BY2PR02MB172: X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB172; 31:vdL2X7mxlGsndTRT+WTERmU+C6y1BuobHbMR3L+AI4K2t5UehZEVQpCFiMQ7P8yeJ+pLJ7gOJ7UjMfsdc1lfAvfjo7qVIwNUn2GKtieoGIJSjgAU3Pz1MnyW0rYD490iYFEWwteEnCrIOA0Grxw5OSCvfRkdNhhSHYqpHGwFg918y40RmgJgquCVtARWqCByKvHUwbpfBLuIr7ZXvhWr0ZxuGfqjJ0TmVpMUeTYAx+Q=; 20:iksHvqlP+NW9T7ktv/9QRRXI8gIaXxy40z7G+vfo/A76z56tYJazTrc2CkWHS1ZeOG+bc1KRFbEJVj5GHZ0qU0CGawJUlziLCqa+Pv/RXQj7RUpGzYPifyaQUljRH8VQjfw5XT38nmuEXiUxI3nb6qhIkefAyyk44wkab5DbQ+gnpN8pnNL8oFr0LSAvyHdM2UoxhxpsG/bsfUXyvLQreZhYgXvvpC6Wl+b4asI15rzUWZQgEfRwo4qQNHMAXObEnHQLlOarfKYTw0QJ8VzGo8ypORdB9ApMA2WOxTFha3YsT3UV8D77dDhDTTHqXm2XOTa6A151XVDROeKqZ8BDS4gTxRDxws6z5EQx0j4LQ5jDyGyK5bklDo+Dvk2S4HTMu1Aka0xH0Gvx5+d+6xPMZy5KILzGJKwzyzgAhkWbzb5i0cJL2EFVrfNsgtrhzxYvSmPT2dHziKucu6/Nda4yxnJzLSlCKwhZ/bv8N6dNX/T3pO5mLQ/sxIwMbzww4hAc X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93004095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:BY2PR02MB172; BCL:0; PCL:0; RULEID:; SRVR:BY2PR02MB172; X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB172; 4:Nls5jZieBTvAtzROef/oze8KMycKn1G/lNUVfYc9zLZnTG6MHIkGOxfpFeHSCA+QFKUAN2Z+W4pTowO1wuUTTKdylWccHDyWAIuBOfpJn9u/n336WDxoMwdxZIbnXnEXwjXIMCMqu+QybIKwvYNs4Aw1VMWQ7/TsS3AD6qEZd34T3ZxdfaypfyDZSTsPL271Z0WvcxeyPuyxlRrkQIhLBqAI7+jU2OG4MEguo+ypUBGso2LJ0yfZXt6UH+B8b457+YxiY3/fIj4CnZyPKz9lBiWRCJAP2NtMbWjTCCjLHfkx48Ob8n88wEcZ7kMaTLa0 X-Forefront-PRVS: 0717E25089 X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB172; 23:Gab9szGY0lr2qDg/38xAvxYBnzZFgNHz5o2cIOL+DWZbGq7tXLhnieyk5FudbtZrBjsGzOnzWR81zrPsYu9YPXQw6aNVEPpCydWC6/2wlaaGqe0Whp7xCbYtErIPOsxRUmZ39asG9hjTyuxqjiIgaRZol+X/sqGImPZCbp3GudGQ4gNaddF4d9NJ1Ckhb7BDmlEQE2bN30tpvYlbrftnMLnA0WUUGppnbGfzzYovEO9L+tJYGR22LsHyTshKpyNNqsk3Tbgx8yFUmHIdRHfPikg9sWaRpT1IPKLlVcy8TA9kba/svzinYo4WlkXHhsodLckFQi6WQO5aqPLOfPbcAwZjtxjgdE2ltklenzCKrngPvAIV5KBaL54wHGsuzKmx3JbsYQyT30OOQvg7X8Mv3OVBUEAHUF7bAkgztFw8ZCvp0NBqdqeafaLdodNAmo7u5QZuTrxFzt4rIyPvJPd6xjw6YbWVn97Xq8Wn7r2/Mj+Fx5omkGuDJ1DmrTRO0PgxufwIiZHNSnU6TEgdMvG9/PZdzWrrvv40/MBV6DRqmwrtMJul/zr/K1EGInjHEvBQnHC689j9iGp3urbz1vhim3riWcQ8W7ibq9X4J8aPi22ieucG5dZEZ9SdJNM88r1ugWB87ZhzitiezSfcU3mryfEgVap/0dul/zZiKJsHTuWfL45DkrXYf+gMGGB1UkxsRtfbcgpS5TEWv4MSibZ5dlciaq4x7b9v9OdwTdun5h+zE4QNr1hCaiwEiTBwtJwIGUKriyDcA1+iMUg87d/aDBHPKHd696xUrLkeLnct/VghRnzPPlD1FhvVGxxmfbT0IwvvrEaXuKiz8wxnNS0wxhEm7Dr1XKg4MdnUQJhcHtnKebqj0lx9oCZLwrer7iCw9BA/el9z3QqmLE2+E5oGNYJY+XP3jj7YqPaANgWGx27B9ctcWogoopWR5CVuVVwAUzqOyjE1ojHzS5UtV/rTjsqjEgw6EkJ1WLFc1FoW2CDut4q57SfP73FFNfsWdtoVcKQqYuTN+lUAkCcwHOBIFH2fyZQmYvnQMs5qpjAuxXP4A41Qy0X1QEjLE6Squ4bRYai6D89fV6JVyrZE2mmTNMCK2IKtE7ZQv8R5RsaNzYERHzPaZEkoUR9CLYKzKYn7P8UCkSCpZ7omjvW3lrW8VRKeVpzuAPwfKLOAWsGBrkY= X-Microsoft-Antispam-Message-Info: nBxpX7VVagAH306oER84p/4XKYLlKOYsbgTp0lhLQP3jpxXPXLeoIq1JIkcdVqrXtCVCowGGjs0HT20jNPATCwLIa8Mbx9epEfnGTchigo/Oaw0j/03PDimfb1ee735IiHKbp5zQlVBoNs+FX6rJPkMYwcRpcJOC50naPKFmT8rlLDu2ZOzgAcsFecFBoEPSWScvJVgE0DKhjkXUS73aEC4cwXioO8oLl+lr+/Z/G1fgZI6bPMvVKOxlHOIghywG+wItRUT6HVl5yiw0xZXbX2PSXjui66urwTWCG4otrRMstc96pW0FNOzLLiHtJeBYrLOyAYzFPDjVFGK7hoMrLflRw5VEeeYLYlGZ/s0KKaQ= X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB172; 6:h+gk51w31gf6SC2a5iUlLRl1muNhnZ98XtKzcuDTm10CYSu/L3gJ7dQ7XL/hsms69/LpP2MPqHUykZ77KUTyF21jskXc12zMlkGkzhnonn++pl+K4UQ9TfcHxv04dTOCcTAlLfCKDgJK8OdVs8cazZfziWeYsoig9bygUAuFEjGNoj9r9oZ7fRN1JYZKt0hLVwzYOSYsI3RCz9ln6DY2T4spqNKeO0HcoONzAYZtlD80W29GwDl2nbIbRTaO+PtIFo25h2eNJ+zU0f08m4txI/2BXyvbkStN5c8jWOiSXKZOteUcc8ahICULVG5jiY55/4w5H/yGKvhG/Xk8lS49y98CzmsvQsDEJx6IY08vSOwqvgVnVz4CRYDwNRajk21viTKQRuAmah/jYg+6lectxurBcxMf+IKNP9qFVqA3MHp8djEcCuMOGPGTy6kuVsQPxXx5XgvK9Q1seOIZn05+rQ==; 5:RCZA9UyMQG/VjmInXe757pRQmfOfC4R3L/kW0OWOv7cmoget0o+XNPUB0MFrkumPGLfRP6Sw42RVt44+b7+6ipgYNeMM6IdN7CwhV1NS8+iuD7KhTPWh+TTxQdirGAQveFLQ7chZELOBJ1eI++lP6roIxEvAKZvSR/HUXJA1dn0=; 24:uIZ4SDGSJEJ+Vqd8rDhKvzr5gvu1Dxq7TdLNPX2GoYgRUs3BxLSZYNiNYzVw6TTVfx2gZT2wBwWvrrfRhGvnGu7WCh08P4deSCz/AJOy1Gc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB172; 7:UaZjvsGgLEyJzPANj6/GKq+yyiX+LzWUPwSIBcE4nZLnxo5JAu7JN0AIL9KrBkQQyPxE1FfCK6q9VXwsM2t0bCKsqk3qGiySGHf32pEq3DWqoqpnAPQu9gRsTEh3V6IFj02SrFHSu/gf88/Uz+tptsuFoc3t8poruwaULOO9Pwu57yLXlHVIuWoTAfc/BsCgFBxJpy2oNYe/FnRtGBy/NallafJllGxtqM6AZoVCEJ/cE+7yCWqOmzXhZ19HkJ/1 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2018 13:12:03.1066 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 38dd2f35-55fb-4e3d-fa29-08d5dcf8bdb0 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB172 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes below checkpatch warnings- WARNING: Block comments use a trailing */ on a separate line WARNING: Block comments use * on subsequent lines WARNING: networking block comments don't use an empty /* line, use /* Comment Signed-off-by: Radhey Shyam Pandey --- Changes from v2: - None --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 34 +++++++++++++++--------- 1 files changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index a17f0b6..f96c920 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -70,7 +70,8 @@ #define XEL_TSR_XMIT_IE_MASK 0x00000008 /* Tx interrupt enable bit */ #define XEL_TSR_XMIT_ACTIVE_MASK 0x80000000 /* Buffer is active, SW bit * only. This is not documented - * in the HW spec */ + * in the HW spec + */ /* Define for programming the MAC address into the EmacLite */ #define XEL_TSR_PROG_MAC_ADDR (XEL_TSR_XMIT_BUSY_MASK | XEL_TSR_PROGRAM_MASK) @@ -336,7 +337,8 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, drvdata->next_tx_buf_to_use ^= XEL_BUFFER_OFFSET; } else if (drvdata->tx_ping_pong != 0) { /* If the expected buffer is full, try the other buffer, - * if it is configured in HW */ + * if it is configured in HW + */ addr = (void __iomem __force *)((u32 __force)addr ^ XEL_BUFFER_OFFSET); @@ -357,7 +359,8 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, /* Update the Tx Status Register to indicate that there is a * frame to send. Set the XEL_TSR_XMIT_ACTIVE_MASK flag which * is used by the interrupt handler to check whether a frame - * has been transmitted */ + * has been transmitted + */ reg_data = xemaclite_readl(addr + XEL_TSR_OFFSET); reg_data |= (XEL_TSR_XMIT_BUSY_MASK | XEL_TSR_XMIT_ACTIVE_MASK); xemaclite_writel(reg_data, addr + XEL_TSR_OFFSET); @@ -395,7 +398,8 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) /* The instance is out of sync, try other buffer if other * buffer is configured, return 0 otherwise. If the instance is * out of sync, do not update the 'next_rx_buf_to_use' since it - * will correct on subsequent calls */ + * will correct on subsequent calls + */ if (drvdata->rx_ping_pong != 0) addr = (void __iomem __force *)((u32 __force)addr ^ XEL_BUFFER_OFFSET); @@ -409,13 +413,15 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) return 0; /* No data was available */ } - /* Get the protocol type of the ethernet frame that arrived */ + /* Get the protocol type of the ethernet frame that arrived + */ proto_type = ((ntohl(xemaclite_readl(addr + XEL_HEADER_OFFSET + XEL_RXBUFF_OFFSET)) >> XEL_HEADER_SHIFT) & XEL_RPLR_LENGTH_MASK); /* Check if received ethernet frame is a raw ethernet frame - * or an IP packet or an ARP packet */ + * or an IP packet or an ARP packet + */ if (proto_type > ETH_DATA_LEN) { if (proto_type == ETH_P_IP) { @@ -431,7 +437,8 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) length = XEL_ARP_PACKET_SIZE + ETH_HLEN + ETH_FCS_LEN; else /* Field contains type other than IP or ARP, use max - * frame size and let user parse it */ + * frame size and let user parse it + */ length = ETH_FRAME_LEN + ETH_FCS_LEN; } else /* Use the length in the frame, plus the header and trailer */ @@ -602,11 +609,11 @@ static void xemaclite_rx_handler(struct net_device *dev) return; } - /* - * A new skb should have the data halfword aligned, but this code is + /* A new skb should have the data halfword aligned, but this code is * here just in case that isn't true. Calculate how many * bytes we should reserve to get the data to start on a word - * boundary */ + * boundary + */ align = BUFFER_ALIGN(skb->data); if (align) skb_reserve(skb, align); @@ -708,8 +715,8 @@ static int xemaclite_mdio_wait(struct net_local *lp) unsigned long end = jiffies + 2; /* wait for the MDIO interface to not be busy or timeout - after some time. - */ + * after some time. + */ while (xemaclite_readl(lp->base_addr + XEL_MDIOCTRL_OFFSET) & XEL_MDIOCTRL_MDIOSTS_MASK) { if (time_before_eq(end, jiffies)) { @@ -1029,7 +1036,8 @@ static int xemaclite_send(struct sk_buff *orig_skb, struct net_device *dev) if (xemaclite_send_data(lp, (u8 *) new_skb->data, len) != 0) { /* If the Emaclite Tx buffer is busy, stop the Tx queue and * defer the skb for transmission during the ISR, after the - * current transmission is complete */ + * current transmission is complete + */ netif_stop_queue(dev); lp->deferred_skb = new_skb; /* Take the time stamp now, since we can't do this in an ISR. */ From patchwork Thu Jun 28 13:11:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 936149 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="MmbhAFuB"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41GgGh5xcYz9ryk for ; Thu, 28 Jun 2018 23:14:20 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966001AbeF1NMI (ORCPT ); Thu, 28 Jun 2018 09:12:08 -0400 Received: from mail-eopbgr720066.outbound.protection.outlook.com ([40.107.72.66]:46544 "EHLO NAM05-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964921AbeF1NMF (ORCPT ); Thu, 28 Jun 2018 09:12:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fCDvwAOqrb7TGOifQTqqRWg4bpWH9AP3SzMg8Tlljzc=; b=MmbhAFuBhJkW+c8YaHMB2pL3pHvEOuDcD7BuyhTV8YLtZBneo9yef3BYmQmt316dYkJuiIvdYtmHE5F7LPouXPxHCl1rWCpr9Htgj7PuTB3o9m3JN0pmNRULLdechRwjCdUCg9AVlaYpFUUsk3qwzyUK4Dc+aNrXvqabnZf9wHQ= Received: from SN4PR0201CA0003.namprd02.prod.outlook.com (2603:10b6:803:2b::13) by MWHPR02MB2653.namprd02.prod.outlook.com (2603:10b6:300:44::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.23; Thu, 28 Jun 2018 13:12:04 +0000 Received: from BL2NAM02FT060.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::201) by SN4PR0201CA0003.outlook.office365.com (2603:10b6:803:2b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.906.21 via Frontend Transport; Thu, 28 Jun 2018 13:12:03 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BL2NAM02FT060.mail.protection.outlook.com (10.152.76.124) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.906.15 via Frontend Transport; Thu, 28 Jun 2018 13:12:03 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1fYWiQ-0006cO-Kv; Thu, 28 Jun 2018 06:12:02 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fYWiL-0001yd-I1; Thu, 28 Jun 2018 06:11:57 -0700 Received: from xsj-pvapsmtp01 (xsj-smtp1.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5SDBtKu027111; Thu, 28 Jun 2018 06:11:55 -0700 Received: from [172.23.37.80] (helo=xhd-paegbuild40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fYWiJ-0001yC-1o; Thu, 28 Jun 2018 06:11:55 -0700 Received: by xhd-paegbuild40.xilinx.com (Postfix, from userid 13245) id 3C275B20956; Thu, 28 Jun 2018 18:41:53 +0530 (IST) From: Radhey Shyam Pandey To: , , , , CC: , , Subject: [PATCH v3 net-next 5/5] net: emaclite: Remove unnecessary spaces Date: Thu, 28 Jun 2018 18:41:50 +0530 Message-ID: <1530191510-10310-6-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1530191510-10310-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1530191510-10310-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(376002)(396003)(346002)(136003)(2980300002)(438002)(199004)(189003)(486006)(48376002)(76176011)(2201001)(50466002)(51416003)(52956003)(90966002)(36756003)(16586007)(14444005)(316002)(42186006)(426003)(81156014)(336012)(476003)(126002)(2616005)(54906003)(106002)(47776003)(11346002)(106466001)(26005)(186003)(81166006)(8936002)(8676002)(5660300001)(6266002)(446003)(356003)(110136005)(305945005)(478600001)(50226002)(63266004)(4326008)(36386004)(2906002)(103686004)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR02MB2653; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-83.xilinx.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT060; 1:VCZ8tj2oCsMTMa7KNfRXzuNDW1TyqBZOzkdQ0O3n8s3PeiGlt6OXXiNMXdrOniYfLPBAezgXTHzSLTvUj1M7byPq5OZgHcbt7HntJOQjwZXi2p8IQSuhsxQSvQr183O+ MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: db40c707-5c87-4fae-4178-08d5dcf8bdbe X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652034)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:MWHPR02MB2653; X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2653; 3:16IZJyadUUcVj3r6vyas6zbLOIxQ3jxuxCznRer1GYHD0Ay+RWFSb3WzOorq6TCCuBwsZSFdws5JPlhXHraZ97FgyhtIzdborZlt70ZXOEKLWQnaS0WC6qmAWFs0SastcsF4BfSWp0M7M7CPnAr+2CoFbDyCrKRLTPV/SnAHWzdx7Qv7NazKJojNx/fYsEZNTZYqSCtYNOTjMZMmMS8lek9gxlisygRySgMMJtXWCok1iGLa/MCDX9X1AjQevTzfbTw/ubkZf7sfp3SVyQUqjf7q3kWThzQg7RwFqeZ7SYkeyhZd6ffmcUYpf7YZ9DwlE8XHqX8Y2P+ZY6W0AcSfrURn0WZ1TjRaluFkHg5HkF8=; 25:mhoAwgJLGTjPpG2kRT7B7XmQDT85caISrCR+Ly0naTle+AkY/5FloChHLynq4eZneFmjEEgk7cYsDS0w2KQS+Ovc1gNmkJdzU5W0aY6Z9p08KeVwA9JtLBUTb22IxP3eyFfxDffn4JRyFBaz+gnxdA2gUkn2WGFUOxD9L+Q6pFMiRoMKJ9UIfQ/LewVRP469RU3EUyc4DoQOZtqRjr+n488bHCREE4V534EpYN98b84NrcLs2M0L2eq7nM9IrqZDj6b1XcTYY7AeEhtmlGeDOhlTt34WMA5IzplSggBBhUB9zSksoAwGQaARGGP5bM3SBv44jBR2TJLOwJ7b+LHIuQ== X-MS-TrafficTypeDiagnostic: MWHPR02MB2653: X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2653; 31:oIrMAKzgJHu1YbuKtgbdm+iX73gSDNH6e6JCmW+5wSa8wcHfSEDvnbgnJk7lhKtLNfiS9O7m4LW/dnhLNsturPqNPXJ+SMkTIIKP04gxtrOu2Jp7966BggpsjY7Nft8U1Km0i3kCx0B0rlo0DyA4GIpobtTfeGyg6gHyIGWh+QfkO/BUxr/Kmu/E4rzm3eTxhMVK+s5PBmZ1603J616sxcjsqqy4yFO5kqowJTbGdPI=; 20:o9juoHFu0AxcMz/K3kvT70JmdQHCOYkKaPR8i9ITJ3uZxKC/0vIU+qoTA3yJc73nxN1DDYW+eMYRwiNnimTNU9zJ/n3jiEExwxqqkjhTmEDnyQV2sNH+PG3dBO+7X0O0j86HwohnvCO9ddSUppc+jJoduMPBUUrs/RjcdGVbS3zKg1EJ6dlYvG2Xx79TKuRqM+nVti4V+WXg7ktJoBwm/TJn8l5/nGJD29hZyCtxm6v62Ixsh3iLKdNBW89WDL5q2E+XmQ05ix8NvEXjWNeLImfhSAFO5RE1iA7jpBVhUj1nm2+YJi5N2sTCq3N5Ge+gm/HobYcSDPiDPZD3Qz2SuI8ZJYQ+UbockD/sOtNRnbMkVrbxImXjRU94GjiZ0puZ6JlVPnkrXuoEgldUOXml3DezfxTjAYGWAmNDpJgg/uE+J76ygjbl2qZUAjjIgi3gKx8vK8cdYwkFCZpWqJ5dMe2asinWVZNOGfo0wgn8tqFSVrW5iT/d+jqRD28ng0OV X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(93006095)(93004095)(10201501046)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:MWHPR02MB2653; BCL:0; PCL:0; RULEID:; SRVR:MWHPR02MB2653; X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2653; 4:Dl60OICu3pOud9I70Vgj9Gru6fbDXVowntlRygFBrbrE5MQh3DnM8O0u83VshFYEfKxNZK42BafUUZ+eunQaIFd5A2U+XgphgZC6/n1PtMsGp8J+rP7pH27cDfce/+6PQ5byloFOa4wJpukmEbjCPaFXe/KUiyTYls9FesofTKlfPdO52v9k7q4yZOq83n72Fo2fNkxIwpdBwMDzS8g3bAxPt+GOMCO6jUNl20kd5LHLdBfPJUR3xVBp4Ni3uAHIwEvexXeQeOpx33NgBp5HsnrOXYB/T+jm+kMYh2k1fiAhNYfbjqCMkfQqTpX5Zcmm X-Forefront-PRVS: 0717E25089 X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2653; 23:qxp0NB3Q/NOYb9vMDs0/y8lfIT3N384OIa5fFUcPIBuezXxeUoV30nLjNBsVuPHh3xIS9BMr4xN0jMbcO4kQel6mhxRbfbk5oBD4uCarA6+ibShrBld3XH3YRRf7mluX/kD/qUX42yeJgS0uw9qbkbh9nyjxsu8vjSqx4sFJxZJeNltaOVzfiDzJncNFpUAbyuilSp7dMhoc3B0U48rHI2v/T8YZiNXyR78c9qgKKi1B8WLvJoMmgN0j83RMt4Y9uhLX0XQBm6segOzx7hfgILcerEXECp2BMlcANdcgznXCE/QaRDSRY1qnN/JrAI5nXiewuUUOYxF+CCcR9EXfDmagDo+kLjX5AsWso+hsOd3WaNFiUZobqfjZUvYat4MnLloMzZhzn/jepcXuCDYFVY/ExaxLlz2M++L+VHe8LYOPzB/ccKT57hyd3IKLf5zCkcl86gKbuRFcQ4TlwgISPZ2vM7b8lBab5KIy7nVfejOfUqOEVKH9C80L+WsaKLPaZRNsxedQxCSZBA8d4gdnRlIr0wB6tdcv0rfNVXuER8qw6LpVFHB0+REbTRikoCYPxLLPVf0AX0/08Uk6FrUahbtsFUU4SdO8tMcg6QvytLUDPp610ppHfPtKEO8WiKBAm7eHr39MyRXXu88Af6t1ORbTu3grf4swxmTDgG1wGlayUPnvpwrFv0Ek0NBBUw1PNgyllu1wR0WRPVNbgou16ftsPgsYnM4Ii2puMCv8gIXT65ApD7wYqLsdb1b9bBQhw165zyNq3DNWgm5lW7Y+yFTh7PzCuJaCeLkYhG+JVa+xk9LnEvrN3thXdqX93+ibmOWggPq3OYOOrVjTjxCuPqiZY+WNK544Q2QVOYAHPCLNHJCZ9CAoRZtqzKzVVMQa3Njh7wzmGbhk3vWDiMTXFZ+FLI/N/d2yoA74eGSIM372WSW26C2WFSrGVqGDSLMG/cEcQZbdK+ralD3Hox7SjwVtVXPuq2NaWU5MOxlfrTlYsbsOrslZPMxjTAUhPj/V1DGTidNh0tOpTAKSR6selQVX4dL0+F+41U8fj3Pt4XaU9VSbtdjodCAgtuDlmRPy3whz9HvbRrXygKqxXQCIr7BHdAgGcK4t/RDO2+S2lQA0f9YmD/wbzLjAg7y12w8a X-Microsoft-Antispam-Message-Info: 5s9ur2gWKvufsLB/9KBo34go+DQE5R0lfFnibWoiTgQ3dhv8GuJO6tgYIwxSg5K2AEs5+NHay/Xi2v0AMdAs5D3/Frd4s7eVGgz/IDYZvsR77ifxQLOGTjIsfj6DAXbGGI5Afr+aw95z6apnkl9i7BGDJfQNY8S4NWm+VCtPL8P7LqmNYpOoM903ItiL4t4HH7Whph723d3oioPwxAjpO/Avatyl9yAiZ19UbsAcLDjBv18CgDof7G1QJt9Fzt39hZLsBnyuok1NVt05SU/wcCa4kGJ0UsaPO4Bv6atzXMNatEg3tbd/B0M6N2Q/T/1xC3UOZEZzZKHuDUgSCEl2KNvUarYt9EI3a+IAapAcz04= X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2653; 6:sNzwxuKJ/GGml7BjZvIKNhbvdGJwmu7EBr++dRXOCaq8FdS06h61ECxsACyry7Wshh8wYbiO4ZxkzkaCSYZYOkDvLro+qDKlRK80KnCTY+nnOt8XsyOX3NIHHt4H/yoQE9HL1ODR20pUibY5cNP3m9FrXthzRdX68cvzIgK0rs64g3kGXCLN0phYM+RSbfSQanzooCzvEpFGutMJMr6cpK+h9U97DWtGsYno5wN9vZoN2R/vXhhjpM6Sy3kTaA5mEi7QPhNXUPGZgsgNZkezsJ/PrU1nuhs75Ldz8QpvMPUXHHGCYucOwpvk3GKgjRX0JZzreeophwVPEnNqZzV+jhUrzYcalrsVajPH6RAbvy9VrG6D8MtENezp/NI0M0HIEVfdz1eounY78rsQM8EqySGxExnJHetx0Ty6CcRC80S+lMbB8OgZ8mnma7JRG4ei4v0iEtDZeUpfgK2mNdoAXw==; 5:ARIR5SxY8gMwxnvuG7WFpuUcJA6WlYyKQyAZLYVFiaOFCzcJar3ibTEa249WWQgkbUeJlwqodtdQIFKLN7XIx/ZiJWzx+lluorM/ROiESJ7wfXFJSMp+iBMmuhIq77baMG7PyEpAl+zaW+r5619sOxY6vS9eXq6WyOpUiht1WRg=; 24:z3YjsbPTUckVta0DuNYSGBsFsOdSdrvPe2EPoMEv4SAZoQlNGRNtjQNX7AKllU6GMG+eQmG6HCjz36SJYH1UmMSrGPwblDgTQMYBwl+Ogmc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2653; 7:rv0lUlPT9LtRmcPGhwfacqoAp3c5QA2I53PbFhSmIdBjKj3tmM2e0Ev7w6LjShoHRtzUeiSDKiR31L7ZHMGR5HAE3z0nF+cev3gV+UaX9ZD0WE+IRZrHpIcCATxjqwKtoEGeaXK9x6LL0nEfcQgoohP4L3S1H3Jd/N/6/TkDGiv1Nsm/g/PN2HO8NDuFriax/c2UippZ7mQGsBBfAOhq53yuKD6WYZnr3i8vD79skjxnT0LKjBALNQVge0ljgzdH X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2018 13:12:03.3655 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: db40c707-5c87-4fae-4178-08d5dcf8bdbe X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2653 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes below checkpatch checks- CHECK: spaces preferred around that '*' (ctx:VxV) CHECK: No space is necessary after a cast Signed-off-by: Radhey Shyam Pandey --- Changes from v2: - None --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 27 +++++++++++++------------ 1 files changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index f96c920..42f1f51 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -95,11 +95,11 @@ -#define TX_TIMEOUT (60*HZ) /* Tx timeout is 60 seconds. */ +#define TX_TIMEOUT (60 * HZ) /* Tx timeout is 60 seconds. */ #define ALIGNMENT 4 /* BUFFER_ALIGN(adr) calculates the number of bytes to the next alignment. */ -#define BUFFER_ALIGN(adr) ((ALIGNMENT - ((u32) adr)) % ALIGNMENT) +#define BUFFER_ALIGN(adr) ((ALIGNMENT - ((u32)adr)) % ALIGNMENT) #ifdef __BIG_ENDIAN #define xemaclite_readl ioread32be @@ -239,8 +239,8 @@ static void xemaclite_aligned_write(void *src_ptr, u32 *dest_ptr, /* Set up to output the remaining data */ align_buffer = 0; - to_u8_ptr = (u8 *) &align_buffer; - from_u8_ptr = (u8 *) from_u16_ptr; + to_u8_ptr = (u8 *)&align_buffer; + from_u8_ptr = (u8 *)from_u16_ptr; /* Output the remaining data */ for (; length > 0; length--) @@ -273,7 +273,7 @@ static void xemaclite_aligned_read(u32 *src_ptr, u8 *dest_ptr, u32 align_buffer; from_u32_ptr = src_ptr; - to_u16_ptr = (u16 *) dest_ptr; + to_u16_ptr = (u16 *)dest_ptr; for (; length > 3; length -= 4) { /* Copy each word into the temporary buffer */ @@ -289,9 +289,9 @@ static void xemaclite_aligned_read(u32 *src_ptr, u8 *dest_ptr, u8 *to_u8_ptr, *from_u8_ptr; /* Set up to read the remaining data */ - to_u8_ptr = (u8 *) to_u16_ptr; + to_u8_ptr = (u8 *)to_u16_ptr; align_buffer = *from_u32_ptr++; - from_u8_ptr = (u8 *) &align_buffer; + from_u8_ptr = (u8 *)&align_buffer; /* Read the remaining data */ for (; length > 0; length--) @@ -351,7 +351,7 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, return -1; /* Buffer was full, return failure */ /* Write the frame to the buffer */ - xemaclite_aligned_write(data, (u32 __force *) addr, byte_count); + xemaclite_aligned_write(data, (u32 __force *)addr, byte_count); xemaclite_writel((byte_count & XEL_TPLR_LENGTH_MASK), addr + XEL_TPLR_OFFSET); @@ -448,7 +448,7 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) length = maxlen; /* Read from the EmacLite device */ - xemaclite_aligned_read((u32 __force *) (addr + XEL_RXBUFF_OFFSET), + xemaclite_aligned_read((u32 __force *)(addr + XEL_RXBUFF_OFFSET), data, length); /* Acknowledge the frame */ @@ -479,7 +479,7 @@ static void xemaclite_update_address(struct net_local *drvdata, /* Determine the expected Tx buffer address */ addr = drvdata->base_addr + drvdata->next_tx_buf_to_use; - xemaclite_aligned_write(address_ptr, (u32 __force *) addr, ETH_ALEN); + xemaclite_aligned_write(address_ptr, (u32 __force *)addr, ETH_ALEN); xemaclite_writel(ETH_ALEN, addr + XEL_TPLR_OFFSET); @@ -572,10 +572,11 @@ static void xemaclite_tx_handler(struct net_device *dev) struct net_local *lp = netdev_priv(dev); dev->stats.tx_packets++; + if (!lp->deferred_skb) return; - if (xemaclite_send_data(lp, (u8 *) lp->deferred_skb->data, + if (xemaclite_send_data(lp, (u8 *)lp->deferred_skb->data, lp->deferred_skb->len)) return; @@ -620,7 +621,7 @@ static void xemaclite_rx_handler(struct net_device *dev) skb_reserve(skb, 2); - len = xemaclite_recv_data(lp, (u8 *) skb->data, len); + len = xemaclite_recv_data(lp, (u8 *)skb->data, len); if (!len) { dev->stats.rx_errors++; @@ -1033,7 +1034,7 @@ static int xemaclite_send(struct sk_buff *orig_skb, struct net_device *dev) new_skb = orig_skb; spin_lock_irqsave(&lp->reset_lock, flags); - if (xemaclite_send_data(lp, (u8 *) new_skb->data, len) != 0) { + if (xemaclite_send_data(lp, (u8 *)new_skb->data, len) != 0) { /* If the Emaclite Tx buffer is busy, stop the Tx queue and * defer the skb for transmission during the ISR, after the * current transmission is complete