From patchwork Thu Jun 28 07:39:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 935978 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="eA8/nYqZ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41GWtV2m5Mz9ryt for ; Thu, 28 Jun 2018 17:41:22 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965087AbeF1HlT (ORCPT ); Thu, 28 Jun 2018 03:41:19 -0400 Received: from mail-dm3nam03on0082.outbound.protection.outlook.com ([104.47.41.82]:36469 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933985AbeF1HkC (ORCPT ); Thu, 28 Jun 2018 03:40:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fFSggHwdG7nvh9KYZA41ycqlvu7/5RFSBhdpJ4ztS6U=; b=eA8/nYqZruDGAURoBh5i/qiFFUF7p7POG8j3MBXo6OkLMRCHHAQqaa8Rui1Sjc3u48ML2McPITs3vE6CfdI+EXz6F8zb0+6dUQNqyeCoOBu3WNHoYSErS5OW/w3fXOmgoXCyAvwIiZ82SjASHHT0ihnfJLywwiwdkMpXbXlHWPs= Received: from BN6PR02CA0095.namprd02.prod.outlook.com (2603:10b6:405:60::36) by SN1PR02MB2157.namprd02.prod.outlook.com (2a01:111:e400:7a48::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.23; Thu, 28 Jun 2018 07:39:59 +0000 Received: from CY1NAM02FT020.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::204) by BN6PR02CA0095.outlook.office365.com (2603:10b6:405:60::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.906.20 via Frontend Transport; Thu, 28 Jun 2018 07:39:59 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by CY1NAM02FT020.mail.protection.outlook.com (10.152.75.191) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.906.15 via Frontend Transport; Thu, 28 Jun 2018 07:39:58 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:34936 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1fYRX4-0004OH-0N; Thu, 28 Jun 2018 00:39:58 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fYRWy-000195-Tb; Thu, 28 Jun 2018 00:39:52 -0700 Received: from xsj-pvapsmtp01 (mailman.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5S7dlMd022788; Thu, 28 Jun 2018 00:39:47 -0700 Received: from [172.23.37.80] (helo=xhd-paegbuild40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fYRWt-000188-CG; Thu, 28 Jun 2018 00:39:47 -0700 Received: by xhd-paegbuild40.xilinx.com (Postfix, from userid 13245) id 892DEB2067D; Thu, 28 Jun 2018 13:09:46 +0530 (IST) From: Radhey Shyam Pandey To: , , , , CC: , , Subject: [PATCH v2 1/5] net: emaclite: Use __func__ instead of hardcoded name Date: Thu, 28 Jun 2018 13:09:40 +0530 Message-ID: <1530171584-20673-2-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1530171584-20673-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1530171584-20673-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(396003)(39850400004)(2980300002)(438002)(199004)(189003)(81166006)(336012)(36756003)(6666003)(478600001)(8676002)(5660300001)(47776003)(575784001)(36386004)(50226002)(2201001)(186003)(6266002)(14444005)(305945005)(51416003)(356003)(26005)(8936002)(2906002)(126002)(76176011)(50466002)(106002)(426003)(103686004)(42186006)(106466001)(81156014)(90966002)(11346002)(52956003)(486006)(316002)(476003)(16586007)(63266004)(4326008)(48376002)(2616005)(54906003)(446003)(110136005)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR02MB2157; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT020; 1:2+UgbRxpZK5wai/uSsgW/vW+KeSrFHf2DK/+hNuaYscE81OHaemAIs27E0hz8Rm74F1PfM/UhRnDlRAQPIIGocmbVLDsYszgTA01oQvZMGPyLgUU6dQfdtK/IMYKVE5m MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c23c0b00-39c8-4139-9925-08d5dcca59a4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652034)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:SN1PR02MB2157; X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB2157; 3:XNAZpwl8Pv1nFoyEQTHZhhiTS2we7c7Mg3ZoFJQL9XjCAkVA4N6XjG1hyAPpHdUgJq8G0/FRmxbl9c6ftIhXdZDxpj1JqsLy+pveS+5Ac1DhoB4RR3nNxM1Sxe5lEEjqjw/nEhA/Z2G9HjPAjZLuz8JVIGlWE8MG9MtAxJOntipkBbpBFHxLd1eyCihI/ktiuehsoIFW0yd4nZUUiFnMIn0vQSJIuUbr/peYXLVDWCc5wSvQ/L8BtQvOD6eI+B/qdJBJvNjWQAIO0osyaCUQyHVjxWbMuWljkUkHtnxiuGaYJTFUD5aT0jGBJ6i6LMJiNk3Gj2cJn6Te4/o41LayjteO/Ml9LOEMGe58hVRwKpQ=; 25:GYfMvWGnQgiImWKEJkiOMHuQDouI/NE/G8sqSA5W7Z4LhH42MKv3aMy/cxgs9SWWUa7RInGwT7vz/A4UMYacvZhbmRfkJj9b4JCBPAr2dUmS27Ip9Gnqpq4MiepRA5ZiABjfpfTX6mlvFWVyE9bWt36Y9+UEJKO5PFNnOHKJt2RcKkXsYSNMTK8YeahJkDgDe/rgSq6enKWQG/aMe+vMz/ZJ5mbFcOjH96r3ZHAJk6pm41CXfs/qpB39GV5RlhS7/Ufr2bWd1H7/WYDrTZWwbJOG/2Y6ZBEV79EFA9EAe+fJqHuYB+YdScFgF+XwWDedBGbIheQUCiiBWZUreojI+A== X-MS-TrafficTypeDiagnostic: SN1PR02MB2157: X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB2157; 31:dcvxgmWPC+0fCvxkwvMwS3aYhm011q6ekC2OwfVb5KA5ozlRsjJFoKT5CsTdyKtqypG7550Yn97Mt0zXxQIZIn6y69jlgZ5viRk7kfLeQmrro+DTDlQnWkJ/QGVrsUnFfxu2Z2G1b2P7VpX7wZiZFhFaq3LibBmNihuPqXM81zRrFWMASV8/hFIbhkQv2M7sjSeo6P3JettybaMgRuU3tnUQuyI8av2j3IAU8/zBVVE=; 20:D9ehI8SV6NPlvJ5YPV1/CMP6ys1GRz8mQlaFS3cabUb5MfoTnxttDqD89/kOTqGS5ASnB/4yyTgV1seuLwAkMuYIQ2SpbI5UxhYdQaz+9FR0IKBPzcQYJy4w+dE8p7ZwD4N+jRzVvlzQZSrfTNssqAAzeUnd78CDxtEssnRNJ5cie0Q1D2lBZjxl8xbJnTGeRPM9e9vNnnYEwd0bmcWpaGkNyxK2ZvjuSOBLzu8ujLzbdaawbAR8A0y/t5DFO+E5lhtegQgTQk/jHGjTf6EwvRmNozg84Ms8BWqT+f/KyeOzgpDG3ulMaErgovu2H7FuE/q1+mM2QuOi/x1BS2GC68gbcf/uvk2x0QnALblDUb88WcfJ77kR/ykPu3ziRhW75QQ0NH9j8B9ZdGs+KQTim4ateUbsFYy0GSWhtHbT16l4fzAIaos37LAg6Ly3dkGl5bnpjJPaYcm/bdvcz9exKyovQTRu+7a9yn7W2bwiAfhV89YEch8B2ANyoZRFTrUG X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231254)(944501410)(52105095)(93006095)(93004095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:SN1PR02MB2157; BCL:0; PCL:0; RULEID:; SRVR:SN1PR02MB2157; X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB2157; 4:6VVUIvNNtXGu/FSrodiY3Y+zZGeZE6QILEazHCt3VCJK4Ia3vZLSY3Vpox2+T0244voGkpSOVZ4TOoXkw/AX/94ZcR4lwOd1IvOakIbdhKPTmCMZeD/ljemsVJNdgdqXd1fyPi9tx8/0A/TdoPzqxQ4EPmLwsFmu+JzmqKa2/9k5qXskpjNqB6FRSf6ZIqdohjCC52W/rqSQAMXBEeNuhhml2z6Z7LWiV9xHbWQ7ud20ucTM+xf06n93dZeQrnU4b4PSJNuk2ryBIjZgvFA5womY713G32tNMEppbVO/zH6Fo8y2MAu+f7MdMGpeK0fY X-Forefront-PRVS: 0717E25089 X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB2157; 23:yXAQhKFPW4FSAgkH06+C7FtgyTeegBeEe/gNYi2Ww8JWgjeqMvVyrpKPirsS1ramC+7FohQvG0rroncgZ3gta/CwHHFYNaVMh8mD/PaF5ZsH9Ll3aopk4MFPBnjqfrAxPaqRBtizjvvtXNTN/xW3PjGV1wSeHXU8oTyGaH96UnTuzVLP036MCsm/usaOMgWo3MEfnTzV7MyNJEulRk8BIkmGjCe2j+DFy5dS103BU5nUuNALm4+haVvuEj0afl3pQcN3CpWkukdH2tarMImpLgaFMue/yOyb3TZJANNZGSqJoGaNcufjZeEXCm2ekiDXuA45k3URRdf6AlKZQ2aJKsk/un+az4tQxx4p3hmOmCE7BRSMLbZrgVDssQ1y7QaB5iYPQXJxINtkcycDKgPjhFDFJtIrdEz//A1zPaj/p8ufoJiI0AQPYxoz12FEp+JlJLg7hhzA7lg9kJNpo1tl9YSahS0TY7DZ+8FGwajPcSdU0Q8YcbQWi3nELqDLQvxJvIkUC87rLbb0XZAAcnfhM2fD9jNS01pFGYNy9oPyQWe67DKcox1ZWj1esnZgD9UmcIIbv7h7KJkcmzYwZNInoiZ1+bOOCVWArT6Wiui6G9nPkmzopOBCplm7iVwoMWqOrtFp/G4bPEoBWPYmgASRvf5Ca6cvKEGjyhUOJaPYsM1SCE14vfQ7Pi6ojFMMixHgNZPhDi82pf/WVXYSRwarZGiJbQOaxTOEqxsOMNxFQjnnYvFMD1R9UbKissEXBcyIDI252onqM8DdkHdO1LCIRhvdabJk5BEBt2SOS9ydVvqLJbud8K7unDg9SRg7+e8jGOP+dNXnJdaAnxuCVH11nRQKHo1LMRtiTRFEFfHI6MXDpCpDo3XAJMt3020fFFrzQjc7yRGMOGqvg3pUPadOHJJsEYBg4VFf0T0+8lb2SEH9aoh6WAMBgQC3vhFNUjEAX6G1kcnWhO1fxEYOnG7THOU3QSqQ2lO/MFS5Zbpt/cdIVCN9X50xM9ovh+QeIBpeSNdfHurEhljZ81s12EA6p3aIriGqyFpSoHUgIoyCuibzGhjRpvl+mU4lwtpsNVqRSV814Sc0OdfNZBOfnA00QCkWwPeTzY8m/Dn1JEg09hr/qLxFqwYq8b1yxTklEGDgKYeOOPyti0IA9wHrKlMVIod1dDraRtYOs7H3xrS+jfbv8fatwzVfJtY++/aCf2nSjIBqEP0GpoCABW6rBlM8jQ== X-Microsoft-Antispam-Message-Info: SC00/36J3nOp1XJ5y/1t81TXlWWhhL5dSdBKjqLMPrgrVJK6uvoBO32Y1TepX8GguT+mTTnWVpn/LxLKz2Qp5hi6IMZOT2w0IHiWoM7ZQSjjMjewXC6F6+9CeC2F0RJsmdy1xiz2pEMv9JY2RIZ7TH0R3TGjtkkPaoW+SaL5OPcqQ2NOxTGrpZkGp2qI23HHOVOEEz7/EnrkZ6ii02QEq1NN1lTbHxVi9C6VjosEs+HhyUzqrp2aZqQcdgbFfyw0pwBRCLxL2FtMSKjQDhoVx9KjtbecY2haUekVkVhkSWZcu64H/Mft0Qt2f5v6JagdGWl2OiS1YDSFk+2ICsbT5XPC9jJliINrQvJD/8j/64w= X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB2157; 6:o4cCSnB3PatUGk68GvBxb3qAQwvX0H8iJ7Vy469OcyDOYZI5tIT0ajU0YvYHjrSdm/s2cokcbrKAEmQMHbr9mT8gU9kJBiCMxaUn7zdJxBvCpqA6K6J+wk4BDe05x/HvES8YbKuF4NOh95gkdBn40qUGHJAjmGwIFwJaL0A8JiUEzxujUp6mGK+TEXhEYRbLmz1dJaZGgbDGx/64U3JXUQMn5FEbQBJUv28Fu34S3rcDgSU/PEcvvA54xc+OuIDlfMO7YRdQi1LU+l7ABs0lingtTJTNf7wLEZX9Uhf+vo8jiB0/ttRJNzb2ne5Q+5hs9rzE6P5Hq8dwvWj0wYb02GqsomvXCQvHGk8CQgoSGPDwJI7GPBw3rAvDq1IkZO5IqzTA2L5Y4VoZ+81mef2ricPIQ76GjjxzVc6R3x7MjXF5ANvtiv+gN1yNGSCSkITMOVVAJkGtZzMBuLujyEviEQ==; 5:N6DTeflV1vN1lCDIDN2q6c1sZSe3Ui6rcpGjyCphR1vH9VXuKM+cBAIUktp0VVqqU5f1EUAuAa5ZQvjzhOlaBM6a7Gsi9LsJY2o5uIc3donaB/dnxOSiGhlVcNfQTixRlgIeWPnvre7Dvg4YhiBcol14Lxb7Q0krYqN6We8Vrmg=; 24:DrQBLCGH8q1M9HjtklabykJKqCJhrBtPUCDdAlOmopl0Km7WBnshQQnpLO9apQ2g10kXnr6sPjCTByeAw3xlBPvOOqulhnPmcp6a7Wr4UqY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB2157; 7:HEqsb8nYnePf7dFQeARjXkSl22Z7XUAphiHIJvMs6bz/EXi9+NKrDI1VWUoobjCQAJM4ODmK5+d01+M4zWoeujEeIfSkeZ/SiXLPn+D6e0YFBePH3p4y5QQHUqhq4kkTmM/3x+F6es3sERYLjMiSDEyUWDTHknne8ufchwOgjgjLnf1R+EtTOxWXsuzd0yuxa8JQZq+dMl7KzqvmnUdRy8j/fWEGXFRZc5DSdC0oIslg5I/yl6yfSUbK+MOvuZlM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2018 07:39:58.4663 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c23c0b00-39c8-4139-9925-08d5dcca59a4 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB2157 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Switch hardcoded function name with a reference to __func__ making the code more maintainable. Address below checkpatch warning: WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_read', this function's name, in a string + "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n", WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_write', this function's name, in a string + "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n", Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- Changes from v1: -None --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 2a0c06e..0544134 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -757,7 +757,7 @@ static int xemaclite_mdio_read(struct mii_bus *bus, int phy_id, int reg) rc = xemaclite_readl(lp->base_addr + XEL_MDIORD_OFFSET); dev_dbg(&lp->ndev->dev, - "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n", + "%s(phy_id=%i, reg=%x) == %x\n", __func__, phy_id, reg, rc); return rc; @@ -780,7 +780,7 @@ static int xemaclite_mdio_write(struct mii_bus *bus, int phy_id, int reg, u32 ctrl_reg; dev_dbg(&lp->ndev->dev, - "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n", + "%s(phy_id=%i, reg=%x, val=%x)\n", __func__, phy_id, reg, val); if (xemaclite_mdio_wait(lp)) From patchwork Thu Jun 28 07:39:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 935976 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="VVAANjjc"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41GWsx2yTkz9ryt for ; Thu, 28 Jun 2018 17:40:53 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934070AbeF1HkE (ORCPT ); Thu, 28 Jun 2018 03:40:04 -0400 Received: from mail-bn3nam01on0075.outbound.protection.outlook.com ([104.47.33.75]:13440 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933094AbeF1HkB (ORCPT ); Thu, 28 Jun 2018 03:40:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D874GMDayWfT1uP+jDbn/NLmI3HhhstzdAjIQb4tujA=; b=VVAANjjc2bDCitY1anJ5v5ETrx2ajy2MNZ5tS4ok2FECQK/jgA/CpVxeiTVGxjVu1kX1Isyb3y8IEnozmd/weJeewRWJzFAc3uKpgT2TTuzw8mwaqLFplTTZKHFk0uVoPwcoSgmybluA4fLN3U2YMKpRvvmfwzHGUi4GVPDWbQk= Received: from MWHPR0201CA0024.namprd02.prod.outlook.com (2603:10b6:301:74::37) by CY1PR02MB2154.namprd02.prod.outlook.com (2a01:111:e400:c5ac::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.24; Thu, 28 Jun 2018 07:39:58 +0000 Received: from SN1NAM02FT003.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::205) by MWHPR0201CA0024.outlook.office365.com (2603:10b6:301:74::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.906.23 via Frontend Transport; Thu, 28 Jun 2018 07:39:58 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by SN1NAM02FT003.mail.protection.outlook.com (10.152.73.29) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.906.15 via Frontend Transport; Thu, 28 Jun 2018 07:39:58 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1fYRX3-0003eH-Ow; Thu, 28 Jun 2018 00:39:57 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fYRWy-000195-Lr; Thu, 28 Jun 2018 00:39:52 -0700 Received: from xsj-pvapsmtp01 (xsj-smtp.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5S7dl0o022790; Thu, 28 Jun 2018 00:39:47 -0700 Received: from [172.23.37.80] (helo=xhd-paegbuild40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fYRWt-000189-Cg; Thu, 28 Jun 2018 00:39:47 -0700 Received: by xhd-paegbuild40.xilinx.com (Postfix, from userid 13245) id 8CDDFB20951; Thu, 28 Jun 2018 13:09:46 +0530 (IST) From: Radhey Shyam Pandey To: , , , , CC: , , Subject: [PATCH v2 2/5] net: emaclite: Simplify if-else statements Date: Thu, 28 Jun 2018 13:09:41 +0530 Message-ID: <1530171584-20673-3-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1530171584-20673-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1530171584-20673-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(136003)(346002)(376002)(39860400002)(396003)(2980300002)(438002)(199004)(189003)(8936002)(305945005)(90966002)(4326008)(81156014)(81166006)(8676002)(50226002)(106466001)(5660300001)(63266004)(76176011)(356003)(51416003)(478600001)(6266002)(103686004)(36386004)(316002)(48376002)(446003)(110136005)(54906003)(16586007)(106002)(2906002)(42186006)(426003)(6666003)(52956003)(50466002)(2201001)(36756003)(26005)(47776003)(14444005)(486006)(336012)(2616005)(11346002)(126002)(186003)(476003)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR02MB2154; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-83.xilinx.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT003; 1:/qLkgG59wa11MJO+NUfVzZsbwhebRDXRtb4BGuF0ToEbDFKf0bZ9o88N3wFczZP0z6r4G8oEPQHt4P0zSdZQ4IFS6UFw/UYdn4s8rH3dL3hBDUSKzWOSIHcg70+TwOh8 MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 29c820c8-2787-475c-c0eb-08d5dcca595d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:CY1PR02MB2154; X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB2154; 3:Ot7XKlHolEWy8i1bavx/EflyyV+SeFGpyE71nugjwNKR8ugRuyr2nVd1IzXuHqrw2Tpjb0gpAp2qEpOUH2PU9xIAeQzy3TlkT7S3XqBtwaC7gmlbw+kXQCploV2lqmnbYPYqvq4ozWSTaTuR/b2/KAnVWTOSuAqOMcjtf1wP6BLt7f+kcVMOK2G1iTmVQZc4s7WKIi0w3casJeiNhROILBZoqB76XygmT6aU7CHyMoMMATGYnp6QZpt2CeGLpwlwCb+qlEX7i4sI4941twQoj5Zma1o3f4PkRexxG1HI+o2EZtkJjaBhOR+L0d3RzqYv9fOc5LqXKzStofnE+XOkoS7xSuPrjEhI2d3EzEKieDk=; 25:feWS1/yMV6oifKpb4pgZ8Zo/Cgsjq3Bw9VPSY6UyI/8+9ekLcDY9CRAoZgdAXw2++Ca5RCAdNip0GxL6Lo7W1WEyimhuBQVrfLYQbAEc+OUtiKGzflYlcfvFZ/NOhrityiCF+5WtRuO0/RM7YBIHCseJQsu8iNWtR7ioAQS4s9aKbgq+k3UW3vODp0tagKk04GE1fp7J4F6NHYhcG1SeFY6a7ZUDk6XQqmSF9QhRySjrjcb7Z8fWIo0AREPFP0yfolvdUOmTS3ZmSZYb06HG+4ynpkO/7z18ZY0LUdB6JTz6FU4vTvubtOmgBWzLorWR/E9U+p96TJkL8fKZ4pyvRw== X-MS-TrafficTypeDiagnostic: CY1PR02MB2154: X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB2154; 31:uCzgBkJ/nbSTTv/cBj6VCumOmaunWNUpEVvPXEdjCfJOBT/9AoY+U0Pr5c7ZAzw7H2z7bn/sqeBaQ8YDERUKOCAEofig1CIK7q5RnbLZZW6zCQJ9CZdq32MBptvVJqn0oGHt0R4d0MbXwJeyeDS53FXOdsyFYsPk76gY+1pInfEJlbS6knblEFZhEsANJKWPnM+jJP9bBIhJ59Ri24k7G9YFb7+HqQCAN2PVEfuHBiE=; 20:xoTdPY5JzfnCfYoby/XDbFmn0EfCIid8z9UhwKwWpyFEvGYOhsUPD5abFF4iI6ekDWOvfnNW9dadS9Y3OWm6vwlIB6/WMADZwqMnmV1PGm5JVsdwaZWCqjH0525yZrQdhYObQQZmKRGWaMpWgdHeveM6UZfqD8nCIv0T97F89cu2rO1HIJA0kYFZJeAUSAkPFzmzlNp8OdWj9C/oFL0/3ejFVIIrgUCou8x4aQ/znF8OlyTRZxCgizvAd1qlqQNhVhn8mu98FovPDFJ6KF3qYjRjYnF+ZmMCJ/0MRZuFRSfAWKq9ccb7XDYu3Qi8SPLxPDLa+moJfYlGo9LIFz29pwx61DruBQ44doLqBdEXikl22gb9PUkQGf8W74zQSdJ7BehJ1KSA1FvARq89JrnCMXLexV8EPtdmiqLS7fUPywrHc4Z/UIRMtq5htwkHQ5D9pnQvEIZTnn2X7EdaCgAVdeSgHBFLjxisa9Um/WK72pB8T/FnnZZNNdcDJy3qMZEW X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93004095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:CY1PR02MB2154; BCL:0; PCL:0; RULEID:; SRVR:CY1PR02MB2154; X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB2154; 4:sm1ZzbE9SQNHlQi9povtGG5THszWhT9nChrNUkDXbJjSLlhhd0D0zJRPvSmViZrZKoXjDxs0XlaxtKWXZiyg2IVh/A9SrxiFSSdWZiQaTbJ7iNouT3LmM4LTSp65Bx+i5K+BRwli1ylsOfmGoIoK8kUx5LwhzUB+73I6aGHYkDmoQK1IuXR7Nk/2vCx+fIzrSsEuPSkRJTY0LHuRfRaqhvPMPFiZv9Jdnf/cWlAq/9ABKBO7pWFINhirC1K5SRp2LwJt0kds9kLQhqG5mI0NqPklKRhl5uFqreiYD53xo77SSqSiwgdNfrnj5wjHK9Ep X-Forefront-PRVS: 0717E25089 X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB2154; 23:FSQHomUd5n5npcM/1vv8MWJMa3bZKazcTH66wZ5WfzyGTSBxYkwmUraEsSPwJBFIeBstsyxFaOCfYciaC5AUP+5hU8+5+F+cwjWii/nRFRsKP6LaBFxaZEtnsbtlxfWt+2y048ysPN3O5Jb0SK/d/7MGVjjoK33zb0keiv3YbQWAacMfr2+nexEte0pbqobPHzacJXeHVwh2GcvBgqbXF7qjUIG9eQAI97Bla7yab+Sb3f4WwaDJGEBrPeMeYXk3lSssW8njX+JwK0Kex8pd3577Vwm23L8rKk+eU+L/7p5UKhNNCtSEFv2tniz2uSbVdIvQrtes7VsLcAcQhWmh1AYMStv/og7pH5UbrVlOf1IpSaRV/xgjPlVVn3I3ma/gVrkXn59B/jsB27d3oppU67vHH1X0MKgm3zyfrJOiybCTmU9e9vUk1sBHpcebTsh51h4jqvEC5la4aht9W3F0Q57w1l4oYMxyLLK0CgkW4Jf9bnqPxf9r/iP8reEOlX2SG9RmDBRvA5eimPQ4qbsKASxuAz1FjQv1kpFi5vsFrv30zlqtzDGFd1IgYPXrFQ0mDcc+YOAY/BXa9BOOgyNlgYDuwOEn1qu1yymdSaJTkZaTrm1xlhzQBHEjtH5v5WWrjYV5Z3vmwtsfgdeQHJ1u2zPtRKLHSQkqi+YV6xa/fq/6Tvs8qPhnC6ibG4QhbwDbOIozwUsLTRSP3PjXc8HUIEmTxEGvJtnXEOuxykdcufGPtnJpFR0opqAJRKNnSJAvovi8iW2800r87hzsmt5A3fGd3q9+NcBVe5ZC3e6zJvD0aWKygxdpchrcbQa2WlGwfiumEpA9G3tMVfG7+c07uwpWM1We94Hq/ySltxxA01fNnYzFYPydRmc/GMa7LFqchdC2z9txm/eEAB1vHEQnTyImLAQSZkwsue/qz/02s/i3MydoRxZbGjNQq6BQTMnLAumbhG5cDFOmgOSa8PmU8txk6iRQlo0OrZQIJ/vfpOGhs8hIoD+Yk0GM9LcQTjR5X+zs9rm6Raln9bCXHWctMc5dw2SPLRJucPGIDfrjtvEfGFMGHj3Rt+KcD6JI01WFPUGQ4vxRVtvR0INHUjWxqpKqLoaN7P1MhQQhkBF8z3ECpS3m4rMI//gwn7MTsA8PeYBbDU/j6mHdNUv5ga99nA== X-Microsoft-Antispam-Message-Info: qeRhDR/grVwBMWEckWDRnlCQNrY6u8fP1MJoXcnY4kyp0b9Urk8GEovzGkNtOo83fMb5Jc40jDST3xsg3PzBCar5z+tPKiWr8/5cT81kuhsYA93dlbRx/ukB3hPnakmqf3YJIVajZr8y1R+GUZCOzhcaeF9pPoacdY0a4KDace6xsQrEQbRBOuomfAYkgJu265VAtj4Ld1bgnH2LrIm5RfKb7XRo2EAwwszb58Ezw0fE6dnyJQ2mwH2oNHgrN55n7lp96JYD5cvauvndoCprblzA3fN3LpVZJqFa1odWuad2kRGMsJZVwdMyBe5irFd/JPVuLY/elGlVaNDioOjYN5MC+2SA3iWtBq/vwchCjFo= X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB2154; 6:zeXYRJNdIuaOM9VrXyO/pCsWVeLaG+vOkQIp73DRUNYWeuy7A0OFh1MAd02Jwo8SYM/I/xaI2SEvdcaSkn8A71AHS2lSguhLvHbqIYCdXmF5geyLOTVthCo5qmlzhx4AzC1P+KHQuapXfp1kTEw5azaerVmjctMboVWl9LcDbGLiar8bTRU8ut+d09Hv/sFvDqnfkEGOFIwyrdK7sr6NK7UNOjAV8uKFuJrgiwdz0aBFKvevLwCJaXGg/bIEMmPD+bYumKTcj/P3lJkJgH3w1VTJ/dXRrs6fcfZh9XqYhGUsGZOKe6j0tRBcYOfvIh2DywetJO21lxhuA6KQmLT7TXVwtdFfCZXqdbvHQpvMPtZ9W12+d3D/kuvN1xv/cat4+k2MksfnIfpinNvxvPhig9TLNuZ2hJX1IoCR8n1dYPcDSPTSqJkkHoqkNRKYnDs246HYQyDLvE6i2FmJD0SyYg==; 5:3btekSGtT7km08LwDWuBSCaVXTS/6RBKrJBF3Usd9DePduG9lpbCor28K2HgxARXlgC6BLNE2NEUoJF8AKnNZXUSVAWFglUBltX5BXU/EXUp/XbSmr03wZ7hdbrMzdYPuS6xga8FkV7JIoD5jpAxu3Z9mKu5CtYU6oGmAebLs2A=; 24:mwINQGRtLXBiwhhKqQKsmZznz9a+rBruiQn9HEI00cvp6NE16Eo+VPO3m6L0TYEH3IEOwmxsgeZIDPkQuKJgrnJiZCVaugVXIldAKfWlCrs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB2154; 7:l+DWFUy6Y+ghe/imMPHADpfPea7L21KqpDZM1UNYKM9fHqZWV/McHixyqpjmM+KykuFYXzdVj7vUP/hDbVMbKXx+sxofsrFEQgqs5CQLSfWwg4bfPIFqPWhTdlBRX/I1eXFTsbEsTUKWWgd4yMQ06ajCxD83ePNFr2L2ivmhu0eR84qX2+ER6w7HjXompLwqBU6Z1v4ACfkmQQAgwgp1e/zYuAysgL2OaTCKwmaqLqmzfdhrkGLqU5H7BtjJIKXY X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2018 07:39:58.1114 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 29c820c8-2787-475c-c0eb-08d5dcca595d X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR02MB2154 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove else as it is not required with if doing a return. Fixes below checkpatch warning. WARNING: else is not generally useful after a break or return Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- Changes from v1: - Refactor to make failure path return early as suggested by Joe Perches --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 31 ++++++++++++------------- 1 files changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 0544134..51f84f0 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -564,19 +564,18 @@ static void xemaclite_tx_handler(struct net_device *dev) struct net_local *lp = netdev_priv(dev); dev->stats.tx_packets++; - if (lp->deferred_skb) { - if (xemaclite_send_data(lp, - (u8 *) lp->deferred_skb->data, - lp->deferred_skb->len) != 0) - return; - else { - dev->stats.tx_bytes += lp->deferred_skb->len; - dev_kfree_skb_irq(lp->deferred_skb); - lp->deferred_skb = NULL; - netif_trans_update(dev); /* prevent tx timeout */ - netif_wake_queue(dev); - } - } + if (!lp->deferred_skb) + return; + + if (xemaclite_send_data(lp, (u8 *) lp->deferred_skb->data, + lp->deferred_skb->len)) + return; + + dev->stats.tx_bytes += lp->deferred_skb->len; + dev_kfree_skb_irq(lp->deferred_skb); + lp->deferred_skb = NULL; + netif_trans_update(dev); /* prevent tx timeout */ + netif_wake_queue(dev); } /** @@ -1052,13 +1051,13 @@ static bool get_bool(struct platform_device *ofdev, const char *s) { u32 *p = (u32 *)of_get_property(ofdev->dev.of_node, s, NULL); - if (p) { - return (bool)*p; - } else { + if (!p) { dev_warn(&ofdev->dev, "Parameter %s not found," "defaulting to false\n", s); return false; } + + return (bool)*p; } static const struct net_device_ops xemaclite_netdev_ops; From patchwork Thu Jun 28 07:39:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 935984 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="0u3ajnVr"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41GWwg6j3mz9ryt for ; Thu, 28 Jun 2018 17:43:15 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965048AbeF1HlR (ORCPT ); Thu, 28 Jun 2018 03:41:17 -0400 Received: from mail-eopbgr730059.outbound.protection.outlook.com ([40.107.73.59]:46160 "EHLO NAM05-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933998AbeF1HkC (ORCPT ); Thu, 28 Jun 2018 03:40:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RQPZtY+yyoWa4n+OKGfH/vSTwW1fWmjYjfFbp2zbo6M=; b=0u3ajnVrbF+vNEiKPEkytgaIRjKHGAHmYXmEfJwIeJqkHXtxTyxIzR9YQM9N9cXvxYAxEGkrXXTne46yvU6zZ+ubJBY6Q66767WEAT2mhYZT1w8pytB3MH7dZ70ydjlVIcrO15HZRokfqN0QfMQn3GyzKU8dlYsgf7GEA3MP6/g= Received: from MWHPR0201CA0090.namprd02.prod.outlook.com (2603:10b6:301:75::31) by BY2PR02MB2151.namprd02.prod.outlook.com (2a01:111:e400:c506::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.20; Thu, 28 Jun 2018 07:39:58 +0000 Received: from CY1NAM02FT027.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::205) by MWHPR0201CA0090.outlook.office365.com (2603:10b6:301:75::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.906.20 via Frontend Transport; Thu, 28 Jun 2018 07:39:58 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by CY1NAM02FT027.mail.protection.outlook.com (10.152.75.159) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.906.15 via Frontend Transport; Thu, 28 Jun 2018 07:39:58 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:34912 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1fYRX3-0004OE-Ne; Thu, 28 Jun 2018 00:39:57 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fYRWy-000195-K8; Thu, 28 Jun 2018 00:39:52 -0700 Received: from xsj-pvapsmtp01 (mailhost.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5S7dlM6022792; Thu, 28 Jun 2018 00:39:47 -0700 Received: from [172.23.37.80] (helo=xhd-paegbuild40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fYRWt-00018B-DH; Thu, 28 Jun 2018 00:39:47 -0700 Received: by xhd-paegbuild40.xilinx.com (Postfix, from userid 13245) id 93A37B20953; Thu, 28 Jun 2018 13:09:46 +0530 (IST) From: Radhey Shyam Pandey To: , , , , CC: , , Subject: [PATCH v2 3/5] net: emaclite: update kernel-doc comments Date: Thu, 28 Jun 2018 13:09:42 +0530 Message-ID: <1530171584-20673-4-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1530171584-20673-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1530171584-20673-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(346002)(39860400002)(136003)(376002)(2980300002)(438002)(189003)(199004)(36756003)(47776003)(478600001)(356003)(4326008)(336012)(26005)(186003)(14444005)(54906003)(16586007)(106002)(486006)(2201001)(90966002)(476003)(36386004)(426003)(6266002)(42186006)(316002)(2616005)(11346002)(126002)(52956003)(110136005)(446003)(81156014)(50226002)(51416003)(76176011)(81166006)(8936002)(5660300001)(8676002)(2906002)(106466001)(48376002)(50466002)(6666003)(305945005)(103686004)(63266004)(15650500001)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR02MB2151; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; LANG:en; PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT027; 1:M+bjIGV/is6oJt0IUFLhBKejte/S6BO8S2Fnl2F3x5XOqFDvf8q9J/FFxQ8IXyfnllHUVs4wi/S4X9JJwOjpzaWWhrCr/VnX7/v0q/HuYwv74ak4cD+klxmcClrwpjV9 MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 99e3f6ff-c521-4c02-e87d-08d5dcca5984 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:BY2PR02MB2151; X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB2151; 3:ySJuiy7klPoZ4eNdDdck86QIRdmdIskAj/vpcznThCnuU5J0h+IxkoVpQtY+mN9LFn4QNE5Ak93zFwp8JXqZ04hnfj5INDjWLw854wxR5NHD7ZFM219R15d1DwGM9MqNRleT7k5TSx49ImEQ3l7z6iQ65Cs8dWA00ugNFf8vsCue9MVW2XmOuLttae+qhNohzQVca0B8vlsmMSJYGxrrbU56aHJ0dNXh0v1WrAB5dLWtetwjIehQcUBpbVSQAQVODOFJk/h6M4xn0SYRqG8jcx8xyfvnG5ZtiIK7wRoifX6xgWjnlhnxEtT4xvS4hB1WpuuEjB58BCxPL+Qo89hEJexYEThjFCXnnK+Wpiw8S+M=; 25:v4a26iqY6VUDX4r4i4NQy7AaiNJQCpbeTfUnZKPeeHbaQ/Rr0nbyymuK0Yo340om27S22+zAeLPifXuB7N+zbQCx/FKQWIoBqG6HJdQLvfTWXZkSw57tsPfKUYieCvZ5f9sxysYBSTkv/f008SO/ruhCl0das9KwLnCyJ9hvgugTVJG/Hvd06441DkZ7jMXpMlnktK7pj5ugtHWKS6LSpKm0hjGzA9H8TSp6EL/ufeM7hc7tp4i3X9hYuqtd3v/HjzWgY2h2U60PZQeiHfg1ZfEaRqj3bfMikJy5XknmT7az4Xvs5nRT0On/iGHd/xa6p7dsTxPKwa05KXhr/9g1Bg== X-MS-TrafficTypeDiagnostic: BY2PR02MB2151: X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB2151; 31:fHgpxAuldf88Z7jzuBl6hDyAeSAOHt5pT5meTek+R5NRB+rLgjyrtpk87g96rjIVK1/dZb1g/FHjtu3zSmHcyWr/qKLn1RNyw1B2YuUX4mdKvgbNlK5VsBnU2b9rbEijwhdjG5drCA/EIDWy6Ll/pM+lugSa9JCH0JfKQGjDKIEtXc5e8n/dmU9x0Coz5HzvQ0u/oGO1QJ3QdTsvZKw2y0Ld7Q24o+1F3qy/vyQt6/E=; 20:QQ7RP9OtlQDsv6qEIwLxbyzaFOINY5ZsXx/SqQOh7O1NE1jX7pwvUpEBuD9r5Qmbb34Vr2y9Dpr1SUfr3hvvSGzwtU8PSGTPSj1mQnY6VvnfPLoFllSeVlHPGscEFCqy7+pJOct2PJLh25v7yG8TRQB2nQaUrrWw+/1OUSq4gWwQvSXgj20r43t9zM7YUHKPNJrZNNFABkIQeGNsFayuW9bO0oI5xXg3Q8J9dSOCRhvys6dlOY1cOe3BcpNFQz7kZrW1C3r9aHV7P52i51XlTOqqYkxcQGGEsjzf4Oss2NuOfO2Y2oFpovjqHbg8MECAunych/50CIH+GJ/2GdriaQ+R+qyLhGER5bT3df/zJyI1MCPS7lObp339IvJbso16UJZjHv4RVAmncH+Ou3wTH/jE8dcnTLY0OTfa9NvfPw0MVovdGOut1K1NGVuoMojpV6GwO5WPIaptujZl/8nSyh/6/4li7My3fGuh6XjdzL+9g4JXHloqj4g2MCWhtrcm X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93004095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:BY2PR02MB2151; BCL:0; PCL:0; RULEID:; SRVR:BY2PR02MB2151; X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB2151; 4:tNtQsPmFU3Xkvr8AVuJiej6TmGYUafOCH8Zx1tTyorCuORZ3hXbSdvyCg10WbjiYALkyD4+vulU4mIy5sOb5won0olzEBjAZN6MEBd7zeYockx1dOSsYURPyb10VhWn/uos8cdxE8S8GFUs/Qu51ZSWR8HIkZ/qXC2/IQxH+q48HLXsJ/YGBf/TW0rsBNtTs8ddbs/0V9UPPbzku7VmKiqYcYgWyPhU4LrKGsgQMG0Rff5K2al1WoLh/7d9iUYZIwQ0HMRJB5abTCENspzy3XrR+yY1baGpwxFOP47qRYFv87QbJOgHbUA4ky7vhaBd9 X-Forefront-PRVS: 0717E25089 X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB2151; 23:NCxACX2x7wGOFmNC5HAQSiXUU0CoMgJNSGUo+pEQQinyoD3gj7A3D/w4kCFMiuZbzDwCI+nKAClZlmQ8wnKHcEX+YMdygtZYz0UPvIyGfv8OE5e5lS4rXhEqCYIa/ZYMzO8N0kpyJTYC1mcVs3znD9tv6kDsV7TvbJMzWYVJA8kODN4HcL3R63SRbBKwXZX5CYvyFxTN6gUsYuGlSc5RGdsOfrTxs8+8YqCTqIrKD7nLzX14sKqs/XDHkAiqgT0AzDP4ZIofu9zku0C/ZGcXoZ1tax1qiurS34xH/wwQdzevaxocRVyOn1c/npVYn65QEdKdONxZmnwYwS1MezBFqAhKi/RhURovsuI2UDkBIcCGXiQsvlXeLi0R6q6OggVk6pN0Lg1AjxDLJAbuMziQyzffZcbVmBJbh1rf38lJEPyF/9UcwbTYDFIg1nxL2Gadpov+hCQHIyp/xdLG39B3vq5ZLBD5U+LGZGjUMyPmfVr+RQhxkfopVAaB/kNvc4XoCCowARctbebn5QKta87u2jzPb58B8GplOurr+3Aexku6Z4pOfj33XQVb1KeouaBtWOcmUpo0PR7tvhDAtxd8vP5kOwPQC9prAtjtUf735nrojynqgZa+Rdmc0Uef6aD7euyDgcbNnj2a0WE1UkkeNmZwbXLDa4JKAMLFO4INc2vaoajEXpvywLhUXwAk5GLU1CLyVMwnsLFiCGPaeF77W1kCKJGspgjM1q3qkEoosNXchMqJQ2DVvUKcm14NEWyiOdbRe88mC7MD3sm7HUgwt5T40USAUfQj1UucSks9XXtPEpNEHdRlYcJCm+tbgryVKAzW7jcl9gCWboKFZXVpTmuKw5ck1G23Q1U4e5NE6JYjRD6HxKqPN8uBiwa3Et7onOVt/NWwMCnqxv4cQXcLBwpnUdj/opycHoPX1KN0dE8mjMOwxxyBD8K3nSm6Bbn/ZMlzQiaTmRNX3jwMqP06tqmy6m4/n2c//8Y/KRieWnVDrnx7zdSSXDBWrv6bOmHfEueS4EKwjXUWWf+1uXoKo8WriWdcjZg9eaThpHo8a7sNmYmQxd7uoTri7R8DdhisRt8XxU0aAV/gUKC+FeOUAUNCbTVcB+Y6bT0LBfHvM/CvZm314Fo+J1jgmb4G8CWD6W2HOkzR0/kxs3A7UFQvDNqpNOIcXm31S4+kHfEynVbLQeGyYxZDxZBNZEf9WxZv5gb14DEVl2IXPdAokm/q8w== X-Microsoft-Antispam-Message-Info: b4P2k78eFXUMIGrxnDgk88gavjVz6ojHKLAm4oterHd6kTYS8uDfwzVtUzoD7+5mZ5IT4AoaQfd+2HkvIuLHBZgC2rNfJ6POsASdPZZfrb/V76NeCnPZOIHnu63EwIyereRGXjfnBhVSlbvl91RpakHHTFAyG2JSfVP60U6mlU66tr955snk5fSd3ed1D6zdXTGMiiioAzyfvCA6iCVd/P7e8x1X8XfmFJW8KVk8JKbuMCZYmhN3QG0ZP49+IRsNU7smaROOpOjzr12AwtXhwi04gJdIr6qrtCBhugCvWvw8iz0iWPBmIyMbKMRFBb07UcCZAruGya9qy2dh1PwqwxYuIuFB81lYgsbaYcdFYnE= X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB2151; 6:7WT5G0Z+BwlO+bPJ7acSiS8whD9k037daJvhiNeThaVcbJpwySFkMQgfgeyETQCHfJ9XvrQwRWF2cDxq6QYKYlMeh6JqtNKduYPcdatlSKPblbqZiverHfqrx4jQqzwyU8Yhh1zkTKBYBgcsBiZ1M+PZdhDaJ856HcaznsXeU/TH4Wv4pvwhD/9yGFsBcss/9ALZx6mKKP98wtOm151GAHlompA7zpbaDehGtGirR5GlGAaJVdNVF7RfmqI20YcWZawvJitTJtEtITbuUik9HZlpGlWwJf4AKNyHivLGfBWk4ELM6nEed6z21WHwnITF6FtUYerkwpEpH50H1VpGspbi8cHSwwRJGL/cAHfbsCjaHYAICZWUWqqP6lRH97MuX7vcVXlSzX5UoML2/SPAL957s5aOv3k14kqNX7dSH+1ipUHSx4ZQSF1D9OnMAHP83ZFggoRqE03/M6aTCQnCRQ==; 5:Z8OXiyR7YvPqsQr14XJfNjCjE8UrZ0l8aenkYddAoy6c6ZoVqyqPPeNs6Mod5epH1M4d9PvMNIpMQyfHMcR7pgNOtp9IvU8HOGjnwMw4ws9MELujqDPWkvrKgHlTBEfiHql7g2M1nIn5aUK5bxUc/xuQtqh2TKNC8tx+07yHMng=; 24:d3GZ4zOweOmzyZbTbQ+ASf9ohv1s7yx3QWgJ1tvkE2Lao+GhwDQUbm2SXwZYvCxu7JXY9i/w1ldY2mnZqWPDotcJDH9XKyWAhFgfZEX6q48= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB2151; 7:juVw7i1yXKOfS1S93hw0qGtA+c7bFKZBNfZBYI4NPG5ocoUOFEt6e7fr7YHnqfSFHBLYB7sgsspLy/jk7x8rXO41iqTpn/FRwl0rCAkQJw12rlyzhxk4iFrCmMFAIW7reh3GS6P7zWIl59KT/yh6kvX1wB5TKvTwaNOqE7Hy2OtCqMGicxJtSgsYK+DwXIizGy+jkZopOGYbh5cuxHntYUoRJCBES1iJR8ZvSg/RhGqpa+MJShmEofyyGGf2UXpQ X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2018 07:39:58.1961 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99e3f6ff-c521-4c02-e87d-08d5dcca5984 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB2151 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes below kernel-doc warnings: Function parameter or member 'maxlen' not described in 'xemaclite_recv_data' Function parameter or member 'address'not described in 'xemaclite_set_mac_address' Excess function parameter 'addr' description in 'xemaclite_set_mac_address' No description found for return value of 'xemaclite_interrupt' No description found for return value of 'xemaclite_mdio_write' Function parameter or member 'dev' not described in 'xemaclite_mdio_setup' Excess function parameter 'ofdev' description in 'xemaclite_mdio_setup' No description found for return value of 'xemaclite_open' No description found for return value of 'xemaclite_close' Excess function parameter 'match' description in 'xemaclite_of_probe' Signed-off-by: Radhey Shyam Pandey --- Changes from v1: - None --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 15 ++++++++++++--- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 51f84f0..2cc9353 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -369,6 +369,7 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, * xemaclite_recv_data - Receive a frame * @drvdata: Pointer to the Emaclite device private data * @data: Address where the data is to be received + * @maxlen: Maximum supported ethernet packet length * * This function is intended to be called from the interrupt context or * with a wrapper which waits for the receive frame to be available. @@ -488,7 +489,7 @@ static void xemaclite_update_address(struct net_local *drvdata, /** * xemaclite_set_mac_address - Set the MAC address for this device * @dev: Pointer to the network device instance - * @addr: Void pointer to the sockaddr structure + * @address: Void pointer to the sockaddr structure * * This function copies the HW address from the sockaddr strucutre to the * net_device structure and updates the address in HW. @@ -638,6 +639,8 @@ static void xemaclite_rx_handler(struct net_device *dev) * @dev_id: Void pointer to the network device instance used as callback * reference * + * Return: IRQ_HANDLED + * * This function handles the Tx and Rx interrupts of the EmacLite device. */ static irqreturn_t xemaclite_interrupt(int irq, void *dev_id) @@ -771,6 +774,8 @@ static int xemaclite_mdio_read(struct mii_bus *bus, int phy_id, int reg) * * This function waits till the device is ready to accept a new MDIO * request and then writes the val to the MDIO Write Data register. + * + * Return: 0 upon success or a negative error upon failure */ static int xemaclite_mdio_write(struct mii_bus *bus, int phy_id, int reg, u16 val) @@ -804,7 +809,7 @@ static int xemaclite_mdio_write(struct mii_bus *bus, int phy_id, int reg, /** * xemaclite_mdio_setup - Register mii_bus for the Emaclite device * @lp: Pointer to the Emaclite device private data - * @ofdev: Pointer to OF device structure + * @dev: Pointer to OF device structure * * This function enables MDIO bus in the Emaclite device and registers a * mii_bus. @@ -904,6 +909,9 @@ static void xemaclite_adjust_link(struct net_device *ndev) * This function sets the MAC address, requests an IRQ and enables interrupts * for the Emaclite device and starts the Tx queue. * It also connects to the phy device, if MDIO is included in Emaclite device. + * + * Return: 0 on success. -ENODEV, if PHY cannot be connected. + * Non-zero error value on failure. */ static int xemaclite_open(struct net_device *dev) { @@ -974,6 +982,8 @@ static int xemaclite_open(struct net_device *dev) * This function stops the Tx queue, disables interrupts and frees the IRQ for * the Emaclite device. * It also disconnects the phy device associated with the Emaclite device. + * + * Return: 0, always. */ static int xemaclite_close(struct net_device *dev) { @@ -1065,7 +1075,6 @@ static bool get_bool(struct platform_device *ofdev, const char *s) /** * xemaclite_of_probe - Probe method for the Emaclite device. * @ofdev: Pointer to OF device structure - * @match: Pointer to the structure used for matching a device * * This function probes for the Emaclite device in the device tree. * It initializes the driver data structure and the hardware, sets the MAC From patchwork Thu Jun 28 07:39:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 935983 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="vQhrKmif"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41GWw469nCz9ryt for ; Thu, 28 Jun 2018 17:42:44 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965102AbeF1HlV (ORCPT ); Thu, 28 Jun 2018 03:41:21 -0400 Received: from mail-eopbgr700081.outbound.protection.outlook.com ([40.107.70.81]:4992 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933896AbeF1HkC (ORCPT ); Thu, 28 Jun 2018 03:40:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1msWc9l2if2whBq8sEfawYTGG6QwXQuD0nhUKll9BlQ=; b=vQhrKmifIoPkl1KWCtaN6arvJf9nB7wGa8xa5Ok8GtXyCa/LgyNmvLrUJhIiIf0xSrK8mhdz9yF68NWPeMRAplCmScm9jzbT7doGycUOjeRe9HnR1ptKzWtgYc9c9kqDFczYeoB2ayrMs/jYpNS1ZeKkER/JE5wDxbLuo4QdVlo= Received: from MWHPR0201CA0009.namprd02.prod.outlook.com (2603:10b6:301:74::22) by CO1PR02MB174.namprd02.prod.outlook.com (2a01:111:e400:101e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.906.20; Thu, 28 Jun 2018 07:39:59 +0000 Received: from BL2NAM02FT036.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::201) by MWHPR0201CA0009.outlook.office365.com (2603:10b6:301:74::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.906.23 via Frontend Transport; Thu, 28 Jun 2018 07:39:59 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by BL2NAM02FT036.mail.protection.outlook.com (10.152.77.154) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.906.15 via Frontend Transport; Thu, 28 Jun 2018 07:39:58 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:34931 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1fYRX3-0004OG-V4; Thu, 28 Jun 2018 00:39:57 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fYRWy-000195-S5; Thu, 28 Jun 2018 00:39:52 -0700 Received: from xsj-pvapsmtp01 (mailhub.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5S7dlvg022794; Thu, 28 Jun 2018 00:39:47 -0700 Received: from [172.23.37.80] (helo=xhd-paegbuild40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fYRWt-00018C-EI; Thu, 28 Jun 2018 00:39:47 -0700 Received: by xhd-paegbuild40.xilinx.com (Postfix, from userid 13245) id 99016B20955; Thu, 28 Jun 2018 13:09:46 +0530 (IST) From: Radhey Shyam Pandey To: , , , , CC: , , Subject: [PATCH v2 4/5] net: emaclite: Fix block comments style Date: Thu, 28 Jun 2018 13:09:43 +0530 Message-ID: <1530171584-20673-5-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1530171584-20673-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1530171584-20673-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(346002)(39850400004)(136003)(396003)(2980300002)(438002)(189003)(199004)(90966002)(51416003)(47776003)(478600001)(6666003)(5660300001)(106466001)(36756003)(106002)(50226002)(103686004)(63266004)(4326008)(81166006)(50466002)(36386004)(446003)(336012)(2906002)(6266002)(16586007)(126002)(2616005)(476003)(52956003)(11346002)(8676002)(356003)(42186006)(486006)(2201001)(14444005)(76176011)(305945005)(316002)(26005)(426003)(8936002)(81156014)(54906003)(110136005)(186003)(48376002)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO1PR02MB174; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT036; 1:nPRgh/GUJZP5FtkDLIXe2NBlJ1NoDBCkE/3frYRL3TJGFpk+9Pk3wrf6r4HsWqlXKC7NO4qLZbMKO7HXqlp9kwgkhPB0a9WpsThxwu0rgcMdKuP8ueJMmUGpDLLhYzJt MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2033b3e3-ae91-419a-9a9c-08d5dcca5997 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:CO1PR02MB174; X-Microsoft-Exchange-Diagnostics: 1; CO1PR02MB174; 3:tWBlNH3Dvwo1yf5PMLFF5AajquJpVo3/mesrrzt0tntMhRv0iPPH9EgkOT6Vqk9Kzmqb5huVHmRbix5Sbf/BfTI56z1+Cy3xJM/rBVbAecIJlqCa68Hd0iXSrPBwAiVBB5V06FeY4lYptvHHzWw1SMMHvNb+VSb/ZyRTkf9yyXUmu336mr7aqT4+ooxxVq0Sxw0Xv91FvwRKSw64mc2y66JdPUUfPOeaoSWor8YmXUAFz1jSIHroEO+pMP2TCA/ptPyCQ5XQzddPjuD+3nl0gz30MrjP5Bh9DjEikZnUOrGDjmks0QN3FHfOiq7+sYXXjMPbo/CPA6nUIKHDM2aeNAM11uDI7gzdFAXaQR9DlX0=; 25:6hBtD7Yfqh5FDoM28bSOmN3SZFZQw4LCRFL3byms/s1uCWmCI8G7Hmub3KkUwnn8D436lclVTFl5FCTji3ptQyJOT5tUxhOF32VFY6DHoXvphfJQvbYIiE04qwOqcpIF2xSiD9VKa+0NCuTjhnoA9NN3jCpmwC38hlTw6RePB/OOAatDyfTuZ/6KHCDaqF+Ph9Ba8KKyENNlzH0hTjPQGqladLA8WgHujlb2eXke+foQghJahYl5gqCIjiJSPHclNuT5lNAHhH2UcJl7LxEJ44ykcuJWxONi7MyyIutLKBDocAdzOki+OiCyhgQCA0bwvBb/SUtLGDGilsdSM0NIDA== X-MS-TrafficTypeDiagnostic: CO1PR02MB174: X-Microsoft-Exchange-Diagnostics: 1; CO1PR02MB174; 31:CUcwDX8YsV+xFLKBRBiyLRXbj2YSXAcb1QAqG0x45ir5JU3338gDZyg3oH3hDIUe/VZi9aYoOalFJyITGd85bZdMfueWDyunDbrHw3tdO5VCM4WmAGhtMGA04UDpspZ8cn1UEFWRV6XYZlrxjT/y4ioehWoA4Edgyx8MO6k7/Nnh1uE7m3GjW8x7I06D5FpQQGccsbezih9yVFY3Ed+XTps3EANBQZHWaKGFX4ZXULs=; 20:hNtvkIxVsVax8Jf+ZOUT/hf9yNRWqS5O9Yq6A1IU2Vz/60+2RLzvTpz9soGAPPVT8CFdMfhQw4YcKHKwmLtZ97FNhCvHMUaDnShRrA+NLi0vKqJixvz/DLQMqyGuIxp5CiclGY8uM84Aqg7agTzsmMqEBQiJmWNX3Myfq8ZkVlO+4Qz+Ms3jfVYRXdaAXiW7nRfLbiEQ9LlJ2RBNmiyWVamGAsMrHXQnhs3PEfCI/Rvx/bX1xH+W+H4hK0P1QzsNUqaXDb6CzXFRoTyCzfiArXktYY0o4efFgcEqOJIeBYnwwY/mREdzKYd/W1rDTEECTFx+1w8ZHkzi3reINt7+6vOsXRNTymxBJJyvhJdHCFT6vZRRGpnW/l0/qvwdtzihjkHVaqK7tav/3OBqcCOmNGlUeJJsC6KyFjftimbQGk+Jt4ZnoMblRuZQtbkpBu5umWFiUMsSr242KRq0Xl+iCzGwVcXGclXubO+oKufKq4PKizIO+7R8qOv4O/PRUPFG X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231254)(944501410)(52105095)(10201501046)(93006095)(93004095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:CO1PR02MB174; BCL:0; PCL:0; RULEID:; SRVR:CO1PR02MB174; X-Microsoft-Exchange-Diagnostics: 1; CO1PR02MB174; 4:vek7qNx6XEwPP9qBYtFyDmp/3dV5h8TOKlxU0lDq3MvUH8nHRTeQZ3YOV3XBFIolHi5af9A4CrAuDI9G3lnLiMfIdfsZkfL66L2FkYJWXpqhpp/Ujm35FxoMTt5am/ez6fMqvr07jrWAfK1/iMvXvzOAvtzykxvD6m/D+RbK883dLYPnd2Oo6SB9OEKf48DuM/wvG007y9DoGjpN2qheslNjA/qhatMSsIN3WNxvdIH9J5kQA91GoXzXN/l/5bajRmfTAZh0h/z2pHmyj46e3kCdB359KVWzdhlaBGq6KDeUo3Ju0XZ4+gLr4q1UqcOS X-Forefront-PRVS: 0717E25089 X-Microsoft-Exchange-Diagnostics: 1; CO1PR02MB174; 23:oGqLTQPpBDYB3/9TEpUhUA6ElPSM9LDX6nPrVav7736Ur5DqfU7i7nEUHN2JI0WoTocvrEKZlLvJdGQdA/83EAp/h/uBu2aEO7FPHTEaj4vzYbeTEjfXdbAqcAf+EIDeKCmRtWMwP2V5lgsiRtFrVtnMCcX8gsIYWHdJXiLDS3sxelcLAjyfwTAsERqat5RqphYOcHdC3MGJQp7RwrSmIPjiM0CZ6oxVGmGwAkthEr1JAc/7mLuNmTgtinuhk7dc1hGPkmGxti7Uc6T7yu6s5eJT3GeKRbn/aYIjMjZ5orUbVpLNyyvPjb83alKUnhX1HM68HTN8+uNAcpf7SJfsUTfw4yUh5sZuQ5gSULg1ajtYShqv0eYaN3px33CGoEERv+Ay1RxvHbrVJcm50UADtQpP8rGmgIENhjGPpp3gcTUniAqALtsEMOl/Ya/QdTftS3JkDPLH3lJeP1l3v4kezHlQAKuAezXimTk42SCN+vOSS0yPLIDHHBh6G5sRkc0H7A3gaXXTc1Bwn3B8ptCXTlZSX8niLH00bDFPYSrA4cNI12AuOOqrkxL2REQ8gvm2NKX21vFf9M0+hNr8aI2AnBQypY1+gtKZ2T1a0j5HoVNiPa9YMS7IhfTYkcn+1LH8udRUBpRc1R/hLUdflSXjJlopOEFcaRbKlfuHms0Db3SE+9XT4VN23+92eS90jqbkVc8/cMIg3Ub4oT9ZJf43NUsLB/LQdd/KYUva6LwOhQdTqt4kaRy1iO4VWJN2v1aIzXhCxMk1QwzK6ZN4KJNsMv4YH3D2GV82XIxL3AeaMrsCooA5FyKgLhEM+xXkzsmQGHuuXXXIN2T5I9Wk8R8MSYPhB4EPc1QFYH8nW/76yxt+8gadzf+DHw/IvLPKHp5XsdCoctfaICtlZh7UrBJYRgbq6k/ImzNvFulZPu19BFrxNyaPokVJ2NHu35afeabgt2/kKmVKezBIzcGMu73hpkaJuuur4VKd4ztmJXdMQZI81RxyIzY6MKgCjT8B1kEYqrp8up78PJp4yhgztGKAy/xeEz1ShbkobAUXQmTcAH04noyi7EtCoA5jixGsi/Jo1rudmfx1xIMopmnALOBnVQHWAXZJvOe6JBwwF8xKch20x2j8gnSwDOFZenMOXiiNvt6rEA9lcCeOOBJhAqyPcTg91B9KerZ9gTn64CEu/5DQRQu1ybfUYiIvnWZBYTda X-Microsoft-Antispam-Message-Info: wFtUu9Wc1cnBiBU5aCOC4fh1cVliAy0F9ZonO2KZoN0e9G+X+kBvndqsm8+QRTlfp8RkMFOylyD4wxS/wRofsnuyvBZh8cqSnY6hAfMUcOA1GQfkb2muPH09DtQkFRp48tdMrcz1g62MAg4xzoRWHIj1caKRlqsNFf6Efr5EkfU78r/NaHCLC+X29+IgNHnCItFWg1JdKl+tkAQy7scYBbR7pCrAqVoxuo6XAF2Q8MZfLZkDBFLU75/R/6me5q8iJQ+gSojknrIdNg80CHX5bxu7FN64G3DvFiPF+pzqFBYuMsgTdX5n++kW9EO/7AKI61DtOoDvCiPr5klCY/nHQZQUTvXEXzUuG6K/EIxCixg= X-Microsoft-Exchange-Diagnostics: 1; CO1PR02MB174; 6:STy/lDrMEALQZlhmFxHWWV/1zDdpkg959f9/miBZJr2v4Z3lISOqZrTlSn0o6Ex+GUqfUhVnEKWDGoMQRKQp2EOiG5mtxrI2HXG1RvswmcUm4BuX8Hw1agma+lribA64HKXF60m9xyNYQUuE2x3iKF0JB980nlMkDotxPBF191IzN19syblryhHJ1Lm48cReVirdGD42JBG2PCmxMWa5XO6BC1ngliFx439sm9ki/VSdzYOVIDJEFRTHXlweKFr46pRvgLr0ekx7SfqqJZDgEJ0+U3+Ex3wPyRqM9V0HLQ2UG2gTJlcQiSBl+gnBK6VOZ9AlPMITbXQvt8oT8U/a1VR2bz3qu94I0FpPbhCS7z4htEJMsWJh/05T/IsN7O6fkcW5byPXRSzeAiHYTtUyCORsn6n6TbYsIuLYER/6Ay6CkYf1x9P6F7xEwCil+LR3b1T9ueE/QqlC8/nu0zMY0w==; 5:rZ+XKiZbE8IsPffmQyT2CbIrF2/Wxntot+4D59UuO5LSr3EkfA+xffPzP17cHk34TgfUn5XFKC74sZ59s8gOxgKJw1IUY8Rc677/iJqPLv7P1hs/WjuVkn9Nf5F/A0hu0hCEbIvDSH8Xh42FfrFUzXh5Op18uxOWM5LkMzcspJc=; 24:qLFAREL8SfE7inGAe+OWmvjqF6p1IKiaeW9i0DVsuc3zpgy6nh6IMdTfd0neiMJSOkBVKbdU+mDDLJWc2Uw5VEOxj7sqDG0/l5F1dEP0mYM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CO1PR02MB174; 7:e8CYXLEr1NJDDmw+jlubRyauQiijxS5KIV4zwLn8OWVszdgRCgqbXR3q3iNMh3ujSU6DS2HqAg6EfS9PgNzoiX+p0gkQoq9StXR5K/TIt7m2GyeBjfuRpiDxg8hlhnpSsw4HfWIXw0F+aZwj+xXkpAtsbXwY5P7MC5TD3XQigg1ab++E/ID3BZl7Po3WZlATG1PdDCXCw1tKTJ1rSwqGTd4O/DX+i2ZOqCUZUbfmfjlA2NDHzr+RJdlfwqG4DwXI X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2018 07:39:58.4905 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2033b3e3-ae91-419a-9a9c-08d5dcca5997 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR02MB174 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes below checkpatch warnings- WARNING: Block comments use a trailing */ on a separate line WARNING: Block comments use * on subsequent lines WARNING: networking block comments don't use an empty /* line, use /* Comment Signed-off-by: Radhey Shyam Pandey --- Changes from v1: - None --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 34 +++++++++++++++--------- 1 files changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 2cc9353..59f4ab8 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -70,7 +70,8 @@ #define XEL_TSR_XMIT_IE_MASK 0x00000008 /* Tx interrupt enable bit */ #define XEL_TSR_XMIT_ACTIVE_MASK 0x80000000 /* Buffer is active, SW bit * only. This is not documented - * in the HW spec */ + * in the HW spec + */ /* Define for programming the MAC address into the EmacLite */ #define XEL_TSR_PROG_MAC_ADDR (XEL_TSR_XMIT_BUSY_MASK | XEL_TSR_PROGRAM_MASK) @@ -336,7 +337,8 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, drvdata->next_tx_buf_to_use ^= XEL_BUFFER_OFFSET; } else if (drvdata->tx_ping_pong != 0) { /* If the expected buffer is full, try the other buffer, - * if it is configured in HW */ + * if it is configured in HW + */ addr = (void __iomem __force *)((u32 __force)addr ^ XEL_BUFFER_OFFSET); @@ -357,7 +359,8 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, /* Update the Tx Status Register to indicate that there is a * frame to send. Set the XEL_TSR_XMIT_ACTIVE_MASK flag which * is used by the interrupt handler to check whether a frame - * has been transmitted */ + * has been transmitted + */ reg_data = xemaclite_readl(addr + XEL_TSR_OFFSET); reg_data |= (XEL_TSR_XMIT_BUSY_MASK | XEL_TSR_XMIT_ACTIVE_MASK); xemaclite_writel(reg_data, addr + XEL_TSR_OFFSET); @@ -395,7 +398,8 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) /* The instance is out of sync, try other buffer if other * buffer is configured, return 0 otherwise. If the instance is * out of sync, do not update the 'next_rx_buf_to_use' since it - * will correct on subsequent calls */ + * will correct on subsequent calls + */ if (drvdata->rx_ping_pong != 0) addr = (void __iomem __force *)((u32 __force)addr ^ XEL_BUFFER_OFFSET); @@ -409,13 +413,15 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) return 0; /* No data was available */ } - /* Get the protocol type of the ethernet frame that arrived */ + /* Get the protocol type of the ethernet frame that arrived + */ proto_type = ((ntohl(xemaclite_readl(addr + XEL_HEADER_OFFSET + XEL_RXBUFF_OFFSET)) >> XEL_HEADER_SHIFT) & XEL_RPLR_LENGTH_MASK); /* Check if received ethernet frame is a raw ethernet frame - * or an IP packet or an ARP packet */ + * or an IP packet or an ARP packet + */ if (proto_type > ETH_DATA_LEN) { if (proto_type == ETH_P_IP) { @@ -431,7 +437,8 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) length = XEL_ARP_PACKET_SIZE + ETH_HLEN + ETH_FCS_LEN; else /* Field contains type other than IP or ARP, use max - * frame size and let user parse it */ + * frame size and let user parse it + */ length = ETH_FRAME_LEN + ETH_FCS_LEN; } else /* Use the length in the frame, plus the header and trailer */ @@ -602,11 +609,11 @@ static void xemaclite_rx_handler(struct net_device *dev) return; } - /* - * A new skb should have the data halfword aligned, but this code is + /* A new skb should have the data halfword aligned, but this code is * here just in case that isn't true. Calculate how many * bytes we should reserve to get the data to start on a word - * boundary */ + * boundary + */ align = BUFFER_ALIGN(skb->data); if (align) skb_reserve(skb, align); @@ -708,8 +715,8 @@ static int xemaclite_mdio_wait(struct net_local *lp) unsigned long end = jiffies + 2; /* wait for the MDIO interface to not be busy or timeout - after some time. - */ + * after some time. + */ while (xemaclite_readl(lp->base_addr + XEL_MDIOCTRL_OFFSET) & XEL_MDIOCTRL_MDIOSTS_MASK) { if (time_before_eq(end, jiffies)) { @@ -1029,7 +1036,8 @@ static int xemaclite_send(struct sk_buff *orig_skb, struct net_device *dev) if (xemaclite_send_data(lp, (u8 *) new_skb->data, len) != 0) { /* If the Emaclite Tx buffer is busy, stop the Tx queue and * defer the skb for transmission during the ISR, after the - * current transmission is complete */ + * current transmission is complete + */ netif_stop_queue(dev); lp->deferred_skb = new_skb; /* Take the time stamp now, since we can't do this in an ISR. */ From patchwork Thu Jun 28 07:39:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 935975 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="Q/5qY89P"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41GWsk0VCvz9ryt for ; Thu, 28 Jun 2018 17:40:42 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934203AbeF1HkH (ORCPT ); Thu, 28 Jun 2018 03:40:07 -0400 Received: from mail-bn3nam01on0053.outbound.protection.outlook.com ([104.47.33.53]:3657 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933822AbeF1HkB (ORCPT ); Thu, 28 Jun 2018 03:40:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WCIOfudqmCYmvVMf2TDApFlfIKqr2oSUTCnqi+aclU0=; b=Q/5qY89PvSHOyS8VaVLBIDBAmpXTfh0ouA3nIt/bmtLF+YJ5zD0+71RHSLKyLRBStQe63JauG8tJREu7OSiDNDxm2DeIF3PoLcwB5yi4PJ7qpXDVLSKB6EDn63oaX1IvUHuILQtviGkD8/BkcMEceOUEA0gzDa0fUJ55UHkAXVg= Received: from SN4PR0201CA0054.namprd02.prod.outlook.com (2603:10b6:803:20::16) by BN1PR02MB168.namprd02.prod.outlook.com (2a01:111:e400:20::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.906.24; Thu, 28 Jun 2018 07:39:59 +0000 Received: from SN1NAM02FT049.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::204) by SN4PR0201CA0054.outlook.office365.com (2603:10b6:803:20::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.906.24 via Frontend Transport; Thu, 28 Jun 2018 07:39:58 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by SN1NAM02FT049.mail.protection.outlook.com (10.152.72.166) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.906.15 via Frontend Transport; Thu, 28 Jun 2018 07:39:58 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:34908 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1fYRX3-0004OD-L7; Thu, 28 Jun 2018 00:39:57 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fYRWy-000195-H8; Thu, 28 Jun 2018 00:39:52 -0700 Received: from xsj-pvapsmtp01 (mailhost.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5S7dmHP022806; Thu, 28 Jun 2018 00:39:48 -0700 Received: from [172.23.37.80] (helo=xhd-paegbuild40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fYRWu-00018W-Gs; Thu, 28 Jun 2018 00:39:48 -0700 Received: by xhd-paegbuild40.xilinx.com (Postfix, from userid 13245) id 9EA09B20956; Thu, 28 Jun 2018 13:09:46 +0530 (IST) From: Radhey Shyam Pandey To: , , , , CC: , , Subject: [PATCH v2 5/5] net: emaclite: Remove unnecessary spaces Date: Thu, 28 Jun 2018 13:09:44 +0530 Message-ID: <1530171584-20673-6-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1530171584-20673-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1530171584-20673-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(39860400002)(136003)(2980300002)(438002)(199004)(189003)(2201001)(63266004)(103686004)(52956003)(4326008)(106466001)(90966002)(2906002)(36386004)(14444005)(26005)(476003)(48376002)(50466002)(186003)(426003)(305945005)(336012)(126002)(110136005)(16586007)(47776003)(2616005)(50226002)(54906003)(478600001)(42186006)(5660300001)(316002)(11346002)(51416003)(106002)(486006)(76176011)(36756003)(356003)(81166006)(8676002)(81156014)(8936002)(6266002)(446003)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1PR02MB168; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT049; 1:OEACoIRbN5EhB3bK9/hKfHRG8Kc+xgdNOwnbDuhHQfiwOmvhEQv9r6ZOAuOluT+I2S2rM8lx6/sA6LTwb3botSLKrMz77WiOnHcHe2jLs4tXP2BDzFgDEsnQ0eI1kAHG MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9b24b96f-1ef6-436c-3a3a-08d5dcca595b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652034)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:BN1PR02MB168; X-Microsoft-Exchange-Diagnostics: 1; BN1PR02MB168; 3:mnDbcIzf+xeJj34RHIsDjzIMe1dv2uCA/Wzsy4yQJ8m3zFZufkEMWRUQQlgigUyQGqBcBp8wnWxwPyG25NPCcKF5v1hXhdQQjC25g2YMlZtlLjdeHhgf/X7hAAl9KtVi/q536mDH1IjNh8UUNwTIue6isBr/BLs/gUcCAcKDHM47h/pPqbBEmy78r2PGbEqmZ70SpQMLeIIQqdnOl9eX8Mhfhy5afTr+eQkF/RXwX+3eCvlJSlteS8bbLk94xgAvYctrfonQ46NdFUY4k9ysmmgKxcg05qyMlipT9DJslaFhDmJnlPrWJqwDHSpligL1gZoy8ip3KW6Xth2zLseem/oBTjDsr6ZzP0t0ezAmGgc=; 25:0jhOZfT9vElDf08ap3126I5VyAfmCBCnjOLru7MCx9Tp0j3irWrHYlv0bM218zwGn7Lg5/KI0nTK4bPh1H5vTO+mlsK+5jHNonEb2oeLq/CkuOO6LOydyeWpaNs6eB67qn12k5xzD+H2mR75RO0ECWoWojeYezaXkO2Je1M/Eu8UxMLDU0paHTk0/quC55Sv0MVJrL4yZFR9ZH6sbOLUzkUD6t6d7YRQqgjy52yOx0xsatpSzMhYTa96oMPnqPu3jSI4YcUmlTnH3MLfR8lbt4BTjss4LzcZSAG429vWt7v8OwtWiibTiyZt9Q7HPuysmM6Ofh88SJTSI9qJdHletw== X-MS-TrafficTypeDiagnostic: BN1PR02MB168: X-Microsoft-Exchange-Diagnostics: 1; BN1PR02MB168; 31:M7i/VxdoCfuiTp5kUdSC8iem/A93Ux93lOveIcIMJN4rf0ZA7le9RckvKzbZXRfixcKTB43EYIxx0bD5bVZU3dbrwWMADnjf3BqAHNSJdaquYdv9SosXQOFPPpz4Tf7qEBFQZpxQY1Y9Xwq0dDQx5WuE0xnGv3q7J5e3UGrl//Uu8++C3hw2vH45b0jAmyqfg1E7ab/btSkRhMdImv2pEEp38y4Es87GaPkY0k2mY+w=; 20:xl0PG8Nek8X4HfmSGTF/K8LmnVzerzZmOYbsztGHNi5xVYeonesh3+RMVjXwSboGbrJtlJYXrkzpINiw1sNvc7/l7b54gmIBijFymSlP5gt1ozebelUXcf8rdZ6jV4FnETGwheB1mE8yHIJKghYqMoyW4EmV2ht3ui3LxryNa0CUyr2yBWSE/p2vS3Wpll7gEM5cmT1ixG8ypGjrPajeqb2zjNifjzfVKqnWQvOTavHs/F/xXScHFgNzTO1OK5lzoqs9dUqvmW+CqVJ/Ff2CJDexm7J78chWKlnnT+l6U9sn4cgCJb5h4bRt1LVSsKvraNvTylmlT347ww8zXy/QWXTu79YuyUVxJoR1+sD51tkdPoWMGdPeDH6EHDrsX2IVlwYx1kwzsQenPJ4zSMp9F8BTrRUv1PbuF924PcIIpbbGlwcbMG3gC7SWiRO0hbZAGjehaxsacAO1MWYMEhJzXvM3uhZk0PC1rT11y6JZQS9FaRNYIFPQO2aZThbKlv2H X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93004095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BN1PR02MB168; BCL:0; PCL:0; RULEID:; SRVR:BN1PR02MB168; X-Microsoft-Exchange-Diagnostics: 1; BN1PR02MB168; 4:Pc40yiS5DAcBvniMxwztNvChjryMh04GloSz8f3VxJIGnfgoKAGoAcZNR0M2S9T/M27y6Vk6gvgDDX/Nb0Yj5xHTMQssR1FMDXa5UBbo8fGWrCEV12XRCqheb+lwpVRFqyHfDH2gXalWXxKYTNOpWhEYpkHxDSBv3lzmtetXj3zZn03s90iA02qeQU2hNf1yVENmp/PH0T0l2LYMfxgKcZu9i3NqVZUDN0GybG7zTY2e9q1rAr3k8yNnwbTtWBqp7GHFPc32V9mIkf8FwrsNd1s5V7FNqEFNEyvvgLBchT3gPGPI7DZx6d+vMygm0VBl X-Forefront-PRVS: 0717E25089 X-Microsoft-Exchange-Diagnostics: 1; BN1PR02MB168; 23:z+UkiIm0snnIW7X/1qkJvFXh+o9WTw700kDxazDTqTWsbyMruQUjf8qDfCkHb2n0h0oXAtzhKJ3rzo1yRWfSm4RSHz3AOnNTSw+5UWhKZB8gnUZxtubRnJBqQHW42sX8zPOIt8nDUWKrf20hR52mmBZjDTcAsWJig/KIGqXKN6tpe/l4doftKUjNz+fhzf+U6gDiwVRqczjKpEItX0kGrwrzRLhXSZBZ9cQJYpebOEC5LUQUPlZ0+G+G0edD3EjptB0YRKdby0z4iPBgUhdFwUaIFKev1u+hScZGWksb/hYYc1amY7tHALtgvWmT5BnsQ8jLYWBu6sslCtokWmoa3lA9WLZIic6ie3SV4B2KV9WFS46x4RwGhWSSYGYEO8FepuTqApUrucY7dvHboOI7qYsTpA2wHo3krhD+vGLe2Vzy1JBp0Wwp6/6GloXjsjXII4FYdy/TgNYyDX7a4iVrwgjTKeZ31rf8SM6eWqDFiEPw5lJOQK3xsmTQVE1uesDQmjRT1EMM1+toEYXotIGHEtxDH2TDM5zDsuTN2BS5abHlX+xA0XCfSsJGwn8UoqQ7FFaZv6qK4l3SWC3SX+sVzPbuBwbzfI0sbD+isR+A0/WRLF6lRHWibPAVApk215o4s4GHV0X+WM6yasr9b8pWCsKzMwCdEG0BRKAXdk4s35cl0WMCNl7rTeBAfKe95R/aJDBTMcxeY5wg39MmpDKZV5usPnSRRPCvNOLy6JG1s5qFbD4MvW1Z891tXwpzc2gIqSmDwVBHVvVKxuRElnASs7SlJAJ8/zvycQXlkQgXY8IALBTkDdVEB50tTMTdvgS4brXKgSa0DX7LUhjpWEVSEYagv/73ktyCD6x0Hn5biT6F8LYe0pUq3N+c5vOeJHSl3asHUmuTNouuONpAiNq3LJIokn84Cvnt8z2WQIt4tCi8UItxzkbIyafTY/o1zQIDYaC7VUFjobcC294jYRj7GA2RptcREoCWZv94fGn7HMJ/OjAOgKdGvh5KG19oW2GmAJHn7k9+At3FLzkqh5qFITR39sYteXlb/ofN5spE2KGvUn63Gqp7o9dAqYoUvynCfRaNDMyyZumaEpV87Oj0vT+RSXZndub2SYyUrTltF0c42UGav1oxtQ1h9xRsUESitW/Fkh9nWRcyFbsFrQWpop+71aXB2rbN3uFm72iVEB4= X-Microsoft-Antispam-Message-Info: Jcy7pZBRvTYtjnjxcwt3qONiGZ1gooFV6k0wRQ62V3r8XwnZOo7vdV/cX89LDYyMnPlzu2Y5rTdOJRNLpl8ChJk44uIwPYz1+upRTaenwtWsRVOVqwXoo4YiGrQ60d9u1meq1P/bA5Qz/5/+hMNK7XZkCvRJ9jrKwd/h2KTpZLRgizY4fJ1/yP53wB6iL1+hiLwf5iP8dgHBp9+QfIi+w+xRlGtxsTGE/fDngLcSvVKAH+5z4LFLfOqP1qRIv68xXCEEnWcRcvG4hwoEpKR8lh5wMJi3/oumWzjvnH6f6gcLyJ7qfLZ2V9s8OgSrtHByj4YqzJLY83a5A6gJpctboXmjVgD+DiELw0dGYTNIkr4= X-Microsoft-Exchange-Diagnostics: 1; BN1PR02MB168; 6:rDKX7p29KgR2nIVPQHhGX7kDUAPlRv1NN/Qa9cnn3OEUgVzH37G8TdGJssFszDix9XpUwOoXkfmZJ3SN6Z5A5g7Fbf0O02V36I6DauDwHeefXKM14vv8zQK+p+fVPauWpMuXUyBaR8jKi4D2Ii7i0ICJh3aYx5Z8Xw/eD30w4t+/dPNwIMjQMMcuPztZNQC9VVHD9Ko/6eIyNr9KUZl5SZSu2CvKxYo/u0OySrbYeOYSgIVHvwFn6QafffoLusBHr2Ukp4DB8FJofoj3GKft6jD+Z25N50VtH3Z9SBqs436hnZnYIZKw5NgQbkj86dO0NlJBLLCiTYG6LOLVeBQv5faxH2rFn1uzLAGN8jCjfAcID4Ey+7BK2IgilDVXCrHou3B7xXJ0/ydL5wZ7MmgBNwXyH5npHa1JzOch0Ye4endXBdVu6Bz9F3kqQQ7zsv+lPY5vewiojtznQ7JTTkCiEA==; 5:JsIFbE7pd5NtUk/kCgPqlGIijEazeAtE4F4E1BEhu7FnMkdmZoN+dafDkQ+sFvSz2ENAFzmiIOmNx57hM0aOWI+XuKf5q2Y2t+alPtyPaHLFgIYbS1bQEltZHGYidhKUOmjcjKDsG7gMzINToOMFmsmKgb75L9fwnSo02cGcLyI=; 24:hUeBa2jYUARvOwO35w9yLRHrSFzXBTgqUIQ4cNxkfsedGudld5g2QDktgjIlwYznzC0kIOWqDwKEelTsvA6+680Hh7TwAWS6ApJzW2jaPgA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN1PR02MB168; 7:n3dyNLUkcD8oQwQ08vz1Vr1YELEOtHQM0GzuLLfJIVcUoN00V4PIoczZduMkqMaEymKVsLmi9yR9IKCx2BaHpEZzIxW9IlwfRlx6wI7g/AU7xZWU2iFGXW0N9Yipn2PtuxOainLhOn3+MGavRA55FR1E4lS4zmt0VImG/Y3urchk78Qn+v62WPhTKdYQ0kxZkJlFrzdT9gIkqvLcMIKWyL9JsU5ZohY2bDNZZ9jj1yFYNEsjswfeq+HB0DThKaPO X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2018 07:39:58.0636 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9b24b96f-1ef6-436c-3a3a-08d5dcca595b X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR02MB168 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes below checkpatch checks- CHECK: spaces preferred around that '*' (ctx:VxV) CHECK: No space is necessary after a cast Signed-off-by: Radhey Shyam Pandey --- Changes from v1: - None --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 27 +++++++++++++------------ 1 files changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 59f4ab8..8b93940 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -95,11 +95,11 @@ -#define TX_TIMEOUT (60*HZ) /* Tx timeout is 60 seconds. */ +#define TX_TIMEOUT (60 * HZ) /* Tx timeout is 60 seconds. */ #define ALIGNMENT 4 /* BUFFER_ALIGN(adr) calculates the number of bytes to the next alignment. */ -#define BUFFER_ALIGN(adr) ((ALIGNMENT - ((u32) adr)) % ALIGNMENT) +#define BUFFER_ALIGN(adr) ((ALIGNMENT - ((u32)adr)) % ALIGNMENT) #ifdef __BIG_ENDIAN #define xemaclite_readl ioread32be @@ -239,8 +239,8 @@ static void xemaclite_aligned_write(void *src_ptr, u32 *dest_ptr, /* Set up to output the remaining data */ align_buffer = 0; - to_u8_ptr = (u8 *) &align_buffer; - from_u8_ptr = (u8 *) from_u16_ptr; + to_u8_ptr = (u8 *)&align_buffer; + from_u8_ptr = (u8 *)from_u16_ptr; /* Output the remaining data */ for (; length > 0; length--) @@ -273,7 +273,7 @@ static void xemaclite_aligned_read(u32 *src_ptr, u8 *dest_ptr, u32 align_buffer; from_u32_ptr = src_ptr; - to_u16_ptr = (u16 *) dest_ptr; + to_u16_ptr = (u16 *)dest_ptr; for (; length > 3; length -= 4) { /* Copy each word into the temporary buffer */ @@ -289,9 +289,9 @@ static void xemaclite_aligned_read(u32 *src_ptr, u8 *dest_ptr, u8 *to_u8_ptr, *from_u8_ptr; /* Set up to read the remaining data */ - to_u8_ptr = (u8 *) to_u16_ptr; + to_u8_ptr = (u8 *)to_u16_ptr; align_buffer = *from_u32_ptr++; - from_u8_ptr = (u8 *) &align_buffer; + from_u8_ptr = (u8 *)&align_buffer; /* Read the remaining data */ for (; length > 0; length--) @@ -351,7 +351,7 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, return -1; /* Buffer was full, return failure */ /* Write the frame to the buffer */ - xemaclite_aligned_write(data, (u32 __force *) addr, byte_count); + xemaclite_aligned_write(data, (u32 __force *)addr, byte_count); xemaclite_writel((byte_count & XEL_TPLR_LENGTH_MASK), addr + XEL_TPLR_OFFSET); @@ -448,7 +448,7 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) length = maxlen; /* Read from the EmacLite device */ - xemaclite_aligned_read((u32 __force *) (addr + XEL_RXBUFF_OFFSET), + xemaclite_aligned_read((u32 __force *)(addr + XEL_RXBUFF_OFFSET), data, length); /* Acknowledge the frame */ @@ -479,7 +479,7 @@ static void xemaclite_update_address(struct net_local *drvdata, /* Determine the expected Tx buffer address */ addr = drvdata->base_addr + drvdata->next_tx_buf_to_use; - xemaclite_aligned_write(address_ptr, (u32 __force *) addr, ETH_ALEN); + xemaclite_aligned_write(address_ptr, (u32 __force *)addr, ETH_ALEN); xemaclite_writel(ETH_ALEN, addr + XEL_TPLR_OFFSET); @@ -572,10 +572,11 @@ static void xemaclite_tx_handler(struct net_device *dev) struct net_local *lp = netdev_priv(dev); dev->stats.tx_packets++; + if (!lp->deferred_skb) return; - if (xemaclite_send_data(lp, (u8 *) lp->deferred_skb->data, + if (xemaclite_send_data(lp, (u8 *)lp->deferred_skb->data, lp->deferred_skb->len)) return; @@ -620,7 +621,7 @@ static void xemaclite_rx_handler(struct net_device *dev) skb_reserve(skb, 2); - len = xemaclite_recv_data(lp, (u8 *) skb->data, len); + len = xemaclite_recv_data(lp, (u8 *)skb->data, len); if (!len) { dev->stats.rx_errors++; @@ -1033,7 +1034,7 @@ static int xemaclite_send(struct sk_buff *orig_skb, struct net_device *dev) new_skb = orig_skb; spin_lock_irqsave(&lp->reset_lock, flags); - if (xemaclite_send_data(lp, (u8 *) new_skb->data, len) != 0) { + if (xemaclite_send_data(lp, (u8 *)new_skb->data, len) != 0) { /* If the Emaclite Tx buffer is busy, stop the Tx queue and * defer the skb for transmission during the ISR, after the * current transmission is complete