From patchwork Sun Jun 24 00:28:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 933816 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="aMz+k8GX"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41CtSg1Rl0z9s0W for ; Sun, 24 Jun 2018 10:28:18 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751814AbeFXA2J (ORCPT ); Sat, 23 Jun 2018 20:28:09 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:38513 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751585AbeFXA2I (ORCPT ); Sat, 23 Jun 2018 20:28:08 -0400 Received: by mail-qt0-f195.google.com with SMTP id e11-v6so8572033qtp.5 for ; Sat, 23 Jun 2018 17:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=GQ3dJCNg1LYijbYzoZU4RLPNPpHPKs0JXYGMb1MTSpA=; b=aMz+k8GXDy01ApBfEMnLv5XH9LODCElSsaYlm1ybsWxkqU9oeQ+CuLG9Bqi+6EBEpS /K+nJSkbCLxG8ZQ0gn5GZulaw8BFh5RvGolUw7ToSF/KRtQ04STUOuXuibuKARCR574z 5OfI4+lYy1DeYMS9fE0QeNnhzII1XG2DwPn5hFWiVC2ZldTcLzTP7vV2OuzkuJhTxJvz majD9sVY+fcI128xzVG+OD3ZEmVqLVAvRwWpzMlH6joQ1wvIMs0HacTgwrg+VSp3uSKu eZyV03JhO76l6QP5vP5da2J8fFRdKiNdlFtSr3wT0SxAOdlLZkzdTDhfZOFOPXsOuM3n 258g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GQ3dJCNg1LYijbYzoZU4RLPNPpHPKs0JXYGMb1MTSpA=; b=d3yjLmcBHoeCOLWXF9WvgJvjmdCxWlXZlrJYWAWt9HCdq+8vhScqHcezK8Oy4ZwHUL FxGO8tXuJTYiUANluLWaI1zBTyBR5JQiQk9XmqV0EEirC487I17Q7oeVVrDrX/GxxmqE 1EUwPmofSuGUSUg0jKxA/hA1RkgHNCh7oYzdHok2YjLRO/jtnw66keYdLHTw6ltIxfck /nPjX6wPMx2yCsryWZm828GMqHLRF6wyR42yfCr8q0gSTOFiBSaa9AsLPS3OpN/roXBa 3BuuCOkXJqfwhTecS0ciD4cTaizr662JcYpZ7BoNy/E0vLrrbmENKk0hsR0UHGw/pdeW feWA== X-Gm-Message-State: APt69E2BO2FmIup+rTwKK8hwJJbM9A10DyiMeIb8me8H4Hjkel8HH9Rn Vt/uGskJOGR9UFGBz/RtZNw= X-Google-Smtp-Source: AAOMgpdo5VGJqbrxToM0KQWuuXnW3XpCn9+DDOljUY1m7gHMKVbOvzVthRdQvI+EnXzPjHdS9DOagQ== X-Received: by 2002:a0c:bd0e:: with SMTP id m14-v6mr6408698qvg.164.1529800087937; Sat, 23 Jun 2018 17:28:07 -0700 (PDT) Received: from localhost.localdomain ([2804:14c:482:583:d5b4:c4a:2129:e7d1]) by smtp.gmail.com with ESMTPSA id a8-v6sm9001626qtb.15.2018.06.23.17.28.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 23 Jun 2018 17:28:07 -0700 (PDT) From: Fabio Estevam To: davem@davemloft.net Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, Fabio Estevam Subject: [PATCH net-next] net: phy: fixed-phy: Make the error path simpler Date: Sat, 23 Jun 2018 21:28:22 -0300 Message-Id: <1529800102-18287-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Fabio Estevam When platform_device_register_simple() fails we can return the error immediately instead of jumping to the 'err_pdev' label. This makes the error path a bit simpler. Signed-off-by: Fabio Estevam --- drivers/net/phy/fixed_phy.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c index 001fe1d..67b2608 100644 --- a/drivers/net/phy/fixed_phy.c +++ b/drivers/net/phy/fixed_phy.c @@ -259,10 +259,8 @@ static int __init fixed_mdio_bus_init(void) int ret; pdev = platform_device_register_simple("Fixed MDIO bus", 0, NULL, 0); - if (IS_ERR(pdev)) { - ret = PTR_ERR(pdev); - goto err_pdev; - } + if (IS_ERR(pdev)) + return PTR_ERR(pdev); fmb->mii_bus = mdiobus_alloc(); if (fmb->mii_bus == NULL) { @@ -287,7 +285,6 @@ static int __init fixed_mdio_bus_init(void) mdiobus_free(fmb->mii_bus); err_mdiobus_reg: platform_device_unregister(pdev); -err_pdev: return ret; } module_init(fixed_mdio_bus_init);