From patchwork Mon Jun 18 11:08:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 931418 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="I5UuCUKF"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 418xzp5fqxz9rxs for ; Tue, 19 Jun 2018 15:56:38 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965358AbeFSF4W (ORCPT ); Tue, 19 Jun 2018 01:56:22 -0400 Received: from mail-sn1nam01on0088.outbound.protection.outlook.com ([104.47.32.88]:24160 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965136AbeFSF4D (ORCPT ); Tue, 19 Jun 2018 01:56:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u68EaC/+Rf3BT1GMhpaBtVmLhkJFNvZ00jMaXBmW0DE=; b=I5UuCUKFgWQqaQQwTFc5FyL2n8WvA2FGjE+tuv3MFCwBS1i6SYxOe4HFALn6xuBqHtKjz2vd3a7vYb9v1HDhP/EME6K8FV+XFmEGvzCSWs4GfE9Db2uVa9nJKheFNaM6lcIN9pIc4cw9TvjAuRu6E1m25eNwAiK+FaX3CGWKV8c= Received: from BN6PR02CA0092.namprd02.prod.outlook.com (2603:10b6:405:60::33) by BL0PR02MB4625.namprd02.prod.outlook.com (2603:10b6:208:4d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.16; Tue, 19 Jun 2018 05:55:55 +0000 Received: from SN1NAM02FT049.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::209) by BN6PR02CA0092.outlook.office365.com (2603:10b6:405:60::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.863.14 via Frontend Transport; Tue, 19 Jun 2018 05:55:55 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by SN1NAM02FT049.mail.protection.outlook.com (10.152.72.166) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.863.11 via Frontend Transport; Tue, 19 Jun 2018 05:55:52 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1fV9cO-0003YT-9R; Mon, 18 Jun 2018 22:55:52 -0700 Received: from [127.0.0.1] (helo=xsj-smtp-dlp1.xlnx.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fV9cJ-0002dz-5l; Mon, 18 Jun 2018 22:55:47 -0700 Received: from xsj-pvapsmtp01 (mailhost.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5J5tkXX020560; Mon, 18 Jun 2018 22:55:46 -0700 Received: from [172.23.37.150] (helo=ubuntu) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fV9cI-0002da-5h; Mon, 18 Jun 2018 22:55:46 -0700 Received: by ubuntu (Postfix, from userid 13245) id 8549A3C33FE; Mon, 18 Jun 2018 05:08:30 -0600 (MDT) From: Radhey Shyam Pandey To: , , , CC: , , Subject: [PATCH 1/5] net: emaclite: Use __func__ instead of hardcoded name Date: Mon, 18 Jun 2018 05:08:19 -0600 Message-ID: <1529320103-7711-2-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1529320103-7711-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1529320103-7711-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-Result: No--5.591-7.0-31-1 X-imss-scan-details: No--5.591-7.0-31-1;No--5.591-5.0-31-1 X-TM-AS-User-Approved-Sender: No;No X-TM-AS-Result-Xfilter: Match text exemption rules:No X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(2980300002)(438002)(189003)(199004)(63266004)(106466001)(426003)(11346002)(446003)(2616005)(476003)(8936002)(90966002)(126002)(336012)(486006)(7049001)(36756003)(305945005)(2906002)(498600001)(47776003)(48376002)(26005)(8676002)(356003)(50466002)(186003)(6666003)(81156014)(81166006)(4326008)(54906003)(59450400001)(51416003)(76176011)(6266002)(5660300001)(52956003)(575784001)(103686004)(50226002)(106002)(42186006)(110136005)(2201001)(16586007)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR02MB4625; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-83.xilinx.com; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT049; 1:ENtIdBOOhmJlezfMs7WeDzEPM2GodJBOerl2RVaAriThrna2ypnrhKuavXfTYlraiwtM9lBPiZkZAYcPv0ZFon8+FOmS2pDjH/0LI8eOMFlJURuC6mIZZemVoVas2LZ4 MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7d3c8c4d-3588-42d7-811d-08d5d5a95236 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:BL0PR02MB4625; X-Microsoft-Exchange-Diagnostics: 1; BL0PR02MB4625; 3:2OgKN15xrEzx+8NznBFqJr9HJg8wwsbuBrCu5xMN6SW6SWHr8xGKctoYZgNc1etw0xwqAEOKuvhEou2fintVoCZf6E1En152Dsr1jX4z8CkJAz/BBnKffukuOD0nYYFDdVCrEQ/M/XNX8zxDY5OC0yGpZiab++M7nU63DKL3kTVHHb2oIyf6Jih6mzVLSTg0cktCiPDB0UcU6ldT/kGEFnThWwIyyY4wrSFrwycLSmOIn7G5smemRPoy5VGgnGTlUE/zPks622C2nwwY8jADMNNOJwAkJYTEwtMWCMc8eXZ46FlCQ3uw9OJhQc8cWQ+H9/BPihJFbsjEi0/XNIPW7gM/rjLJvwuU5hFi4L+hBCk=; 25:0XJNQMPz5G25mv0Q5xmKtlAEbyQgdR9R/3PnLxawU1UGfNOutJOVv27Ijz/1jEO1zUD7VdJkukCUmtrth2X7hXzx/RY5kvKlginFG5ji1y48q2cnwNlQ5BCYipPx3TkJ67s0dsXfTuSlr7iszF/Ei0Jg6jxTHOTe32l4YAcvPjhtz95Xkufi7Sxwt9l05wPoHtmvRrQBNmNBxWOnZzQmtvAi/90gBU0OfWOX0fTq2HM4L7OE0V0xV8hS98F0DP3RItbM9xtuRW21Ds6ApXWPzkqymq3qbLurtJEY8YI7iaLl9pJ+wQH37KGKme5nMrGv85VMHmueqppiADbu1KGeBA== X-MS-TrafficTypeDiagnostic: BL0PR02MB4625: X-Microsoft-Exchange-Diagnostics: 1; BL0PR02MB4625; 31:soRdmikyuGQ1cFmgvoTgkwKDNtFEZvQPGETGbiyFPUhmAAsweA2MtRAwJEa94i/zR51kp0CbGHcdGyONX+LnxcI4GAhGAC4wKBvo/qyORAU5BQfW45ZeW/4qeSmtyyR4gL+Lhi5EO8Fn2a1AI5f9RrVXZ72HtF4KbYvHOzSeV38gv7ML7iDJ8vmeq4wRs8ksxUvQSH0MWAx8s9RMmAGERzYJbQrrN0gvK5nnxFWmJ1Q=; 20:hvc19qEPieOT0uRWlQ7cPbcH0K6A2nLDt+5MQshJawpfvtCM9tAfsSvWVYnV9hHI+SiYvEGEHZOxIR34BCcCg7slVj+OWycYFBL/yuFPX5YItk3rukZh7nb5rc/x6NFjR/onNH5xPuTTk1dhawcloHpQ3oZBAQMgI8EXF/pO2mC9D+s7s5TRkQ2R2zQSQOG1o6kCBWOFfdqDtdTZsQdC59KmplJg0LErxHpleTTuPZ3hT5IezcTHZA4xmU61NAxpCzh8qdZXcCZ/gb8Zbwn7J1dothDWonNnQRRAXGwrMHXo2nArIHwtHn5ranP/rlr6Lx8AV3+CXeTtyGOrRVzpbEb3etJgDfbEc2kcLN/skNOdvRj/AESJnto73d3YjU+nH/n9tXl6gb05VFJxi5nQDXhc8LAO8QTQpPSKc4Whzsn+GlAFtR/5OUYSpqMyGW+m1zi/PZSaSy1geTeuMcimnz2setDzHdmV10HDS/e0Z6suBI8hNtHHNywB9D/4itjT X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93004095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201703061421075)(201703161042150)(20161123560045)(6072148)(6042181)(201708071742011)(7699016); SRVR:BL0PR02MB4625; BCL:0; PCL:0; RULEID:; SRVR:BL0PR02MB4625; X-Microsoft-Exchange-Diagnostics: 1; BL0PR02MB4625; 4:eJ+VB3v446GySoEslNvgwT7mNwr08MBS8wwR6NqKw9dg8GN4rCmXAbpJQqkYttyzHdFpY+/gDwOWQRxqLATqnJpydUv3pYcJpLedXYtfW18XSZmDsFfbIBrD1x7HveohBy5OiilT+WqXf3LsxEepjHT4nM29UiTQjXYGmozl3c3ORsSu4EhYJ5YxXQvrvDgLLQ6XQI4ix1MHDxpOuYXX6E3r2tXSZTn6WVyY4RxtQ1g+UndiXkACk08qUjeYoYovHeOrNmM0EY9v0GYJGzFcOlKBwfAJIbn2pRePmtCqS/EPLjIb/hz3BaVTMeyaOZ7P X-Forefront-PRVS: 07083FF734 X-Microsoft-Exchange-Diagnostics: 1; BL0PR02MB4625; 23:qnS0Ld4Hf7NfnNt5+Bv67QLsRBlPjcaDlL1HhYVtnCWUBOJ7XezW9YgJsJZs5C60E06NnUscXbri/dFRUZObsY2R/DSCeelAG6GQXCXqBYEIsLa0heSoVRzrt4PYvV5bY2Jbnk6iZUjznchfOk04/wpwfFHAg31jpGFEQEK4+ORl4skRlN4UIzbESe5LICha6m3DuVME0V0HJ4EAjWYKh3MGSs+ya5PJiuv5nDG/3Hz09HgDEJ4T5/nuRZLPTh/x+X0iIcEgZUQFsUNj0OPUdzLi0ZYcdfvZTxyJyJ0an2bcQyUOwPeCyI5Kfx1AX1fKzKz0DiacfTY1W0BYqrGIilcGw5dzGQ7MlPUkiUDulXaaCPB+f3v9fWooJ6EfbsTo9g1crfH0O/1IOx4+DbizdYEZYrN8pDb4c9DRpAiLOv858SIKK5aHiVN8bur9VFc/4kfbVhmiXZxvDnC+0iH+5Fu7rZ81dm5yYki3j5oziUhoTyz+53lWEzaeKQiZWO+3/kLf/J2Y3KXgqwkQrBWHuFvxxu07e+gDZGS5zjV3aMveGhE27wsjZSGmXFzr23YJHuTRZDY8SZNncpVcrp4eMswTUgOoQTh7xyZpBkzg/sivxod5Q0l/a63B0jvUmGgFxDUJ5BWkJZp769S+tqq61+e4pMm8aZCgjpgbSV0i3evHz3/4qdpHpGWRh9hkHfmromwJxMTlSGKkje3vLHtA2VaaC8+Ou9qa9U5dz6ZM08YUZpUaPYSoMM3hFn0nRCLVzORBZeNYz96gfkGMGZHf3FV5U95tG8l/SFLvlzhSi9iDDhul084ZrkAsGNvPigpw8XzGZWmVDPHexes9HYQtNWrnVfy4p5c/WkdOPF3D87eNxvgfpOseHKUFGkdwCnFXH/YjHAtOtSchkPT7v01k9K+Bf2ONsAbyNVNPEpn5dUwLjZwcr3FzR8Z6hbZXidy7htDseFBdpLFT395GqxvhUVpxrHeOgXTd74B/8lRh0B+FjwfowIcPpAz4KVakGXPojUz75UAX8PA8ml7whSTcDSvNPT0GiG1X9EmP7Q+gXuO7I0C6NRPCa1SM5hrQVUh+df/vKT1+lf5uW52dAKROvw== X-Microsoft-Antispam-Message-Info: eY/b/opfvS1WX95QpXZLlMgNX5cbpQ9Fh1TW0jeDgT1i86ECq6YKMJw9GYwCCi3Z3D8PTA7GDdocMt7vU/oHiAsk1SJvzVVnyaLlJMiuzbsPxwGFyEfqkjFpGOo1BAdZkn/M/HuZAxwLva9Z/3tVPMD3sQdUjkZ0vlm0jEaDDW94H4HvmwCOvLF1MTLEhRE+hqQfM51ti/TKMvcAtMtdLYqDbOrJwQir/CBEB/A0cNsgluE17/HfNNO56Xia+24kntRnednI8NNM27CY54aIp4fS0CBmWhVu2sel+8+DatlSYvUofRmBX8LvGXz1Zu3hCrtxNSP7DDHC4MXnCVbzCQ== X-Microsoft-Exchange-Diagnostics: 1; BL0PR02MB4625; 6:MdqQ3HexWwbsCZl8bZGS5CnVLQArZGifMjTVzpBjR4aJt4300iGclMdEESu2sErYy3yqY3aW4s81WLVmImPU1C8T+e9GA1qyBVINZQHwYOn8bX8Ucn4aCl841tdP6hh2bUd1fpoYhNWifgAet0pfIZBzE/D1PYwK/vS4XHlkEq5S8uCj0PK2pMEGlzONFTZIDfQ9nm0FF66g0cZSn+/UZFK0gKDLDP5C8NLSCuDltBnlaie+Lp91HKTyM6/WnO67yrawwwjpWR+CXD3HG5DhGI6AvJPuyKI4HFxnAcD/hc3rmhrqzgRN8KqNUsQ6J0l4Kj7CdeawNgdxe34kxoUcSovVX0sb1Qj7t2aN5fmJOVxqLG5Sr6AcSt/pmmcyNt1I/F6U4qi9D6sZC6c5zjp72WRv+9f6+OAEX2XW3KBdDu1K4UE7GJXNhudn9sI3BmqMytNcsbeulxW6vPOODjr2UQ==; 5:qnsyUI02DR2HvmwxAPAvLHnoanZN65iFjk37fJD79zGyiTK5Ifq6VJpnx7SFJBEkPPl5qaXkat7YSCByUtzX16RSOdh99AkAJJFWJkOFqdln6LtSFR6zDJB8zMHNVFGP2LS5d1ncMVDt6Noh1SYM8jYgNLAUPZxitDCBavu3MzE=; 24:vkWP6v/Na9ruhni+HLEclXcuoohghoF/C9+NUrPtVvkucT9+1xD7yP9v/BlVer5A7Kk9gUk24KQZHuZkwsDWOPaOtk7AzuvAIuLyklgWwJw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL0PR02MB4625; 7:EV0uupAWH0fMfjEwFMxuYQDPOPU/oxT4lYbcqlGikWqG+uObkEo/9XmYAyU+MBK9aQFHB7gfUZFTxd1mNPf5y5VqTQ0cvQpZ4Fqj6ADORhh1/ALFOuJhKTM6BDu/Hy0S/kyK1YHpvQ+KY11LHRG3YycQLfz+S+JozkzGwo87qH+a6CaMg4jG+EBcz0Tzuy+zDFPadfRAdzjPLJ9HfBglmNXdzaf2I8kLA9/GmzPU0n0OXnGrGK2lY5aNAzfR9XVE X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2018 05:55:52.9535 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7d3c8c4d-3588-42d7-811d-08d5d5a95236 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB4625 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Switch hardcoded function name with a reference to __func__ making the code more maintainable. Address below checkpatch warning: WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_read', this function's name, in a string + "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n", WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_write', this function's name, in a string + "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n", Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 2a0c06e..0544134 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -757,7 +757,7 @@ static int xemaclite_mdio_read(struct mii_bus *bus, int phy_id, int reg) rc = xemaclite_readl(lp->base_addr + XEL_MDIORD_OFFSET); dev_dbg(&lp->ndev->dev, - "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n", + "%s(phy_id=%i, reg=%x) == %x\n", __func__, phy_id, reg, rc); return rc; @@ -780,7 +780,7 @@ static int xemaclite_mdio_write(struct mii_bus *bus, int phy_id, int reg, u32 ctrl_reg; dev_dbg(&lp->ndev->dev, - "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n", + "%s(phy_id=%i, reg=%x, val=%x)\n", __func__, phy_id, reg, val); if (xemaclite_mdio_wait(lp)) From patchwork Mon Jun 18 11:08:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 931420 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="mpc9Qj2V"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 418y0K2Kqnz9rxs for ; Tue, 19 Jun 2018 15:57:05 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964890AbeFSF4A (ORCPT ); Tue, 19 Jun 2018 01:56:00 -0400 Received: from mail-bl2nam02on0059.outbound.protection.outlook.com ([104.47.38.59]:4160 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751964AbeFSFz5 (ORCPT ); Tue, 19 Jun 2018 01:55:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gFI0Bb359RajYsl2LlY9a+iCpDcGa1wTgr1YH2H8PHI=; b=mpc9Qj2VsWsGgGq/QPfJ/8se9GFc+pxbv43/suLWne2cX5kIMIC6nkBcMKCkg2sNLyGTazS3BWDC4Lvm54PiZbm/rPtnsXU2CZfnTs5ttfbzj0x17+BQgkgiA1Jav6jU9EAXIKnI2s1Aacj67myxsdawBARQ0jG548PbrvLmeGA= Received: from SN4PR0201CA0039.namprd02.prod.outlook.com (2603:10b6:803:2e::25) by DM6PR02MB4634.namprd02.prod.outlook.com (2603:10b6:5:21::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Tue, 19 Jun 2018 05:55:55 +0000 Received: from SN1NAM02FT013.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::203) by SN4PR0201CA0039.outlook.office365.com (2603:10b6:803:2e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.863.17 via Frontend Transport; Tue, 19 Jun 2018 05:55:55 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by SN1NAM02FT013.mail.protection.outlook.com (10.152.72.98) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.863.11 via Frontend Transport; Tue, 19 Jun 2018 05:55:53 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:60978 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1fV9cO-0000Kk-9V; Mon, 18 Jun 2018 22:55:52 -0700 Received: from [127.0.0.1] (helo=xsj-smtp-dlp1.xlnx.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fV9cJ-0002dy-5m; Mon, 18 Jun 2018 22:55:47 -0700 Received: from xsj-pvapsmtp01 (mailman.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5J5tkYm020559; Mon, 18 Jun 2018 22:55:46 -0700 Received: from [172.23.37.150] (helo=ubuntu) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fV9cI-0002dZ-5c; Mon, 18 Jun 2018 22:55:46 -0700 Received: by ubuntu (Postfix, from userid 13245) id 87BF53C7257; Mon, 18 Jun 2018 05:08:30 -0600 (MDT) From: Radhey Shyam Pandey To: , , , CC: , , Subject: [PATCH 2/5] net: emaclite: Balance braces in else statement Date: Mon, 18 Jun 2018 05:08:20 -0600 Message-ID: <1529320103-7711-3-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1529320103-7711-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1529320103-7711-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-Result: No--7.993-7.0-31-1 X-imss-scan-details: No--7.993-7.0-31-1;No--7.993-5.0-31-1 X-TM-AS-User-Approved-Sender: No;No X-TM-AS-Result-Xfilter: Match text exemption rules:No X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(346002)(376002)(396003)(2980300002)(438002)(199004)(189003)(6266002)(26005)(4326008)(63266004)(36756003)(186003)(356003)(106466001)(52956003)(103686004)(305945005)(50226002)(2906002)(2201001)(8936002)(478600001)(126002)(476003)(2616005)(11346002)(81156014)(5660300001)(336012)(51416003)(8676002)(81166006)(7049001)(426003)(48376002)(47776003)(486006)(446003)(50466002)(110136005)(106002)(54906003)(16586007)(42186006)(316002)(59450400001)(6666003)(90966002)(76176011)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR02MB4634; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT013; 1:vIkdeh7cqKVGNWNnjkoKcqKUELKLzwwXYXPhKbw6i23hL1fd7AFeVfVlOrLKwxQe/DjD6b0SLZoqHZ3esSlJk4LSq6HXASy62lrcyAbtAWlmwXCb3aL7qoByjXu5mTxr MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 25073b1a-9bf2-4b55-469c-08d5d5a95244 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:DM6PR02MB4634; X-Microsoft-Exchange-Diagnostics: 1; DM6PR02MB4634; 3:mVw2Dqh9+ak8PE7ocfwrQwVVum4sgtXnYq/0I2naAl0XBjVN37Q5gQBenL6memCxW00gMOoqJ4YkcbmHpJNwDnI6F2y0mRc0niLikwsornHv76f0oGC3tXjaqinQinKq2Li+X/fYCQ/09rmtG2KCZ6AvC83LbXcJ5qYSwX9E+U8pKauceXK740oUKId7mcrBdC5TfYnofQJh/5LzUgJS9Z6Usqq7tw88e+mGXZ2KPLpKajjaquu4VL3uOSWXgIT4Jmhrbs1aRlw/pEBHzlHI5KcylXHcrfkkQSfZhCXgoRP/jeoiZdGD2V4WJIj2mrP2S1tKwvX/x/j0DSIxp/YFaQ6t54Gu0/uZ+HF1Rbsy27c=; 25:51RfVnyPzeZkyvVbATU2dV5VMjOjJcAzp3bbky5R7TyIHHBHozN/lW8frA/wsT80jYvCZfTXLGWljMoySColcYVjzAKTS/5KCVKo/d3gzWWmGjXQl+qf/1LkPVKmwfv9VlfSxcaXiQQTRYpGlIEqmvlwo3ByVM9JARyxz9EikGihQfwKKWlGdSqxwXLlq+nAA7Uj5XClkOl2AuSNSoIEOUBP5AKIGvoryEeXv52b8GXjH7q3GoQstIHYUTI83ugj8M4grqhREgojDwa4pYLw0TAEgzHb73CSjhPLzH1YU4jaj5SKwFBa+YsRLfc5/zFh3ahSqCM+quzj7bq1sb5BZw== X-MS-TrafficTypeDiagnostic: DM6PR02MB4634: X-Microsoft-Exchange-Diagnostics: 1; DM6PR02MB4634; 31:uifi7+xK4z6XC7eSCrMY26pgUJdQ2WPXUWzXGeQ0Dc/AONVGDFj/a5KPTilKuqh2Rp4FrO21Goa85GB5hnEMryO1oCFkN6aoJnhG001IusrgpEuBgb71IMPsUHD3ObQQ5tNShbyWTqAZVbJiJnfMy29DxqLqI3GpdYFTsUWeFQs2vv/PSchZ62GCO0b1bOg07dP5wvR3fRzS1U6rUyWGXp9GerA43RG3ptCmw+aLLsk=; 20:9JmVCbBTs3xvEjoumf2nMkVW/ctz3T/h7SSJhrBecBbAhL5rqSN9nn/vAXfYkXNy3zvOIEcgGSDo5W2UjPGgTfptbJ9ytf7on4pyHQ4K96iUb6rMxtmOgYmPvOELtLxOxiuKhLt6KJgt1jUTdCPidVflIZrpMjXyXBNFQ9w8oIW3b6H06TT3pqh2tHAyapDJetChe7hQAgmdnZn4yNdM6s17LdOXsxclTjG+ODwyyVk6la0U9iHpwaKPtuRdBixuqrt6n0ZJ2yaKVWOc0nF/rx2xTThPoDTDwa27tljPPxNYNB6Pg5hWEHY0Dsr3y+ocIAIjMRIBRHfcqbEUQWNEnpTSjyuyUJlt90A+9a643M7VgMPUjTcfwoJDhuqj2e6ytBLNDJGmy0bJK05BMAVLtkWV/1Y9k4fyrWkfRmN6OurqWljhXB0MI6h+0Mjkd7HoYdc1wQRbU6He6k1S7rwpD5IdUYbhfQL8aRi4OfvXs1yd3t1TRW2qxCEIluzDTi7X X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93004095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:DM6PR02MB4634; BCL:0; PCL:0; RULEID:; SRVR:DM6PR02MB4634; X-Microsoft-Exchange-Diagnostics: 1; DM6PR02MB4634; 4:Uy/Qld3wEnOqhY9tzg3lVCSvEVCbpRmCb53SdbqoxI2gwLRCwDpAAkTAoPuwxASHi51soM46Ghjc2O28NvPhqYp72jIn9zykVxFNyRPmmj1Rgk1gfQb9Nl+4z6pM9HA6ZLA0iMk6QaYgoP+bcb8y9I6yX0H12NFFhSBC2ijFu9acCEbIc+746O/JHFQX3mYxvdGMgaiWJoEcTt6TQlnlStGWmUfzY1JBSuqdishiJrlxRWm42e8H40J42ulWPfcnU9erEykZgJF04TcQMUE8QLBYQcj7MWBwFYI2KL4xIskoTCNIjiCvF7XDTnh46UQV X-Forefront-PRVS: 07083FF734 X-Microsoft-Exchange-Diagnostics: 1; DM6PR02MB4634; 23:4jZYoh6mXA78hyNAWZvYqggdOTpVU7DvVMZwrk0+DUtK47Xs4+RE/Wby8rykTiGAtwjXs59NVeBjpggbm7mmFBtM43zjszr8XDg/pQQIy1Dp5wjZN0lUpqw7AHHdy0ayFUBsdsPuy/Vr6PoMifIxxIwdAudwq4LzQrHp1E3Qn/qftHE/mk/K+d+l2ng8PO4ktVN5j8rXG52bQOSbh7YTzIrD4n6NfQ3I5XXrWDQ6ui22L8yDHJ+W+R0VFMyb3//oWf8OzKVpiJir2CdiisuTh4ZSOhGbVTUpdzIwvs4xrwsv1u1fbd+m/xIrBMHcOmgeZvmk0YAx877IVhL4t3/IPxjjSyIfiaayAAQbch/B3WbcBGpfZZM2M88ykV1aIQNw2Uf9Ze2Gwo0bctBZ+f/P0CtJ38Rh1VdzfhViAm6TiuFPx5a+yfrqbcktfC7X9scHGLUPwNEP+3SqVu/HrgpRFfzjxYFturygpFShXgNwZ2QnwztKA7JUQqVWo+lRWbqkECkybn2l1nKassrtQzBBP7VNozwuR2o3RtVyBp+awxJHqv9h+/ECPpxk5tDtFzF2m6TCb4oAuSHHIjqvVXPpn+O7fYFKASyTCYoph1mRmbj+c7YnxxQFOdtVe5aKp84AJ1miU994rBJSFjQxw1uqHA6G1E0AepjthMEgkAxd0Dv0CRxi0NQZgjtdvswIOc/QgMQe7KWZN7ztwyoVJDmmH4aG7Aa6wUehQIrRHMPGhArLgcrjKbM7fxwyXbKOflyFV4+7ZYuC6CZyRToJocvVv+/K23hXdiOuvUvcfNUUluSK2UOrIUIQsG2T2Bmikk8APi6+UjVOZ30E0FrCZKmHFnWK476mj5O1d0PId/8jOzcugPWcxQ98oFUf/TEF06sbRxovR9LZpwD2cvhBx/53smqC6McvUS1AogHN0xmvGJsAMh/+FwD7SSrG52B8AvS/pMO2uikE2G9GC9N87IGyaOSW0VD9TuO4ulbX6bX/Dt7ZhRNgv2UVmDzRTo7suOp0V09qMBfoJ7EfF8BF9cWvzT+rmmc9gp5nqNDtA4WmjyM7/H3FJf+CAoa4Op9ammX7dssdwtoOlQRN65W2addRYNakDE9qUOK5JXoCXcyec3s2xiVY6XuUNg6k4W9Ww9bbJSs9Z84eNiob+cuz4OPt3xW5FFEv7wfHNJH23BNDFElzwgwuwrueahZufuXwinP4 X-Microsoft-Antispam-Message-Info: fLrJ4/P4uVW47DbNvV3GDjjB/LDM6BMxT/Rgj0xeiWzBTvZrfYyfNT5B/liolXHIt7G7wIyDYvSUDT4+Wt/Q26XNxdNE6+z9dZICwbDd5AXxiqfxDKPrV2PIh0NOllO/5aeFbyRP78/84DN+pQWCQVQ9GqoxQ31IhkFxt8Asq7kkaEYNvqy5OT4xDbyj3ZQXPd+3koe6nFTskj/GtraRD6F8HiY0hMfHl5ygT3UK7c4YG6iUmeKrjBD1Rhlq99xkyaCVHUP0x3xhmyjnIMGatOfkD8+Ukrb42/Cslom5LLXYOWiJ8xsgY4zjgghmCeSm/BIHFk9GGdNRyf/wlPgAmA== X-Microsoft-Exchange-Diagnostics: 1; DM6PR02MB4634; 6:AepM+hCiEx2GqzhG2Pl5u/fcEOGyNunYt8CWyc8lNqjJj1VM47T/boKJHRT+rSazgYT4W0YNbzjxMTDY6Zjje0af+pOowX1m2alNKIS/CZio6RzRKcD0D21GbOzW45dho1Hkl67Bee15rh6SS0C0eHTutiAWIZKXF99M9kqMtDZpjUvdkkwB805w64aqqkhCNuY3loboSEjh227kTlEvIcr2rYS5Iq739scP2fkNxB2K3hydb2KiO8Cx8xBgI4ipD3tNwl4O8JgioKU6yFDfRwFJKQFHl0oRRlApOTdu4DOFfH/S9U3dW33N/ycaSBMqigib23z+fQZUmY5tk+VsluQo2G/XFCfjiIHOrTJ87NNifdbSH1lfHMHDdB9xSVvUzSL/B93U144mQBVlIIkqoPCBP8TyH8KDBPFd8EetECzQ3epGTgysVFyUGDC4LnJa5A2Qf/vxu9kmeOF+oY9Bog==; 5:a7hbJElEc7olkZqqkUQNd40+DVpBaL1k8/iy915dFDmUewBTcuYsu20/q7zfu4D9bKN7/cJys68/mTE0rGINjyFs2qM5/THwTBhVZBSv5yNCIJfAePMZTU3dZkpV3GGNigkuQKZs0UMst9qE08Re0wAi8U+uTfePxqs0e2e9Jp0=; 24:truuI/rtOGERQB+cNlPUMrW4RhMG6HaDQ+c1KOn+DfG9F2f+EaJLwD39e916kPtV7j0P1JauN0eOEziwqjaKEV/y5cXA7/OaM22lFvr/3no= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM6PR02MB4634; 7:ZZIX1EJ9Jxye/1zjV5jQMP/p/VpH7L0IXFhvDAklMVmZSdev6oBUuX13doBpgrEBTEGTbzgR6dUoar/SEine8yV8coOrgtP2DnoeRHjs9KXoWxZGeajEN/qcIS2U10IP7hPjhSqq086Wwi7qMvW+wduPb0sgh4kEtGI+nPWZkPdKZwrUmnTaiDaB2yLT3UVbsz5sG8nKRsXDCuWd3xwp13DhkMblbZXc1d0e/g8ZwwAyNU/jixQHol1TgX6cd3Sr X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2018 05:55:53.0438 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25073b1a-9bf2-4b55-469c-08d5d5a95244 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB4634 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove else as it is not required with if doing a return. Fixes below checkpatch warning. WARNING: else is not generally useful after a break or return Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 0544134..8d84f58 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -569,13 +569,11 @@ static void xemaclite_tx_handler(struct net_device *dev) (u8 *) lp->deferred_skb->data, lp->deferred_skb->len) != 0) return; - else { - dev->stats.tx_bytes += lp->deferred_skb->len; - dev_kfree_skb_irq(lp->deferred_skb); - lp->deferred_skb = NULL; - netif_trans_update(dev); /* prevent tx timeout */ - netif_wake_queue(dev); - } + dev->stats.tx_bytes += lp->deferred_skb->len; + dev_kfree_skb_irq(lp->deferred_skb); + lp->deferred_skb = NULL; + netif_trans_update(dev); /* prevent tx timeout */ + netif_wake_queue(dev); } } @@ -1052,13 +1050,13 @@ static bool get_bool(struct platform_device *ofdev, const char *s) { u32 *p = (u32 *)of_get_property(ofdev->dev.of_node, s, NULL); - if (p) { + if (p) return (bool)*p; - } else { - dev_warn(&ofdev->dev, "Parameter %s not found," + + dev_warn(&ofdev->dev, "Parameter %s not found," "defaulting to false\n", s); - return false; - } + + return false; } static const struct net_device_ops xemaclite_netdev_ops; From patchwork Mon Jun 18 11:08:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 931423 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="uTjXAH5C"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 418y533GW4z9s19 for ; Tue, 19 Jun 2018 16:01:11 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937311AbeFSGA6 (ORCPT ); Tue, 19 Jun 2018 02:00:58 -0400 Received: from mail-by2nam01on0053.outbound.protection.outlook.com ([104.47.34.53]:49431 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S937104AbeFSGAz (ORCPT ); Tue, 19 Jun 2018 02:00:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ffd3eZVt9Xll/luLMgbKGF00JmC+hSAePszTXjMombE=; b=uTjXAH5CKmR+qa7AcXQdxbBfOP/mq5OirOFzjdcTYdYdi+ahSGId7j2ujkQMyMLbi0e51lQ+LPMq5RQh4oMfpmYcTN9sKlestjatHiCnJlS/iMOEDM/x1OkI4GWldwvk3j/aQuVskCR7L4Bxkn2+/tDYFS1jRECTLlgDI7HA3mk= Received: from BN6PR02CA0038.namprd02.prod.outlook.com (2603:10b6:404:5f::24) by BN7PR02MB5091.namprd02.prod.outlook.com (2603:10b6:408:22::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.16; Tue, 19 Jun 2018 06:00:53 +0000 Received: from BL2NAM02FT023.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::203) by BN6PR02CA0038.outlook.office365.com (2603:10b6:404:5f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.863.17 via Frontend Transport; Tue, 19 Jun 2018 06:00:53 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by BL2NAM02FT023.mail.protection.outlook.com (10.152.77.72) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.863.11 via Frontend Transport; Tue, 19 Jun 2018 06:00:52 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:40201 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1fV9hE-0000Ma-Fg; Mon, 18 Jun 2018 23:00:52 -0700 Received: from [127.0.0.1] (helo=xsj-smtp-dlp2.xlnx.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fV9h9-00046N-C0; Mon, 18 Jun 2018 23:00:47 -0700 Received: from xsj-pvapsmtp01 (xsj-pvapsmtp01.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5J60kcK031737; Mon, 18 Jun 2018 23:00:46 -0700 Received: from [172.23.37.150] (helo=ubuntu) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fV9h8-000465-El; Mon, 18 Jun 2018 23:00:46 -0700 Received: by ubuntu (Postfix, from userid 13245) id 8CFEF3C7276; Mon, 18 Jun 2018 05:08:30 -0600 (MDT) From: Radhey Shyam Pandey To: , , , CC: , , Subject: [PATCH 3/5] net: emaclite: update kernel-doc comments Date: Mon, 18 Jun 2018 05:08:21 -0600 Message-ID: <1529320103-7711-4-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1529320103-7711-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1529320103-7711-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-Result: No--8.329-7.0-31-1 X-imss-scan-details: No--8.329-7.0-31-1;No--8.329-5.0-31-1 X-TM-AS-User-Approved-Sender: No;No X-TM-AS-Result-Xfilter: Match text exemption rules:No X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39380400002)(396003)(376002)(39860400002)(346002)(2980300002)(438002)(199004)(189003)(48376002)(110136005)(54906003)(316002)(336012)(59450400001)(50466002)(16586007)(36756003)(186003)(76176011)(26005)(42186006)(426003)(11346002)(446003)(15650500001)(2906002)(106002)(5660300001)(2616005)(6666003)(356003)(52956003)(6266002)(47776003)(8936002)(81156014)(50226002)(7049001)(103686004)(90966002)(478600001)(81166006)(8676002)(305945005)(2201001)(106466001)(63266004)(126002)(51416003)(476003)(486006)(4326008)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR02MB5091; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; LANG:en; PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT023; 1:4z8NFxuApF1KnKrdUAR4vnHPCoNdRv6Y+MRvTKWWyytArBLpeUVZ9IFPab/eS2YEBslA/pWDya+x70e3IbVPEww/jdiexoq1K0yVsoBwJV5nl4xHwAqTicJW+03RNJ0b MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b451342d-993c-4da7-5017-08d5d5aa0409 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:BN7PR02MB5091; X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5091; 3:H5ruZApekDLe9hPz85rP3D/LkObh5W7evEGLF8qYUSlYSHAwnWDpp8T/gFP8jErtH9avLBdLjy+ilcZDse8G3YZH7E7gOTWwMslMedWrJCIHgvTVDszDXKJE6ptQPXP/0OT4aHzhs3l0lnYJT8JCIdBmBAd4lGjKuZim4gA2oyjX0bnwY9xl4sJDSmejxc+yDDYk2iWYV/4jWNvdlKwWDbKqKmxCEMFRrlKo/Jj/fYMpAQKoqGHwVVpIfa7IxM6iFbV/cb6bzmTrqC9DUCUDAH5TfGR8Z37CrLpnZ4VStLr87sUGqCk7ew5vxfIbRz+6aeyzCpDKphmrgKvhiEUxZVGfX9K8bJMKhiVZXwBgSPM=; 25:rtTCpmyEyps9G7iWL/J+HhCcVAamQ1C+bL7QAle+0WwJ2EeLamdklk7lejYC6el+z2UYeLepwpq3OKQi9eCCz387jsiWI86QJpoSCrAJKdR9/2RREqnijUmJQCxCjtmwy2MHHuWsIas+25hB902CROrfqZBqsZ6y5Zi2fGvU4bAbmmG/hNDe7H5ChHnPwpbGPAeHmbOU+E0Vt4AVuFRxIi46K7KmHJx4eoB06UtEdc0iM1xpVMuyoCvV6LJ6qfoCdyBBq9aH9MA2eyQlUIsyQELFi5TF7g4arrsq+kJUwESwltGCKr8foDCX9rYyCHm3TTg8W/ikNMWKHXvCqp7pbw== X-MS-TrafficTypeDiagnostic: BN7PR02MB5091: X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5091; 31:pwmWVLtDPJg/yrHw7NoXMPJwmzma2X7ttwVYzx9cJPaq3Z40VDsFDyVYmT/SRd16oJb2vBfxx5IBIfI21QPG9PHhyqO01/9Nvq3b9AE2vEOBGBLEIYl+0PA99n2Au3PnRyMCC2WVB2NSOOQ9MHCRNDrpcWCendiSdYFTpkGJJBl96wBtRdnRtK4Dl/lJun+d91SZ85s2YquvidjejWZhT+HW7VTSAIiqDdQbzVRRp7I=; 20:czVo9FJIBggc8TIUP0zjOhCLfWAwxEOI/YgiJL5IkGW8VOys4EMCOF9sygVt+ytVb9T8/qyWJoD34OhMjRPbCV/4AeOnvbQhRTHJO5mbo+tCuVopfHSJxCXuld/HP0Z+Zq/7EmENwwyxDiIZl0wzvNYOcO1ermlUuUWeEPPIhQL4srIZeQG0XJtKzTUXV4fGQFsf5jei+gGmEIwlXk+tqa0qp8hH6IQOX8JTT5Lp6kyooheKN2U4V3X+jj1wYzrN6SDSnKTW09Ozf2HbtADJ2Q77buRzg7B/q2IczdL2ckmBET3z/2PMxPmBrk/GhIc73UGS06yUvqjNs98hU7Iai3EFCX4JxdWrtT54/Kagubb9bXVvpj8Z6A+7SQKdat+HRS2hU+c7zl0dC84eMUe7Ye/YXAZsl1N9z9i8EH47nI3X6p5B5HITyrSDBgROP1rUr2hvvPOzQlkXHzNdadBepO9VPJoTlYwazPKYwytALUvLMAtogcE3TRtnWSUIx5Gm X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93004095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:BN7PR02MB5091; BCL:0; PCL:0; RULEID:; SRVR:BN7PR02MB5091; X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5091; 4:gL5E5dBZK6/1TiDT/p4LtKf4RRNSdArLjLSDt2lXKm+mezzItL49dok7+pGh6fVRXjY9Uc4JGIEPF5QaZwH36HkOj19UDmjpZqS1CVP2iKlJd29vWwSoXb4ic16741nHPW6Kug87ncpmAJWS2UjMFCl4ecTloB+p8Cr+9BcSa2I5NIga8N7/gC6M3VC2jMwzRkkej9lXMH/WGi/x11YyT8P17Qo8HAZQw7Rj/aaVxwUwOghyecQsg+VdPevccJO6OPsFo67OK3xBX+tbR4K+gdlh408oOIxka9LbPs224i+a9TBPajj2I8h/w3JWj3uR X-Forefront-PRVS: 07083FF734 X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5091; 23:44g1kKI6XNyjRVVtUAngYqUxzCZc7oQXjviyqqh90qtN6PlhGFCN7ObbsXtooQP3CW0o9J/Uf0RIV21D/wZiPtMryMPprTKu09MExX8slkjvIONLPdL8EcMd2d7x7Nt0QaN5WByvyZtwERmveMGeBp2ShB+e5nzDDmriItHjc1ALvvcWs23Gar1U8LTuj6OUqkdjQYK3S2J2AL74qqECW/8LKwCUirUnkzSDqqwEl2MpXcQgbCqodVlVKjGsCpI80w4X28VUbqiOSoEcpwYIRoKWSGVmAchX8BUZfyhUz2w0fYm944Nw3XT1KjQwA4DnEwWig9jwzNpvvnFKefqSzTb7ZeCD7+M7pceE1pb7TPD1tc8NmKj2q0Xa80QrGDgcpKVe3S6LFDOfZv+osei+DIdcHc1XswKtTcNYbUgqLDn52XxxkQBCi+9kr3AaYhubxSG7wX+xx0jBXVidVMDRimNriCcOkTv6SARHqY0pIjVzV+rJ5prROZz+D5y/PmC1bFs7QGA2AV7NS7mgWcz+MFPvuxkl1c0rZEZe/PN2UfxOVx6xs9zj4Tc7O3iuKylqfgltky0N5yu6mpnQ5tDrwOlXlyNclQuLOhlkiOGJ9HUYLVmNRknUlZAe1xbECwGTwzGS9A5GA5gSJ1rEu+rGhC+0wVvadPo/bg97WpIBpO22JcXpjzClpkJ7GWZL/E62BczuAdDQbGACEoWuzV+k48AXw5cODuKtMvVsxIDdKB5JQe5PAOL0r7/gSDl5OSohtYkZD7KvOJZyHgSespCuocCPlvPb+/ZeFUqtGa5i34llEVVB/006/GUuerqQ8/Z+pFWunwYchRNoz2+QqOansLyaiY409IzUPylnnfJnMjy8dgwCNn92W0yhsQYsKE+nOdh/Q3Nm+yFQqNTmCjgl1hKwVroD/7GGcWklpjAu9/+LOlHJgjhnIqh2FEigkxXNUcnwy1v3vzwezALHtwkEUL0pNb5kiWVzC3F7oA/jdw+bzAGRzb6Lhy3heN3jeEPQ+YAE9VZlPby5s0noQqqM0MCO7D2HnM/krblDi1ilrfcUBcezEnLrgQt04bCHQ9qUGqdzWg/7aRpIrtqneY/tXiBvVhSZ1nrd9Adr4M1/tuuTq5ggiZozBtIPeEmDt1jSxPCrMxdHxlcbZMsX4J6SDu8bFrWuXhdCxKacYXdGEWz95Paq9mtHHyVEAFO14eZj8nQJsQPy9ROzE4rccexVciKLV2YJWWtOadFNSNg1oxE= X-Microsoft-Antispam-Message-Info: 2U7Tw/yAPi/sP9BicSsQLwTf4SewkQJNtGhK32SG/Pu5Jld6lxdKUfzmP6XHrnG1ETXm3slR2C3kHtpCbmnFyy5SzTINNE6YS0jD83XMMM7VaXxZ/d3B+lIqSU2trN5k8/E9P1hbq4mNAad4R/KCOc+8gPtdkChmRAePzy2KuAq0BsWnR3aWFw9CgBDE1BZPA5vA2MtF4QJVJamndUNukho76XtGEUaNZ689L0LK1OXxBLQY6Q+JGn2cFVZstgg+p9+9fGit0eeji3MuSA+uFQ6e7jk7r3DlJxdkNxnLuiZBwDgiHjThg5JuybmQtfxjmU2NvoCc/dQOvn7/ef4wPQ== X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5091; 6:G9ThcnE8GHAPFwI+RuvOY3V8wMKOKihIKc194z1XBs5LS/6bUQy61aJSAr5pAjQA+XihsYQhITyzut00P7/fE9ce1sN+l/sHrz5PNnuwc08Heyzg/bmxHBrLMh4SgmlmsnlMRFHb7X7YpJ2b1nz9bKVZF1vYdINi+4zsOs76bfAhj9OI4VmCnfbnyNdtYl+oG7pRQJE+tTnWqUSr1Gv4hxrw1hZTW0or4byWXIynOxLqHM8r38m9l6n6lblbBnThgCxZn9oleIxoHv0dUEJBaVmiDWxhCH9WxufRqQFNJrDPm/ZLZPUeHlznnDiVyITooQtQOoCjXPGbJklBh+tNFXqTZVGPmtRQdPsvUDS6M0VM89lqCoXmLUUPYCh3kxAUhAkTJrMRABQG71i3t+LCchh3cEtOo8n6eyfDLFkOHh7Lm0DFC4bOvVywxE6fhqlh8+kRSnRqZizGszb1sfOJPA==; 5:ff8TrG2ysWIqWPs4oP0YrYhb4nBcyX/CtPGpB48WQa1Dv2EpotpCfVn5Fy+qJU1sijHiQLMglyYV3JgPIoPBa8iEkH5mTVBBlW+dqYlb2Xd4FD3CKYazo3gymxBWHNEg0+z36THzbinzyRDxnij0l07esEBkCiZEYAAV7FPIGH4=; 24:JRDnaiJRlxM9ytZ4idiLD1AC3KoVJ/8yQFJcFUQYr9osgqfqTzq7w92GVDG0UJbwPUgvsobx6KvHBMGsfrw+NXciNSdq+k1MOdXkXa13Wvg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5091; 7:qKuVekWUm9s9uFqkq/IfcvHqSOalHe5Z/ShI0npUktwNjyWF7w5vAT8hMFEZ0j2s0L+NhVLeiKZ0vSE7QdZFGMzD51paduk87qvpYdMVOygKU1E1cif2fyBLOOAjSzefDnV7bhIziW9FwzZbor6XTmdN9kufdUs48F+YjbrJee/VaCODZIobz3aNBd2ElAoaDNvxl4b1mwOm+JBe3PoYlktr1uYHqx+fMD3Lyy/Galt9JQ/AEZnASXz6BqgiJMwE X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2018 06:00:52.9168 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b451342d-993c-4da7-5017-08d5d5aa0409 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR02MB5091 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes below kernel-doc warnings: Function parameter or member 'maxlen' not described in 'xemaclite_recv_data' Function parameter or member 'address'not described in 'xemaclite_set_mac_address' Excess function parameter 'addr' description in 'xemaclite_set_mac_address' No description found for return value of 'xemaclite_interrupt' No description found for return value of 'xemaclite_mdio_write' Function parameter or member 'dev' not described in 'xemaclite_mdio_setup' Excess function parameter 'ofdev' description in 'xemaclite_mdio_setup' No description found for return value of 'xemaclite_open' No description found for return value of 'xemaclite_close' Excess function parameter 'match' description in 'xemaclite_of_probe' Signed-off-by: Radhey Shyam Pandey --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 8d84f58..0b41cc5 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -369,6 +369,7 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, * xemaclite_recv_data - Receive a frame * @drvdata: Pointer to the Emaclite device private data * @data: Address where the data is to be received + * @maxlen: Maximum supported ethernet packet length * * This function is intended to be called from the interrupt context or * with a wrapper which waits for the receive frame to be available. @@ -488,7 +489,7 @@ static void xemaclite_update_address(struct net_local *drvdata, /** * xemaclite_set_mac_address - Set the MAC address for this device * @dev: Pointer to the network device instance - * @addr: Void pointer to the sockaddr structure + * @address: Void pointer to the sockaddr structure * * This function copies the HW address from the sockaddr strucutre to the * net_device structure and updates the address in HW. @@ -637,6 +638,8 @@ static void xemaclite_rx_handler(struct net_device *dev) * @dev_id: Void pointer to the network device instance used as callback * reference * + * Return: IRQ_HANDLED + * * This function handles the Tx and Rx interrupts of the EmacLite device. */ static irqreturn_t xemaclite_interrupt(int irq, void *dev_id) @@ -770,6 +773,8 @@ static int xemaclite_mdio_read(struct mii_bus *bus, int phy_id, int reg) * * This function waits till the device is ready to accept a new MDIO * request and then writes the val to the MDIO Write Data register. + * + * Return: 0 upon success or a negative error upon failure */ static int xemaclite_mdio_write(struct mii_bus *bus, int phy_id, int reg, u16 val) @@ -803,7 +808,7 @@ static int xemaclite_mdio_write(struct mii_bus *bus, int phy_id, int reg, /** * xemaclite_mdio_setup - Register mii_bus for the Emaclite device * @lp: Pointer to the Emaclite device private data - * @ofdev: Pointer to OF device structure + * @dev: Pointer to OF device structure * * This function enables MDIO bus in the Emaclite device and registers a * mii_bus. @@ -903,6 +908,9 @@ static void xemaclite_adjust_link(struct net_device *ndev) * This function sets the MAC address, requests an IRQ and enables interrupts * for the Emaclite device and starts the Tx queue. * It also connects to the phy device, if MDIO is included in Emaclite device. + * + * Return: 0 on success. -ENODEV, if PHY cannot be connected. + * Non-zero error value on failure. */ static int xemaclite_open(struct net_device *dev) { @@ -973,6 +981,8 @@ static int xemaclite_open(struct net_device *dev) * This function stops the Tx queue, disables interrupts and frees the IRQ for * the Emaclite device. * It also disconnects the phy device associated with the Emaclite device. + * + * Return: 0, always. */ static int xemaclite_close(struct net_device *dev) { @@ -1064,7 +1074,6 @@ static const struct net_device_ops xemaclite_netdev_ops; /** * xemaclite_of_probe - Probe method for the Emaclite device. * @ofdev: Pointer to OF device structure - * @match: Pointer to the structure used for matching a device * * This function probes for the Emaclite device in the device tree. * It initializes the driver data structure and the hardware, sets the MAC From patchwork Mon Jun 18 11:08:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 931419 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="J8A22Jjv"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 418y0B0F6wz9rxs for ; Tue, 19 Jun 2018 15:56:58 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965477AbeFSF4q (ORCPT ); Tue, 19 Jun 2018 01:56:46 -0400 Received: from mail-eopbgr720044.outbound.protection.outlook.com ([40.107.72.44]:32640 "EHLO NAM05-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755611AbeFSF4A (ORCPT ); Tue, 19 Jun 2018 01:56:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ynaRtMBBtvQ+gi/s12fxuoSCX6OR38RiJPpygqjAh6o=; b=J8A22JjvOWf+GxKOA6zcZLigyypJCzq44bAK9s8Nr8o7od/Iu+VeytBZrjsaKRdhqmvz48GEoG4GWXYJUGtkB8ZnFspLs43fGZEbN8zjDq2JRsk6SiRzLX2vsLpbOatMWJOrwt78kC0nmvlHMJ2ka32W/9V2YpCRfbwoqFUABlQ= Received: from MWHPR0201CA0023.namprd02.prod.outlook.com (2603:10b6:301:74::36) by BN7PR02MB5092.namprd02.prod.outlook.com (2603:10b6:408:22::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.16; Tue, 19 Jun 2018 05:55:56 +0000 Received: from SN1NAM02FT034.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::208) by MWHPR0201CA0023.outlook.office365.com (2603:10b6:301:74::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.863.17 via Frontend Transport; Tue, 19 Jun 2018 05:55:55 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by SN1NAM02FT034.mail.protection.outlook.com (10.152.72.141) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.863.11 via Frontend Transport; Tue, 19 Jun 2018 05:55:53 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:60977 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1fV9cO-0000Kj-9T; Mon, 18 Jun 2018 22:55:52 -0700 Received: from [127.0.0.1] (helo=xsj-smtp-dlp2.xlnx.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fV9cJ-0002dw-5m; Mon, 18 Jun 2018 22:55:47 -0700 Received: from xsj-pvapsmtp01 (xsj-mail.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5J5tkJH030016; Mon, 18 Jun 2018 22:55:46 -0700 Received: from [172.23.37.150] (helo=ubuntu) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fV9cI-0002dY-5P; Mon, 18 Jun 2018 22:55:46 -0700 Received: by ubuntu (Postfix, from userid 13245) id 920F13C730F; Mon, 18 Jun 2018 05:08:30 -0600 (MDT) From: Radhey Shyam Pandey To: , , , CC: , , Subject: [PATCH 4/5] net: emaclite: Fix block comments style Date: Mon, 18 Jun 2018 05:08:22 -0600 Message-ID: <1529320103-7711-5-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1529320103-7711-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1529320103-7711-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-Result: No--8.201-7.0-31-1 X-imss-scan-details: No--8.201-7.0-31-1;No--8.201-5.0-31-1 X-TM-AS-User-Approved-Sender: No;No X-TM-AS-Result-Xfilter: Match text exemption rules:No X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(346002)(376002)(39860400002)(39380400002)(396003)(2980300002)(438002)(199004)(189003)(50226002)(106466001)(446003)(186003)(305945005)(26005)(63266004)(478600001)(76176011)(4326008)(2201001)(52956003)(6266002)(356003)(103686004)(47776003)(2906002)(2616005)(486006)(476003)(36756003)(11346002)(126002)(7049001)(50466002)(8936002)(6666003)(336012)(90966002)(59450400001)(81156014)(81166006)(8676002)(5660300001)(316002)(42186006)(110136005)(54906003)(51416003)(106002)(16586007)(48376002)(426003)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR02MB5092; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT034; 1:Yw/rQ6pBrb9vax0aks/VaWwBc6y0oHcYLcLo1AZ6MSw/lXeqVoeDrU3qycGJGVZRBJ8rJ6Llofe/gzW5RTYjo8d2GpoCSn54P6PP7/mwbrCWSAoxH0INkqoOSkzBEI48 MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e6732872-07d5-4866-3228-08d5d5a95249 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:BN7PR02MB5092; X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5092; 3:j302dHnngdDiX5/A9s3jqKPSGEFDb9MyOwgKcdAU2iplqkhCWrfoUPMs0eQq5oQpyx/Nxw/+EJYa4TAvSAIbWd67RP6fdwu6s6CC7gkDkcSeXyoMahx36fxfKieUZ6Xp9AXJOXOiNb826E6XAWweE/X3uf53hmD/qEvFko7iOyDqf04dlmEMJ08FkBkuEc5KhMSyydMGFJrotcPdy5tr7+nQiLf02Ej9rYglaIDHWtiqC6t3ygIikM/KBFfpZDWUVFSSETEAtUYwBCTdtJjiT7I7r9qAP1aAarvNx9LBUcssjICGYBAIpqcG1qm/Q0622ELt1K4UaQo7CPXRsxWc16wOI33gj+/CCuxPf0uk7oc=; 25:nyJHKuEfAqsczVMXdbl8JhWPMDma1IJXXFTH5MyFT+LBliAxGJ3DXiM9h/gMhUKnOkc44iL2RC7xARM0Qj4ewOiAFcsbPhZ4zgZnT0n2JEhVI1pSNdrQ2SxiFjuH/PUiNSm4wO88/guInGQ6vIiHLAJAr/DcYrOJxaYydDYSXB+v0S35G1U5MFr64Wbqx9JbJwPceWF2PfuAdmVWojTKHt74szhjSuIk/HbE/Fm4hwIx/SntKf/R02627FlFMlSOmHAy7fj1s37oURNIga3L6NC14Kgv1Ucml7yGgzhUxNsCPexpvdYh11a3XoMnpbyl2PZFGckSckshxzMZCLNtug== X-MS-TrafficTypeDiagnostic: BN7PR02MB5092: X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5092; 31:gKkRwshjP3i+Yd1tXbdaQJ72qcjKLOjOnfNUgvwPPBuvuMrdqzVuPTakCgORCtcBquwCW9K8caQGdiVy93lv+aoA6yacrYlvrrMfd0La6h3BrvOlDq3pENPd6tPZ4sSAtMw77u5uHBuDjakTtK+mhuSDlCOAHSjuG3zAX/Dw0REMAmdIHBbzFVhtUmB6FqqOPLv51TfkbPfN4lkXe5tHFbVO/t0N8cN5//R01FKYX78=; 20:S2lNktgI6nfjvPFTaRDrXD+noC5znxTMYXtjmGBDHGcOI2olwUjr3HfL2xSED/WJ8EYBSXSwZ60r6ZbeKiLqI9XEyvDzOr5K0S1r96GjFQ2rlFcW0PBiildiQ0hlGf2XqiNAFAf5PgIXCxKJAyrZazR0sYMN3eG+26JO8AmOIOt6uGopOMosO9XZzKbsSArERgqBvkXo8ktrjxF2lktKkHlwAn4pUclHJ77sbckPmQfDziPpUe7MZDZ38lhDylnZwhGPhehpd6+yO3F1z8eOyYpnEJvsy4mGtw3d0UMetwHDZcyBwpUnjJXW7Y22piLSX8WHPQMNLPP94c5/0otKQPupTp9yMdVS4qAXrsOhHYKtBdE25sFpIqT9qRfQPczR21/N6lCsxn6krFDMGwiujs0y2jRzlaYa8hDKY8ATGrHfL3sa3Ok0fxPQwkjdpd/dT8L4OH1bh/fQv53JncA9eWwS6ZO7aCsCRdX85z6gB6v3HhCPBwxJ2xwV3ZfVtlEa X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93004095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:BN7PR02MB5092; BCL:0; PCL:0; RULEID:; SRVR:BN7PR02MB5092; X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5092; 4:VUuQb48Aqgy9G1Xvg/EolWoAAXUctGWT0X4Uxd2lugxppXvczhMZvt8t5rBRwWcvvCdb2Iafd+poTiOSqZeiyNbwWAgGLPdTPs4ZQOy3r1Fovni18KUF4Ekr6G1nEbdHf/RfIcEkSGM7t5xDF+S2d6wDeZAv9dLuFvK7fECLgQYNpZiRxi+M8DuKzXRTqq0Zv52SvROKp8dDMB+ORw6EDFT0dFOOgvh9FuV3DtCd7kpT3xnCc2NnRYvbAKAxHNiPuLpPqnzqUXACRuzUH8UQ9fQQ41oplILkNhW4VBOS8HovGjXHCl9+SX+TiGxslXXw X-Forefront-PRVS: 07083FF734 X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5092; 23:ZJ43SRLGIu7wPXv8cLGNBnrDfHuu8Fj9PvkgQPKYDaaM40aRBl3FmdHPQ09FiIKUzGW9yrWIo2z1tABMOV8JLdkt+2z37l3Q23xmeaAhE8B5IOEirNM26XPCeH5BbiIpunaCrdm0eI4bEulZ+b2XFWBdBTNVdQb0eX0wAQKkO9f2742tmzqfH2k91MOyq28n6qjBXgJtJGaocI54AZovPtdAaQ/HGPzeO/TXjg/jCyjvZbiTU+bg4fUmTDtWJBZYqvUgjv+EEXdz6wClTaa+KFr1gJ6sZi33msKa2U/5zoDUQP0quXPjsev90rLHfZzFBp5Esd0BcHG4DZ857CBELPIMlh7Q0NW4Cjt+5EVLsjzsZ80ED9WWMlh3eQwtTC2cxnfdTRYnhHfhimeTNLSQM/6CTGphTV6Z5tiYkuINdxC0ldZXSwgoLtnsdVmr8NpCNrmawzmWOmzIuYXp1EdG4sIynw+laq05jb6HZvDyVK3mlhkh+DdsRJ2J9fIl9SQn2o4Yr/QShiN76p24Cvty9TeWn8nMSm9bK4cJ/y53TwQi5e+n0Amw+kUNLkv6MW7zHhy+5oBb8P7NAezcUXepLOzCH9fJZFjsk32x9u/20dt0d3GSHPWJiqsRxc6R4xSAUnvaDq7ZI2/GiQCoCtTjORY7LVRfSQseZvIiR10eRslKQRdJ/m6hPhfH1XpMSoFPSDl6kkehCvPYws3v+tHQEkCmYrb9cH6YC9ShOY0YZ1WzcEBKRSTuRcBG2HF/LTrxucwKH82yAZ1sUIcd49viT0NaPHuFurURrSb3S2TqdxzGUm2/diXqFTu234gYaAeT656slcYlg+CZBXvMo+I5fB2KC4RCYFqo2Tg9RpzFAc4ORjr2fOIom+37GeV6WIlBg9oiG/nz1yh23wgv9XIVhFCFpM7cV1GN0f2uhtpWycxn0KH/CQIzn6oOei9uJgloBYVeWHXE1+IyTTFa4Kwh7uC8kiAglnwseOtMh9gIiBYRBL+kKqtUEKARI8k3K4AkV+RihQErMKNFscRGkXKVY8rN30Cm4p6qJrmixzSz4Zq1nZRC7qqZDHa8PVRGbkn5c+erZUHXO5Xka6SgLvD98Q5oNzkpvLYxHjb34dAz6Jy/fFiWMDaxFwRXClBnFYmS11opbdLzusR12z/V8lR97sepV/tqb+TDeGF2UBHKqbG7RuaJtv3C7QVWwvjN7f6Z X-Microsoft-Antispam-Message-Info: vL9SAWDFnVR1LLeg8SnGOykMtG7OR8cGz6TbLuATWztm4xHMB12QgN3dgvxehIS+oyugW8gRDZMH/0ityOcjDkG6S5MFMhT000bl9FzRCodRuBi5V245vbC/Z9120XF5AIYgTzssvPCNOOpJJ2XrxrmFgeEJiinDbMKklHddZnMUxTbxJG702sZoIEhB19rcDNDafNxTMczyBI9TUXqsdqSDfkeoBrCGnEmP5c0HVBsSDuXaHJ9yjON22wZDDSJcC0oHyI631I9pCDyAzn7FXkw0ur6eJoWKxbgvd9m9gnmrvmEyHngcv2wqLgoVWiUjSV58jLLzz/tZXJdLPmnT1w== X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5092; 6:dEp4YcNklW0JAWzV1xIF9gxyxcyds2bM/j+orgssvx+h9NP8YRgUSzGD3VjYUhQTdmjTEuRhCVTlt9GHoTp98swsv+uV4LdnWrqW0l0fixiS/VIWz1mephqGNcPWz9TXIaHFRWVk7vqbb+JiX69d5dUJz+M61cQHKFCfAiPbvfT8KxjtdrXuXW7gM1xCtKw76YjdygqPkWVnOWN8O4FOhWEo4CHwtWyRHO6d8aMAs6aDKhYXYIrigJFQETZZgdcIa+XLXKwzA2jElhl0rLGl0tsZHuITAqvtFA+ScQObEJOYu6Z6n0h11f4RiPaW7nJGnsndhD/n0YsXgRncYlkAjRl1mJ8GGz0UuyqQR2/SPNMNbjA3lPz58P7txXHw5XXKjc5oTJ+J6h6mtIwRwv5lWHY60gtOokJ+U2V4GrJq5ggo/adSgyHXXb2fNSjxTT5cOtBYjG0lzySyFx61AnJlhw==; 5:lrbuBP0qLm3DQbeM15JQYdHxtZrpi7BAhB7EWV5hWrflJeb6e/MMDQneadkHXtx/kajQRamsyvavkQmmeTdEkukJjaFkqGKS7VXzbnt8DFNlaTmiYYjkO5rHmvRksiCbBOpZx8BUicDfBU/HHnswGTbHHlDkaLc685197yGWyv8=; 24:3IwxKr+rDqKMUwcELQF8VGt11ufTT9PSaKOOSZUWSJjyaQRVAxTUlg5AMULA3QT/jo5TB/wrUzk356Ft4BA+7bPZGkVVyvY6ltgw4ueoDsM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5092; 7:bsNOSA7H4mOwTzSGXqjy4E6QgZc7YS9iJVjR+6J6TKe7CnCPGRWxRkpMafns5tRx7TTRtuegCwY+DivhAINz6ipsGr3ij6wUh1937sr2yNmkIvUw4xj2bYVEc0t5mUHlYkiz5sXS0gCokJulw+sVvwDATS7/h+40rR/noxvPD38Kzhk2MCzY8SLRRZUBAWHRkbYzRzJOuzd8ep8hj4rXankcz+dNtS/B0DVxgANBjCbh2xYjOK70urgSCpwG4vnY X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2018 05:55:53.0448 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e6732872-07d5-4866-3228-08d5d5a95249 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR02MB5092 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes below checkpatch warnings- WARNING: Block comments use a trailing */ on a separate line WARNING: Block comments use * on subsequent lines WARNING: networking block comments don't use an empty /* line, use /* Comment Signed-off-by: Radhey Shyam Pandey --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 34 +++++++++++++++++---------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 0b41cc5..e8bb7b3 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -70,7 +70,8 @@ #define XEL_TSR_XMIT_IE_MASK 0x00000008 /* Tx interrupt enable bit */ #define XEL_TSR_XMIT_ACTIVE_MASK 0x80000000 /* Buffer is active, SW bit * only. This is not documented - * in the HW spec */ + * in the HW spec + */ /* Define for programming the MAC address into the EmacLite */ #define XEL_TSR_PROG_MAC_ADDR (XEL_TSR_XMIT_BUSY_MASK | XEL_TSR_PROGRAM_MASK) @@ -336,7 +337,8 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, drvdata->next_tx_buf_to_use ^= XEL_BUFFER_OFFSET; } else if (drvdata->tx_ping_pong != 0) { /* If the expected buffer is full, try the other buffer, - * if it is configured in HW */ + * if it is configured in HW + */ addr = (void __iomem __force *)((u32 __force)addr ^ XEL_BUFFER_OFFSET); @@ -357,7 +359,8 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, /* Update the Tx Status Register to indicate that there is a * frame to send. Set the XEL_TSR_XMIT_ACTIVE_MASK flag which * is used by the interrupt handler to check whether a frame - * has been transmitted */ + * has been transmitted + */ reg_data = xemaclite_readl(addr + XEL_TSR_OFFSET); reg_data |= (XEL_TSR_XMIT_BUSY_MASK | XEL_TSR_XMIT_ACTIVE_MASK); xemaclite_writel(reg_data, addr + XEL_TSR_OFFSET); @@ -395,7 +398,8 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) /* The instance is out of sync, try other buffer if other * buffer is configured, return 0 otherwise. If the instance is * out of sync, do not update the 'next_rx_buf_to_use' since it - * will correct on subsequent calls */ + * will correct on subsequent calls + */ if (drvdata->rx_ping_pong != 0) addr = (void __iomem __force *)((u32 __force)addr ^ XEL_BUFFER_OFFSET); @@ -409,13 +413,15 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) return 0; /* No data was available */ } - /* Get the protocol type of the ethernet frame that arrived */ + /* Get the protocol type of the ethernet frame that arrived + */ proto_type = ((ntohl(xemaclite_readl(addr + XEL_HEADER_OFFSET + XEL_RXBUFF_OFFSET)) >> XEL_HEADER_SHIFT) & XEL_RPLR_LENGTH_MASK); /* Check if received ethernet frame is a raw ethernet frame - * or an IP packet or an ARP packet */ + * or an IP packet or an ARP packet + */ if (proto_type > ETH_DATA_LEN) { if (proto_type == ETH_P_IP) { @@ -431,7 +437,8 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) length = XEL_ARP_PACKET_SIZE + ETH_HLEN + ETH_FCS_LEN; else /* Field contains type other than IP or ARP, use max - * frame size and let user parse it */ + * frame size and let user parse it + */ length = ETH_FRAME_LEN + ETH_FCS_LEN; } else /* Use the length in the frame, plus the header and trailer */ @@ -601,11 +608,11 @@ static void xemaclite_rx_handler(struct net_device *dev) return; } - /* - * A new skb should have the data halfword aligned, but this code is + /* A new skb should have the data halfword aligned, but this code is * here just in case that isn't true. Calculate how many * bytes we should reserve to get the data to start on a word - * boundary */ + * boundary + */ align = BUFFER_ALIGN(skb->data); if (align) skb_reserve(skb, align); @@ -707,8 +714,8 @@ static int xemaclite_mdio_wait(struct net_local *lp) unsigned long end = jiffies + 2; /* wait for the MDIO interface to not be busy or timeout - after some time. - */ + * after some time. + */ while (xemaclite_readl(lp->base_addr + XEL_MDIOCTRL_OFFSET) & XEL_MDIOCTRL_MDIOSTS_MASK) { if (time_before_eq(end, jiffies)) { @@ -1028,7 +1035,8 @@ static int xemaclite_send(struct sk_buff *orig_skb, struct net_device *dev) if (xemaclite_send_data(lp, (u8 *) new_skb->data, len) != 0) { /* If the Emaclite Tx buffer is busy, stop the Tx queue and * defer the skb for transmission during the ISR, after the - * current transmission is complete */ + * current transmission is complete + */ netif_stop_queue(dev); lp->deferred_skb = new_skb; /* Take the time stamp now, since we can't do this in an ISR. */ From patchwork Mon Jun 18 11:08:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 931417 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="YgxDFYpy"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 418xzP3x56z9s0W for ; Tue, 19 Jun 2018 15:56:17 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965152AbeFSF4E (ORCPT ); Tue, 19 Jun 2018 01:56:04 -0400 Received: from mail-eopbgr720044.outbound.protection.outlook.com ([40.107.72.44]:32640 "EHLO NAM05-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755586AbeFSFz6 (ORCPT ); Tue, 19 Jun 2018 01:55:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8RxUSiSJ5MvZkW2EBnr57KQte9xHDwI+CM+W5koJQAo=; b=YgxDFYpy6JqSPNSblwpqO/pYYib0H7R1Za/xrBopaOdyTgmInt0St4JBjOLN554+7tt9gDFfzjXoPjjNEUMQLshwuO8c365ArKHnFALOlCcTiHl0r6YiZAYfW7OKi4szvox4ayibg9GLCc2+vv0t4isBU08QY3+3EtTCg4zyU80= Received: from MWHPR0201CA0036.namprd02.prod.outlook.com (2603:10b6:301:74::49) by BN7PR02MB5092.namprd02.prod.outlook.com (2603:10b6:408:22::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.16; Tue, 19 Jun 2018 05:55:54 +0000 Received: from BL2NAM02FT021.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::205) by MWHPR0201CA0036.outlook.office365.com (2603:10b6:301:74::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.863.16 via Frontend Transport; Tue, 19 Jun 2018 05:55:53 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BL2NAM02FT021.mail.protection.outlook.com (10.152.77.158) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.863.11 via Frontend Transport; Tue, 19 Jun 2018 05:55:52 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1fV9cO-0003YU-B2; Mon, 18 Jun 2018 22:55:52 -0700 Received: from [127.0.0.1] (helo=xsj-smtp-dlp2.xlnx.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fV9cJ-0002dx-7I; Mon, 18 Jun 2018 22:55:47 -0700 Received: from xsj-pvapsmtp01 (smtp3.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5J5tkOj030014; Mon, 18 Jun 2018 22:55:46 -0700 Received: from [172.23.37.150] (helo=ubuntu) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fV9cI-0002dX-5I; Mon, 18 Jun 2018 22:55:46 -0700 Received: by ubuntu (Postfix, from userid 13245) id 96CC03C731D; Mon, 18 Jun 2018 05:08:30 -0600 (MDT) From: Radhey Shyam Pandey To: , , , CC: , , Subject: [PATCH 5/5] net: emaclite: Remove unnecessary spaces Date: Mon, 18 Jun 2018 05:08:23 -0600 Message-ID: <1529320103-7711-6-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1529320103-7711-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1529320103-7711-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-Result: No--2.512-7.0-31-1 X-imss-scan-details: No--2.512-7.0-31-1;No--2.512-5.0-31-1 X-TM-AS-User-Approved-Sender: No;No X-TM-AS-Result-Xfilter: Match text exemption rules:No X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(346002)(376002)(39860400002)(39380400002)(396003)(2980300002)(438002)(199004)(189003)(50226002)(106466001)(446003)(186003)(305945005)(26005)(63266004)(478600001)(76176011)(4326008)(2201001)(52956003)(6266002)(356003)(103686004)(47776003)(2906002)(2616005)(486006)(476003)(36756003)(11346002)(126002)(7049001)(50466002)(8936002)(6666003)(336012)(90966002)(59450400001)(81156014)(81166006)(8676002)(5660300001)(316002)(42186006)(110136005)(54906003)(51416003)(106002)(16586007)(48376002)(426003)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR02MB5092; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-83.xilinx.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT021; 1:rtw5P8oEAql7qKnpZeRKmDgGx4ffBHvpKg+B/0FHVhx1Se7dpZmrQRAV/u5qTcQH0QHWqfgUaBPYYSk0B62Zz0/gB1tB3alMOBhlLpzKYXS0TNuAJ1o88BoeR3ULDXrX MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 08b5741e-6962-4737-fd61-08d5d5a9514c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:BN7PR02MB5092; X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5092; 3:GOO+I2y7Z0v7n34dSEbDmBE/Q3aQ8MfyPfW5q+XhWGigMigOOZJWMsSZO5wQB2ppJx6gM/k8irT0LsLuwV+muXGniuCGxig6rjih09lUd9YAwH6e+dJVIlBucQYClI6nGDQR075NiwIZcM4NDAqQCePgnnwygoYnPU+ZFJABYb7qNhW0mFVGnGWkKxji7cUHUeKbL9fDV2lrASUJfkLWvSumdkaX4/FQ071TkUoW5PPIp8dehH/7AjKoxs+6hPPIWnL37MlNZI20zVpxEEvT3SbGFXgexNzwQM9Zk5bxo4M9NaqhPm0aBv+bpegft4AAUpZS+2YSFWNynAzwtYL3QSrTlEpnW7hBAmHM1xfix+4=; 25:apgZIDBrIeZ5BnxrPx3960cdE259vpkcJDxZ0TpM9riSMP66dfMEOF8my3oKVa2RTldwC08smziu3iJSgRF1KDgnpXTKfC4BxgP6qjh4pv8jc/kIT/SK76b7gUhpmbv8g+jZTYciv5gDwZUvfrmnyTdaes29fEJUpS3Sh0T+QxNa8tjkRX2LF8D2ISBpxvXO318fkcoUv2BJ1Hwd6fFA0l2FW+sZgC3f6R/sfj72URPza/j2jFeZZirXZgec8M45R9qUDonFfzSIt8OAyCfl+iKdq2o6UZZDgsZdhkwr3FQ3NwqLZ+Rh4T/ASUbBcxdcnxqxFD20oDEqRwn+Bh2mhA== X-MS-TrafficTypeDiagnostic: BN7PR02MB5092: X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5092; 31:9YPD+TZlUqBfVcd8WR4yH52e4MivOrezBEORddIAPin25GX8IXw6dI0e7Kf4b+RGY00bbKgT6D3miGiIITazcSPEMHBIrTD9+8RlT+Dxn8/9iedDJ9L4LXu7Me6tuQRYi/d7UDSCNQmPFvqHgGYubNAR8ztGy3/Ij9D2vBTWipQ8kF2Eq7ayj0UYadLIJLTXIVrJY8/Es1SmJFOeJPNd741gjGY1GYdz3DAfk5F3kCM=; 20:vqqUfGHTbBL/xPSAuzBP8HJNLURgJ5M3gnmkmpdZdKS5GyGjxgQk9+FQrkFzxt/M3/NKHwyw2Oy6i54OtO8dP2BMEfLf6dPfr+g6wsxYzClGEiA+LDcGSqvKQk6rFK7pgzkuWE+IW4QKeYb1YKsBO3ySHk8wUUXz+P78is4yE65HD53+PR3lxlLKJj0D3eA9U/KxpP+xZZsaW7BYB0n+bWYNmbZsylhAYLV/O5l2SkuGgMa+MwT7uV6glrHcONQQT80XFT2PXdRola52khF72NpNnqQqLaZPjSWy2khHcDgF6an/jEuWR03fwumypWUmrCjkzk/0SWn6TpyAg874rvgz22AH9xJsjX7qPl2Wm2lnNUeix2eGJShkJUyNQ2FITQiZ2eZhP6LFQYXAxGlx+VWraFXbIJIk8xNxuxKUIsp4hgO0hIDYDzKAgwgTKKF5/E6mzdzSXxdKBEbnimbPDe3NE/J4956R/LO4IIOPPgBzkETdEc+O5Rq7/RsTuLkI X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93004095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:BN7PR02MB5092; BCL:0; PCL:0; RULEID:; SRVR:BN7PR02MB5092; X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5092; 4:fXm7Po+RyuILNOSjLvZSLB5+RDcHIYiLyUpcZSvae80loip1UbvvXwQyrMiEKp5/ksp9k7+stwQ2RyHnqNPGLUekLbdlXmjF2gP+4mzfKCTO8KbLh6uO9o/ee0Tnubdni5v71ZXsJScG6A1QSslEcOmuAJgsL93EtDgEfxVAp1fqgSLfa0px53p1m14OblEtNRg7IOcypz2m9ppL1vsHJJIK7lcq7Wc9VN3+P/EBqgLnslTLo2cSXcL34g0HMcIItN0LeLnUtrkYYzfPBhz/STNbMgEzSVn9Z1+89PzK1eeDjqPuTUtxEFdwmbGtz1dG X-Forefront-PRVS: 07083FF734 X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5092; 23:S/Bbh5fyvRyufQzsts+sVs61REB+Rq/bPToZ0+E0UgMgaGIng588uXPB7yqRVWSDYmGMerMsishdAI66h9fqKpLykTFC6FqmR8w1UC780jXUlnPccbp97s05P3ow+EGcS/h3nttfe0eaQFUL2FMV9ywBrFdbz2+EImyYJx/3e3KMVi3zDmkoTk93PzAKyQGsb8b+cl/sYrVhwOMn6c4/Lh1SdOgFYOFzvqc+GVo5JuzeU08H0sC78fK4QVdz/CE4KzN+KFtXR7F8M+mQowdFx9Tvovr6PgGAVsYPLv14MLV7xIHS3gzM26xpfDrFCKx1mdKQdbSVB+55miiarok/+gVML+97gnAnIw03Fz7xW6k13QasYVdUmx6yZd9T4HPl0V0gCl7N2pKzFae+uMqw1tF8hcjhJr1bm9o5dYiGIIEg1rzjRr+6Ppe0JsG7fd3qqHJon8QdJ6oMKiWb0Rh0Vs32W9a6I+peuVgQO8reTOyP9DQkt00GcAmqW19vS9HwKZH8kEpaOcYzITty1RSaY6dWz4jU8s5vAuI/Y7edz1fhyC7MNro/PuoloHfOVnuO4usNqhkTVqAIFiGLC7gD5oPdFy/0uyfb65l0jC+C+GZb3oVmHql+EKQ3KQGeocH3RnvJCUvf2yVlGiHr9kxpN27IqJOvSW0S8YXl7GoJqqK3xGceJq2AVaFyb044H8QSR8rUVc2U2jH2vHqJzshzaO1PQbrtS9t8vdRLFp68laqeRPlZ4Cy+iMQePjVoYmvrJdPV6cYx4Tj2XWBCQr21HB3wF9h+R5RtDaJKhSdOS82gkHL4OMvov27bKobFfJ8KWAo7Kz+HclSHMiiOr5zsb1ErBWyqiYlZGiyHLDxHrZYDuN85MaBQaf+7niZ4L0HTrnNFfKMo/+0qBUZqZXuxUzeZpNCyCsyRWy5wWr1pw/lLU0ytcqnYFpTmiFj8GZc0LTNeSDQDSOqGFVJIIXJE4tZmr+hql3fe0r3tQksWQ4w18Ty1jGpj2FNf3zXZJGlX4HF2JV106RmybJJW2sAPGyDamlYfwSPNxMSG1+4uFbklFMrfGWghljdCCGN5u+e5tkPLEMBLi75LABR5AByf2670ClbpzhI+tSmNjZ5eyt7PRQu7XtDLrInWPkhYyqOwwB7hxuFmj5xqcKryg9Ap+zYKnNtpwYSzDUY65IyDUrA= X-Microsoft-Antispam-Message-Info: q7KmbB177XbuGq6xMt5QgHgJbfxVOw4a6s0+xRWLkPu8N8zW/CxajnlzWILuXydgieSJx4OXl9liWHcOGHCa+TZBKNHYfpVs/3sRcQzHo9AXeJrRQYyZ0W9dHSxQY54IKeKw9k39HVJP1bMsh3PENAks8ytRWRgqiKYk/qKaPAoJDBFz8CmDkniUfdbLzdmK9TmhQSgIYaIEFbNTNVeyopB1+aZJZBr9zY5pJCQbLmhZuuCyGiVJSE1kEMOOLs1dOiqSbRSOqn29wSFhw3uVoIJAPQ7K+1v9zJMo8U4M2GB4UBzV6lZQDSgjp7ICUWfo X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5092; 6:m2NOSenw4LcPvIkqhgfOQ3+Fgdlqsl6lN1LC5kVNHwmSSMp7xr30GRYJhbZzMo7tnGNcAFlSce9m2Soc5tzl0AZEU+xFp35ua8XKbSCHLfh56Usq23k4E+i5j7KJw/Au1ZKbIxl+4PrlBpMzYr3E5/G7yGAAsC1K6gwAKogWLLExNtBUSYzViEjrNrbiRpO7PmXBZCNSmDmkL5/s4gHhH/8iGH8CcfInbbzl0ux33NiJmmgNf/Z8dT5r6qSDqV7euVdY6JKtFEruysquhL0pe+7MlKplxXjEawNwVdrq0zwWvwHV/2iOrHNATi++7aLMZNL7RNgojnNlycT8lA6YRjyUQub0qnSRFqBZlAZaoXusHTDi1kpMwVRk8pBytp5BzMB07/u/qtjSEtOULspSOUAKbhQjxikQv0VJYLpKZXnWEMPFZ768qMHfCmBmACw/vmEfysuVg9nQHhqpWVRSvg==; 5:v8K9fzYT7x3ub7jIHB/AttHD9/zUXunSmCT1SwOU1NNcQBODpJcCyh7731mGr7WoTSS8rz2L2zcrUXoMOPaEl7tzC74zEFw5qgMTtGt8yahKHtIOCASfRphtwbcvpCzNcNMkbyMBL46lNbIte0qkrQa3Lw7ulNYURSqL4bZkB94=; 24:uJrj59EJTvnqNZ1IQRHk+i9jntbu7eDBTIF4t2iNBxlImXdyztQxmT7ciwkeUGZd9eoT9o5MViVUZybkSsr3vgyg9Wz+z0KstHXMaGX8ZsE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR02MB5092; 7:ODPjud0bh31abPT3IH8DYC6nnRS3YbidCsbMhkNVVoO/Tbi+qrybfE0FcfVuJ2/d2Dd1O02a4Jpcm37ChJOBhWA/hxgYxM/Qafri9CqG5qYta0lb1RBatxgoBuvyFJ1F6anhQl7reCCO0g43nUxlG+u5w3ztIY16uaHh640E22ZvHqenZiaA0zRNf14JGirzs9i7o3Eeyd9S31xExjKA5ZPd/LwvK1U9mbacJZ6QSIjKzY8NtKytHyjLe992svoA X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2018 05:55:52.7506 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 08b5741e-6962-4737-fd61-08d5d5a9514c X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR02MB5092 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes below checkpatch checks- CHECK: spaces preferred around that '*' (ctx:VxV) CHECK: No space is necessary after a cast Signed-off-by: Radhey Shyam Pandey --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index e8bb7b3..f62e4b6 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -95,11 +95,11 @@ -#define TX_TIMEOUT (60*HZ) /* Tx timeout is 60 seconds. */ +#define TX_TIMEOUT (60 * HZ) /* Tx timeout is 60 seconds. */ #define ALIGNMENT 4 /* BUFFER_ALIGN(adr) calculates the number of bytes to the next alignment. */ -#define BUFFER_ALIGN(adr) ((ALIGNMENT - ((u32) adr)) % ALIGNMENT) +#define BUFFER_ALIGN(adr) ((ALIGNMENT - ((u32)adr)) % ALIGNMENT) #ifdef __BIG_ENDIAN #define xemaclite_readl ioread32be @@ -239,8 +239,8 @@ static void xemaclite_aligned_write(void *src_ptr, u32 *dest_ptr, /* Set up to output the remaining data */ align_buffer = 0; - to_u8_ptr = (u8 *) &align_buffer; - from_u8_ptr = (u8 *) from_u16_ptr; + to_u8_ptr = (u8 *)&align_buffer; + from_u8_ptr = (u8 *)from_u16_ptr; /* Output the remaining data */ for (; length > 0; length--) @@ -273,7 +273,7 @@ static void xemaclite_aligned_read(u32 *src_ptr, u8 *dest_ptr, u32 align_buffer; from_u32_ptr = src_ptr; - to_u16_ptr = (u16 *) dest_ptr; + to_u16_ptr = (u16 *)dest_ptr; for (; length > 3; length -= 4) { /* Copy each word into the temporary buffer */ @@ -289,9 +289,9 @@ static void xemaclite_aligned_read(u32 *src_ptr, u8 *dest_ptr, u8 *to_u8_ptr, *from_u8_ptr; /* Set up to read the remaining data */ - to_u8_ptr = (u8 *) to_u16_ptr; + to_u8_ptr = (u8 *)to_u16_ptr; align_buffer = *from_u32_ptr++; - from_u8_ptr = (u8 *) &align_buffer; + from_u8_ptr = (u8 *)&align_buffer; /* Read the remaining data */ for (; length > 0; length--) @@ -351,7 +351,7 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, return -1; /* Buffer was full, return failure */ /* Write the frame to the buffer */ - xemaclite_aligned_write(data, (u32 __force *) addr, byte_count); + xemaclite_aligned_write(data, (u32 __force *)addr, byte_count); xemaclite_writel((byte_count & XEL_TPLR_LENGTH_MASK), addr + XEL_TPLR_OFFSET); @@ -448,7 +448,7 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) length = maxlen; /* Read from the EmacLite device */ - xemaclite_aligned_read((u32 __force *) (addr + XEL_RXBUFF_OFFSET), + xemaclite_aligned_read((u32 __force *)(addr + XEL_RXBUFF_OFFSET), data, length); /* Acknowledge the frame */ @@ -479,7 +479,7 @@ static void xemaclite_update_address(struct net_local *drvdata, /* Determine the expected Tx buffer address */ addr = drvdata->base_addr + drvdata->next_tx_buf_to_use; - xemaclite_aligned_write(address_ptr, (u32 __force *) addr, ETH_ALEN); + xemaclite_aligned_write(address_ptr, (u32 __force *)addr, ETH_ALEN); xemaclite_writel(ETH_ALEN, addr + XEL_TPLR_OFFSET); @@ -574,7 +574,7 @@ static void xemaclite_tx_handler(struct net_device *dev) dev->stats.tx_packets++; if (lp->deferred_skb) { if (xemaclite_send_data(lp, - (u8 *) lp->deferred_skb->data, + (u8 *)lp->deferred_skb->data, lp->deferred_skb->len) != 0) return; dev->stats.tx_bytes += lp->deferred_skb->len; @@ -619,7 +619,7 @@ static void xemaclite_rx_handler(struct net_device *dev) skb_reserve(skb, 2); - len = xemaclite_recv_data(lp, (u8 *) skb->data, len); + len = xemaclite_recv_data(lp, (u8 *)skb->data, len); if (!len) { dev->stats.rx_errors++; @@ -1032,7 +1032,7 @@ static int xemaclite_send(struct sk_buff *orig_skb, struct net_device *dev) new_skb = orig_skb; spin_lock_irqsave(&lp->reset_lock, flags); - if (xemaclite_send_data(lp, (u8 *) new_skb->data, len) != 0) { + if (xemaclite_send_data(lp, (u8 *)new_skb->data, len) != 0) { /* If the Emaclite Tx buffer is busy, stop the Tx queue and * defer the skb for transmission during the ISR, after the * current transmission is complete