From patchwork Mon Jun 18 11:50:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 930809 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="rJGXX1p3"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 418Tx53k9mz9s19 for ; Mon, 18 Jun 2018 21:52:41 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934377AbeFRLwM (ORCPT ); Mon, 18 Jun 2018 07:52:12 -0400 Received: from mail-by2nam03on0056.outbound.protection.outlook.com ([104.47.42.56]:12864 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933523AbeFRLu1 (ORCPT ); Mon, 18 Jun 2018 07:50:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u68EaC/+Rf3BT1GMhpaBtVmLhkJFNvZ00jMaXBmW0DE=; b=rJGXX1p3QhwirPXSGM5/05eIBRxqpchb7sfO6SiHSpdJRGloJTdcSVPRmruppyTELjF4FioFuBxmA74jZ3D16jQQQnbc0YRJADLq6E6KkBH60Q6pf2+lo4f+ncz0hXye/Q0GVLENtWsJt+4/sgUsNB7npOEqqqHokvn42FOXiCg= Received: from BN6PR02CA0075.namprd02.prod.outlook.com (2603:10b6:405:60::16) by DM5PR02MB3734.namprd02.prod.outlook.com (2603:10b6:4:af::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.16; Mon, 18 Jun 2018 11:50:25 +0000 Received: from SN1NAM02FT040.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::202) by BN6PR02CA0075.outlook.office365.com (2603:10b6:405:60::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.863.16 via Frontend Transport; Mon, 18 Jun 2018 11:50:25 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by SN1NAM02FT040.mail.protection.outlook.com (10.152.72.195) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.863.11 via Frontend Transport; Mon, 18 Jun 2018 11:50:24 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1fUsfw-0005mR-I5; Mon, 18 Jun 2018 04:50:24 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fUsfr-0000Qd-G0; Mon, 18 Jun 2018 04:50:19 -0700 Received: from xsj-pvapsmtp01 (xsj-smtp1.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5IBoDpB006504; Mon, 18 Jun 2018 04:50:13 -0700 Received: from [172.23.37.80] (helo=xhd-paegbuild40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fUsfk-0000Jp-TD; Mon, 18 Jun 2018 04:50:13 -0700 Received: by xhd-paegbuild40.xilinx.com (Postfix, from userid 13245) id 15F09B2047F; Mon, 18 Jun 2018 17:20:12 +0530 (IST) From: Radhey Shyam Pandey To: , , , CC: , , Subject: [PATCH 1/5] net: emaclite: Use __func__ instead of hardcoded name Date: Mon, 18 Jun 2018 17:20:06 +0530 Message-ID: <1529322610-27215-2-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1529322610-27215-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1529322610-27215-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39380400002)(376002)(346002)(39860400002)(396003)(2980300002)(438002)(189003)(199004)(50226002)(36756003)(47776003)(50466002)(336012)(48376002)(81156014)(81166006)(7049001)(51416003)(76176011)(90966002)(478600001)(36386004)(4326008)(63266004)(106466001)(6666003)(8936002)(103686004)(52956003)(6266002)(316002)(575784001)(42186006)(106002)(2201001)(59450400001)(356003)(305945005)(16586007)(11346002)(126002)(2616005)(54906003)(8676002)(426003)(5660300001)(110136005)(446003)(2906002)(186003)(486006)(476003)(26005)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR02MB3734; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-83.xilinx.com; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT040; 1:zlVl3mLh3+PZAtuxshcjyyF2wH3ONs/jJ6YwElkIsMSTKDRVc6eCCulaXG1KvdQ4ZyRvvC4YgDhJl0JKDhSTVZccwsC7c4E4SI/0FphK566yqME/hgfXs6uEMfEYTh1t MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1305a797-90c3-41ad-4b18-08d5d511ade1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:DM5PR02MB3734; X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB3734; 3:2Pa5CNsp1JgYMRdRMSJaZDCEXxid/Vy55kpBeM3l5hkg9OlINMMzf4E/wmvPOXRAc1kiAccDHSzPJ5wWqhE4G4JubqeEc9chGQxVy55QKZOm4jPVmtsovNEkFCdK6anSg5DtenMCJE9zCkAx51Odw0TDPbaieIcqfG2z2wTpks/7mZB4TiX0XK2eKjJWp27IR7Im8IswZFz+qTwLbGrknDHcfSNYaBnwi2XN8RVw43HMLp+RsoMERWR1xNoaDUmyGsjKziaIhLmd35mUH7+RfYNezrCsSDrua5cORNYpIBh40cLZZNXCSiuv/vV6kqcryJMl5OcIMLsteHCo8X8EcYzOa4fTrfX7QL+VsWKWZp0=; 25:yo8s870WSV2StEhS1kxG9EfN+V+2vpF5qPGH634XYSpcHBwxlpv6VMfovBHypU7alhF4ghJJ9TOHUj5gA5uQYYywPDPqfhrKbuXgTSYgOZDdU5kJ95Vqj1qtZG52wm7wHZ6iLKQv6elDMSyyuHQAnzZYiaGbWt71ZDw6w3pzyv44aaZbsKtekTWy0S44rchY61VSRmTnAil6GOTLDahJLTKJ9Li6febHY33cm0uVt0OJk5N/M1AZBsO8PnivQuBLOrnmgD7ncaM1XDWJMo0vmF+FK10h6SpMYn/rdZSoBm++cZ2xnFC4klBkh4LEYv2nrDFScGmFf8AP4UEEHTP32w== X-MS-TrafficTypeDiagnostic: DM5PR02MB3734: X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB3734; 31:zcaOFdiu70FDYWNopqD9y8bGGLoa8nE0Cot877NPaPbiquIjsDIV9TZXUSaCUgLqZCEyPqtiCGBcWih2/ZFR2BbWZCDdTVqSw5z9U4JnVTaqXWOjRG+Jq5axaznfqr96Dvvk/c0r8SEqSmNVcVGjz+eWTQWZrGzFhWDN5KBP3bq0tlJYThk3PEz2hNrCyKBHRci8wjXAE2Yp/XcQN3piUyz2FsmBgIPyU2IHv0cYzWM=; 20:Fd/cOtsM4lYTeDzn6LubQUzUboyRYfVkgvnohBlBgsMNOVV9ixXq2Hd9q9pV8pLSMhV8uNlSl6D1avUTJx7EBj0ShnkP2HK//uO4bZQiks6szH3ZsdT+IwIpaPfwjejHoF4cjwEUKDtibjr5YbcZuDy8v4reimCsAHc3MF38XjZa4bSm91Cd8uKjJwkehRjmX11UnYGWtyRltfuFprZ+oImEXiV9Xs3dnZaJsWNBeDXorRdg808lRn7BkvOslXSuMQPOglDeBLqLw0P7s6tJ2Ppp50hBNoDPT0f8B7xGwo71QtoHqxDPgWgPo7v7HzrUIDmIYQ1pHJblI3hK8ph23VYUiK7a1PiSXFadmmKkm4By8+R/SC1+sPnvoj/6xUK5jirMMT2cC06GTw6TzSrvQEq7DKhyRMll3mjH5nbXWqZ233iNYJ/zyaiaZBJjsSjFCbLvlJ0mkLUJfJH4yQX08LLMaSks6NssL7fYZ2kgUEk9EbSVIA/fr/Tvc+UQBiJ5 X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93004095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:DM5PR02MB3734; BCL:0; PCL:0; RULEID:; SRVR:DM5PR02MB3734; X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB3734; 4:KC8mGrswkk83gRqacsRe0ZHzk21r1KxJxp8ccF4wrTBcWqGM9ITi68/MoORfc4zPTQlpwwitiPAFchTgETuMzu92N0U8CqkBCv3R9Ir4loeYBZR9UUU7XK18hgtIsYuPbV3UFNDcKuIIWeMMm2UEAcvJxjsqyGqfTNk1oIM+sV2d4bgoS5QSSevhQ94dKZxgghlctTeEREBJKBj75p3++pKVld2WZDozCxntvYrS+VS9+Dx+0nOsNBYsz7QwiL1dLAsg/H1gfy6tDadsUlNPJeBsBmL2TnW3sk7BxVp18/rIHUPhXJWJQgrbwKnxNIiY X-Forefront-PRVS: 0707248B64 X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB3734; 23:nrZbTljm0TRnT05/UVY0VRnkTKZudkCoeAUGtY2ldoNgWrZ5P65vGgQ23kr/U8Rak7vPAopth3s+QVEmlJ0od3l3xp6fXgMkvp4YT9k9YiLg2/terAcf5m6LZqw6uEzPQCTu/vMNXYfLkrdAF/sZVHrgyAuKBCVYDwUS0tQH8+qcNPnoKa/QKuh+RZTtD7cIXvNn5c/TaByZuUXQmgg7z9fiFk+cbxi3i4NJHlqy4epGaIIyh6JLmAoAUYbRCgS0MjrF86DfwsEDio5NavTzzG+nvQojwhWqRAJF1QaHAKk11XtHC+R9gHK3adPjzpXjYcyt6jcUGa6LHk28W6o2R2dAkLLK9wiiXn6xzIHBMm0DUs6L+H/8v2Bg8gHZRjFpPEoZ2JsMPZb9y6njvBlp8xntN7u+cw8Ck4Rwz4T7+NPVEDQ1bIgMql8sxwnmpxoQxekjNG0fGQyt0fIq5b4io5gIAAslpxO02w1WdCkLWEd36F9DnvwJwqnVn2F17hSVsFM0DRDGK2DWy+UB5+tTDbT3rWHwERCIr1Orzl5gaJLXHxLcf4IRy4D63Rn41L44c9wjqlOTlaQnHVeaS3duwbSwqkQWtdhsmxgx/lSTeJj8Zath3ZgnAD5CNmoS/qnToIaKhHu3bBubTcWqoM//YF6IfpbqO1Edo2U4Bvn/xD1WJJj6K35/D0Yuun5fNRdjp+oarM0gNTBOIGiiCsLGoGew7/aG+scHvBOtg8kMTF9kwwg1WjKUbjXnsCbw4+e/2MaXKf9ZItmDLo+vzAdybUrR9V7gFpv3OAywanUzXZ+svcF7Y82683yjDDQUdJhwYbip4CrXkuhLM29QeLbypo/F5aWwDxZvC0g/Ny/k9AHWj08Go01NyQOic4k7xX8s4CVM+/R/CkS/uIOTl9fEEu3pzt9izB9itE/jEQibaunNjEdOfWOBlhO8bbn8dr+gvoEmoVbUFwCGOz5ITz4jbV9fE0CjyOHHyR/B7aNTaK8ZRcSz/RaUZoSG6BbtndtKvY0HKrWfBrptsZ+rzDekIHXaTFhq5Zw8mcaDz/XNfNY5dAcp4plMzJLheXLsqkvyvCanE9F8KiCONMTCuamBsONTZrsbWywsWO1ajvk+FZpcV6lHo9fLxFg+6gQtP5Ia/PyAO/+wDmt71hYMqb/Y4eBjSVnZaSE3LHcMfbX2RSWOqTbcBi5667lcVA+hLYPq8Lfjtne402LHdSuYqCQX6g== X-Microsoft-Antispam-Message-Info: wkqqSTYnviT/286ts+BcsjZKvdS0IGswsALUCPY8DUtO8O3pRnN0fMNVR7hwRZmeZN82BQn1uF0x8iY3jkpBTbyNU8rAY7OFN802Gd89BrDpjebsbouBIoyWCD2AYFJYETzQI74Anqk0upkm1EtuzgtYG4capO6IBeouUyc6seDhltdOg2ECIUVveiMvBDRQqd/aMcynO4BkRldFuk7z31ZaEMViIO44lkWwGEaOnNzD6QiYrFeEj+vh/Ly2TGb4+efX208Kb/gdZOhjZTHkmz+5BBvY01WpcoC5L3Tu4MzVvCU94xxLQQLJz4UvoF6lpxrBMhAfZGK0lFuCrLUWMA== X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB3734; 6:R45l5g5TlJj5Y+Q7iatoP3zX2whSgxfNSNd4oKnosRk98BLtYmlsq0WMyhjjUrR2HN2byPVhsgcVJ8uUmEZczW5Vqff+AH38sj0ipK+elFA9QKcyLJcMFhFXGBU1isAdF3l7Z87MRxFkDgNgTAnk35cCpmBg/dAhscmq2lQ/TZfwQk7H3sCYHJxB3/x4a06O9rqrNsaNKbmLBtxNNRyIlRUXzC2l4xAizKHsxTWMrScdBXkSmBXLeYDm2zF+1Ow3D7uCGAyQ7RseH9VMJZZcT8D8bErIEyRFNpzkqM1I7WwKD7S5Ni5Xa+hUyjsd6R+yKhVOr7D0OZ+b0HYz0IYaxT+5B/ijFTgIMgILsjUZZa5Uwf5Ejz3984uxyYE18khKQeqy0mHEW85u+Rpjzey5PT3jUNRFZKLHXO1maVD08VoIpR51nB6rvDpPLK466cuP4qCsPDgooyDy6aVimQ3SOw==; 5:T1K9T80M+HEADoakuhMkDhCXA7YniwuRSS/lWUrfkLT3zlQfOkjDZ9qseIW6FntyfNZpU/JnS2881G0GFSQWF3JT7TWwDu5aoZvtCuvEf+HBzI3fZL435ERhlcYL1o2xHczEjXJko6m6K8xyI1uUMBcEp3y6KKjzgJilPWiJpeU=; 24:nrSo9DqqDw/jspMqjKmkLMRMwr6umul6dK83t2dAPTHe7I/l3aKiI0EFES3O9ZZCwzMkX1eZs6g5uN2xNVajZnHAOK0rv46DpiUWbwb8ycY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB3734; 7:L6iDHu58e59dQInNh0O0sbfBTnFR9BG4Twj8lt9+g6qqcwJ8vvKtlSalqy/5BJI55eaOQs4KRD7kPKKF2xkcXKk+LWkFW8HajRpbCCqAkw6Y+jmMHsnjvIf5KTx8IjhEF4ffTjnbrPdPPjEGnEONg0xzmDMdm7lIb63VonpGEJSVr26E1kLnmE15d9qQyyViYATzKeRNUOwxg1/V/Pvl8V4sTsbKcKS5clt65xdQe0ylko4MNdKuI/qPy+/HeL02 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2018 11:50:24.8832 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1305a797-90c3-41ad-4b18-08d5d511ade1 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB3734 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Switch hardcoded function name with a reference to __func__ making the code more maintainable. Address below checkpatch warning: WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_read', this function's name, in a string + "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n", WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_write', this function's name, in a string + "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n", Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 2a0c06e..0544134 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -757,7 +757,7 @@ static int xemaclite_mdio_read(struct mii_bus *bus, int phy_id, int reg) rc = xemaclite_readl(lp->base_addr + XEL_MDIORD_OFFSET); dev_dbg(&lp->ndev->dev, - "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n", + "%s(phy_id=%i, reg=%x) == %x\n", __func__, phy_id, reg, rc); return rc; @@ -780,7 +780,7 @@ static int xemaclite_mdio_write(struct mii_bus *bus, int phy_id, int reg, u32 ctrl_reg; dev_dbg(&lp->ndev->dev, - "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n", + "%s(phy_id=%i, reg=%x, val=%x)\n", __func__, phy_id, reg, val); if (xemaclite_mdio_wait(lp)) From patchwork Mon Jun 18 11:50:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 930807 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="UuxsHI0N"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 418Tvz15C1z9s19 for ; Mon, 18 Jun 2018 21:51:42 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934517AbeFRLvW (ORCPT ); Mon, 18 Jun 2018 07:51:22 -0400 Received: from mail-eopbgr690051.outbound.protection.outlook.com ([40.107.69.51]:63907 "EHLO NAM04-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933830AbeFRLua (ORCPT ); Mon, 18 Jun 2018 07:50:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gFI0Bb359RajYsl2LlY9a+iCpDcGa1wTgr1YH2H8PHI=; b=UuxsHI0Nq/r8b0jre+RlHSybGX2HkIArAg4jFLa/GxqCjWkCLmIfGTGnJYCpXq/o+wJ6NcdbZrdlGiSer+5W+set3MRdSdNpLFDFa6kGEWqHT/vyxV0PANfjz0EWHgMp2M1jAzm0T9Nc3o26swR1oh3BDH48DKj7uQslQy7qr1M= Received: from MWHPR0201CA0055.namprd02.prod.outlook.com (2603:10b6:301:73::32) by BN1PR0201MB0770.namprd02.prod.outlook.com (2a01:111:e400:58::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Mon, 18 Jun 2018 11:50:27 +0000 Received: from BL2NAM02FT049.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::209) by MWHPR0201CA0055.outlook.office365.com (2603:10b6:301:73::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.863.14 via Frontend Transport; Mon, 18 Jun 2018 11:50:26 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BL2NAM02FT049.mail.protection.outlook.com (10.152.77.118) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.863.11 via Frontend Transport; Mon, 18 Jun 2018 11:50:25 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1fUsfw-0005mS-Sf; Mon, 18 Jun 2018 04:50:24 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fUsfr-0000Qd-Qb; Mon, 18 Jun 2018 04:50:19 -0700 Received: from xsj-pvapsmtp01 (smtp2.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5IBoDpE006509; Mon, 18 Jun 2018 04:50:13 -0700 Received: from [172.23.37.80] (helo=xhd-paegbuild40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fUsfk-0000Jq-Te; Mon, 18 Jun 2018 04:50:13 -0700 Received: by xhd-paegbuild40.xilinx.com (Postfix, from userid 13245) id 1A59BB20856; Mon, 18 Jun 2018 17:20:12 +0530 (IST) From: Radhey Shyam Pandey To: , , , CC: , , Subject: [PATCH 2/5] net: emaclite: Balance braces in else statement Date: Mon, 18 Jun 2018 17:20:07 +0530 Message-ID: <1529322610-27215-3-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1529322610-27215-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1529322610-27215-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(376002)(39380400002)(396003)(346002)(2980300002)(438002)(199004)(189003)(36756003)(2616005)(90966002)(36386004)(103686004)(7049001)(446003)(11346002)(476003)(126002)(50466002)(426003)(486006)(48376002)(16586007)(316002)(336012)(42186006)(50226002)(2906002)(6266002)(54906003)(110136005)(106002)(4326008)(51416003)(76176011)(47776003)(186003)(8936002)(81166006)(81156014)(305945005)(59450400001)(356003)(8676002)(26005)(5660300001)(6666003)(106466001)(478600001)(2201001)(63266004)(52956003)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1PR0201MB0770; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-83.xilinx.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT049; 1:cfxYPJen+d3timtHlAew/Z5ngZsCSPy698iTndDFoCAC2YQ2esriDDSbA8zQbqS8Rm2w5pKv6nq7ba52cZjgZcmVSnbefZCZz2EbjtT4zE27X4TFHF0mCN05OUAPT+qY MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 04991699-fc29-46f4-140f-08d5d511ae30 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:BN1PR0201MB0770; X-Microsoft-Exchange-Diagnostics: 1; BN1PR0201MB0770; 3:q9u6jt9bn4yCfDDdlj/9/r3ytQHoegXZ77RxlMLyxmN0cWg2+Qjrp/uY2lufkmpRX/9GariASlk0ZkvCM9KXa+HN9Om4L25D7ewZKiCk2LsC2jVvN5vbRVEmrd1UiHg/hA+IRF2q2Mlp5SL4zCtU56Eb2m/+Hf+Vq/PNj/QA/WOiEmnriV8ojXJVJOCs+rtcXlpVbq6r6b/2FyrEGAGF41g3U3/ulcJ29mD8bhQA36tXTPSGYN7MvMH0BvzV027omy1tgbP3HpmzQPpivRUd/Dovg7HubnLOE+BPgcqPiR0GV3UNdOJuz7O6bYIPJ+QX4cAJZv6ZVzZLfKKm7FUrLkDNa1jDDGw5eRmXUNOLtI4=; 25:JFWMj76c0o5sRDLygt2XPviIJujGn2oLc45l90MqCc6pmueLz4DlM8UOVL4cT39Fd5SLgEXyd6c43lV//Ul3zWWWKHsgNn+oWuLUbe6qq8KDWevAIrvEUgMh+33Sc3kMp8GwNZIsL7NFW5hLtwQbpMKCD9YLp9dH47uKziXkISi5ZdzdcHOOLAvUfoWFZgPpX/Hyx3UzEziRgvfLycsoonu0+ajo67Q6nuFYXPHA7PSryd6ZL+rewV5xrPja91hdb9TE7WeWtTpCU/vxG/flqtbS1aOZhluhZOo0aWCgUy6JABt5VeuRH7WO2AOjP10z8YSR2r586SvHi9foC7OnQd0dbDW1Bu8Yv6xsxKIhFNQ= X-MS-TrafficTypeDiagnostic: BN1PR0201MB0770: X-Microsoft-Exchange-Diagnostics: 1; BN1PR0201MB0770; 31:37A6iNde2upOVwBJ9Od+X1tHPT+S0mrh/aWO6hpnad45JaxIAwrz4VyhiMx2uLR2mhD4kXqB1UkYwQGqc39hVHa9Ok7mI+JQ0D+rF6h4xDN+w2oK9wVMBJZt1JipAEHxT92drNriN3wU/DHEu2PyQIbYHpLYaIxsaqOVxmU41gkO3zwKnZHjiYrzn45YSkLlZXwxxt7HRQGGd3qh+yI1NjGuL1Yd4rRZNR6Ne3uGmgM=; 20:QrmNfakov9MFfi5q8nyzs/4fhX5n3NFOLwIa7eoFwKEN8j3NxbewGLBtkzzd3wI6LE6YECqFA6rm5G3wnALB7G+aqqoFYM/v9Qj2bT6ftlJjyk1pDkvd92VyH5OLpf66Vd96Tt/bKQjpwrpOpTgRI8tGB0LU9EipyG6SwiZieNrw63NcxfMyozhDsHV+Jnc9aEGoUUmF0zHs3qxCBY1eJMauCTtqmijOp21VIf9ZGWu+iSQj9BXdz5E2BDdv7dKYW4q/s/Y70Hvl9k+8gzdp2Zfl7o7j+u0slhiPzD6wv9QpmfcshUySmEd7qnd0FubUA+Z0DxJQV9WCh7OD7KzdmWMgC0uLgBTWawnaJflOR4bKpPg4Wadgs3tHs5tvg+plLZhFmAj1WR89SXI3eHXuOG1hFEX3oh00gr2b0dx5tuXjjAIfESbPgiBKpDdBLoqEl3EevHgz2aBdLfbvofep8SiNc9/RoAzMDN+g0DjWdgQYjxLnsHbKq+Vjsy5ZQ3G2 X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93004095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BN1PR0201MB0770; BCL:0; PCL:0; RULEID:; SRVR:BN1PR0201MB0770; X-Microsoft-Exchange-Diagnostics: 1; BN1PR0201MB0770; 4:4B8J0BQrU0MjJGhW6JcjV03kmjxPpNcygOTksaenoGYFbuq8RM1TuoUZDjQN9YoFIaWFSL8SeF/KEHe3P654CSIU2RNGd1F7SQFumU7Lz2qMcJBRumxQaIdTDQT//89AoSwF+Rbn9DMjUJ8NpIdLcN2hAaoYEU7kB1uNfW0AIxWehoq6H7dQuRRnfYfmexCW9VsujrIIf6lKXWMX8unWalCBT0yC+W24pf9R0U5zNV4h4bLSJ/9Wo6zkIpewmnP0y0xfQac+AmNOV+Ay88yMeY/DmuyAzKuB93QrTsF2kUawsiZK765G0d+l65R24k6r X-Forefront-PRVS: 0707248B64 X-Microsoft-Exchange-Diagnostics: 1; BN1PR0201MB0770; 23:QQe/Ea0oVQq/PBvn3SxpevHoVBUf8INqopnuZYLfiMEU/bzE/C07GolPbQ/H0sPswrwbJQXB/w7J6UQ7k9cvz2U7A8jNHhJ1caEU2I7QKs3HUPWkLO31ifZnxklWrhpX38ixVxvmynEvE0Pa8R/J4NT2B/yfm12YiWdXmyb+oQUskcDOTaJQPEtFBCAlNoF0+KQoHGH62EBDwbHpLbH9CsDgb3G4Fr0YGpEudf+k3RfpZlhRuJmHUGtbJOPLUX2durEf8d4puH/L0hhOOADlMEEOhmZ3C/yLh193SBfJ0V0jbTVdmj/w3lZ6DepP8sjRp9vM2cwOFTmUWBrDyC5Iar0Ori51Q4iJJOjUhuTDkb2ur2rJ3cVOfU6fjnKslxFuD1TtAMprpw6VSOHvJWoECBE3uxDfpeTOiQz0/zbCbko3k5/RJwkNGETODWfRTotj3IAAJhEBHDktmLzK9NwwQk2LjJuABF9UpHFStUEQOUW8bV5IPDasd71jEyVuqLexLnrhw3wL1Dj9sXlDMlapoLk5ioSkZ7e5RcmRLO4wXd1u9GUSO+bLrHOKGv+VtOGLD6dtorIsD02qVNlyrrpb1gQc4htEjRkkUg5Cf1sdvlcMb9hv5j+TBkciBYAXxKQcKuoTUU2ApQ0T/DuE+qMb+WZwsX/Y9gRHZb1hF5H+SmZ8dB7LkDReKd58XfpOqR3I0ZotvQdE4/UZasWxILAoX/m9d44GRuT2CqFoBygqQ3IvIJHE/IyJR2aRulYKVbKhM355XqhCLsPER/8H0yl8W1ZNTNQoN7XMEQT+xpJ6BMYYdE14hg4dt/Gkvw6ETkioQnEikcyvhm7jRD56a6q2hHIYDLNE2cwRI1BkBEwGvg5vGhz7GNSRf7K32v+pC7ehRPUv2q5wQ0lmIYp6f5VYx6vnZ8pD3xFMNm+wSSYDyqQ1HWbi4hTopuYjQ1qjHB64iwEQ+9EUaGTF4wSxiklcKfvw3F3xO/DvXMG23myoHkOtlv2ModlJ/OPED9jRhvJGtYgwPXAxLYduqvj77PoBaWTcgZVYd+8v6XOzIDdLQB3wr3Pjb3CXN4/uXapzWpjOQ+l1cZxQhcF+yD0g40ma8CVRyX3rLrF/2YaTAy2Ki7XJUAmVmDvT/oXCYqTUnhPedp8sKftNHbjgmKllP5m/5oQ8dQcwaZUBPqvzKvO6yt+gAHW+2MldQFmflFZk5pgJ X-Microsoft-Antispam-Message-Info: ZsZug8UuUFJe6gNgT8hY5ECb1qj6HtJr3Dm7RInXC7Jd9Fdmq9KprnRzKIIWcjedrBFiHH2cKkce3n4vIf12Rx6y3IgNilxIn1+qrs10t2kugsUW+EdO22LzGcyMvB76XCDPNp09Oxk3Y91yXzSRiBI1IEWPAHzQ9qrUTywsLZbQkTApDbmculZcfGV4owk1fN95TlCUOfWaFfsBteuIWSYhljlKVuhyO8h5Rl0ipANNB8/8ukZHaMbkcPHILjIhHYrKD0H2/FUsG+Koqaj8T3v5zpG/iZKDk9pn6PnklGMRcwxrLPG9qr8emt4QR4OXEEtAWXqoeSWHxohFNyB2Zg== X-Microsoft-Exchange-Diagnostics: 1; BN1PR0201MB0770; 6:lmYUXnrmjGRxN8xfsKRO7afLbfxokOjkVTjEhd4rcAIZibUEa3XfoVyytd7u+1wmxoTndQYPspdTTgRXdo8+1e+w4ObAMk1r65hIy1/SsjvmDardAEZ4LqiRTMyiok9vOKRX0c5kqRMJPNehOU2Y5qPzuT6D6XCsoMtqJLLxQibfdcdemSpBXcfpwtU3EXk2iSskSOfpmjGsOdBPzIKVPRXmxROnWmVZloN9xCs2DxdBokfpL4OL+dTD7125Rf7QtCuE4yatFIl5HeoQwxgkSTaWkkQbXw2b9ArDCs7XxqlQ110SJcJr/DWQikbT2U0owAVQKNXyK/wRvuVkqREnI/v5k3W43YsMxVUxkY2C4qpVPZEavpEpU0nYbQDuh2coHtQHVvO76ibnEZMt094wKqlwZTorNS7qiQmXOerrTRF34DJnut49cU5SkSYpju+r3wmT8dntPoggq4uB9Hk2uA==; 5:mj5tRx2CnPJU9Zfn9NIUHU9RQfxyYFD0gjXpl8uyNYoAPRRVdKlHG6kLczRo9BLRRDamL4/cwW8s5JSvBCYoRdbfYyYYrPr5zch6+uOZNIYtWQnRwTevmsx4XKMJ9hbHrmJZzhkkWPNliVvSAh5f48rK5Yo6rivkPr3dQvkMZI8=; 24:TcCP9HZyMGUoaa6U9OMEqopwEihSS2HbRK9oMbcFrBAYLaOgRCX1hNDTqq3W/OcKDZ94hlHC5NCEKFvSsLHEYREkVXevHdbdWqm1ul9c/gY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN1PR0201MB0770; 7:B5Cl5W0oEdUJEFJopnsANZrLqZZtX+v1r06fpkryLcO6WhLML3kTq/vSRCTV8tFbhy71GRpjfpuCXcCaJBxMUcKeuo3TJzUxKBqavUQ0oQc+Kh3tq8lHoo/rRVfWIZQvSNiBaYS/bzxaJiQ9S88X/SqDTWiTZBwNwIz4mWZGOseVbL5AIUnc+OJEV4l7cjvmViiHTVg1l2moED4SyIyG6SezqFjEzbx3yWajEAXEJYbmCJT52I4l6Db8M7g7+oSE X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2018 11:50:25.4464 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 04991699-fc29-46f4-140f-08d5d511ae30 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0201MB0770 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove else as it is not required with if doing a return. Fixes below checkpatch warning. WARNING: else is not generally useful after a break or return Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 0544134..8d84f58 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -569,13 +569,11 @@ static void xemaclite_tx_handler(struct net_device *dev) (u8 *) lp->deferred_skb->data, lp->deferred_skb->len) != 0) return; - else { - dev->stats.tx_bytes += lp->deferred_skb->len; - dev_kfree_skb_irq(lp->deferred_skb); - lp->deferred_skb = NULL; - netif_trans_update(dev); /* prevent tx timeout */ - netif_wake_queue(dev); - } + dev->stats.tx_bytes += lp->deferred_skb->len; + dev_kfree_skb_irq(lp->deferred_skb); + lp->deferred_skb = NULL; + netif_trans_update(dev); /* prevent tx timeout */ + netif_wake_queue(dev); } } @@ -1052,13 +1050,13 @@ static bool get_bool(struct platform_device *ofdev, const char *s) { u32 *p = (u32 *)of_get_property(ofdev->dev.of_node, s, NULL); - if (p) { + if (p) return (bool)*p; - } else { - dev_warn(&ofdev->dev, "Parameter %s not found," + + dev_warn(&ofdev->dev, "Parameter %s not found," "defaulting to false\n", s); - return false; - } + + return false; } static const struct net_device_ops xemaclite_netdev_ops; From patchwork Mon Jun 18 11:50:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 930805 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="lFaY3N/E"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 418TvT0Klcz9s1B for ; Mon, 18 Jun 2018 21:51:17 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934158AbeFRLud (ORCPT ); Mon, 18 Jun 2018 07:50:33 -0400 Received: from mail-by2nam01on0048.outbound.protection.outlook.com ([104.47.34.48]:19296 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933631AbeFRLu1 (ORCPT ); Mon, 18 Jun 2018 07:50:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ffd3eZVt9Xll/luLMgbKGF00JmC+hSAePszTXjMombE=; b=lFaY3N/Ek+N8RdJ+PUlJCURTXzsOlN4eHA59FEEVC3GmFHr+6LndmFodqis3dJBMhwPVVBgSyKWm9bL9onDv1P39BbhLmb6bvv0FbqTynT0UNTfQpbH/6jOy9zATSo3/AOd/PaBCnqnrxHnYkYVJkD1NE0RbClDLAIXrhtPMCW8= Received: from MWHPR0201CA0019.namprd02.prod.outlook.com (2603:10b6:301:74::32) by MWHPR02MB2240.namprd02.prod.outlook.com (2603:10b6:300:5a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Mon, 18 Jun 2018 11:50:25 +0000 Received: from BL2NAM02FT055.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::205) by MWHPR0201CA0019.outlook.office365.com (2603:10b6:301:74::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.863.14 via Frontend Transport; Mon, 18 Jun 2018 11:50:25 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by BL2NAM02FT055.mail.protection.outlook.com (10.152.77.126) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.863.11 via Frontend Transport; Mon, 18 Jun 2018 11:50:25 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:36311 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1fUsfw-0002rt-EF; Mon, 18 Jun 2018 04:50:24 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fUsfr-0000Qd-BS; Mon, 18 Jun 2018 04:50:19 -0700 Received: from xsj-pvapsmtp01 (smtp3.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5IBoDLe006510; Mon, 18 Jun 2018 04:50:13 -0700 Received: from [172.23.37.80] (helo=xhd-paegbuild40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fUsfk-0000Jr-UK; Mon, 18 Jun 2018 04:50:13 -0700 Received: by xhd-paegbuild40.xilinx.com (Postfix, from userid 13245) id 1FF6BB20891; Mon, 18 Jun 2018 17:20:12 +0530 (IST) From: Radhey Shyam Pandey To: , , , CC: , , Subject: [PATCH 3/5] net: emaclite: update kernel-doc comments Date: Mon, 18 Jun 2018 17:20:08 +0530 Message-ID: <1529322610-27215-4-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1529322610-27215-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1529322610-27215-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(39860400002)(39380400002)(376002)(346002)(2980300002)(438002)(189003)(199004)(336012)(2906002)(478600001)(316002)(50466002)(426003)(47776003)(476003)(90966002)(446003)(11346002)(126002)(42186006)(2616005)(36756003)(486006)(59450400001)(36386004)(186003)(103686004)(7049001)(63266004)(48376002)(52956003)(110136005)(2201001)(54906003)(6266002)(16586007)(50226002)(26005)(6666003)(4326008)(8676002)(5660300001)(8936002)(81156014)(81166006)(15650500001)(76176011)(106002)(356003)(51416003)(305945005)(106466001)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR02MB2240; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; LANG:en; PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT055; 1:9xE5dwTskkBmOvp+eo9b0/eG3O26u/B4GYgWBku+scECQk+ZoH/5wzR4hnt7tuGiOYG1EFFBGSMw+6lzILMuSua3NNdm/zqKyp0kX4+d49L+2NGEjGUoTYBt1yrbXqP4 MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ad301b5e-25d0-40e6-0e10-08d5d511ae00 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:MWHPR02MB2240; X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2240; 3:wr50vNkKH8CUs4wnZNnKImycs4Lzqkt8xGNSc9gW+uFsbquop/+k/yx5Tqxqw5QgEnoYToaYtCJy5Bz9LJkq61MEshHP7nG8ix7NHL/EpWpADG0hkbHLNj+2y3I/WDXe/AusvfZ59k7cypEAaW0+cDxBvvmrKW9YApRK/+XPWEFJCKVrxlv0SzhYjOfgGKuMETjRpjmHJEHeqTcoT4f/q6sz1A9d6dcVwfWbRXyVOHkxr0Ds4V9gFvwnOf8MPbdsDBLdpHhZV+yxENXgKYGpffrwUvJeFrI4XsP5QucisOTBXacHoYNoD62mUkaODNjqC+9d6t8kuJrOZ7/FUTjynPhtPokqH2aaB9ohVMkHXME=; 25:eJTb0059BSk8wGyT4CUEkeXjQrgbTbGmF8Gc98fKNksFMQMejHaHxr9901lHaa6uGS6xPiEEVnAzgbrh3l6KOYFp3hZbZWSw5mbnoBWtKC6k6qWUaNfMNEDXIq5N+Rdbg/a3mwdw/6Z8yl3UwwQx12dhbFFen/zSPi9sr/zyF3v83yAyBPM0iVupV8mteULOwZqojiMw20E7WRw85gYIwYwWhDEYUerRAfinvIlbyzocoQxPVanHnMXSrDOOj2VJy4aTCgtaTkbvORHNxuPmy2O+VI8+B8H5DkPEhWqBAH+ZxATNAfbihVZv0vY4VKeXhld7ghCSFB4xKqKOKVk1eg== X-MS-TrafficTypeDiagnostic: MWHPR02MB2240: X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2240; 31:BU4VZV01t1/M//3yzv2AmZPzI0janJK80c2F1+UhrZMMp+d2oZUMExauPISC3O3ANg2IPrJfHPOUlQ9JuNd9rcuXC9Kat65zpbsg1ea/rtYjiUVlSDPqJANtFt2CICiDvLpYTpeBUf9XtdkMjGzCiOAAXTQEFf50TlkXMDnyQnYR6BbhxSTMBlM2U0GGQIKuUIUzbTGWh4Tn8U1d0T3b2+yCwS8PM37eBpDDMEUvNB8=; 20:ixgbskvUMU+ibbOfufBvIQrkG0OliGXtA8NRdEcltAtedmRX3scVprjlAcqx4YxbdbaMGVn5BeYrdbuX0OhIN2YNWiEOlXaEuWZjhDv0K+h+cHcEzo91RLs3yZpxKVqnHsiCwxhcY6akoqWY1Tw0ffOY0GeLHedc/SNW5woaXwOVfKcnO3zIqLpBPJg2LjShq9wXfHGOYEQ0Ui0rMujB3FxGXj132ACllbAJIgd158I62MJUVnbnQ+GHzopHwiXhPocluU3SYTdNh1vnkRtyxPk4NnQOIE94Av3craqKspzOUnLCsNPURI7n4RmW8VJDFPO/p7WaHV2D0hSjU3dIvcUxWRes8dJL3x7hM0fA9VApA7D8KKEYFctzsWNc4e3Q5xIodTuBZU12Qi8qxT1EyAROnzs5psIE7ptpyUHPQpyi28nY0Ql+RplOxtn7EIgXtFjAO6BzJTxtsmPLqcmMH9sepEFpqB7zEt52cfst3L1vPsRzR55Nyld2qP4wZsLj X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93004095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:MWHPR02MB2240; BCL:0; PCL:0; RULEID:; SRVR:MWHPR02MB2240; X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2240; 4:XmRIsjw/FpMntfs7NXnQiv8VR4xh3CeDEBM2S91pbSZcW4s2Gps8BexEo3SFGZTm6WR+7Ip2bcNWEhSdcvKKR8OOU3M9A5G3RDk1Wigf3vjSQm/yWk/YeJjZckiOkPjsNYCgBx5cJimVDLROX0qrnEoxmln4xAQDnk9qR6jQ2ih5Nlzmr6ulNnmJLyItF+8rs/fo0ECxH9RCgwukMgAyZgIq4oJ6W1nW4sdeojxzDTnU9LxeicJG9oC1eIvVtSH75pCDVurZ+41zroPYoVRJTShBfscD4YB7tyiFfVP+fGNWQXDBzGDxvkbkfqJoXa1e X-Forefront-PRVS: 0707248B64 X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2240; 23:hqm6hKa9MhjMrgQ4SGOPHu+bdwvTcBYm2lND8YdRXaKrbxQUOAoFhLOuZyeP/S9jokKfwl/Ip4p1qrCSRfGlw0eb7UY4qSdwigW3VSZ2xPlxozd4gAHFy3RhExnsFlRG94zAIEYV+cli5/h0IICgwAAwn6+rk9lbnSRM29gHXT9dGnw0p54nWjkC1nie8nfhhUqCsn0zV9/OsKj8YoGJGcpzvsM+GUCzPuB46wULWnT71xYod+fSErET3JH9uHHt5sPdG694CiS1R4MqcJ8xgNolFoGDtjjyu0517SbsTCYwTacB12sb4Xj4u1JAYJt+0N+MWuTQ9FvuzT4YyLOnIzpAQIT028RwqthJz+pm22KfqO5d2MN/Ya/lXJIEVvlxvK4I+0bxD4XZdjuGbgEWffkaxHIkYaJdy4Ef96xU4R9WpOlbuskkuhguD82H3G+ijBzTzBuhTTwyizMyMSEVBycZP9DCq+zCKofyIq8IHAjO6P5ImrPGf7yBhmslPREbuD/r9LPrtPMLjxlJB3A8RlnDQ47niaFtmeHKbI9d2b53jxFG2H1Y/eoz7aYzeOtiwZm8p/xxo8jYxCqz8Zx3ZvO6YKj9d0e3rpXoa1cBwP3C7aqHbhEr53mB52AR7V/1UQyPsUh2CZkXiCv//XXeD8JM7v6TP2xKkjbSnNF9tQgAPO3Og8zUnAIj0Y9ljPs63W3q8myEN3iObN3f9ODI+iHDCIBdYESZZutpFW7ZYORo/frTqjkmMAaoVMtiJuI/SOYCiy8BieUJENUfQXLCs3Ax0jtE7TzBmf38qqk5XYuD32dR5cr/uDLK5NZBEuk33SmiR8tOvSHLanGvk0M/R+gcw5WOSAJ3g6KBMr2cXMWpHm/DSWJxlCtjsFUgzwaY1dUUzJUBc8CsXAWQ5oa/em5DpU6MHfWtWquFmBHF08toMej4sFhsRUZIDqDbwJ953Zc9h+rjoVlvYBe2rZx15UjSQMiBuLLUClBqjYEs467A7zEf7QXawQXfiO6rFWDOn08G9pyymO9syjp4axQ/D4VQW4GfiNGemy7GjiuaCWP7HQ4ch6CyNyVsvpKQrJFFgd4kfT4gLGuQPsG1Pi18uRlnORHc1crv9Jpq7C6tgGOg4ktnHwJhNAWLGdnyC/qESn36OYN6xnJL+m4MMbnz5Y5rVrRdL1p7nSdC1SBKG7Ipb6Uc5+ihEJy257eqKMxZiN84eZD3F0OwDyRNj2F+d59LUp3ZaFKf9dyYWeMBvny99sFSQ3pUEaR6w6gWE+jX X-Microsoft-Antispam-Message-Info: xWo/ifBeB8rjqYkSRn65nbgFN+HgXAAZBdR3KnsAho5EGNwjHPB/2pYXC+DyAH5iW94iR0XczUxC6ZHta7a+HQeM/kjmfgOAd14vVzswstDoGh6eCRdWtwubh0oh2UJ6f4/l0Qk3iLFJpnPHbatOM8LEOKAqiMaeIiHja2mH9/pny8GD6RhAuo4GScZtE7lh X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2240; 6:p4gRc4mgQVVj5Bgj8VlDv8DG6Meugz+b2C6N2lU6yQg4N/9Q9HVN0tTB07HIFuAiF/daTh1UlhqsKlQbxuR/PS+yLodl5oUEgzNBo2U8JfhyjB7CEj4I4k0euD17y7y1m5NKC766i3j0ndvoPTQml7wD9jfUxKVGztLGvDuieRfG1vacigqRXHmZvEuhnRjWJhQA+DLjj3X2rzrwYaJ449BrILMvLp1VOeSn3iLHSSYou0a/S/yO/9EDcjqjUB8f/QNNKXKjGCxrTVnYSV/6r0YI4VGz/DoDGRqmnjrZqvzxDBsjbwx1aFyYSp8wi5A8s3fFS19Jht/DAUdCiLTmwfN+xpfuaRjxnJtX/MY6EcvzDB8BPZsmxssTLpg/FIN0n+iZnBz8d4YZbniTpsKbXjMfmonsoEy+wURKPRSde4X67AG5mWuYGFh+Rl8NG28y+fIR3/73kHRextnw2aoUtQ==; 5:J8C3tFSE34rYGnc8oqUR7T37E1vYXu6WDOQzVkM/FuO0mJAdJx64jQ0flQCe/+0UaQ94HLqJVKsNVDr2EcAolY8JeaJuXiB5Dd8kN2XkTcTdEea6H9Dlb9a9qzqOn0MssJMhxTTkDx6lsg/KHhZkekurzWDcvD40hzzSPQgmrSY=; 24:2Z5FBYp9s2QGXAf1Xhes8ZNaCID3jgxvAgh3fkdoU6mceL3ZXwHi/u/5YSgqgo7j05XO8smamk9QlGSLvDhKU/gbP0u82hgdG+E7+W0rVDI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2240; 7:WwPX25J5DWniguShRvUwFz8oAV0BGzUz1JAC2ez8/8/Lo4iGF8Mzd3UvhstX26Fkkc7b+yAs40aThEUXeG8OmwToIulozISVvwexLLcGu/bqWFYAbI+N/SyomElM+2mRlkaqrQtxYdMR+0ymrRezM2Ykx8agjIjID25qvA51Jr13m4CQy8ivaXb7/H9QhwtSGJotoYZcn4sFtBYmkL02neEvBVOgjs90TRgaFtRKUt/v47Klz2EYRk2oOTWvzvI+ X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2018 11:50:25.0692 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad301b5e-25d0-40e6-0e10-08d5d511ae00 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2240 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes below kernel-doc warnings: Function parameter or member 'maxlen' not described in 'xemaclite_recv_data' Function parameter or member 'address'not described in 'xemaclite_set_mac_address' Excess function parameter 'addr' description in 'xemaclite_set_mac_address' No description found for return value of 'xemaclite_interrupt' No description found for return value of 'xemaclite_mdio_write' Function parameter or member 'dev' not described in 'xemaclite_mdio_setup' Excess function parameter 'ofdev' description in 'xemaclite_mdio_setup' No description found for return value of 'xemaclite_open' No description found for return value of 'xemaclite_close' Excess function parameter 'match' description in 'xemaclite_of_probe' Signed-off-by: Radhey Shyam Pandey --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 8d84f58..0b41cc5 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -369,6 +369,7 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, * xemaclite_recv_data - Receive a frame * @drvdata: Pointer to the Emaclite device private data * @data: Address where the data is to be received + * @maxlen: Maximum supported ethernet packet length * * This function is intended to be called from the interrupt context or * with a wrapper which waits for the receive frame to be available. @@ -488,7 +489,7 @@ static void xemaclite_update_address(struct net_local *drvdata, /** * xemaclite_set_mac_address - Set the MAC address for this device * @dev: Pointer to the network device instance - * @addr: Void pointer to the sockaddr structure + * @address: Void pointer to the sockaddr structure * * This function copies the HW address from the sockaddr strucutre to the * net_device structure and updates the address in HW. @@ -637,6 +638,8 @@ static void xemaclite_rx_handler(struct net_device *dev) * @dev_id: Void pointer to the network device instance used as callback * reference * + * Return: IRQ_HANDLED + * * This function handles the Tx and Rx interrupts of the EmacLite device. */ static irqreturn_t xemaclite_interrupt(int irq, void *dev_id) @@ -770,6 +773,8 @@ static int xemaclite_mdio_read(struct mii_bus *bus, int phy_id, int reg) * * This function waits till the device is ready to accept a new MDIO * request and then writes the val to the MDIO Write Data register. + * + * Return: 0 upon success or a negative error upon failure */ static int xemaclite_mdio_write(struct mii_bus *bus, int phy_id, int reg, u16 val) @@ -803,7 +808,7 @@ static int xemaclite_mdio_write(struct mii_bus *bus, int phy_id, int reg, /** * xemaclite_mdio_setup - Register mii_bus for the Emaclite device * @lp: Pointer to the Emaclite device private data - * @ofdev: Pointer to OF device structure + * @dev: Pointer to OF device structure * * This function enables MDIO bus in the Emaclite device and registers a * mii_bus. @@ -903,6 +908,9 @@ static void xemaclite_adjust_link(struct net_device *ndev) * This function sets the MAC address, requests an IRQ and enables interrupts * for the Emaclite device and starts the Tx queue. * It also connects to the phy device, if MDIO is included in Emaclite device. + * + * Return: 0 on success. -ENODEV, if PHY cannot be connected. + * Non-zero error value on failure. */ static int xemaclite_open(struct net_device *dev) { @@ -973,6 +981,8 @@ static int xemaclite_open(struct net_device *dev) * This function stops the Tx queue, disables interrupts and frees the IRQ for * the Emaclite device. * It also disconnects the phy device associated with the Emaclite device. + * + * Return: 0, always. */ static int xemaclite_close(struct net_device *dev) { @@ -1064,7 +1074,6 @@ static const struct net_device_ops xemaclite_netdev_ops; /** * xemaclite_of_probe - Probe method for the Emaclite device. * @ofdev: Pointer to OF device structure - * @match: Pointer to the structure used for matching a device * * This function probes for the Emaclite device in the device tree. * It initializes the driver data structure and the hardware, sets the MAC From patchwork Mon Jun 18 11:50:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 930811 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="zw6gS4K3"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 418Txd756gz9s19 for ; Mon, 18 Jun 2018 21:53:09 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934398AbeFRLwF (ORCPT ); Mon, 18 Jun 2018 07:52:05 -0400 Received: from mail-bl2nam02on0072.outbound.protection.outlook.com ([104.47.38.72]:18464 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933645AbeFRLu2 (ORCPT ); Mon, 18 Jun 2018 07:50:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ynaRtMBBtvQ+gi/s12fxuoSCX6OR38RiJPpygqjAh6o=; b=zw6gS4K3ov90LlF/68CJrHsenVgYzo33/3Xt/c5eG/MZwPuNw6Hq8gAlVbHnxMP581KXpv5oh7asbiUtN2DbzgJMhjCJXWiyRitXyXipp+Zt13sVR3DGrc3a+b2xdxr+H00Rzf0JEF+J7/Gfb0gGPx588FKaf6n3Tvj2OT3Jt/g= Received: from CY4PR02CA0031.namprd02.prod.outlook.com (2603:10b6:903:117::17) by DM2PR0201MB0784.namprd02.prod.outlook.com (2a01:111:e400:3c09::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Mon, 18 Jun 2018 11:50:26 +0000 Received: from SN1NAM02FT041.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::204) by CY4PR02CA0031.outlook.office365.com (2603:10b6:903:117::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.863.16 via Frontend Transport; Mon, 18 Jun 2018 11:50:25 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by SN1NAM02FT041.mail.protection.outlook.com (10.152.72.217) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.863.11 via Frontend Transport; Mon, 18 Jun 2018 11:50:24 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:36337 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1fUsfw-0002ru-Lm; Mon, 18 Jun 2018 04:50:24 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fUsfr-0000Qd-JA; Mon, 18 Jun 2018 04:50:19 -0700 Received: from xsj-pvapsmtp01 (mailhost.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5IBoD4U006511; Mon, 18 Jun 2018 04:50:13 -0700 Received: from [172.23.37.80] (helo=xhd-paegbuild40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fUsfk-0000Jt-Vs; Mon, 18 Jun 2018 04:50:13 -0700 Received: by xhd-paegbuild40.xilinx.com (Postfix, from userid 13245) id 2C988B20955; Mon, 18 Jun 2018 17:20:12 +0530 (IST) From: Radhey Shyam Pandey To: , , , CC: , , Subject: [PATCH 4/5] net: emaclite: Fix block comments style Date: Mon, 18 Jun 2018 17:20:09 +0530 Message-ID: <1529322610-27215-5-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1529322610-27215-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1529322610-27215-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(39860400002)(346002)(39380400002)(376002)(2980300002)(438002)(199004)(189003)(316002)(106002)(356003)(476003)(103686004)(59450400001)(4326008)(426003)(106466001)(305945005)(52956003)(36756003)(2616005)(336012)(76176011)(126002)(11346002)(8936002)(16586007)(81156014)(2201001)(446003)(54906003)(81166006)(110136005)(42186006)(486006)(51416003)(26005)(6266002)(50226002)(8676002)(186003)(6666003)(2906002)(5660300001)(478600001)(7049001)(90966002)(63266004)(50466002)(48376002)(47776003)(36386004)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0201MB0784; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; LANG:en; PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT041; 1:mzzERF300i8Hq6l4hxPF3L1ozuWCGzbCd8rELJ1m5IgxNx4GZSSVpdaSqT1u96iLMwRulwJNDTjmPncQeW3RKLR8cqmPf3otKvp0ZAcprH7hFfrflET8DdlvpSX5zjq/ MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2432d758-4ff2-49dd-5752-08d5d511adf0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:DM2PR0201MB0784; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0201MB0784; 3:6LhIu+16uI51jENr6cVVWvqf2i40GY0Q4oXySTgf63q7IWZsvMf7vIpMhoQQbL913LV6qWaVtW7ngUr3cj+2A0E3dq6fboLBTUQVIDZyVqjZpLmyUqX4mB9WmwNT40mdIx1pXasulewsv8i1FSXk1E6NT44JZ1NeZpBs2Qd5m7kYGCwbdNHetfKAU2jMIqrRp1+TdXA1Bi6v3CiN46I7zKFTt2iyvo8TUu63FBMM8PVpXrL68EUjq58Qqoz+ArG0v1kx1GFt0DxvkGvr1fG+hFW3YiTHaLvBcGI4Pe3hOyeGeo6TezCYm9YRX+w1Tcvq2hhypMMUAoF0+oYIsV8/R6Vml70dNnitJrAeIfwccec=; 25:pvgXOoKBhJ2ZQ6zi6COcchTfeapc3ikqwkUQ3wphx9+6InWbePOnmIQwt+tFHOS2tzI/4/oAarOmO7iOAY9rtyrNvAQJ/Zd2aGWHiyfoDDOGc+VV7202OcXP+5QLKs5gvSJ/6BCv+NqtI5xezCuL4M3xSlK4dRkZFNwyJWXQFuZ1YFltqt4Ur50H6gce8aiYkR/wheIr6uVsp+Fq3SHJOmICPPc42PGt1VEls+HRIy8rRmHW+dIQxdOvI6xISQPDPLylB7bT8V4I7jj2MXnbCOZafvKsh4WGhq358r9R6fRxbxER7DqeVSs6pZIy4Jq/WuycXzd7N4pc/bxlRnGSFG2Dca1WCh7xp1EiDL1Ko2c= X-MS-TrafficTypeDiagnostic: DM2PR0201MB0784: X-Microsoft-Exchange-Diagnostics: 1; DM2PR0201MB0784; 31:siE8xkdJS6HKUmMuUp7lraB3Ad643JgOk+RzdOXxQVCNvZccl7YvjbFs7aV5bYVHBIGLb1WyeYL9ImO02tQgdo9wmcEc+jzlCOMj8ZkKqlnt3Lnu+Qa0hDAPw1TNqBkuhpNk4sM6zSsp+raZjygGA9vO+GXAmXVbVRWdLQa1g2PW6XgKgA/8IhdLVHd/bzc6TKVxu0qeYtB/3wZjqlE+3ofImI8yZ/JQmR56YVNfTu0=; 20:9UJtLz/rjvi5BKrhbko6+KV3T7C2nTZkSitc/iOcYNZe6zFEkoMgfHdnxMuiApujE/+QUatUOeFMCXu0yVpC81w5DW8ZifhrX1kqVt28/yTZ+S7OCeD2IEbwnLvlnLYTtPVgtYwmqKy4ih7RgCSQgSF0FhTVSCCCx1a0SUg895i2GMPZH9+Hl7xupQlghEXSE3BS2ACEzxnUgqqoDGg/hkx5x49Vitoj71dZZBi0Pdk3PuYAb4Ea03jw0dani4CIkGqEe20xoBwhgft2CutcCnYTD6m6VnUBdEAl/FpAK/8S2j4x7VDxN7ADT3AvtN1Q2ub6pQf4voMmXTL7Np54xiUjV5DiUGnsc9n9oVzuKP+dZ+r7y6TWnAxnUm4SyPFYC/QkNl+c7E8rDJWLXpMslxfpI8OwxeSS6Fv43p/lZ90U+ShYR/PM9wPdqnTt6jJGP4IGtftp2QQHQKdEsWefvV+sUQxAh0pBAE03e32I7A4W+QSYne9+AVZdZ6MNaXa5 X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93004095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:DM2PR0201MB0784; BCL:0; PCL:0; RULEID:; SRVR:DM2PR0201MB0784; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0201MB0784; 4:86nHJbILNg5WsbvioVMpMPTvZXaKcoDd4rqP6UN8asi7/Db40lWtGBjhx7EVtQOXzetv6BUHAoy77EpPOKf62A6dARx27EK+vgBE+9yjAuH4UYE7TKWeM9vWBEmgipNZGDDLQ3DCsCOWnHW2qIoZyEbGSZnJb59PaEg5RkBgO45Edpm8B49Yzf4E1LaCWDX/iCgROrp4fN1XfuObLbYhUxrcN0j44+Xe5oKBkoIlutBdgX48+NR+bhqkaoWMh/GNZC6az1L8uNY0I2JDwULjs/KUz8KKZgxxwT2tjPWZCGEpeBBdWUkRFS7DgazF95Aa X-Forefront-PRVS: 0707248B64 X-Microsoft-Exchange-Diagnostics: 1; DM2PR0201MB0784; 23:ObNF87I7PAi+ZYPqy7hyvtbTcUNc2jhdq8L/iedtzy6ZvtVbagjFB9wykeXeqdY7TqJ0dpGo6BTnp4K1271q0WULojKTOjqaT8s5pfpVs1Sec4jH3R0VjNU3nMYGJTLmcLJvnRTypTKKFJrERQD9jfnBlKs5H5FCOO6yGd/boXnOEWvSfB38A0nCYf24jovWbsARnxgx4S0+31sZlTYrJYEPLCTRzVEM6mMGJQ/y3eN/h+oA/AQqRTHNL31JWDXPXBt5MmER0eYPYU9dVJQUTEzAQIbK+oaOn/RvxWnmfKvwZOKdocTNBvqy1elUEUTc+H/juuuSXjA/xE0CphxmeW8RzRzIyIVU0R+5GEuUav/eTIASRc25zCCFkvZm+fBR/M6omH9P5Ht7RrlKRpHPp5MI4v4kd9ow0eOxV/ZZNQtd7EgzUN5tnkdjZHg/7Ba0S3gfH9JyZrTU8UTaWFznznrPqJrWXx93zHcCMOTtmm7DVr1WGlgqZwFXlFTA7slpXnnykv5WGu4I7cFHZBvwaQ4JoPgNfbkoXJyoKHhnGfMo8FdarV+8E4toTxcGrhXj8o1zSfPdvDkgsQLMytwdy8z0sPUyLFAOToxJySzZsuQYvSips2QjBWPxkTksYzHjfOcnaJzCQX1hhdonHaQqnMgaMY5NJznAoKOlIoYoCk/wcQl1RC/0bKDrgbKUmAxAOvGNQNTjAlVNPTg8Gjy07ziEiTvcWbFQVBq38fxZHfxzyyTjuIqDlMwI6ZuebWLS9D6GrVv7tc/GF9/xwToSbhE7H2N4hEufayco7ThOKxBDmXjQeOm52EFTvkWi+iq3cKXDsoQyZNCsegTs7Y5X40pXNGclTMbtaCEuyaTFqfp3795tEMZxEzZkJ1Dmpwq7ZTXBfLz3baV3Np+AXzBGKZEYJOC5meT6FBr9jb+twW5gTqvjhNzuOSG+HdJFVticcJ0X6ynPo5BFKDJTyzyoGJegotlVjLbYMEDbijyY8SDhrUJrHcCdbBn9ajetFLK63Zeaw3b1pRC29mG+5XZfoXKtMqWJhykuy6V8CU35Yr8pep2naN1acfVnCvmUDfARtblMv3SOn0Itc8wuv/AKHg+k/A43mdDEOD/0IHs4kX4y2W1wlot/K8T/WdbDCSHj5EvAgV4edV1YAQYh8kGH5I06I6HEekyGew7xJ0vXv/lcFLZCNk2Trmn2hyvhCVSAcAQUNfUHFPfG+LqEP/rEpw== X-Microsoft-Antispam-Message-Info: KEql3GyIf5BXfv7MlCmfaO/gKljmTzEPSTVkWwOfAK0ambR9mUY5k8DhSmfoZnFTE9SA1aVS7u6kCr0uGlQbqEgMDyAKF3/GxmFyNeIHaIbxG7j57De4Ln41Pze7ykiePCNar2oeIk0awDV/W10BH8Kyd/EximobCRuyq4lyCBDvlB+aNUorj0pE0yJK1+/ZsIiOmT+17eCZ2qZvUu7Ktl0dRPQdwjr+OiVn7yVnsM51qy8u34vvqz0u7co7roDVB3yyJXfzrj7xZITtw3x3ivka9I45O13LSa09fNDjfpcNhb+WgXpoLJYZNjghVSP6fVX2TmBDv3fTLc+G8+mYcw== X-Microsoft-Exchange-Diagnostics: 1; DM2PR0201MB0784; 6:m88hEqI0RPhi4g/ywo6xO0IJw5RwIXpYQVOOcZ50QLRd3xnLZ+euBCd4ADWa33xdbYrn9BbcPD7Wej9WfC6sIN/tH1d4uLeZzx1FBwv1ZT/UqBokVnoQ6COgITOc2I7Fztv6um6oFn+xPrjeD4ksVAEpEC2DjgbrHC08cEObPMhsj6TH+WahQqz4g44SnwTddfNTZJyhJ2fPujB+w80/RvoXpCCCg8icewIQYcpj41Z4t9oIRCw8GncG41FO9iiTVGUze1o4csjfjs3W3OvoAZxQpDzarrH7R1OhgNiNUrWpXsBgRuh6ocek89TQew4o4sWqg27BG0AuvdC/p7g4t3oHxQOuvOWOtdAeqIjtW9P+AwOZOzssUdiNyrQyy6+gLurDdlSdc8vZmsyYYUs6lPo0CnsNEbtBzaiG820vxuK7/OCqUvwA0HejKQBGikhnmAQczfIfUB6VpRq+RGsuIA==; 5:ZtV5B+DhymaNDPaYXg7w/WIA0DooRPM846RURomssAkKUOEbjeVLzjQFV3/TAV5QCBtcDLonO1J3K1pqjANO7XQAaDv6fQJs9Uw+Fnwh29OUhPQkWJt6+teiPWn5/9OzKHEABo9xvmK9ciFvlBJXGO1B7jbUB3I1tdgckWS/AaU=; 24:Y9OB6+/sCaWrOjFMkqYJ3YTjiGBEJ6JR35LX8G/WHECmNYL41KHD2VbZXOPlGGivjJ9eqiNOLXHqvYFTJwMuTRHpNu5u6lpUwWz90nuzIyw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM2PR0201MB0784; 7:KNBsPIpEr1ig86YSpiwHEECDjKheygdv+0MJ3K3pcJQ7noM3PGojIcKsiz158/WviUGTJHv0IEVwlVO9BnvycJ4dMa+AzKUDEJ9zrvAHa5m8hTiOTw/mSnqtiJNg/18JExcasiCLwsQ0z9WjqMX1ERSI9+MCm4tZPye7PxPIngJng1TS3sj/2OiUb3faxyOuog3q83D5kJoep6oz+rknGUtQ0W3o7IkahddCbBISQfgJwJW/w7UrkHEYIe0Wj4Hi X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2018 11:50:24.9350 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2432d758-4ff2-49dd-5752-08d5d511adf0 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0201MB0784 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes below checkpatch warnings- WARNING: Block comments use a trailing */ on a separate line WARNING: Block comments use * on subsequent lines WARNING: networking block comments don't use an empty /* line, use /* Comment Signed-off-by: Radhey Shyam Pandey --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 34 +++++++++++++++++---------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 0b41cc5..e8bb7b3 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -70,7 +70,8 @@ #define XEL_TSR_XMIT_IE_MASK 0x00000008 /* Tx interrupt enable bit */ #define XEL_TSR_XMIT_ACTIVE_MASK 0x80000000 /* Buffer is active, SW bit * only. This is not documented - * in the HW spec */ + * in the HW spec + */ /* Define for programming the MAC address into the EmacLite */ #define XEL_TSR_PROG_MAC_ADDR (XEL_TSR_XMIT_BUSY_MASK | XEL_TSR_PROGRAM_MASK) @@ -336,7 +337,8 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, drvdata->next_tx_buf_to_use ^= XEL_BUFFER_OFFSET; } else if (drvdata->tx_ping_pong != 0) { /* If the expected buffer is full, try the other buffer, - * if it is configured in HW */ + * if it is configured in HW + */ addr = (void __iomem __force *)((u32 __force)addr ^ XEL_BUFFER_OFFSET); @@ -357,7 +359,8 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, /* Update the Tx Status Register to indicate that there is a * frame to send. Set the XEL_TSR_XMIT_ACTIVE_MASK flag which * is used by the interrupt handler to check whether a frame - * has been transmitted */ + * has been transmitted + */ reg_data = xemaclite_readl(addr + XEL_TSR_OFFSET); reg_data |= (XEL_TSR_XMIT_BUSY_MASK | XEL_TSR_XMIT_ACTIVE_MASK); xemaclite_writel(reg_data, addr + XEL_TSR_OFFSET); @@ -395,7 +398,8 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) /* The instance is out of sync, try other buffer if other * buffer is configured, return 0 otherwise. If the instance is * out of sync, do not update the 'next_rx_buf_to_use' since it - * will correct on subsequent calls */ + * will correct on subsequent calls + */ if (drvdata->rx_ping_pong != 0) addr = (void __iomem __force *)((u32 __force)addr ^ XEL_BUFFER_OFFSET); @@ -409,13 +413,15 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) return 0; /* No data was available */ } - /* Get the protocol type of the ethernet frame that arrived */ + /* Get the protocol type of the ethernet frame that arrived + */ proto_type = ((ntohl(xemaclite_readl(addr + XEL_HEADER_OFFSET + XEL_RXBUFF_OFFSET)) >> XEL_HEADER_SHIFT) & XEL_RPLR_LENGTH_MASK); /* Check if received ethernet frame is a raw ethernet frame - * or an IP packet or an ARP packet */ + * or an IP packet or an ARP packet + */ if (proto_type > ETH_DATA_LEN) { if (proto_type == ETH_P_IP) { @@ -431,7 +437,8 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) length = XEL_ARP_PACKET_SIZE + ETH_HLEN + ETH_FCS_LEN; else /* Field contains type other than IP or ARP, use max - * frame size and let user parse it */ + * frame size and let user parse it + */ length = ETH_FRAME_LEN + ETH_FCS_LEN; } else /* Use the length in the frame, plus the header and trailer */ @@ -601,11 +608,11 @@ static void xemaclite_rx_handler(struct net_device *dev) return; } - /* - * A new skb should have the data halfword aligned, but this code is + /* A new skb should have the data halfword aligned, but this code is * here just in case that isn't true. Calculate how many * bytes we should reserve to get the data to start on a word - * boundary */ + * boundary + */ align = BUFFER_ALIGN(skb->data); if (align) skb_reserve(skb, align); @@ -707,8 +714,8 @@ static int xemaclite_mdio_wait(struct net_local *lp) unsigned long end = jiffies + 2; /* wait for the MDIO interface to not be busy or timeout - after some time. - */ + * after some time. + */ while (xemaclite_readl(lp->base_addr + XEL_MDIOCTRL_OFFSET) & XEL_MDIOCTRL_MDIOSTS_MASK) { if (time_before_eq(end, jiffies)) { @@ -1028,7 +1035,8 @@ static int xemaclite_send(struct sk_buff *orig_skb, struct net_device *dev) if (xemaclite_send_data(lp, (u8 *) new_skb->data, len) != 0) { /* If the Emaclite Tx buffer is busy, stop the Tx queue and * defer the skb for transmission during the ISR, after the - * current transmission is complete */ + * current transmission is complete + */ netif_stop_queue(dev); lp->deferred_skb = new_skb; /* Take the time stamp now, since we can't do this in an ISR. */ From patchwork Mon Jun 18 11:50:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radhey Shyam Pandey X-Patchwork-Id: 930810 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="eFtu9Dz4"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 418TxP0Jkfz9s19 for ; Mon, 18 Jun 2018 21:52:57 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934634AbeFRLwH (ORCPT ); Mon, 18 Jun 2018 07:52:07 -0400 Received: from mail-eopbgr720062.outbound.protection.outlook.com ([40.107.72.62]:58688 "EHLO NAM05-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933651AbeFRLu2 (ORCPT ); Mon, 18 Jun 2018 07:50:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8RxUSiSJ5MvZkW2EBnr57KQte9xHDwI+CM+W5koJQAo=; b=eFtu9Dz4VpDzNrtggQzd9zNMeDZVfkVf5c/fiv40eoWbKFM+DgsfgpFUBCDN8ISbxh571V9U2sjrwPis44tc2qHmfUChsD8gfharQh4WMyX2nEAd8cWUYfiRThDgOH4pOF1SfWY54CiV/k6gemfgh4XCy+JmoehrIXvtZIJwNzU= Received: from SN6PR02CA0010.namprd02.prod.outlook.com (2603:10b6:805:a2::23) by MWHPR02MB2238.namprd02.prod.outlook.com (2603:10b6:300:5a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Mon, 18 Jun 2018 11:50:26 +0000 Received: from BL2NAM02FT016.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::205) by SN6PR02CA0010.outlook.office365.com (2603:10b6:805:a2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.863.16 via Frontend Transport; Mon, 18 Jun 2018 11:50:25 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by BL2NAM02FT016.mail.protection.outlook.com (10.152.77.171) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.863.11 via Frontend Transport; Mon, 18 Jun 2018 11:50:25 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:36363 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1fUsfw-0002rv-Rw; Mon, 18 Jun 2018 04:50:24 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fUsfr-0000Qd-P7; Mon, 18 Jun 2018 04:50:19 -0700 Received: from xsj-pvapsmtp01 (xsj-pvapsmtp01.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w5IBoEJJ006557; Mon, 18 Jun 2018 04:50:14 -0700 Received: from [172.23.37.80] (helo=xhd-paegbuild40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fUsfm-0000LD-16; Mon, 18 Jun 2018 04:50:14 -0700 Received: by xhd-paegbuild40.xilinx.com (Postfix, from userid 13245) id 35525B209A8; Mon, 18 Jun 2018 17:20:12 +0530 (IST) From: Radhey Shyam Pandey To: , , , CC: , , Subject: [PATCH 5/5] net: emaclite: Remove unnecessary spaces Date: Mon, 18 Jun 2018 17:20:10 +0530 Message-ID: <1529322610-27215-6-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1529322610-27215-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1529322610-27215-1-git-send-email-radhey.shyam.pandey@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(39380400002)(39860400002)(376002)(346002)(2980300002)(438002)(189003)(199004)(106002)(103686004)(110136005)(5660300001)(2201001)(90966002)(26005)(305945005)(54906003)(36386004)(2616005)(186003)(52956003)(426003)(76176011)(51416003)(126002)(356003)(476003)(16586007)(478600001)(59450400001)(336012)(486006)(11346002)(446003)(63266004)(106466001)(4326008)(50466002)(2906002)(8936002)(42186006)(316002)(8676002)(48376002)(81156014)(81166006)(50226002)(6266002)(47776003)(7049001)(36756003)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR02MB2238; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT016; 1:GOYevAYr3IZv39atDoe6b5Lp7VScmWV3iBwu0kUHm7+96Nm0eotT0CjQ9T4hfRmR3Lzs6ndkmS78fClobquJ+WjWBhFXV1q7IpTnbv8Z6Gtc49XXW+3Xd6F8YW2pNeN6 MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a08c108d-1424-4079-36ff-08d5d511ae44 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(4608076)(2017052603328)(7153060); SRVR:MWHPR02MB2238; X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2238; 3:MLwcWZsjS7igAQ5fZVbJL+hiirc9UoxciIpT+qf8J047V8eB+rQ1hSFbkH1OBOhMYIkDBM5dSt6Hba5piTSh+GKTJqePgdTcq4Zf5Du4Ak0SIR7g3T5jdUvbL3SAsTfOKURYLcx/jM3Bf5x9QQPdTU1ieN3aIDWunXxdHj7oCxuhCBv+2b8yB1Bv0IkFg0mPk1x9nWk/dV5Pk6BVQjHiarjfepOpzwcPXJfkiqZL6LLqgnFGXM6FHmYvryZFZoT3NhThkzMxFAPNFuwf+Has7XuTEt28tTqdfFlgb5/fIZ4WLtzxJ+NXjpwWJAL+ifUZ+UQ7Gpfq8/Zq7a8yCxCeee+xVC/zCedhil+IwHFRs4E=; 25:frFMZ8sV4Z5dyMJvA4XnacGj6UD7PUcK1mh3hd3K9KzKlc/3/uCdpY7TAAuEhCfwFy9xN7gQenrfRBpK6nfXNSiWy0mEOB2ahlDUPI40PU/HSVc16UOeul5YD6LvQ19b3Ool7d/5EZkddk1ck+Mp1IDCCotAerD6f3YqkVruR6uGUBzAbfstpn4MG+aA94aVhsviUsW4qGQczDTleEwY+Qv7he6IGREXkh0lapf7FzAy6zxcK3GRBmjqCwsbfsOlUNyJ0lxzwWKEcPDBytImvvtR8RiulaJD0HVWlxMwjUnulpc/h4+lqzkZ/Aq8vCL/yqcnoKJLFRgCDp3QPG1ZeA== X-MS-TrafficTypeDiagnostic: MWHPR02MB2238: X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2238; 31:NzeYi9PbFyZMDnUJ2/ikDpOfaNSVQ/txzLRdEGUIc2FZIBsRZBxjRn63YFOCTQdUldjpozb/D9DS1yCM/6RONyi8C0GWWE7PdO35iYCczSUp5JMQN2Zrxfq3d0UwcS+mzn1autAqmxGdanu7d8pIk6+XjJMOASlJUZzkU1idB2FltVcqHs7rOi0zHRiZADANIQHwqp4h7gcUYA507SqsItNhsixbuTT73tst+rae1+o=; 20:JuWjCRo5Yo7jxS2S4v2u6kyk5VWF5rkA/hbhZAkZvSyQpzGdWPVh0FWOfO1n3jebRIZ95buexYJjaAfuLvlygd5jSKj5OwBuvxqIEEF9X/nR92ICDUL9A7XaC6+1CPbY/clM6IFo4m1OE8J9f7SQkXZJnfjeiG/E35wC1pVIu/ZEMj3El6sVI46bb4q/cbfHpDN825Wzl8+7dzhcB/q3tBxpBHJ9cpr7EIOA21XVPPMBOGJ3X6GHgM6PlKGqRpZbiUBsuUHNV5MLpMnDrQllN97PcRgUXZEz2jzX0m1VPr+5vnyLztvh+V8pj+hu9ncZOHpxgPyVD8jn6QuNzKyAWhSJOnh+iXoBSQFhPaP/7Rh1VCgy7Hdt/a5SJcp6ztRlz93DR6SY9Vfqd8AZPoDiF0Yii0vLGqK2PNMF/w5T7Plj910rbwPQapBcCsQnrWUh8mRqpz3W1ZR1PIIvW3x4kfc6VSRbIvydRGYv9FEGolfkynBxEJDfdqFmGWcr/Wa3 X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93004095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:MWHPR02MB2238; BCL:0; PCL:0; RULEID:; SRVR:MWHPR02MB2238; X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2238; 4:SbpyVCG/lg6zhadYJuOR6fp1GgaXUdoeMU0eUaEkj9RgWhmx3TOup3Ayt0DA2evJlX5AuFg/i7BHDDpzyooJvtr1d/+PxmXpowlzkLHo8tZ9/CmIF0hOvbygsMP+HM62elW2chQ/E4516Yf+qID/YOjFHrfR7a6gDLt4FxDUG1zza3+AsUxHX7zNb4zB3yKhrDvTq3yA35ConxZQU2rHaE84Kc3WAnBPtZDBYC2YBEYbaFpQGas/kVcvSjySAr7OyQicv9SEK0bULYB1cHtrbPwZyVoARZimwVllzY6iynfmdzFk/v9I6Yw5m3juYAsL X-Forefront-PRVS: 0707248B64 X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2238; 23:8iGEg1Z0d2MBwL/+7MShFfs2m9g+g7SndxGLN0ORTTAH/DNv8oVKIyHJzmTkIrwyDoMkQOScXw8n573k7gif2XrVMCrB84NXs9pgCf+HXs8L+qmGA6rb3UkQpWuPFr3xufHeuG/ADFMsGsiFXZgEEhslL+u4973k2kzmQlxuYSNesczd/J6j4BWRxjjZy7SJRaYu04qtd7SxMRuAdgbIh4EL3yljmUzl/AKnbjKcFUsmj/KGyZ5sokOTfSxZkzSeRh2t1XTzsK+aM2Wy6dMZdrpRkzfGL8wFz1zqkEbWKLSZrZBY7YIOr7tzEjsPAv544WkNOSk3uSiG1arQNPi1x7iLZ15iGJdMexEwaWBXTtDC6HptcZbGoHSuoIQZnBck/C2RwQhF5jrWqxJAbuYCTbhZLyqfgAxU0JhyVXMCa+Eo6bqw7/yVANckk+jvJNvd17gxwc7070uzR/pYDoBA75WdnPJ5n+zvx2yNJhjnRjtObB9eTnU7H1cZ3aqTbFtnvJV7YIHqREqP4SSfDf9/Taw3Bu15Qudk9IYmxF0ByNmujt9mObZMplOmE3A6xJFXPKauKGjVc7XCmygw/jHEZ+3c5GpIKc+bUxAr0Go9GAdc9nPKu4pNrirmS2Zlzdr4xql8pUl6/1xMbRbCC8raWpMFd1LEvThc+A9sHg3eX0yWea1b38v3yXH28TitquiTUcH0t/i+5t1r7lC154yvHdx/ggePpqUtYlztJgO5UTD2asp2FvzXlgf+yUyN/bHka8A0CyOgj7fAPTBBJOCqqwtjeEHqp/19VRDDY5xc5gr+EUVLVINvjdq1UWF6rksyRQxrbLePNLRFzcA/601ZJiQ3jX5PdNhiR9GskvkE1twhj4FXS7+NFa6FX6DphPlx5JtMUu+j2rjWd7yLtOBtlw01PCz2lnf5aMVkn8gz3x2afEOTYPE5lKjnALSKldXSOe2+iOHdoLWvx4fpfVQ2srYlHGxwC11XA41y7zSXDCoaNMwcu+dYahjHwPxYd3gsYwGQ7IsfVCldVUCRk+Up+HbzCDAPGxHItyDj3VChJut0uLttha4bDA0oTGI6dpC4vd0X8i2GNEblJb10hih8xn3SlZO7HCkvadVkR4UlKLXf8MRFHObw7AH2HZyvBpKW/mSADsl7Wpgn0BqjmK3CAA8gRQukY3axNC8hyTbwEHj4t0mWVywKK++2KMivZW/RbEq4yVGFEQioAVeFO4RaGw== X-Microsoft-Antispam-Message-Info: mvkmeLWvXGYaTYMLd9FBFX8aicf9rWn0yJrcwPOtuU0cYM3aeBQJiN1d1RukxnVqizEqyoKVOxfjIktf2FSpTJywDVx1I46UBleTgJ5eG9vDKDCCj70Q8p3xP7zr9YsR6fDaa4wAgTUI09CZo0ZCkKJuwx0WK+BfgrHzF/FTJQhGQqvo1JAhwbsMUFhmKUqxc/lPQaRlsa85+DNXK0EYPt7H1b5IwN7nkpOAGKwZDc6NTRDXd7v1y+ZBzoPX2hoOiB8z4XrROr/N1wsW0nBZNW7ChIGwIRJnAQSwljBQMwezWwgIDm8hOFz6SkU870bY X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2238; 6:iPtmZOi8jFzmdiMy37nvfWJxhIQKKsuWls+PMLVdeI9YDuvB/iXnl5FTAPE3ZwNhIwdDe4rM2gtj1uqRevemzZ45rFfVy7Zq9xP85oW8JI9noeVeo8wb2NNaTzr9vqqnrorAUdZMTLl3UvwOwwzX/E4JAopEFTkM0RecK48ZxJHj+OZfUjGAx458YW915mjIMCQxpMqjtpFPYbRLC/rrh0q3QcioF+HYkCplzdzU68ixkdqDExtmQO7otD1Q1tjMVKDyt9UZ8CXTnKw36rmIigvb9NCUCV+mfl4woLVHPvImjcopGjN1q5+EWpC4XtMiUSsXhr3eeYdNUL0saD8MIrKrIYRzIyVJy3m7JVzPeVyJVYYDycgEt+6YYi4dvGSI3nai3TUBWsQ88Me08SK9BiI0yngtjGg4/ewTSlI8Re95R3iRAuBfBFYLWcipsKwkGHuniD4XtOz9BMSxLOhpwg==; 5:84CxsWyl7QmGuODUvIQnR5D4dVYsb5NIYGCSQ2Gk7eQ0fcN4AvT+0VINFpvA7ll+MXHM1s+2NuUa9xI+9g3sa8aYkqDsp5IXCE5xFjYnAfCqCb99kScoTLPhxPrAiCEokexxCIRuy/4do0ei7Blxsb7Tv/DspGnWqXbvvLwhANE=; 24:9TmNDz55K3/Maw5CaAMxaN2qXkQdoVukf8i2lDL9JrpbWDMsqLMhmafxfNKb7IFMAOOFh/bAM88OaHppRY1KzKew29GBov3Ahwva2gHL98o= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB2238; 7:D4TZ+8HbElqWsm2TNwN7xbkB4EHes+lk0Amqqn8Nl1q7JlKem5EPAiqFlfl7Kj4mdBrBsgUPXyWXLrPHO1uuKVUqnZTucZXZ2v9yHZgx7GlvXdK1/MXZ3VRqlJi+sAg93bE+0RJEdsbYlSeRW0bjbs1UkhFQ9UK3nxMLkein44WKMEvaAvX/IUFScmQJ97c7L2QrSVxSMIjBn8uw3PmwntIYKbeXPuGmjhKdU/ItcxyR5GEpasvl7r/I6Wdmq3Yo X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2018 11:50:25.5003 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a08c108d-1424-4079-36ff-08d5d511ae44 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2238 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes below checkpatch checks- CHECK: spaces preferred around that '*' (ctx:VxV) CHECK: No space is necessary after a cast Signed-off-by: Radhey Shyam Pandey --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index e8bb7b3..f62e4b6 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -95,11 +95,11 @@ -#define TX_TIMEOUT (60*HZ) /* Tx timeout is 60 seconds. */ +#define TX_TIMEOUT (60 * HZ) /* Tx timeout is 60 seconds. */ #define ALIGNMENT 4 /* BUFFER_ALIGN(adr) calculates the number of bytes to the next alignment. */ -#define BUFFER_ALIGN(adr) ((ALIGNMENT - ((u32) adr)) % ALIGNMENT) +#define BUFFER_ALIGN(adr) ((ALIGNMENT - ((u32)adr)) % ALIGNMENT) #ifdef __BIG_ENDIAN #define xemaclite_readl ioread32be @@ -239,8 +239,8 @@ static void xemaclite_aligned_write(void *src_ptr, u32 *dest_ptr, /* Set up to output the remaining data */ align_buffer = 0; - to_u8_ptr = (u8 *) &align_buffer; - from_u8_ptr = (u8 *) from_u16_ptr; + to_u8_ptr = (u8 *)&align_buffer; + from_u8_ptr = (u8 *)from_u16_ptr; /* Output the remaining data */ for (; length > 0; length--) @@ -273,7 +273,7 @@ static void xemaclite_aligned_read(u32 *src_ptr, u8 *dest_ptr, u32 align_buffer; from_u32_ptr = src_ptr; - to_u16_ptr = (u16 *) dest_ptr; + to_u16_ptr = (u16 *)dest_ptr; for (; length > 3; length -= 4) { /* Copy each word into the temporary buffer */ @@ -289,9 +289,9 @@ static void xemaclite_aligned_read(u32 *src_ptr, u8 *dest_ptr, u8 *to_u8_ptr, *from_u8_ptr; /* Set up to read the remaining data */ - to_u8_ptr = (u8 *) to_u16_ptr; + to_u8_ptr = (u8 *)to_u16_ptr; align_buffer = *from_u32_ptr++; - from_u8_ptr = (u8 *) &align_buffer; + from_u8_ptr = (u8 *)&align_buffer; /* Read the remaining data */ for (; length > 0; length--) @@ -351,7 +351,7 @@ static int xemaclite_send_data(struct net_local *drvdata, u8 *data, return -1; /* Buffer was full, return failure */ /* Write the frame to the buffer */ - xemaclite_aligned_write(data, (u32 __force *) addr, byte_count); + xemaclite_aligned_write(data, (u32 __force *)addr, byte_count); xemaclite_writel((byte_count & XEL_TPLR_LENGTH_MASK), addr + XEL_TPLR_OFFSET); @@ -448,7 +448,7 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data, int maxlen) length = maxlen; /* Read from the EmacLite device */ - xemaclite_aligned_read((u32 __force *) (addr + XEL_RXBUFF_OFFSET), + xemaclite_aligned_read((u32 __force *)(addr + XEL_RXBUFF_OFFSET), data, length); /* Acknowledge the frame */ @@ -479,7 +479,7 @@ static void xemaclite_update_address(struct net_local *drvdata, /* Determine the expected Tx buffer address */ addr = drvdata->base_addr + drvdata->next_tx_buf_to_use; - xemaclite_aligned_write(address_ptr, (u32 __force *) addr, ETH_ALEN); + xemaclite_aligned_write(address_ptr, (u32 __force *)addr, ETH_ALEN); xemaclite_writel(ETH_ALEN, addr + XEL_TPLR_OFFSET); @@ -574,7 +574,7 @@ static void xemaclite_tx_handler(struct net_device *dev) dev->stats.tx_packets++; if (lp->deferred_skb) { if (xemaclite_send_data(lp, - (u8 *) lp->deferred_skb->data, + (u8 *)lp->deferred_skb->data, lp->deferred_skb->len) != 0) return; dev->stats.tx_bytes += lp->deferred_skb->len; @@ -619,7 +619,7 @@ static void xemaclite_rx_handler(struct net_device *dev) skb_reserve(skb, 2); - len = xemaclite_recv_data(lp, (u8 *) skb->data, len); + len = xemaclite_recv_data(lp, (u8 *)skb->data, len); if (!len) { dev->stats.rx_errors++; @@ -1032,7 +1032,7 @@ static int xemaclite_send(struct sk_buff *orig_skb, struct net_device *dev) new_skb = orig_skb; spin_lock_irqsave(&lp->reset_lock, flags); - if (xemaclite_send_data(lp, (u8 *) new_skb->data, len) != 0) { + if (xemaclite_send_data(lp, (u8 *)new_skb->data, len) != 0) { /* If the Emaclite Tx buffer is busy, stop the Tx queue and * defer the skb for transmission during the ISR, after the * current transmission is complete