From patchwork Fri Nov 8 12:09:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 2008419 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=r3dkL5mE; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hX4M0OxG; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=r3dkL5mE; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hX4M0OxG; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XlHmz2Gjqz1xyS for ; Fri, 8 Nov 2024 23:09:39 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 792703858D21 for ; Fri, 8 Nov 2024 12:09:37 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 8BB763858429 for ; Fri, 8 Nov 2024 12:09:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8BB763858429 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8BB763858429 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1731067752; cv=none; b=fZXwET5Ql0eUyrqa6EWNY/GY8JEVn22ZZ8vQvItVQp1nz1/BZ2YlODhNeKFgdxT5dIbW65XHRTFC8Fb2VV2VxUTkyGgatpU0QYAeVOShturZMotoHricKPUI9BJBxO+IABcT/FoqiiG4knuz4vUWsM9x3GYpbge3GpWC/w9GD0w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1731067752; c=relaxed/simple; bh=gOy1pulKvLrmHwUw1dql5BMp6CszmidfXq9B+Xw+/VQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version:Message-Id; b=G7Uwe+kOnmPTRYAKVZx/poXpbFU2vQ1c0Bu5dvZwwM40RcLbtQ+FdFgAaN81s6DcPpnGx9TXmA/UQiSrcN9kGhHc9Ac5v7S2Z9Pnsmq6MdIgGBd1RFNv3Bn95IvWrABV+G5pZKtRjdZSN3zmt22aULVQjb8I/4im96zGjOIc5Rg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 802601F393; Fri, 8 Nov 2024 12:09:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1731067741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=KLfPAFGRxBV8n5AD4JML6Zz4uwyZ36H3PaYrapOebTs=; b=r3dkL5mExH6GBVxiGskF5pAi1bXjVzbcauZgXBTd/YtVdNbBEGhdTPtJ4Uyag0zvSwhMhe DY7Gih58JEFR9tctAORZt8neU/Z5b/ErsjjlbAuGhX0MQadF6pA7iJuZl/ilSK2HQnEbSE Zi1Jo+EJIYh/bNRHjQG7hjJJxPQ50RE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1731067741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=KLfPAFGRxBV8n5AD4JML6Zz4uwyZ36H3PaYrapOebTs=; b=hX4M0OxG0JwALByuOGz8mQPJuhocT0dO3g6kOqDH5haUrDbFy49XHjOOnuCB9CF9XYFJ2H JUGsZyatjpPmdFCw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1731067741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=KLfPAFGRxBV8n5AD4JML6Zz4uwyZ36H3PaYrapOebTs=; b=r3dkL5mExH6GBVxiGskF5pAi1bXjVzbcauZgXBTd/YtVdNbBEGhdTPtJ4Uyag0zvSwhMhe DY7Gih58JEFR9tctAORZt8neU/Z5b/ErsjjlbAuGhX0MQadF6pA7iJuZl/ilSK2HQnEbSE Zi1Jo+EJIYh/bNRHjQG7hjJJxPQ50RE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1731067741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=KLfPAFGRxBV8n5AD4JML6Zz4uwyZ36H3PaYrapOebTs=; b=hX4M0OxG0JwALByuOGz8mQPJuhocT0dO3g6kOqDH5haUrDbFy49XHjOOnuCB9CF9XYFJ2H JUGsZyatjpPmdFCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5FC4C13967; Fri, 8 Nov 2024 12:09:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id bHu7FV3/LWejVgAAD6G6ig (envelope-from ); Fri, 08 Nov 2024 12:09:01 +0000 Date: Fri, 8 Nov 2024 13:09:00 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: RISC-V Subject: [PATCH] tree-optimization/117502 - VMAT_STRIDED_SLP vs VMAT_ELEMENTWISE when considering gather MIME-Version: 1.0 Message-Id: <20241108120901.5FC4C13967@imap1.dmz-prg2.suse.org> X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; MISSING_XM_UA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:mid] X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org The following treats both the same when considering to use gather or scatter for single-element interleaving accesses. Bootstrap and regtest running on x86_64-unknown-linux-gnu. PR tree-optimization/117502 * tree-vect-stmts.cc (get_group_load_store_type): Also consider VMAT_STRIDED_SLP when checking to use gather/scatter for single-element interleaving access. --- gcc/tree-vect-stmts.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index 9a2c2ea753e..28bfd8f4e28 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -2274,7 +2274,8 @@ get_group_load_store_type (vec_info *vinfo, stmt_vec_info stmt_info, on nearby locations. Or, even if it's a win over scalar code, it might not be a win over vectorizing at a lower VF, if that allows us to use contiguous accesses. */ - if (*memory_access_type == VMAT_ELEMENTWISE + if ((*memory_access_type == VMAT_ELEMENTWISE + || *memory_access_type == VMAT_STRIDED_SLP) && single_element_p && loop_vinfo && vect_use_strided_gather_scatters_p (stmt_info, loop_vinfo,